[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user XiaoZYang commented on the issue: https://github.com/apache/flink/pull/5845 @zentol got it! So what you mean is that @sijie and I will keep updating commits until this work is done and you guys will merge this PR to a new branch. Later PR will be against the new branch. Did I misunderstand you ? ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user zentol commented on the issue: https://github.com/apache/flink/pull/5845 it is not possible to create a PR against a non-existing branch. We will either have to create a pulsar-connector branch up front, or open the first PR against master and merge it into a new branch. I would suggest the latter option. ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user XiaoZYang commented on the issue: https://github.com/apache/flink/pull/5845 @hsaputra There is no error but the issue is 1. when I create a PR to the flink repo from my fork repo I need to choose a branch to which the commits are merged to 2. I'm expected to merge the commits are merged to a branch name like 'pulsar-connector', but I can't create a new branch at flink repo Is there a better way to do that? Thank for you helping me ! ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user hsaputra commented on the issue: https://github.com/apache/flink/pull/5845 @XiaoZYang You can close this PR and create new branch to submit new PR since you are the creator os this one. Did you see any error or something preventing you to close this one? ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user XiaoZYang commented on the issue: https://github.com/apache/flink/pull/5845 I prefer to open a new PR and a new branch. But I am not authorized to do that. ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5845 Sorry for delays on my reply here. I'll take a look at this week, over the next days. If there is going to be a new PR, please also let me know. Thanks! ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user XiaoZYang commented on the issue: https://github.com/apache/flink/pull/5845 @tzulitai @surryr @pluppens @sijie This PR is going to be closed and I will open another PR to brunch pulsar-connector to this issue. ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user sijie commented on the issue: https://github.com/apache/flink/pull/5845 @tzulitai what is your opinion about @XiaoZYang 's comment? ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user XiaoZYang commented on the issue: https://github.com/apache/flink/pull/5845 Hi @sijie @tzulitai, since there will be serial of commits about *pulsar connector*, what about close this pr and reopen a new PR which is going to merge to a new branch named "pulsar-connector". So we can complete all works by incremental commits, then we merge the branch pulsar-connector to master. By doing so, we can avoid resolving conflicts again and again. ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user XiaoZYang commented on the issue: https://github.com/apache/flink/pull/5845 ping @sijie ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user XiaoZYang commented on the issue: https://github.com/apache/flink/pull/5845 @sijie would you mind help reviewing this commit? ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user sijie commented on the issue: https://github.com/apache/flink/pull/5845 @pluppens thank you for your comments. I was busy with pulsar 2.0 release. I will try to pick this up again soon :) ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user sijie commented on the issue: https://github.com/apache/flink/pull/5845 @tzulitai thank you very much for you help. just sent an email to dev@flink. look forward to feedback from flink community and collaboration between flink and pulsar communities. ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5845 Welcome to the community! @sijie I think for this a general discussion email thread will be enough. ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user sijie commented on the issue: https://github.com/apache/flink/pull/5845 @tzulitai thank you for your comments. Glad to hear your opinions about pulsar connectors. I was the original person who initiated the idea of flink pulsar connectors with @XiaoZYang, I am also from Pulsar IPMC. Although Pulsar is a young project, it is a very active developing project. We have committers from various companies and pretty good adoption. from pulsar community perspective, we are very happy committed to developing/maintaining pulsar connectors. hope this can help clear some of your concerns. As the next step, I am happy to start the email thread at flink mailing list. should this be a FLIP? or just an general discussion email thread? ---
[GitHub] flink issue #5845: [FLINK-9168][flink-connectors]Pulsar Sink connector
Github user tzulitai commented on the issue: https://github.com/apache/flink/pull/5845 Thanks for this contribution @XiaoZYang! Pulsar seems like an interesting project. I think before we proceed with this, we need to make it clear (community-wise) that if we do accept this connector, there will be a maintainer for it. In the past, we had connector contributions that remained stale (because nobody was maintaining it) after it was merged to the codebase, which eventually started causing problems such as test instabilities and even the connector itself being in an unusable state without nobody realizing it. Because of that, our previous approach was to redirect new connector contributions to the Apache Bahir project. I personally think that the Flink community could still benefit from good connector contributions, and would be best if we can somehow keep them within Flink but still have good eyes on them. Maybe it would be a good idea to start a thread in the developer mailing lists about this connector, and whether or not it will be maintained (by either the original contributor or someone else) after it gets merged. What do you think? ---
