[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/6001 Looks good, thanks, merging this... ---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6001 @StephanEwen fixed based on your suggestion ---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6001 cc @tzulitai @fhueske ---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6001 cc @fhueske changed and fixed a remained error before ---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Github user fhueske commented on the issue: https://github.com/apache/flink/pull/6001 Thanks for the fix @yanghua. I left a minor comment. Otherwise +1 to merge. ---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Github user sihuazhou commented on the issue: https://github.com/apache/flink/pull/6001 hi @medcv I think maybe it better to assign the issue to yourself before working on that, this could help to avoid depulicate works(cause i notice that you make the PRs without assigning to yourself), you can request the contribution permisson from the dev mail, i think PMCs will accpet your request once they saw your request, it always very quickly. With the permisson, you can assign the issue as you wish then. Best~ ---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Github user medcv commented on the issue: https://github.com/apache/flink/pull/6001 @yanghua Thanks for the fix. I will close my PR as you addressed all the issues in the ticket here. ---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6001 @StephanEwen does this has any problem need to change? it seems @medcv try to fixed this issue before asking me. ---
[GitHub] flink issue #6001: [FLINK-9299] ProcessWindowFunction documentation Java exa...
Github user yanghua commented on the issue: https://github.com/apache/flink/pull/6001 cc @zentol @tillrohrmann ---