[GitHub] flink pull request: [FLINK-1805]The class IOManagerAsync should us...
Github user hsaputra commented on a diff in the pull request: https://github.com/apache/flink/pull/546#discussion_r27410240 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerAsync.java --- @@ -43,7 +45,10 @@ /** Flag to signify that the IOManager has been shut down already */ private final AtomicBoolean isShutdown = new AtomicBoolean(); - + + /** Logging */ + protected static final Logger LOG = LoggerFactory.getLogger(IOManagerAsync.class); --- End diff -- Could we just use private here instead of protected? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1805]The class IOManagerAsync should us...
Github user matadorhong commented on a diff in the pull request: https://github.com/apache/flink/pull/546#discussion_r27441775 --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/disk/iomanager/IOManagerAsync.java --- @@ -43,7 +45,10 @@ /** Flag to signify that the IOManager has been shut down already */ private final AtomicBoolean isShutdown = new AtomicBoolean(); - + + /** Logging */ + protected static final Logger LOG = LoggerFactory.getLogger(IOManagerAsync.class); --- End diff -- @hsaputra Yes, private here is better. Thanks you. I have updated it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1805]The class IOManagerAsync should us...
Github user hsaputra commented on the pull request: https://github.com/apache/flink/pull/546#issuecomment-87879789 +1 LGTM Once Travis done will merge unless more review coming in. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] flink pull request: [FLINK-1805]The class IOManagerAsync should us...
Github user asfgit closed the pull request at: https://github.com/apache/flink/pull/546 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
