[GitHub] flink pull request #2428: [FLINK-4517] scala code refactoring

2016-10-24 Thread shijinkui
Github user shijinkui closed the pull request at:

https://github.com/apache/flink/pull/2428


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] flink pull request #2428: [FLINK-4517] scala code refactoring

2016-08-27 Thread shijinkui
GitHub user shijinkui opened a pull request:

https://github.com/apache/flink/pull/2428

[FLINK-4517] scala code refactoring

the refacter type:

1. case class does't need `new`
2. case block does't need `{  ...  }`
3. match-case instead of isInstanceOf 

references the related [FLINK-4517]



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/shijinkui/flink scala-refactoring

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/flink/pull/2428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2428


commit b02bef1f23943b08908f408e03f75fb8c5220a28
Author: shijinkui 
Date:   2016-08-27T09:17:04Z

[FLINK-4517] scala code refactoring




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---