[jira] [Comment Edited] (FLINK-34001) doc of "Configure Operator-level State TTL" error

2024-01-07 Thread Jane Chan (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-34001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804079#comment-17804079
 ] 

Jane Chan edited comment on FLINK-34001 at 1/8/24 2:22 AM:
---

Hi [~luca.yang] and [~xuyangzhong], please correct me if I'm wrong, but since 
the state never expires is a by-default behavior, so "state retention is 
disabled" is short for "the TTL for state retention is disabled".
You can check the explanation of `table.exec.state.ttl` in 
[config|https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/]
{quote}Specifies a minimum time interval for how long idle state (i.e. state 
which was not updated), will be retained. State will never be cleared until it 
was idle for less than the minimum time, and will be cleared at some time after 
it was idle. Default is never clean-up the state. NOTE: Cleaning up state 
requires additional overhead for bookkeeping. Default value is 0, which means 
that it will never clean up state.
{quote}
Anyway, any ambiguous statement should be corrected. Thanks for the report, 
I'll fix it.


was (Author: qingyue):
Hi [~luca.yang] and [~xuyangzhong], please correct me if I'm wrong, but since 
the state never expires is a by-default behavior, so "state retention is 
disabled" is short for "the TTL for state retention is disabled".
You can check the explanation of `table.exec.state.ttl` in 
[config|https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/]
{quote}Specifies a minimum time interval for how long idle state (i.e. state 
which was not updated), will be retained. State will never be cleared until it 
was idle for less than the minimum time, and will be cleared at some time after 
it was idle. Default is never clean-up the state. NOTE: Cleaning up state 
requires additional overhead for bookkeeping. Default value is 0, which means 
that it will never clean up state.
{quote}
Anyway, any ambiguous statement should be corrected. I'll fix it.

> doc of "Configure Operator-level State TTL" error
> -
>
> Key: FLINK-34001
> URL: https://issues.apache.org/jira/browse/FLINK-34001
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Affects Versions: 1.18.0
>Reporter: yong yang
>Priority: Major
>
> doc:
> https://nightlies.apache.org/flink/flink-docs-release-1.18/docs/dev/table/concepts/overview/#idle-state-retention-time
> The current TTL value for both left and right side is {{{}"0 ms"{}}}, which 
> means the state retention is not enabled. 
>  
> but i test find :
> The current TTL value for both left and right side is {{{}"0 ms"{}}}, which 
> means the state is permanence keep!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-34001) doc of "Configure Operator-level State TTL" error

2024-01-07 Thread Jane Chan (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-34001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804079#comment-17804079
 ] 

Jane Chan edited comment on FLINK-34001 at 1/8/24 2:22 AM:
---

Hi [~luca.yang] and [~xuyangzhong], please correct me if I'm wrong, but since 
the state never expires is a by-default behavior, so "state retention is 
disabled" is short for "the TTL for state retention is disabled".
You can check the explanation of `table.exec.state.ttl` in 
[config|https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/]
{quote}Specifies a minimum time interval for how long idle state (i.e. state 
which was not updated), will be retained. State will never be cleared until it 
was idle for less than the minimum time, and will be cleared at some time after 
it was idle. Default is never clean-up the state. NOTE: Cleaning up state 
requires additional overhead for bookkeeping. Default value is 0, which means 
that it will never clean up state.
{quote}
Anyway, any ambiguous statement should be corrected. I'll fix it.


was (Author: qingyue):
Hi [~luca.yang] and [~xuyangzhong]; please correct me if I'm wrong, but state 
retention is disabled stands for "state never expires".
You can check the explanation of `table.exec.state.ttl` in 
[config|https://nightlies.apache.org/flink/flink-docs-master/docs/dev/table/config/]
{quote}Specifies a minimum time interval for how long idle state (i.e. state 
which was not updated), will be retained. State will never be cleared until it 
was idle for less than the minimum time, and will be cleared at some time after 
it was idle. Default is never clean-up the state. NOTE: Cleaning up state 
requires additional overhead for bookkeeping. Default value is 0, which means 
that it will never clean up state.
{quote}

> doc of "Configure Operator-level State TTL" error
> -
>
> Key: FLINK-34001
> URL: https://issues.apache.org/jira/browse/FLINK-34001
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Affects Versions: 1.18.0
>Reporter: yong yang
>Priority: Major
>
> doc:
> https://nightlies.apache.org/flink/flink-docs-release-1.18/docs/dev/table/concepts/overview/#idle-state-retention-time
> The current TTL value for both left and right side is {{{}"0 ms"{}}}, which 
> means the state retention is not enabled. 
>  
> but i test find :
> The current TTL value for both left and right side is {{{}"0 ms"{}}}, which 
> means the state is permanence keep!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Comment Edited] (FLINK-34001) doc of "Configure Operator-level State TTL" error

2024-01-07 Thread xuyang (Jira)


[ 
https://issues.apache.org/jira/browse/FLINK-34001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804081#comment-17804081
 ] 

xuyang edited comment on FLINK-34001 at 1/8/24 2:12 AM:


[~qingyue] User may be confused, and will think that "State retention is 
disabled" means that the state is not retained, but in fact it means that the 
state is permanently retained without expiration. 

BTW, [~luca.yang] I think this pr is an improvement, not a bug, right ? 


was (Author: xuyangzhong):
[~qingyue] User may be confused, and will think that "State retention is 
disabled" means that the state is not retained, but in fact it means that the 
state is permanently retained without expiration. 

BTW, I think [~luca.yang] this pr is an improvement, not a bug, right? 

> doc of "Configure Operator-level State TTL" error
> -
>
> Key: FLINK-34001
> URL: https://issues.apache.org/jira/browse/FLINK-34001
> Project: Flink
>  Issue Type: Bug
>  Components: Documentation, Table SQL / API
>Affects Versions: 1.18.0
>Reporter: yong yang
>Priority: Major
>
> doc:
> https://nightlies.apache.org/flink/flink-docs-release-1.18/docs/dev/table/concepts/overview/#idle-state-retention-time
> The current TTL value for both left and right side is {{{}"0 ms"{}}}, which 
> means the state retention is not enabled. 
>  
> but i test find :
> The current TTL value for both left and right side is {{{}"0 ms"{}}}, which 
> means the state is permanence keep!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)