[jira] [Updated] (GEODE-3438) Collection added to itself
[ https://issues.apache.org/jira/browse/GEODE-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-3438: -- Labels: pull-request-available (was: ) > Collection added to itself > -- > > Key: GEODE-3438 > URL: https://issues.apache.org/jira/browse/GEODE-3438 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: JC >Priority: Major > Labels: pull-request-available > > Hi > In a recent github mirror, I've found suspicious code. > Branch: master > Path: > geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DurableCqNamesResult.java > {code:java} > ... > 27 private List cqNames = new ArrayList(); > ... > 33 public DurableCqNamesResult(final String memberNameOrId, List > cqNames) { > 34 super(memberNameOrId); > 35 cqNames.addAll(cqNames); > 36 } > {code} > In Line 35, should `cqNames.addAll' be `this.cqNames.addAll'? This might not > be an issue, but I wanted to report just in case. > Thanks! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GEODE-3438) Collection added to itself
[ https://issues.apache.org/jira/browse/GEODE-3438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Shu updated GEODE-3438: Component/s: (was: core) querying > Collection added to itself > -- > > Key: GEODE-3438 > URL: https://issues.apache.org/jira/browse/GEODE-3438 > Project: Geode > Issue Type: Bug > Components: querying >Reporter: JC > > Hi > In a recent github mirror, I've found suspicious code. > Branch: master > Path: > geode-core/src/main/java/org/apache/geode/management/internal/cli/domain/DurableCqNamesResult.java > {code:java} > ... > 27 private List cqNames = new ArrayList(); > ... > 33 public DurableCqNamesResult(final String memberNameOrId, List > cqNames) { > 34 super(memberNameOrId); > 35 cqNames.addAll(cqNames); > 36 } > {code} > In Line 35, should `cqNames.addAll' be `this.cqNames.addAll'? This might not > be an issue, but I wanted to report just in case. > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029)