[jira] [Assigned] (GEODE-4442) Create message for cancelling an in progress backup

2018-02-02 Thread Nick Reich (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Reich reassigned GEODE-4442:
-

Assignee: Nick Reich

> Create message for cancelling an in progress backup
> ---
>
> Key: GEODE-4442
> URL: https://issues.apache.org/jira/browse/GEODE-4442
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
>Priority: Major
>
> Currently, the final message involved in backups contains an abort flag that 
> is the only way to cancel the backup. We should allow a way to try and halt 
> an in progress backup by splitting out the abort logic from the existing 
> message into a new message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4456) Remove singleton calls from all tests in org.apache.geode.internal.cache

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4456:
-
Description: 
These tests in org.apache.geode.internal.cache invoke singleton getters.

CacheFactory.getAnyInstance():
* Bug37241DUnitTest
* CommitFunction
* GridAdvisorDUnitTest
* NestedTransactionFunction
* RollbackFunction
* SingleHopStatsDUnitTest
* UpdateVersionDUnitTest

CacheFactory.getExisting(DistributedSystem):
* PartitionedRegionTestHelper

GemFireCacheImpl.getInstance():
* DiskRegRecoveryJUnitTest
* FixedPRSinglehopDUnitTest
* NetSearchMessagingDUnitTest
* RemoteCQTransactionDUnitTest
* RemoteTransactionDUnitTest
* SystemFailureDUnitTest

GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
* ColocationHelperTest

InternalDistributedSystem.getAnyInstance():
* ClientServerTransactionDUnitTest
* GridAdvisorDUnitTest

  was:
These tests in org.apache.geode.internal.cache invoke singleton getters.

CacheFactory.getAnyInstance():
* Bug37241DUnitTest
* CommitFunction
* GridAdvisorDUnitTest
* NestedTransactionFunction
* RollbackFunction
* SingleHopStatsDUnitTest
* UpdateVersionDUnitTest

CacheFactory.getExisting(DistributedSystem):
* PartitionedRegionTestHelper

GemFireCacheImpl.getInstance():
* DiskRegRecoveryJUnitTest
* FixedPRSinglehopDUnitTest
* NetSearchMessagingDUnitTest
* RemoteCQTransactionDUnitTest
* RemoteTransactionDUnitTest
* SystemFailureDUnitTest

GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
* ColocationHelperTest



> Remove singleton calls from all tests in org.apache.geode.internal.cache
> 
>
> Key: GEODE-4456
> URL: https://issues.apache.org/jira/browse/GEODE-4456
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions, tests, transactions
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache invoke singleton getters.
> CacheFactory.getAnyInstance():
> * Bug37241DUnitTest
> * CommitFunction
> * GridAdvisorDUnitTest
> * NestedTransactionFunction
> * RollbackFunction
> * SingleHopStatsDUnitTest
> * UpdateVersionDUnitTest
> CacheFactory.getExisting(DistributedSystem):
> * PartitionedRegionTestHelper
> GemFireCacheImpl.getInstance():
> * DiskRegRecoveryJUnitTest
> * FixedPRSinglehopDUnitTest
> * NetSearchMessagingDUnitTest
> * RemoteCQTransactionDUnitTest
> * RemoteTransactionDUnitTest
> * SystemFailureDUnitTest
> GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
> * ColocationHelperTest
> InternalDistributedSystem.getAnyInstance():
> * ClientServerTransactionDUnitTest
> * GridAdvisorDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-3583) Remove all usages of static methods to the Cache

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-3583:
-
Description: 
This ticket is the parent ticket to remove all invocations of 
Cache.getAnyInstance(), GemFireCacheImpl.getInstance(), etc... 
This improvement is complete is there are no more usages of the static methods 
to retrieve a Cache

As per some work that [~huynhja] has done
_ grep -rl "GemFireCacheImpl.getInstance" --include \*.java . > 
GemFireCacheImplList.txt

grep -rl "CacheFactory.getAnyInstance" --include \*.java . > 
CacheFactoryList.txt

grep -rl "InternalDistributedSystem.getAnyInstance" --include \*.java . > 
InternalDistributedSystemList.txt

I've attached the files to this email...

The combinedList.txt is a grep that combined all 3 calls into a single file... _

[EDIT] Additional singleton getters that need to be removed:
* CacheFactory.getInstance(DistributedSystem)
* CacheFactory.getInstanceCloseOk(DistributedSystem)
* GemFireCacheImpl.getExisting()
* GemFireCacheImpl.getExisting(String)
* GemFireCacheImpl.getForPdx(String)
* InternalDistributedSystem.getAnyInstance()
* InternalDistributedSystem getConnectedInstance()
* InternalDistributedSystem unsafeGetConnectedInstance()


  was:
This ticket is the parent ticket to remove all invocations of 
Cache.getAnyInstance(), GemFireCacheImpl.getInstance(), etc... 
This improvement is complete is there are no more usages of the static methods 
to retrieve a Cache

As per some work that [~huynhja] has done
_ grep -rl "GemFireCacheImpl.getInstance" --include \*.java . > 
GemFireCacheImplList.txt

grep -rl "CacheFactory.getAnyInstance" --include \*.java . > 
CacheFactoryList.txt

grep -rl "InternalDistributedSystem.getAnyInstance" --include \*.java . > 
InternalDistributedSystemList.txt

I've attached the files to this email...

The combinedList.txt is a grep that combined all 3 calls into a single file... _

[EDIT] Additional singleton getters that need to be removed:
* CacheFactory.getInstance(DistributedSystem)
* CacheFactory.getInstanceCloseOk(DistributedSystem)
* GemFireCacheImpl.getExisting()
* GemFireCacheImpl.getExisting(String)



> Remove all usages of static methods to the Cache
> 
>
> Key: GEODE-3583
> URL: https://issues.apache.org/jira/browse/GEODE-3583
> Project: Geode
>  Issue Type: Improvement
>Reporter: Udo Kohlmeyer
>Priority: Major
>  Labels: pull-request-available
> Attachments: CacheFactoryList.txt, CombinedList.txt, 
> GemFireCacheImplList.txt, InternalDistributedSystemList.txt
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> This ticket is the parent ticket to remove all invocations of 
> Cache.getAnyInstance(), GemFireCacheImpl.getInstance(), etc... 
> This improvement is complete is there are no more usages of the static 
> methods to retrieve a Cache
> As per some work that [~huynhja] has done
> _ grep -rl "GemFireCacheImpl.getInstance" --include \*.java . > 
> GemFireCacheImplList.txt
> grep -rl "CacheFactory.getAnyInstance" --include \*.java . > 
> CacheFactoryList.txt
> grep -rl "InternalDistributedSystem.getAnyInstance" --include \*.java . > 
> InternalDistributedSystemList.txt
> I've attached the files to this email...
> The combinedList.txt is a grep that combined all 3 calls into a single 
> file... _
> [EDIT] Additional singleton getters that need to be removed:
> * CacheFactory.getInstance(DistributedSystem)
> * CacheFactory.getInstanceCloseOk(DistributedSystem)
> * GemFireCacheImpl.getExisting()
> * GemFireCacheImpl.getExisting(String)
> * GemFireCacheImpl.getForPdx(String)
> * InternalDistributedSystem.getAnyInstance()
> * InternalDistributedSystem getConnectedInstance()
> * InternalDistributedSystem unsafeGetConnectedInstance()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-4078) Display full path when locator0vIews.log cannot be opened

2018-02-02 Thread Barbara Pruijn (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Barbara Pruijn resolved GEODE-4078.
---
Resolution: Fixed

> Display full path when locator0vIews.log cannot be opened
> -
>
> Key: GEODE-4078
> URL: https://issues.apache.org/jira/browse/GEODE-4078
> Project: Geode
>  Issue Type: Improvement
>  Components: locator, logging
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Fix For: 1.5.0
>
>
> Tests are often failing with an error such as:
> {{Could not open log file "locator0views.log"}}
> Just add the absolute path to help with debugging.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-4405) Pass information for BackupDestination in the prepare message of backup command

2018-02-02 Thread Fred Krone (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone resolved GEODE-4405.
---
Resolution: Fixed

> Pass information for BackupDestination in the prepare message of backup 
> command
> ---
>
> Key: GEODE-4405
> URL: https://issues.apache.org/jira/browse/GEODE-4405
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Gfsh executes backup in 2 phases/messages. 1. prepare 2. doBackup 
> The target location is passed in the doBackup phase. If instead, all 
> information about the backup task was provided in the first (prepare) 
> message, more aspects of the task could be set in its constructor and thus be 
> final.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4405) Pass information for BackupDestination in the prepare message of backup command

2018-02-02 Thread Fred Krone (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Fred Krone updated GEODE-4405:
--
Fix Version/s: 1.5.0

> Pass information for BackupDestination in the prepare message of backup 
> command
> ---
>
> Key: GEODE-4405
> URL: https://issues.apache.org/jira/browse/GEODE-4405
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Gfsh executes backup in 2 phases/messages. 1. prepare 2. doBackup 
> The target location is passed in the doBackup phase. If instead, all 
> information about the backup task was provided in the first (prepare) 
> message, more aspects of the task could be set in its constructor and thus be 
> final.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4459) Remove singleton calls from all tests in org.apache.geode.pdx

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4459:
-
Description: 
These tests in org.apache.geode.pdx invoke singleton getters.

CacheFactory.getAnyInstance():
* JSONFormatterJUnitTest

GemFireCacheImpl.getInstance():
* ClientsWithVersioningRetryDUnitTest
* PdxAttributesJUnitTest

GemFireCacheImpl.getForPdx(String):
* PdxInstanceJUnitTest

InternalDistributedSystem.getAnyInstance():
* DistributedSystemIdDUnitTest


  was:
These tests in org.apache.geode.pdx invoke singleton getters.

CacheFactory.getAnyInstance():
* JSONFormatterJUnitTest

GemFireCacheImpl.getInstance():
* ClientsWithVersioningRetryDUnitTest
* PdxAttributesJUnitTest

GemFireCacheImpl.getForPdx(String):
* PdxInstanceJUnitTest


> Remove singleton calls from all tests in org.apache.geode.pdx
> -
>
> Key: GEODE-4459
> URL: https://issues.apache.org/jira/browse/GEODE-4459
> Project: Geode
>  Issue Type: Sub-task
>  Components: serialization, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.pdx invoke singleton getters.
> CacheFactory.getAnyInstance():
> * JSONFormatterJUnitTest
> GemFireCacheImpl.getInstance():
> * ClientsWithVersioningRetryDUnitTest
> * PdxAttributesJUnitTest
> GemFireCacheImpl.getForPdx(String):
> * PdxInstanceJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * DistributedSystemIdDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4499) Add DUnit to test adding compressor to persistent region.

2018-02-02 Thread Sai Boorlagadda (JIRA)
Sai Boorlagadda created GEODE-4499:
--

 Summary: Add DUnit to test adding compressor to persistent region.
 Key: GEODE-4499
 URL: https://issues.apache.org/jira/browse/GEODE-4499
 Project: Geode
  Issue Type: Test
  Components: gfsh
Reporter: Sai Boorlagadda


Add a DUnit to test alter disk-store & region to add a compressor and verify 
that the existing region can be recovered after altering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-3127) Add function execution to new protocol

2018-02-02 Thread Galen O'Sullivan (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Galen O'Sullivan resolved GEODE-3127.
-
   Resolution: Fixed
 Assignee: Galen O'Sullivan
Fix Version/s: 1.5.0

> Add function execution to new protocol
> --
>
> Key: GEODE-3127
> URL: https://issues.apache.org/jira/browse/GEODE-3127
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Assignee: Galen O'Sullivan
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> As a Geode developer using the new client/server protocol, I need the ability 
> to execute server-side functions, a key feature of Geode.
> Add parameter-less function execution to the new protocol, verifying users 
> can execute functions and receive expected results.  (Functions with 
> parameters are covered in GEODE-3138)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-4499) Add DUnit to test adding compressor to an existing persistent region.

2018-02-02 Thread Sai Boorlagadda (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sai Boorlagadda reassigned GEODE-4499:
--

Assignee: Sai Boorlagadda

> Add DUnit to test adding compressor to an existing persistent region.
> -
>
> Key: GEODE-4499
> URL: https://issues.apache.org/jira/browse/GEODE-4499
> Project: Geode
>  Issue Type: Test
>  Components: gfsh
>Reporter: Sai Boorlagadda
>Assignee: Sai Boorlagadda
>Priority: Major
>
> Add a DUnit to test alter disk-store & region to add a compressor and verify 
> that the existing region can be recovered after altering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-4405) Pass information for BackupDestination in the prepare message of backup command

2018-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350675#comment-16350675
 ] 

ASF subversion and git services commented on GEODE-4405:


Commit 94049aa1b3046b6143cb155c219a18e628a6282a in geode's branch 
refs/heads/develop from [~nreich]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=94049aa ]

GEODE-4405: Move backup target and base line dirs to prepare backup message 
(#1377)



> Pass information for BackupDestination in the prepare message of backup 
> command
> ---
>
> Key: GEODE-4405
> URL: https://issues.apache.org/jira/browse/GEODE-4405
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence
>Reporter: Nick Reich
>Assignee: Nick Reich
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Gfsh executes backup in 2 phases/messages. 1. prepare 2. doBackup 
> The target location is passed in the doBackup phase. If instead, all 
> information about the backup task was provided in the first (prepare) 
> message, more aspects of the task could be set in its constructor and thus be 
> final.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-3127) Add function execution to new protocol

2018-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350738#comment-16350738
 ] 

ASF subversion and git services commented on GEODE-3127:


Commit 6011e094432c2e528d1c04912d63a7f51fa7c6f4 in geode's branch 
refs/heads/develop from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6011e09 ]

GEODE-3127: add function execution to new client protocol. (#1357)

* GEODE-3127: add function execution to new client protocol.

This only supports function execution on a region so far. It assumes the
default result collector, which returns a list of results, so the response 
message returns a list of results.

* MessageExecutionContext uses InternalCache instead of Cache
* Remove super.setUp calls from operation handlers because the
  @Before annotation already ensures these are called before the
  @Before methods of child classes.


> Add function execution to new protocol
> --
>
> Key: GEODE-3127
> URL: https://issues.apache.org/jira/browse/GEODE-3127
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> As a Geode developer using the new client/server protocol, I need the ability 
> to execute server-side functions, a key feature of Geode.
> Add parameter-less function execution to the new protocol, verifying users 
> can execute functions and receive expected results.  (Functions with 
> parameters are covered in GEODE-3138)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-3127) Add function execution to new protocol

2018-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-3127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350737#comment-16350737
 ] 

ASF subversion and git services commented on GEODE-3127:


Commit 6011e094432c2e528d1c04912d63a7f51fa7c6f4 in geode's branch 
refs/heads/develop from [~gosullivan]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=6011e09 ]

GEODE-3127: add function execution to new client protocol. (#1357)

* GEODE-3127: add function execution to new client protocol.

This only supports function execution on a region so far. It assumes the
default result collector, which returns a list of results, so the response 
message returns a list of results.

* MessageExecutionContext uses InternalCache instead of Cache
* Remove super.setUp calls from operation handlers because the
  @Before annotation already ensures these are called before the
  @Before methods of child classes.


> Add function execution to new protocol
> --
>
> Key: GEODE-3127
> URL: https://issues.apache.org/jira/browse/GEODE-3127
> Project: Geode
>  Issue Type: New Feature
>  Components: client/server
>Reporter: Brian Baynes
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> As a Geode developer using the new client/server protocol, I need the ability 
> to execute server-side functions, a key feature of Geode.
> Add parameter-less function execution to the new protocol, verifying users 
> can execute functions and receive expected results.  (Functions with 
> parameters are covered in GEODE-3138)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-4186) Replace all decayed array parameters (Type *) with std::vector.

2018-02-02 Thread Addison (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4186?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Addison resolved GEODE-4186.

Resolution: Fixed

> Replace all decayed array parameters (Type *) with std::vector.
> ---
>
> Key: GEODE-4186
> URL: https://issues.apache.org/jira/browse/GEODE-4186
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> Replace all decayed array parameters (Type *) with std::vector. For example
> {code}
> void writeIntArray(int32_t* array, size_t length);
> int32_t* readIntArray(size_t& length);
> {code}
> to
> {code}
> void writeIntArray(const std::vector& array);
> std::vector readIntArray();
> {code}
> This removes the ambiguity around memory ownership, makes the method 
> functional (no out param), collocates the length and other array attributes 
> with the vector, and removes null.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4498) CI failure: org.apache.geode.management.internal.cli.commands.DestroyAsyncEventQueueCommandDUnitTest > destroyAeqWhenQueueDoesNotExist_deafultReturnsError FAILED

2018-02-02 Thread Shelley Lynn Hughes-Godfrey (JIRA)
Shelley Lynn Hughes-Godfrey created GEODE-4498:
--

 Summary: CI failure: 
org.apache.geode.management.internal.cli.commands.DestroyAsyncEventQueueCommandDUnitTest
 > destroyAeqWhenQueueDoesNotExist_deafultReturnsError FAILED
 Key: GEODE-4498
 URL: https://issues.apache.org/jira/browse/GEODE-4498
 Project: Geode
  Issue Type: Bug
  Components: gfsh, wan
Reporter: Shelley Lynn Hughes-Godfrey


Occurred in CI on geode 1.4:
https://concourse.apachegeode-ci.info/teams/main/pipelines/release-1.4.0/jobs/DistributedTest/builds/16

{noformat}
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.test.dunit.rules.MemberVM$$Lambda$43/465470667.run in VM 0 
running on Host 39e2a1b72a9e with 4 VMs
at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
at 
org.apache.geode.test.dunit.rules.MemberVM.waitTillAsyncEventQueuesAreReadyOnServers(MemberVM.java:126)
at 
org.apache.geode.management.internal.cli.commands.DestroyAsyncEventQueueCommandDUnitTest.destroyAeqWhenQueueDoesNotExist_deafultReturnsError(DestroyAsyncEventQueueCommandDUnitTest.java:90)

Caused by:
org.awaitility.core.ConditionTimeoutException: Condition with lambda 
expression in org.apache.geode.test.junit.rules.MemberStarterRule was not 
fulfilled within 2 seconds.
{noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4498) CI failure: org.apache.geode.management.internal.cli.commands.DestroyAsyncEventQueueCommandDUnitTest > destroyAeqWhenQueueDoesNotExist_deafultReturnsError FAILED

2018-02-02 Thread Shelley Lynn Hughes-Godfrey (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shelley Lynn Hughes-Godfrey updated GEODE-4498:
---
Affects Version/s: 1.4.0

> CI failure: 
> org.apache.geode.management.internal.cli.commands.DestroyAsyncEventQueueCommandDUnitTest
>  > destroyAeqWhenQueueDoesNotExist_deafultReturnsError FAILED
> -
>
> Key: GEODE-4498
> URL: https://issues.apache.org/jira/browse/GEODE-4498
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh, wan
>Affects Versions: 1.4.0
>Reporter: Shelley Lynn Hughes-Godfrey
>Priority: Major
>
> Occurred in CI on geode 1.4:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/release-1.4.0/jobs/DistributedTest/builds/16
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.test.dunit.rules.MemberVM$$Lambda$43/465470667.run in VM 0 
> running on Host 39e2a1b72a9e with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at 
> org.apache.geode.test.dunit.rules.MemberVM.waitTillAsyncEventQueuesAreReadyOnServers(MemberVM.java:126)
> at 
> org.apache.geode.management.internal.cli.commands.DestroyAsyncEventQueueCommandDUnitTest.destroyAeqWhenQueueDoesNotExist_deafultReturnsError(DestroyAsyncEventQueueCommandDUnitTest.java:90)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Condition with lambda 
> expression in org.apache.geode.test.junit.rules.MemberStarterRule was not 
> fulfilled within 2 seconds.
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4499) Add DUnit to test adding compressor to an existing persistent region.

2018-02-02 Thread Sai Boorlagadda (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sai Boorlagadda updated GEODE-4499:
---
Summary: Add DUnit to test adding compressor to an existing persistent 
region.  (was: Add DUnit to test adding compressor to persistent region.)

> Add DUnit to test adding compressor to an existing persistent region.
> -
>
> Key: GEODE-4499
> URL: https://issues.apache.org/jira/browse/GEODE-4499
> Project: Geode
>  Issue Type: Test
>  Components: gfsh
>Reporter: Sai Boorlagadda
>Priority: Major
>
> Add a DUnit to test alter disk-store & region to add a compressor and verify 
> that the existing region can be recovered after altering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4464) Remove singleton calls from all tests in org.apache.geode.cache30

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4464:
-
Description: 
These tests in org.apache.geode.cache30 invoke singleton getters.

CacheFactory.getAnyInstance():
* CacheSerializableRunnable
* ClientServerCCEDUnitTest
* MultiVMRegionTestCase
* ReconnectDUnitTest

CacheFactory.getExisting(DistributedSystem):
* MultiVMRegionTestCase.testDistributedPut
* MultiVMRegionTestCase.testTXAlgebra
* MultiVMRegionTestCase.testTXSimpleOps
* MultiVMRegionTestCase.testTXUpdateLoadNoConflict
* MultiVMRegionTestCase.testTXRmtMirror
* MultiVMRegionTestCase.testTXMultiRegion

InternalDistributedSystem.getAnyInstance():
* CachedAllEventsDUnitTest
* CallbackArgDUnitTest
* ClientMembershipDUnitTest
* ClientServerTestCase
* ProxyDUnitTest
* ReconnectDUnitTest
* RegionMembershipListenerDUnitTest
* RegionReliabilityTestCase
* RemotePRValuesAreNotDeserializedRegressionTest
* TXOrderDUnitTest
* ValuesAreLazilyDeserializedRegressionTest


  was:
These tests in org.apache.geode.cache30 invoke singleton getters.

CacheFactory.getAnyInstance():
* CacheSerializableRunnable
* ClientServerCCEDUnitTest
* MultiVMRegionTestCase
* ReconnectDUnitTest

CacheFactory.getExisting(DistributedSystem):
* MultiVMRegionTestCase.testDistributedPut
* MultiVMRegionTestCase.testTXAlgebra
* MultiVMRegionTestCase.testTXSimpleOps
* MultiVMRegionTestCase.testTXUpdateLoadNoConflict
* MultiVMRegionTestCase.testTXRmtMirror
* MultiVMRegionTestCase.testTXMultiRegion


> Remove singleton calls from all tests in org.apache.geode.cache30
> -
>
> Key: GEODE-4464
> URL: https://issues.apache.org/jira/browse/GEODE-4464
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.cache30 invoke singleton getters.
> CacheFactory.getAnyInstance():
> * CacheSerializableRunnable
> * ClientServerCCEDUnitTest
> * MultiVMRegionTestCase
> * ReconnectDUnitTest
> CacheFactory.getExisting(DistributedSystem):
> * MultiVMRegionTestCase.testDistributedPut
> * MultiVMRegionTestCase.testTXAlgebra
> * MultiVMRegionTestCase.testTXSimpleOps
> * MultiVMRegionTestCase.testTXUpdateLoadNoConflict
> * MultiVMRegionTestCase.testTXRmtMirror
> * MultiVMRegionTestCase.testTXMultiRegion
> InternalDistributedSystem.getAnyInstance():
> * CachedAllEventsDUnitTest
> * CallbackArgDUnitTest
> * ClientMembershipDUnitTest
> * ClientServerTestCase
> * ProxyDUnitTest
> * ReconnectDUnitTest
> * RegionMembershipListenerDUnitTest
> * RegionReliabilityTestCase
> * RemotePRValuesAreNotDeserializedRegressionTest
> * TXOrderDUnitTest
> * ValuesAreLazilyDeserializedRegressionTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-3583) Remove all usages of static methods to the Cache

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-3583:
-
Description: 
This ticket is the parent ticket to remove all invocations of 
Cache.getAnyInstance(), GemFireCacheImpl.getInstance(), etc... 
This improvement is complete is there are no more usages of the static methods 
to retrieve a Cache

As per some work that [~huynhja] has done
_ grep -rl "GemFireCacheImpl.getInstance" --include \*.java . > 
GemFireCacheImplList.txt

grep -rl "CacheFactory.getAnyInstance" --include \*.java . > 
CacheFactoryList.txt

grep -rl "InternalDistributedSystem.getAnyInstance" --include \*.java . > 
InternalDistributedSystemList.txt

I've attached the files to this email...

The combinedList.txt is a grep that combined all 3 calls into a single file... _

[EDIT] Additional singleton getters that need to be removed:
* CacheFactory.getInstance(DistributedSystem)
* CacheFactory.getInstanceCloseOk(DistributedSystem)
* GemFireCacheImpl.getExisting()
* GemFireCacheImpl.getExisting(String)
* GemFireCacheImpl.getForPdx(String)
* GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl)
* InternalDistributedSystem.getAnyInstance()
* InternalDistributedSystem getConnectedInstance()
* InternalDistributedSystem unsafeGetConnectedInstance()


  was:
This ticket is the parent ticket to remove all invocations of 
Cache.getAnyInstance(), GemFireCacheImpl.getInstance(), etc... 
This improvement is complete is there are no more usages of the static methods 
to retrieve a Cache

As per some work that [~huynhja] has done
_ grep -rl "GemFireCacheImpl.getInstance" --include \*.java . > 
GemFireCacheImplList.txt

grep -rl "CacheFactory.getAnyInstance" --include \*.java . > 
CacheFactoryList.txt

grep -rl "InternalDistributedSystem.getAnyInstance" --include \*.java . > 
InternalDistributedSystemList.txt

I've attached the files to this email...

The combinedList.txt is a grep that combined all 3 calls into a single file... _

[EDIT] Additional singleton getters that need to be removed:
* CacheFactory.getInstance(DistributedSystem)
* CacheFactory.getInstanceCloseOk(DistributedSystem)
* GemFireCacheImpl.getExisting()
* GemFireCacheImpl.getExisting(String)
* GemFireCacheImpl.getForPdx(String)
* InternalDistributedSystem.getAnyInstance()
* InternalDistributedSystem getConnectedInstance()
* InternalDistributedSystem unsafeGetConnectedInstance()



> Remove all usages of static methods to the Cache
> 
>
> Key: GEODE-3583
> URL: https://issues.apache.org/jira/browse/GEODE-3583
> Project: Geode
>  Issue Type: Improvement
>Reporter: Udo Kohlmeyer
>Priority: Major
>  Labels: pull-request-available
> Attachments: CacheFactoryList.txt, CombinedList.txt, 
> GemFireCacheImplList.txt, InternalDistributedSystemList.txt
>
>  Time Spent: 1h
>  Remaining Estimate: 0h
>
> This ticket is the parent ticket to remove all invocations of 
> Cache.getAnyInstance(), GemFireCacheImpl.getInstance(), etc... 
> This improvement is complete is there are no more usages of the static 
> methods to retrieve a Cache
> As per some work that [~huynhja] has done
> _ grep -rl "GemFireCacheImpl.getInstance" --include \*.java . > 
> GemFireCacheImplList.txt
> grep -rl "CacheFactory.getAnyInstance" --include \*.java . > 
> CacheFactoryList.txt
> grep -rl "InternalDistributedSystem.getAnyInstance" --include \*.java . > 
> InternalDistributedSystemList.txt
> I've attached the files to this email...
> The combinedList.txt is a grep that combined all 3 calls into a single 
> file... _
> [EDIT] Additional singleton getters that need to be removed:
> * CacheFactory.getInstance(DistributedSystem)
> * CacheFactory.getInstanceCloseOk(DistributedSystem)
> * GemFireCacheImpl.getExisting()
> * GemFireCacheImpl.getExisting(String)
> * GemFireCacheImpl.getForPdx(String)
> * GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl)
> * InternalDistributedSystem.getAnyInstance()
> * InternalDistributedSystem getConnectedInstance()
> * InternalDistributedSystem unsafeGetConnectedInstance()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4461) Remove singleton calls from all tests in org.apache.geode.security

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4461:
-
Description: 
These tests in org.apache.geode.security invoke singleton getters.

CacheFactory.getAnyInstance():
* PDXGfshPostProcessorOnRemoteServerTest

GemFireCacheImpl.getInstance():
* ClientCQPostAuthorizationDUnitTest
* ClientMultiUserAuthzDUnitTest
* MultiUserAPIDUnitTest
* MultiUserDurableCQAuthzDUnitTest

InternalDistributedSystem.getAnyInstance():
* P2PAuthenticationDUnitTest

  was:
These tests in org.apache.geode.security invoke singleton getters.

CacheFactory.getAnyInstance():
* PDXGfshPostProcessorOnRemoteServerTest

GemFireCacheImpl.getInstance():
* ClientCQPostAuthorizationDUnitTest
* ClientMultiUserAuthzDUnitTest
* MultiUserAPIDUnitTest
* MultiUserDurableCQAuthzDUnitTest



> Remove singleton calls from all tests in org.apache.geode.security
> --
>
> Key: GEODE-4461
> URL: https://issues.apache.org/jira/browse/GEODE-4461
> Project: Geode
>  Issue Type: Sub-task
>  Components: security, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.security invoke singleton getters.
> CacheFactory.getAnyInstance():
> * PDXGfshPostProcessorOnRemoteServerTest
> GemFireCacheImpl.getInstance():
> * ClientCQPostAuthorizationDUnitTest
> * ClientMultiUserAuthzDUnitTest
> * MultiUserAPIDUnitTest
> * MultiUserDurableCQAuthzDUnitTest
> InternalDistributedSystem.getAnyInstance():
> * P2PAuthenticationDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4487) Remove singleton calls from all tests in org.apache.geode.internal.offheap

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4487:
-
Description: 
These tests in org.apache.geode.internal.offheap invoke singleton getters.

GemFireCacheImpl.getInstance():
* OutOfOffHeapMemoryDUnitTest

GemFireCacheImpl.getForPdx(String):
* DataTypeJUnitTest

InternalDistributedSystem.getAnyInstance():
* OutOfOffHeapMemoryDUnitTest

  was:
These tests in org.apache.geode.internal.offheap invoke singleton getters.

GemFireCacheImpl.getInstance():
* OutOfOffHeapMemoryDUnitTest

GemFireCacheImpl.getForPdx(String):
* DataTypeJUnitTest


> Remove singleton calls from all tests in org.apache.geode.internal.offheap
> --
>
> Key: GEODE-4487
> URL: https://issues.apache.org/jira/browse/GEODE-4487
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.offheap invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * OutOfOffHeapMemoryDUnitTest
> GemFireCacheImpl.getForPdx(String):
> * DataTypeJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * OutOfOffHeapMemoryDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4503) Remove singleton calls from all tests in org.apache.geode.internal.cache.executeorg.apache.geode.internal.cache.locks

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4503:
-
Description: 
These tests in org.apache.geode.internal.cache.locks invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* TXLockServiceDUnitTest

  was:
These tests in org.apache.geode.internal.cache.execute invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* TXLockServiceDUnitTest


> Remove singleton calls from all tests in 
> org.apache.geode.internal.cache.executeorg.apache.geode.internal.cache.locks
> -
>
> Key: GEODE-4503
> URL: https://issues.apache.org/jira/browse/GEODE-4503
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests, transactions
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache.locks invoke singleton getters.
> InternalDistributedSystem.getAnyInstance():
> * TXLockServiceDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4503) Remove singleton calls from all tests in org.apache.geode.internal.cache.executeorg.apache.geode.internal.cache.locks

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4503:
-
Summary: Remove singleton calls from all tests in 
org.apache.geode.internal.cache.executeorg.apache.geode.internal.cache.locks  
(was: Remove singleton calls from all tests in 
org.apache.geode.internal.cache.execute)

> Remove singleton calls from all tests in 
> org.apache.geode.internal.cache.executeorg.apache.geode.internal.cache.locks
> -
>
> Key: GEODE-4503
> URL: https://issues.apache.org/jira/browse/GEODE-4503
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests, transactions
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache.execute invoke singleton 
> getters.
> InternalDistributedSystem.getAnyInstance():
> * TXLockServiceDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4502) Remove singleton calls from all tests in org.apache.geode.internal.cache.functions

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4502:
-
Description: 
These tests in org.apache.geode.internal.cache.functions invoke singleton 
getters.

InternalDistributedSystem.getAnyInstance():
* FireAndForgetFunctionOnAllServers
* TestFunction

InternalDistributedSystem.getConnectedInstance():
* DistributedRegionFunction
* TestFunction

  was:
These tests in org.apache.geode.internal.cache.functions invoke singleton 
getters.

InternalDistributedSystem.getAnyInstance():
* FireAndForgetFunctionOnAllServers
* TestFunction


> Remove singleton calls from all tests in 
> org.apache.geode.internal.cache.functions
> --
>
> Key: GEODE-4502
> URL: https://issues.apache.org/jira/browse/GEODE-4502
> Project: Geode
>  Issue Type: Sub-task
>  Components: functions, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache.functions invoke singleton 
> getters.
> InternalDistributedSystem.getAnyInstance():
> * FireAndForgetFunctionOnAllServers
> * TestFunction
> InternalDistributedSystem.getConnectedInstance():
> * DistributedRegionFunction
> * TestFunction



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4510) Remove singleton calls from all tests in org.apache.geode.test.dunit.rules

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4510:


 Summary: Remove singleton calls from all tests in 
org.apache.geode.test.dunit.rules
 Key: GEODE-4510
 URL: https://issues.apache.org/jira/browse/GEODE-4510
 Project: Geode
  Issue Type: Sub-task
  Components: tests
Reporter: Kirk Lund


These tests in org.apache.geode.test.dunit.rules invoke singleton getters.

InternalDistributedSystem.getConnectedInstance():
* DistributedDisconnectRule



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4509) change the InternalCache interface to use InternalRegion instead of LocalRegion

2018-02-02 Thread Darrel Schneider (JIRA)
Darrel Schneider created GEODE-4509:
---

 Summary: change the InternalCache interface to use InternalRegion 
instead of LocalRegion
 Key: GEODE-4509
 URL: https://issues.apache.org/jira/browse/GEODE-4509
 Project: Geode
  Issue Type: Improvement
  Components: regions
Reporter: Darrel Schneider


The InternalCache interface should not expose or use LocalRegion. It should use 
InternalRegion instead.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4489) Remove singleton calls from all tests in org.apache.geode.test.junit.rules

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4489:
-
Description: 
These tests in org.apache.geode.rest.internal.web.controllers invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* ServerStarterRule

InternalDistributedSystem.getConnectedInstance():
* MemberStarterRule

  was:
These tests in org.apache.geode.rest.internal.web.controllers invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* ServerStarterRule



> Remove singleton calls from all tests in org.apache.geode.test.junit.rules
> --
>
> Key: GEODE-4489
> URL: https://issues.apache.org/jira/browse/GEODE-4489
> Project: Geode
>  Issue Type: Sub-task
>  Components: management, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.rest.internal.web.controllers invoke 
> singleton getters.
> GemFireCacheImpl.getInstance():
> * ServerStarterRule
> InternalDistributedSystem.getConnectedInstance():
> * MemberStarterRule



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4489) Remove singleton calls from all tests in org.apache.geode.test.junit.rules

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4489:
-
Description: 
These tests in org.apache.geode.test.junit.rules invoke singleton getters.

GemFireCacheImpl.getInstance():
* ServerStarterRule

InternalDistributedSystem.getConnectedInstance():
* MemberStarterRule

  was:
These tests in org.apache.geode.rest.internal.web.controllers invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* ServerStarterRule

InternalDistributedSystem.getConnectedInstance():
* MemberStarterRule


> Remove singleton calls from all tests in org.apache.geode.test.junit.rules
> --
>
> Key: GEODE-4489
> URL: https://issues.apache.org/jira/browse/GEODE-4489
> Project: Geode
>  Issue Type: Sub-task
>  Components: management, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.test.junit.rules invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * ServerStarterRule
> InternalDistributedSystem.getConnectedInstance():
> * MemberStarterRule



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4453) Remove singleton calls from all tests in org.apache.geode.internal.cache.execute

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4453:
-
Description: 
These tests in org.apache.geode.internal.cache.execute invoke singleton getters.

CacheFactory.getAnyInstance():
* OnGroupsFunctionExecutionDUnitTest
* MemberFunctionExecutionDUnitTest
* FunctionServiceBase
* QueryDataInconsistencyDUnitTest

CacheFactory.getExisting(DistributedSystem):
* OnGroupsFunctionExecutionDUnitTest

GemFireCacheImpl.getInstance():
* LocalDataSetIndexingDUnitTest
* PRFunctionExecutionDUnitTest

InternalDistributedSystem.getAnyInstance():
* FunctionServiceClientAccessorPRBase$BucketMovingNonHAFunction
* FunctionServiceBase
* FunctionServiceBase$CacheClosingNonHAFunction
* TestFunction

  was:
These tests in org.apache.geode.internal.cache.execute invoke singleton getters.

CacheFactory.getAnyInstance():
* OnGroupsFunctionExecutionDUnitTest
* MemberFunctionExecutionDUnitTest
* FunctionServiceBase
* QueryDataInconsistencyDUnitTest

CacheFactory.getExisting(DistributedSystem):
* OnGroupsFunctionExecutionDUnitTest

GemFireCacheImpl.getInstance():
* LocalDataSetIndexingDUnitTest
* PRFunctionExecutionDUnitTest


> Remove singleton calls from all tests in 
> org.apache.geode.internal.cache.execute
> 
>
> Key: GEODE-4453
> URL: https://issues.apache.org/jira/browse/GEODE-4453
> Project: Geode
>  Issue Type: Sub-task
>  Components: functions, querying, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache.execute invoke singleton 
> getters.
> CacheFactory.getAnyInstance():
> * OnGroupsFunctionExecutionDUnitTest
> * MemberFunctionExecutionDUnitTest
> * FunctionServiceBase
> * QueryDataInconsistencyDUnitTest
> CacheFactory.getExisting(DistributedSystem):
> * OnGroupsFunctionExecutionDUnitTest
> GemFireCacheImpl.getInstance():
> * LocalDataSetIndexingDUnitTest
> * PRFunctionExecutionDUnitTest
> InternalDistributedSystem.getAnyInstance():
> * FunctionServiceClientAccessorPRBase$BucketMovingNonHAFunction
> * FunctionServiceBase
> * FunctionServiceBase$CacheClosingNonHAFunction
> * TestFunction



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4457) Remove singleton calls from all tests in org.apache.geode.rest.internal.web.controllers

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4457:
-
Description: 
These tests in org.apache.geode.rest.internal.web.controllers invoke singleton 
getters.

CacheFactory.getAnyInstance():
* AddFreeItemToOrders
* GetDeliveredOrders
* GetRegions
* GetValueForKey
* RestAPIOnRegionFunctionExecutionDUnitTest
* RestQueryAndFunctionIntegrationTest

GemFireCacheImpl.getInstance():
* RestAPIsAndInterOpsDUnitTest
* RestAPIsWithSSLDUnitTest

InternalDistributedSystem.getAnyInstance():
* RestAPIOnRegionFunctionExecutionDUnitTest


  was:
These tests in org.apache.geode.rest.internal.web.controllers invoke singleton 
getters.

CacheFactory.getAnyInstance():
* AddFreeItemToOrders
* GetDeliveredOrders
* GetRegions
* GetValueForKey
* RestAPIOnRegionFunctionExecutionDUnitTest
* RestQueryAndFunctionIntegrationTest

GemFireCacheImpl.getInstance():
* RestAPIsAndInterOpsDUnitTest
* RestAPIsWithSSLDUnitTest


> Remove singleton calls from all tests in 
> org.apache.geode.rest.internal.web.controllers
> ---
>
> Key: GEODE-4457
> URL: https://issues.apache.org/jira/browse/GEODE-4457
> Project: Geode
>  Issue Type: Sub-task
>  Components: rest (dev), tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.rest.internal.web.controllers invoke 
> singleton getters.
> CacheFactory.getAnyInstance():
> * AddFreeItemToOrders
> * GetDeliveredOrders
> * GetRegions
> * GetValueForKey
> * RestAPIOnRegionFunctionExecutionDUnitTest
> * RestQueryAndFunctionIntegrationTest
> GemFireCacheImpl.getInstance():
> * RestAPIsAndInterOpsDUnitTest
> * RestAPIsWithSSLDUnitTest
> InternalDistributedSystem.getAnyInstance():
> * RestAPIOnRegionFunctionExecutionDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-4504) Remove singleton calls from all tests in org.apache.geode.test.dunit

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-4504:


Assignee: Kirk Lund

> Remove singleton calls from all tests in org.apache.geode.test.dunit
> 
>
> Key: GEODE-4504
> URL: https://issues.apache.org/jira/browse/GEODE-4504
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.test.dunit invoke singleton getters.
> InternalDistributedSystem.getConnectedInstance():
> * IgnoredException
> * Disconnect



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4508) Remove singleton calls from launcher tests in org.apache.geode.distributed

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4508:


 Summary: Remove singleton calls from launcher tests in 
org.apache.geode.distributed
 Key: GEODE-4508
 URL: https://issues.apache.org/jira/browse/GEODE-4508
 Project: Geode
  Issue Type: Sub-task
  Components: gfsh, management, tests
Reporter: Kirk Lund


These gfsh launcher tests in org.apache.geode.distributed invoke singleton 
getters.

InternalDistributedSystem.getConnectedInstance():
* LauncherIntegrationTestCase
* ServerLauncherTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4469) Remove singleton calls from all tests in org.apache.geode.distributed

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4469:
-
Description: 
These tests in org.apache.geode.distributed invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* DistributedSystemDUnitTest

GemFireCacheImpl.getInstance():
* LocatorDUnitTest
* LocatorJUnitTest

InternalDistributedSystem.getAnyInstance():
* HostedLocatorsDUnitTest
* LocatorDUnitTest
* SystemAdminDUnitTest

InternalDistributedSystem.getConnectedInstance():
* LocatorDUnitTest


  was:
These tests in org.apache.geode.distributed invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* DistributedSystemDUnitTest

GemFireCacheImpl.getInstance():
* LocatorDUnitTest
* LocatorJUnitTest

InternalDistributedSystem.getAnyInstance():
* HostedLocatorsDUnitTest
* LocatorDUnitTest
* SystemAdminDUnitTest

InternalDistributedSystem.getConnectedInstance():
* LauncherIntegrationTestCase
* LocatorDUnitTest
* 


> Remove singleton calls from all tests in org.apache.geode.distributed
> -
>
> Key: GEODE-4469
> URL: https://issues.apache.org/jira/browse/GEODE-4469
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.distributed invoke singleton getters.
> CacheFactory.getExisting(DistributedSystem):
> * DistributedSystemDUnitTest
> GemFireCacheImpl.getInstance():
> * LocatorDUnitTest
> * LocatorJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * HostedLocatorsDUnitTest
> * LocatorDUnitTest
> * SystemAdminDUnitTest
> InternalDistributedSystem.getConnectedInstance():
> * LocatorDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4469) Remove singleton calls from all tests in org.apache.geode.distributed

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4469:
-
Description: 
These tests in org.apache.geode.distributed invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* DistributedSystemDUnitTest

GemFireCacheImpl.getInstance():
* LocatorDUnitTest
* LocatorJUnitTest

InternalDistributedSystem.getAnyInstance():
* HostedLocatorsDUnitTest
* LocatorDUnitTest
* SystemAdminDUnitTest

InternalDistributedSystem.getConnectedInstance():
* LauncherIntegrationTestCase
* LocatorDUnitTest
* 

  was:
These tests in org.apache.geode.distributed invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* DistributedSystemDUnitTest

GemFireCacheImpl.getInstance():
* LocatorDUnitTest
* LocatorJUnitTest

InternalDistributedSystem.getAnyInstance():
* HostedLocatorsDUnitTest
* LocatorDUnitTest
* SystemAdminDUnitTest


> Remove singleton calls from all tests in org.apache.geode.distributed
> -
>
> Key: GEODE-4469
> URL: https://issues.apache.org/jira/browse/GEODE-4469
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.distributed invoke singleton getters.
> CacheFactory.getExisting(DistributedSystem):
> * DistributedSystemDUnitTest
> GemFireCacheImpl.getInstance():
> * LocatorDUnitTest
> * LocatorJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * HostedLocatorsDUnitTest
> * LocatorDUnitTest
> * SystemAdminDUnitTest
> InternalDistributedSystem.getConnectedInstance():
> * LauncherIntegrationTestCase
> * LocatorDUnitTest
> * 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4511) Avoid creation of unnecessary default pool

2018-02-02 Thread Michael Dodge (JIRA)
Michael Dodge created GEODE-4511:


 Summary: Avoid creation of unnecessary default pool
 Key: GEODE-4511
 URL: https://issues.apache.org/jira/browse/GEODE-4511
 Project: Geode
  Issue Type: Improvement
  Components: client/server
Reporter: Michael Dodge


The Java API for creating a client cache automatically creates a default pool 
although this default pool is not used for almost all real use cases. Moreover, 
this pool periodically tries to connect to the server. This is basically 
harmless but it wastes resources a little bit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4481) Remove singleton calls from membership tests in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4481:
-
Summary: Remove singleton calls from membership tests in org.apache.geode  
(was: Remove singleton calls from all tests in org.apache.geode)

> Remove singleton calls from membership tests in org.apache.geode
> 
>
> Key: GEODE-4481
> URL: https://issues.apache.org/jira/browse/GEODE-4481
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership, serialization, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * DeltaTestImpl
> InternalDistributedSystem.getAnyInstance():
> * LonerDMJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4481) Remove singleton calls from membership tests in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4481:
-
Description: 
These membership tests in org.apache.geode invoke singleton getters.

GemFireCacheImpl.getInstance():
* DeltaTestImpl

InternalDistributedSystem.getAnyInstance():
* LonerDMJUnitTest


  was:
These tests in org.apache.geode invoke singleton getters.

GemFireCacheImpl.getInstance():
* DeltaTestImpl

InternalDistributedSystem.getAnyInstance():
* LonerDMJUnitTest



> Remove singleton calls from membership tests in org.apache.geode
> 
>
> Key: GEODE-4481
> URL: https://issues.apache.org/jira/browse/GEODE-4481
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership, serialization, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These membership tests in org.apache.geode invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * DeltaTestImpl
> InternalDistributedSystem.getAnyInstance():
> * LonerDMJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4468) Remove singleton calls from all tests in org.apache.geode.internal.jta

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4468:
-
Description: 
These tests in org.apache.geode.internal.jta invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* CacheUtils

InternalDistributedSystem.getAnyInstance():
* BlockingTimeOutJUnitTest
* JtaIntegrationJUnitTest

  was:
These tests in org.apache.geode.internal.jta invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* CacheUtils



> Remove singleton calls from all tests in org.apache.geode.internal.jta
> --
>
> Key: GEODE-4468
> URL: https://issues.apache.org/jira/browse/GEODE-4468
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests, transactions
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.jta invoke singleton getters.
> CacheFactory.getExisting(DistributedSystem):
> * CacheUtils
> InternalDistributedSystem.getAnyInstance():
> * BlockingTimeOutJUnitTest
> * JtaIntegrationJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4469) Remove singleton calls from all tests in org.apache.geode.distributed

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4469:
-
Description: 
These tests in org.apache.geode.distributed invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* DistributedSystemDUnitTest

GemFireCacheImpl.getInstance():
* LocatorDUnitTest
* LocatorJUnitTest

InternalDistributedSystem.getAnyInstance():
* HostedLocatorsDUnitTest
* LocatorDUnitTest
* SystemAdminDUnitTest

  was:
These tests in org.apache.geode.distributed invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* DistributedSystemDUnitTest

GemFireCacheImpl.getInstance():
* LocatorDUnitTest
* LocatorJUnitTest


> Remove singleton calls from all tests in org.apache.geode.distributed
> -
>
> Key: GEODE-4469
> URL: https://issues.apache.org/jira/browse/GEODE-4469
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.distributed invoke singleton getters.
> CacheFactory.getExisting(DistributedSystem):
> * DistributedSystemDUnitTest
> GemFireCacheImpl.getInstance():
> * LocatorDUnitTest
> * LocatorJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * HostedLocatorsDUnitTest
> * LocatorDUnitTest
> * SystemAdminDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4472) Remove singleton calls from all tests in org.apache.geode.internal.cache.partitioned

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4472:
-
Description: 
These tests in org.apache.geode.internal.cache.partitioned invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* PersistentPartitionedRegionDUnitTest

InternalDistributedSystem.getAnyInstance():
* Bug39356DUnitTest

  was:
These tests in org.apache.geode.internal.cache.partitioned invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* PersistentPartitionedRegionDUnitTest



> Remove singleton calls from all tests in 
> org.apache.geode.internal.cache.partitioned
> 
>
> Key: GEODE-4472
> URL: https://issues.apache.org/jira/browse/GEODE-4472
> Project: Geode
>  Issue Type: Sub-task
>  Components: persistence, regions, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache.partitioned invoke singleton 
> getters.
> GemFireCacheImpl.getInstance():
> * PersistentPartitionedRegionDUnitTest
> InternalDistributedSystem.getAnyInstance():
> * Bug39356DUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4474) Remove singleton calls from all tests in org.apache.geode.cache.client.internal

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4474:
-
Description: 
These tests in org.apache.geode.cache.client.internal invoke singleton getters.

GemFireCacheImpl.getInstance():
* AutoConnectionSourceDUnitTest

InternalDistributedSystem.getAnyInstance():
* AutoConnectionSourceImplJUnitTest

  was:
These tests in org.apache.geode.cache.client.internal invoke singleton getters.

GemFireCacheImpl.getInstance():
* AutoConnectionSourceDUnitTest



> Remove singleton calls from all tests in 
> org.apache.geode.cache.client.internal
> ---
>
> Key: GEODE-4474
> URL: https://issues.apache.org/jira/browse/GEODE-4474
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.cache.client.internal invoke singleton 
> getters.
> GemFireCacheImpl.getInstance():
> * AutoConnectionSourceDUnitTest
> InternalDistributedSystem.getAnyInstance():
> * AutoConnectionSourceImplJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4485) Remove singleton calls from all tests in org.apache.geode.cache.query.functional

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4485:
-
Description: 
These tests in org.apache.geode.cache.query.functional invoke singleton getters.

GemFireCacheImpl.getInstance():
* LimitClauseJUnitTest
* QueryREUpdateInProgressJUnitTest

InternalDistributedSystem.getAnyInstance():
* IndexCreationJUnitTest

  was:
These tests in org.apache.geode.cache.query.functional invoke singleton getters.

GemFireCacheImpl.getInstance():
* LimitClauseJUnitTest
* QueryREUpdateInProgressJUnitTest


> Remove singleton calls from all tests in 
> org.apache.geode.cache.query.functional
> 
>
> Key: GEODE-4485
> URL: https://issues.apache.org/jira/browse/GEODE-4485
> Project: Geode
>  Issue Type: Sub-task
>  Components: querying, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.cache.query.functional invoke singleton 
> getters.
> GemFireCacheImpl.getInstance():
> * LimitClauseJUnitTest
> * QueryREUpdateInProgressJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * IndexCreationJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4481) Remove singleton calls from all tests in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4481:
-
Description: 
These tests in org.apache.geode invoke singleton getters.

GemFireCacheImpl.getInstance():
* DeltaTestImpl

InternalDistributedSystem.getAnyInstance():
* JtaNoninvolvementJUnitTest
* LonerDMJUnitTest
* TXJUnitTest
* TXWriterTestCase

  was:
These tests in org.apache.geode invoke singleton getters.

GemFireCacheImpl.getInstance():
* DeltaTestImpl



> Remove singleton calls from all tests in org.apache.geode
> -
>
> Key: GEODE-4481
> URL: https://issues.apache.org/jira/browse/GEODE-4481
> Project: Geode
>  Issue Type: Sub-task
>  Components: serialization, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * DeltaTestImpl
> InternalDistributedSystem.getAnyInstance():
> * JtaNoninvolvementJUnitTest
> * LonerDMJUnitTest
> * TXJUnitTest
> * TXWriterTestCase



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4456) Remove singleton calls from all tests in org.apache.geode.internal.cache

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4456:
-
Description: 
These tests in org.apache.geode.internal.cache invoke singleton getters.

CacheFactory.getAnyInstance():
* Bug37241DUnitTest
* CommitFunction
* GridAdvisorDUnitTest
* NestedTransactionFunction
* RollbackFunction
* SingleHopStatsDUnitTest
* UpdateVersionDUnitTest

CacheFactory.getExisting(DistributedSystem):
* PartitionedRegionTestHelper

GemFireCacheImpl.getInstance():
* DiskRegRecoveryJUnitTest
* FixedPRSinglehopDUnitTest
* NetSearchMessagingDUnitTest
* RemoteCQTransactionDUnitTest
* RemoteTransactionDUnitTest
* SystemFailureDUnitTest

GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
* ColocationHelperTest

InternalDistributedSystem.getAnyInstance():
* ClientServerTransactionDUnitTest
* GridAdvisorDUnitTest

InternalDistributedSystem.getConnectedInstance():
* ClientServerTransactionDUnitTest
* TombstoneCreationJUnitTest

  was:
These tests in org.apache.geode.internal.cache invoke singleton getters.

CacheFactory.getAnyInstance():
* Bug37241DUnitTest
* CommitFunction
* GridAdvisorDUnitTest
* NestedTransactionFunction
* RollbackFunction
* SingleHopStatsDUnitTest
* UpdateVersionDUnitTest

CacheFactory.getExisting(DistributedSystem):
* PartitionedRegionTestHelper

GemFireCacheImpl.getInstance():
* DiskRegRecoveryJUnitTest
* FixedPRSinglehopDUnitTest
* NetSearchMessagingDUnitTest
* RemoteCQTransactionDUnitTest
* RemoteTransactionDUnitTest
* SystemFailureDUnitTest

GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
* ColocationHelperTest

InternalDistributedSystem.getAnyInstance():
* ClientServerTransactionDUnitTest
* GridAdvisorDUnitTest


> Remove singleton calls from all tests in org.apache.geode.internal.cache
> 
>
> Key: GEODE-4456
> URL: https://issues.apache.org/jira/browse/GEODE-4456
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions, tests, transactions
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache invoke singleton getters.
> CacheFactory.getAnyInstance():
> * Bug37241DUnitTest
> * CommitFunction
> * GridAdvisorDUnitTest
> * NestedTransactionFunction
> * RollbackFunction
> * SingleHopStatsDUnitTest
> * UpdateVersionDUnitTest
> CacheFactory.getExisting(DistributedSystem):
> * PartitionedRegionTestHelper
> GemFireCacheImpl.getInstance():
> * DiskRegRecoveryJUnitTest
> * FixedPRSinglehopDUnitTest
> * NetSearchMessagingDUnitTest
> * RemoteCQTransactionDUnitTest
> * RemoteTransactionDUnitTest
> * SystemFailureDUnitTest
> GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
> * ColocationHelperTest
> InternalDistributedSystem.getAnyInstance():
> * ClientServerTransactionDUnitTest
> * GridAdvisorDUnitTest
> InternalDistributedSystem.getConnectedInstance():
> * ClientServerTransactionDUnitTest
> * TombstoneCreationJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4465) Remove singleton calls from all tests in org.apache.geode.cache.client

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4465:
-
Component/s: client queues

> Remove singleton calls from all tests in org.apache.geode.cache.client
> --
>
> Key: GEODE-4465
> URL: https://issues.apache.org/jira/browse/GEODE-4465
> Project: Geode
>  Issue Type: Sub-task
>  Components: client queues, client/server, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.cache.client invoke singleton getters.
> CacheFactory.getAnyInstance():
> * ClientServerRegisterInterestsDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4513) Remove singleton calls from delta test classes in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4513:


 Summary: Remove singleton calls from delta test classes in 
org.apache.geode
 Key: GEODE-4513
 URL: https://issues.apache.org/jira/browse/GEODE-4513
 Project: Geode
  Issue Type: Sub-task
  Components: serialization, tests
Reporter: Kirk Lund


These delta test classes in org.apache.geode invoke singleton getters.

GemFireCacheImpl.getInstance():
* DeltaTestImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4481) Remove singleton calls from membership tests in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4481:
-
Description: 
These membership tests in org.apache.geode invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* LonerDMJUnitTest


  was:
These membership tests in org.apache.geode invoke singleton getters.

GemFireCacheImpl.getInstance():
* DeltaTestImpl

InternalDistributedSystem.getAnyInstance():
* LonerDMJUnitTest



> Remove singleton calls from membership tests in org.apache.geode
> 
>
> Key: GEODE-4481
> URL: https://issues.apache.org/jira/browse/GEODE-4481
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These membership tests in org.apache.geode invoke singleton getters.
> InternalDistributedSystem.getAnyInstance():
> * LonerDMJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4481) Remove singleton calls from membership tests in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4481:
-
Component/s: (was: serialization)

> Remove singleton calls from membership tests in org.apache.geode
> 
>
> Key: GEODE-4481
> URL: https://issues.apache.org/jira/browse/GEODE-4481
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These membership tests in org.apache.geode invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * DeltaTestImpl
> InternalDistributedSystem.getAnyInstance():
> * LonerDMJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-4162) GEODE-4162 : Remove all instances of GemFireCacheImpl.getInstance() call from JUnit4CacheTestCase

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-4162:


Assignee: Kirk Lund

> GEODE-4162 : Remove all instances of GemFireCacheImpl.getInstance() call from 
> JUnit4CacheTestCase
> -
>
> Key: GEODE-4162
> URL: https://issues.apache.org/jira/browse/GEODE-4162
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: nabarun
>Assignee: Kirk Lund
>Priority: Major
>
> {code:title=JUnit4CacheTestCase.java}
>  public final InternalCache getCache(final boolean client, final CacheFactory 
> factory) {
> synchronized (JUnit4CacheTestCase.class) {
>   InternalCache gemFireCache = GemFireCacheImpl.getInstance();
>   if (gemFireCache != null && !gemFireCache.isClosed()
>   && gemFireCache.getCancelCriterion().isCancelInProgress()) {
> Awaitility.await("waiting for cache to close").atMost(30, 
> TimeUnit.SECONDS)
> .until(gemFireCache::isClosed);
>   }
>   if (cache == null || cache.isClosed()) {
> cache = null;
> createCache(client, factory);
>   }
>   if (client && cache != null) {
> IgnoredException.addIgnoredException("java.net.ConnectException");
>   }
>   return cache;
> }
>   }
> public final ClientCache getClientCache(final ClientCacheFactory factory) {
> synchronized (JUnit4CacheTestCase.class) {
>   InternalCache gemFireCache = GemFireCacheImpl.getInstance();
>   if (gemFireCache != null && !gemFireCache.isClosed()
>   && gemFireCache.getCancelCriterion().isCancelInProgress()) {
> Awaitility.await("waiting for cache to close").atMost(30, 
> TimeUnit.SECONDS)
> .until(gemFireCache::isClosed);
>   }
>   if (cache == null || cache.isClosed()) {
> cache = null;
> disconnectFromDS();
> cache = (InternalCache) factory.create();
>   }
>   if (cache != null) {
> IgnoredException.addIgnoredException("java.net.ConnectException");
>   }
>   return (ClientCache) cache;
> }
>   }
> public static final synchronized void closeCache() {
> // Workaround for the fact that some classes are now extending
> // CacheTestCase but not using it properly.
> if (cache == null) {
>   cache = GemFireCacheImpl.getInstance();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-4439) Refactor HandShake.java

2018-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350947#comment-16350947
 ] 

ASF subversion and git services commented on GEODE-4439:


Commit c1b21c036d4a425b39ecb3fb1024657fd3332a13 in geode's branch 
refs/heads/develop from [~bschuchardt]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c1b21c0 ]

GEODE-4439 Refactor HandShake.java

Created ServerSideHandshake and ServerSideHandshakeImpl for servers.

Created ClientSideHandshake and ClientSideHandshakeImpl for clients.

Message encryption/decryption is now in an Encryptor interface.

HandShake is renamed Handshake.


> Refactor HandShake.java
> ---
>
> Key: GEODE-4439
> URL: https://issues.apache.org/jira/browse/GEODE-4439
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> Class HandShake is used by both clients and servers to exchange information 
> and perform encryption/decryption (which is being deprecated).  Many methods 
> are used only by clients and others by servers.  These sometimes even have 
> comments to that effect.  This class should be refactored into two classes, 
> one for clients and one for servers.
> Oh, and please rename it to "Handshake".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-4439) Refactor HandShake.java

2018-02-02 Thread Bruce Schuchardt (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4439?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce Schuchardt resolved GEODE-4439.
-
   Resolution: Fixed
Fix Version/s: 1.5.0

> Refactor HandShake.java
> ---
>
> Key: GEODE-4439
> URL: https://issues.apache.org/jira/browse/GEODE-4439
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Bruce Schuchardt
>Assignee: Bruce Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.5.0
>
>  Time Spent: 50m
>  Remaining Estimate: 0h
>
> Class HandShake is used by both clients and servers to exchange information 
> and perform encryption/decryption (which is being deprecated).  Many methods 
> are used only by clients and others by servers.  These sometimes even have 
> comments to that effect.  This class should be refactored into two classes, 
> one for clients and one for servers.
> Oh, and please rename it to "Handshake".



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4500) Remove singleton calls from all tests in org.apache.geode.distributed.internal.membership.gms.membership

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4500:


 Summary: Remove singleton calls from all tests in 
org.apache.geode.distributed.internal.membership.gms.membership
 Key: GEODE-4500
 URL: https://issues.apache.org/jira/browse/GEODE-4500
 Project: Geode
  Issue Type: Sub-task
  Components: membership, tests
Reporter: Kirk Lund


These tests in org.apache.geode.distributed.internal.membership.gms.membership 
invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* GMSJoinLeaveTestHelper



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4501) Remove singleton calls from all tests in org.apache.geode.internal.jta.dunit

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4501:


 Summary: Remove singleton calls from all tests in 
org.apache.geode.internal.jta.dunit
 Key: GEODE-4501
 URL: https://issues.apache.org/jira/browse/GEODE-4501
 Project: Geode
  Issue Type: Sub-task
  Components: tests, transactions
Reporter: Kirk Lund


These tests in org.apache.geode.internal.jta.dunit invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* LoginTimeOutDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4470) Remove singleton calls from all tests in org.apache.geode.management

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4470:
-
Description: 
These tests in org.apache.geode.management invoke singleton getters.

GemFireCacheImpl.getInstance():
* CacheServerManagementDUnitTest
* ManagementTestBase
* MBeanUtil
* MemberMBeanAttributesDUnitTest
* MXBeanAwaitility

InternalDistributedSystem.getConnectedInstance():
* ManagementTestBase
* MemberMBeanAttributesDUnitTest
* OffHeapManagementDUnitTest

  was:
These tests in org.apache.geode.management invoke singleton getters.

GemFireCacheImpl.getInstance():
* CacheServerManagementDUnitTest
* ManagementTestBase
* MBeanUtil
* MemberMBeanAttributesDUnitTest
* MXBeanAwaitility


> Remove singleton calls from all tests in org.apache.geode.management
> 
>
> Key: GEODE-4470
> URL: https://issues.apache.org/jira/browse/GEODE-4470
> Project: Geode
>  Issue Type: Sub-task
>  Components: management, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.management invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * CacheServerManagementDUnitTest
> * ManagementTestBase
> * MBeanUtil
> * MemberMBeanAttributesDUnitTest
> * MXBeanAwaitility
> InternalDistributedSystem.getConnectedInstance():
> * ManagementTestBase
> * MemberMBeanAttributesDUnitTest
> * OffHeapManagementDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4499) Test adding a compressor to an existing persistent region.

2018-02-02 Thread Sai Boorlagadda (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sai Boorlagadda updated GEODE-4499:
---
Summary: Test adding a compressor to an existing persistent region.  (was: 
Add DUnit to test adding compressor to an existing persistent region.)

> Test adding a compressor to an existing persistent region.
> --
>
> Key: GEODE-4499
> URL: https://issues.apache.org/jira/browse/GEODE-4499
> Project: Geode
>  Issue Type: Test
>  Components: gfsh
>Reporter: Sai Boorlagadda
>Assignee: Sai Boorlagadda
>Priority: Major
>
> Add a DUnit to test alter disk-store & region to add a compressor and verify 
> that the existing region can be recovered after altering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-4487) Remove singleton calls from all tests in org.apache.geode.internal.offheap

2018-02-02 Thread Darrel Schneider (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-4487:
---

Assignee: Darrel Schneider

> Remove singleton calls from all tests in org.apache.geode.internal.offheap
> --
>
> Key: GEODE-4487
> URL: https://issues.apache.org/jira/browse/GEODE-4487
> Project: Geode
>  Issue Type: Sub-task
>  Components: offheap, tests
>Reporter: Kirk Lund
>Assignee: Darrel Schneider
>Priority: Major
>
> These tests in org.apache.geode.internal.offheap invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * OutOfOffHeapMemoryDUnitTest
> GemFireCacheImpl.getForPdx(String):
> * DataTypeJUnitTest
> InternalDistributedSystem.getAnyInstance():
> * OutOfOffHeapMemoryDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4493) Remove singleton calls from all tests in org.apache.geode.internal.cache.control

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4493:
-
Component/s: core

> Remove singleton calls from all tests in 
> org.apache.geode.internal.cache.control
> 
>
> Key: GEODE-4493
> URL: https://issues.apache.org/jira/browse/GEODE-4493
> Project: Geode
>  Issue Type: Sub-task
>  Components: core, regions, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache.control invoke singleton 
> getters.
> GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
> * RebalanceOperationDUnitTest
> InternalDistributedSystem.getAnyInstance():
> * TestMemoryThresholdListener



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-4451) When a gateway sender is created using gfsh and fails to connect due to AuthenticationFailedException, it is left in an inconsistent state

2018-02-02 Thread Diane Hardman (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350828#comment-16350828
 ] 

Diane Hardman commented on GEODE-4451:
--

If the gateway sender fails authentication with the receiver, the exception 
should be thrown and the gateway sender should be destroyed.

> When a gateway sender is created using gfsh and fails to connect due to 
> AuthenticationFailedException, it is left in an inconsistent state
> --
>
> Key: GEODE-4451
> URL: https://issues.apache.org/jira/browse/GEODE-4451
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Barry Oglesby
>Priority: Major
>
> If I attempt to create a gateway sender with invalid credentials using gfsh, 
> it fails like:
> {noformat}
> (2) Executing - create gateway-sender --remote-distributed-system-id=1 
> --id=ny --dispatcher-threads=1 --parallel=true
> Member | Status
> -- | 
> --
> ln-1 | ERROR: Could not start a gateway sender ny because of exception Could 
> not start a gateway sender 84 because of exception 
> org.apache.geode.security.AuthenticationFailedException: Authentication 
> error. Please check your credentials.
> {noformat}
> The 84 should be the gateway sender id; instead its the thread id (from 
> \{{ConcurrentParallelGatewaySenderEventProcessor.waitForRunningStatus}}.
> In the server log, I see 5 AuthenticationFailedException stacks like (one per 
> dispatcher-thread):
> {noformat}
> [severe 2018/01/31 16:13:12.638 PST ln-1  GatewaySender_ny_0> tid=0x55] Message dispatch failed due to unexpected 
> exception..
> org.apache.geode.internal.cache.wan.GatewaySenderException: 
> org.apache.geode.security.AuthenticationFailedException: Authentication 
> error. Please check your credentials., caused by 
> org.apache.geode.security.AuthenticationFailedException: Authentication 
> error. Please check your credentials.
>  at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.initializeConnection(GatewaySenderEventRemoteDispatcher.java:432)
>  at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.(GatewaySenderEventRemoteDispatcher.java:75)
>  at 
> org.apache.geode.internal.cache.wan.parallel.RemoteParallelGatewaySenderEventProcessor.initializeEventDispatcher(RemoteParallelGatewaySenderEventProcessor.java:74)
>  at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.setRunningStatus(AbstractGatewaySenderEventProcessor.java:1078)
>  at 
> org.apache.geode.internal.cache.wan.AbstractGatewaySenderEventProcessor.run(AbstractGatewaySenderEventProcessor.java:1050)
> Caused by: org.apache.geode.security.AuthenticationFailedException: 
> Authentication error. Please check your credentials.
>  at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.readMessage(HandShake.java:1397)
>  at 
> org.apache.geode.internal.cache.tier.sockets.HandShake.handshakeWithServer(HandShake.java:1253)
>  at 
> org.apache.geode.cache.client.internal.ConnectionImpl.connect(ConnectionImpl.java:118)
>  at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:136)
>  at 
> org.apache.geode.cache.client.internal.ConnectionFactoryImpl.createClientToServerConnection(ConnectionFactoryImpl.java:259)
>  at 
> org.apache.geode.cache.client.internal.pooling.ConnectionManagerImpl.borrowConnection(ConnectionManagerImpl.java:206)
>  at 
> org.apache.geode.cache.client.internal.PoolImpl.acquireConnection(PoolImpl.java:902)
>  at 
> org.apache.geode.internal.cache.wan.GatewaySenderEventRemoteDispatcher.initializeConnection(GatewaySenderEventRemoteDispatcher.java:388)
>  ... 4 more
> {noformat}
> A thread dump shows the Event Processor threads are gone, but 5 
> BatchRemovalThreads like this exist:
> {noformat}
> "BatchRemovalThread" #96 daemon prio=10 os_prio=31 tid=0x7fc1dd009000 
> nid=0xcb03 waiting on condition [0x7e245000]
>  java.lang.Thread.State: TIMED_WAITING (parking)
>  at sun.misc.Unsafe.park(Native Method)
>  - parking to wait for <0x0007a04043c8> (a 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject)
>  at java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:215)
>  at 
> java.util.concurrent.locks.AbstractQueuedSynchronizer$ConditionObject.await(AbstractQueuedSynchronizer.java:2163)
>  at 
> org.apache.geode.internal.util.concurrent.StoppableCondition.await(StoppableCondition.java:61)
>  at 
> 

[jira] [Created] (GEODE-4503) Remove singleton calls from all tests in org.apache.geode.internal.cache.execute

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4503:


 Summary: Remove singleton calls from all tests in 
org.apache.geode.internal.cache.execute
 Key: GEODE-4503
 URL: https://issues.apache.org/jira/browse/GEODE-4503
 Project: Geode
  Issue Type: Sub-task
  Components: tests, transactions
Reporter: Kirk Lund


These tests in org.apache.geode.internal.cache.execute invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* TXLockServiceDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-4450) setting a client/server diffie-hellman algorithm breaks client/server subscriptions

2018-02-02 Thread Bruce Schuchardt (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350837#comment-16350837
 ] 

Bruce Schuchardt commented on GEODE-4450:
-

Undoing Jinmei's change to CacheClientNotifier.registerGFEClient() fixes this 
problem.

 

I modified the test ClientRegisterInterestAuthDUnitTest.testRegisterInterest to 
add a security-client-dhalgo setting in the client and server to reproduce the 
problem.

> setting a client/server diffie-hellman algorithm breaks client/server 
> subscriptions
> ---
>
> Key: GEODE-4450
> URL: https://issues.apache.org/jira/browse/GEODE-4450
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Bruce Schuchardt
>Priority: Major
>
> Having found that there are no tests for the security-client-dhalgo setting I 
> modified a test to use it.  The client/server handshake in the subscription 
> thread (cache client updater) hung on the server side trying to read client 
> credentials.
> I tracked this down to CacheClientNotifier.registerClient, which sends a 105 
> byte to the client along with some other bytes in its writeMessage() method.  
> The client isn't expecting this message and interprets the 105 as a failure 
> to register with the server.  The client then abandons the handshake and the 
> server hangs until its read times out.
> See also GEODE-4353, which wants to deprecate this broken feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4505) Remove singleton calls from all tests in org.apache.geode.internal.cache.execute

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4505:


 Summary: Remove singleton calls from all tests in 
org.apache.geode.internal.cache.execute
 Key: GEODE-4505
 URL: https://issues.apache.org/jira/browse/GEODE-4505
 Project: Geode
  Issue Type: Sub-task
  Components: functions, tests
Reporter: Kirk Lund


These tests in org.apache.geode.internal.cache.execute invoke singleton getters.

InternalDistributedSystem.getConnectedInstance():
* OnGroupsFunctionExecutionDUnitTest
* RestAPIsOnGroupsFunctionExecutionDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4492) Remove singleton calls from all tests in org.apache.geode.internal.cache.wan

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4492?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4492:
-
Description: 
These tests in org.apache.geode.internal.cache.wan invoke singleton getters.

GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
* AckReaderThreadJUnitTest

InternalDistributedSystem.getConnectedInstance():
* MyAsyncEventListener

  was:
These tests in org.apache.geode.internal.cache.wan invoke singleton getters.

GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
* AckReaderThreadJUnitTest


> Remove singleton calls from all tests in org.apache.geode.internal.cache.wan
> 
>
> Key: GEODE-4492
> URL: https://issues.apache.org/jira/browse/GEODE-4492
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests, wan
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache.wan invoke singleton getters.
> GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
> * AckReaderThreadJUnitTest
> InternalDistributedSystem.getConnectedInstance():
> * MyAsyncEventListener



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4512) Remove singleton calls from transaction tests in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4512:
-
Description: 
These transaction tests in org.apache.geode invoke singleton getters. These 
tests should also be moved to a tx package.

InternalDistributedSystem.getAnyInstance():
* JtaNoninvolvementJUnitTest
* TXJUnitTest
* TXWriterTestCase

  was:
These transaction tests in org.apache.geode invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* JtaNoninvolvementJUnitTest


> Remove singleton calls from transaction tests in org.apache.geode
> -
>
> Key: GEODE-4512
> URL: https://issues.apache.org/jira/browse/GEODE-4512
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests, transactions
>Reporter: Kirk Lund
>Priority: Major
>
> These transaction tests in org.apache.geode invoke singleton getters. These 
> tests should also be moved to a tx package.
> InternalDistributedSystem.getAnyInstance():
> * JtaNoninvolvementJUnitTest
> * TXJUnitTest
> * TXWriterTestCase



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4481) Remove singleton calls from all tests in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4481:
-
Description: 
These tests in org.apache.geode invoke singleton getters.

GemFireCacheImpl.getInstance():
* DeltaTestImpl

InternalDistributedSystem.getAnyInstance():
* LonerDMJUnitTest


  was:
These tests in org.apache.geode invoke singleton getters.

GemFireCacheImpl.getInstance():
* DeltaTestImpl

InternalDistributedSystem.getAnyInstance():
* JtaNoninvolvementJUnitTest
* LonerDMJUnitTest
* TXJUnitTest
* TXWriterTestCase


> Remove singleton calls from all tests in org.apache.geode
> -
>
> Key: GEODE-4481
> URL: https://issues.apache.org/jira/browse/GEODE-4481
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership, serialization, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * DeltaTestImpl
> InternalDistributedSystem.getAnyInstance():
> * LonerDMJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-4353) Deprecate security-client-dhalgo property

2018-02-02 Thread Bruce Schuchardt (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350809#comment-16350809
 ] 

Bruce Schuchardt commented on GEODE-4353:
-

I was wrong about this being broken since 2008.  It was accidentally broken by 
[~jinmeiliao] in her fix for GEODE-1571, SHA 
39c56843bdaa67f0df4dbbb9edc096e8cb4e12e6.  That was on 30 june 2016.

> Deprecate security-client-dhalgo property
> -
>
> Key: GEODE-4353
> URL: https://issues.apache.org/jira/browse/GEODE-4353
> Project: Geode
>  Issue Type: Bug
>  Components: client/server
>Reporter: Dan Smith
>Priority: Major
>
> {{security-client-dhalgo}}{\{ should be deprecated in favor of using the 
> ssl-* settings.}}
>  
> [{{[https://geode.apache.org/docs/guide/10/managing/security/encrypting_with_diffie_helman.html]}}]{{}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-4450) setting a client/server diffie-hellman algorithm breaks client/server subscriptions

2018-02-02 Thread Bruce Schuchardt (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350810#comment-16350810
 ] 

Bruce Schuchardt commented on GEODE-4450:
-

This feature was accidentally broken by [~jinmeiliao] in her fix for 
GEODE-1571, SHA 39c56843bdaa67f0df4dbbb9edc096e8cb4e12e6.  That was on 30 june 
2016.  If there had been tests for this feature that change would have caused 
them to fail.

> setting a client/server diffie-hellman algorithm breaks client/server 
> subscriptions
> ---
>
> Key: GEODE-4450
> URL: https://issues.apache.org/jira/browse/GEODE-4450
> Project: Geode
>  Issue Type: Improvement
>  Components: client/server
>Reporter: Bruce Schuchardt
>Priority: Major
>
> Having found that there are no tests for the security-client-dhalgo setting I 
> modified a test to use it.  The client/server handshake in the subscription 
> thread (cache client updater) hung on the server side trying to read client 
> credentials.
> I tracked this down to CacheClientNotifier.registerClient, which sends a 105 
> byte to the client along with some other bytes in its writeMessage() method.  
> The client isn't expecting this message and interprets the 105 as a failure 
> to register with the server.  The client then abandons the handshake and the 
> server hangs until its read times out.
> See also GEODE-4353, which wants to deprecate this broken feature.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4493) Remove singleton calls from all tests in org.apache.geode.internal.cache.control

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4493:
-
Description: 
These tests in org.apache.geode.internal.cache.control invoke singleton getters.

GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
* RebalanceOperationDUnitTest

InternalDistributedSystem.getAnyInstance():
* TestMemoryThresholdListener

  was:
These tests in org.apache.geode.internal.cache.control invoke singleton getters.

GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
* RebalanceOperationDUnitTest


> Remove singleton calls from all tests in 
> org.apache.geode.internal.cache.control
> 
>
> Key: GEODE-4493
> URL: https://issues.apache.org/jira/browse/GEODE-4493
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.cache.control invoke singleton 
> getters.
> GemFireCacheImpl.setInstanceForTests(GemFireCacheImpl):
> * RebalanceOperationDUnitTest
> InternalDistributedSystem.getAnyInstance():
> * TestMemoryThresholdListener



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4464) Remove singleton calls from all tests in org.apache.geode.cache30

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4464:
-
Description: 
These tests in org.apache.geode.cache30 invoke singleton getters.

CacheFactory.getAnyInstance():
* CacheSerializableRunnable
* ClientServerCCEDUnitTest
* MultiVMRegionTestCase
* ReconnectDUnitTest

CacheFactory.getExisting(DistributedSystem):
* MultiVMRegionTestCase.testDistributedPut
* MultiVMRegionTestCase.testTXAlgebra
* MultiVMRegionTestCase.testTXSimpleOps
* MultiVMRegionTestCase.testTXUpdateLoadNoConflict
* MultiVMRegionTestCase.testTXRmtMirror
* MultiVMRegionTestCase.testTXMultiRegion

InternalDistributedSystem.getAnyInstance():
* CachedAllEventsDUnitTest
* CallbackArgDUnitTest
* ClientMembershipDUnitTest
* ClientServerTestCase
* ProxyDUnitTest
* ReconnectDUnitTest
* RegionMembershipListenerDUnitTest
* RegionReliabilityTestCase
* RemotePRValuesAreNotDeserializedRegressionTest
* TXOrderDUnitTest
* ValuesAreLazilyDeserializedRegressionTest

InternalDistributedSystem.getConnectedInstance():
* DistributedNoAckRegionCCEDUnitTest
* MultiVMRegionTestCase
* ReconnectDUnitTest


  was:
These tests in org.apache.geode.cache30 invoke singleton getters.

CacheFactory.getAnyInstance():
* CacheSerializableRunnable
* ClientServerCCEDUnitTest
* MultiVMRegionTestCase
* ReconnectDUnitTest

CacheFactory.getExisting(DistributedSystem):
* MultiVMRegionTestCase.testDistributedPut
* MultiVMRegionTestCase.testTXAlgebra
* MultiVMRegionTestCase.testTXSimpleOps
* MultiVMRegionTestCase.testTXUpdateLoadNoConflict
* MultiVMRegionTestCase.testTXRmtMirror
* MultiVMRegionTestCase.testTXMultiRegion

InternalDistributedSystem.getAnyInstance():
* CachedAllEventsDUnitTest
* CallbackArgDUnitTest
* ClientMembershipDUnitTest
* ClientServerTestCase
* ProxyDUnitTest
* ReconnectDUnitTest
* RegionMembershipListenerDUnitTest
* RegionReliabilityTestCase
* RemotePRValuesAreNotDeserializedRegressionTest
* TXOrderDUnitTest
* ValuesAreLazilyDeserializedRegressionTest



> Remove singleton calls from all tests in org.apache.geode.cache30
> -
>
> Key: GEODE-4464
> URL: https://issues.apache.org/jira/browse/GEODE-4464
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.cache30 invoke singleton getters.
> CacheFactory.getAnyInstance():
> * CacheSerializableRunnable
> * ClientServerCCEDUnitTest
> * MultiVMRegionTestCase
> * ReconnectDUnitTest
> CacheFactory.getExisting(DistributedSystem):
> * MultiVMRegionTestCase.testDistributedPut
> * MultiVMRegionTestCase.testTXAlgebra
> * MultiVMRegionTestCase.testTXSimpleOps
> * MultiVMRegionTestCase.testTXUpdateLoadNoConflict
> * MultiVMRegionTestCase.testTXRmtMirror
> * MultiVMRegionTestCase.testTXMultiRegion
> InternalDistributedSystem.getAnyInstance():
> * CachedAllEventsDUnitTest
> * CallbackArgDUnitTest
> * ClientMembershipDUnitTest
> * ClientServerTestCase
> * ProxyDUnitTest
> * ReconnectDUnitTest
> * RegionMembershipListenerDUnitTest
> * RegionReliabilityTestCase
> * RemotePRValuesAreNotDeserializedRegressionTest
> * TXOrderDUnitTest
> * ValuesAreLazilyDeserializedRegressionTest
> InternalDistributedSystem.getConnectedInstance():
> * DistributedNoAckRegionCCEDUnitTest
> * MultiVMRegionTestCase
> * ReconnectDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4506) Remove singleton calls from all tests in org.apache.geode.internal.cache.wan.serial

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4506:


 Summary: Remove singleton calls from all tests in 
org.apache.geode.internal.cache.wan.serial
 Key: GEODE-4506
 URL: https://issues.apache.org/jira/browse/GEODE-4506
 Project: Geode
  Issue Type: Sub-task
  Components: tests, wan
Reporter: Kirk Lund


These tests in org.apache.geode.internal.cache.wan.serial invoke singleton 
getters.

InternalDistributedSystem.getConnectedInstance():
* SerialGatewaySenderOperationsDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4507) Geode Native C++ Example (Put/get domain object using custom PdxSerializer)

2018-02-02 Thread Ryan McMahon (JIRA)
Ryan McMahon created GEODE-4507:
---

 Summary: Geode Native C++ Example (Put/get domain object using 
custom PdxSerializer)
 Key: GEODE-4507
 URL: https://issues.apache.org/jira/browse/GEODE-4507
 Project: Geode
  Issue Type: Sub-task
  Components: native client
Reporter: Ryan McMahon


Create an example which puts/gets domain objects using a custom PdxSerializer



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4481) Remove singleton calls from all tests in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4481:
-
Component/s: membership

> Remove singleton calls from all tests in org.apache.geode
> -
>
> Key: GEODE-4481
> URL: https://issues.apache.org/jira/browse/GEODE-4481
> Project: Geode
>  Issue Type: Sub-task
>  Components: membership, serialization, tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode invoke singleton getters.
> GemFireCacheImpl.getInstance():
> * DeltaTestImpl
> InternalDistributedSystem.getAnyInstance():
> * JtaNoninvolvementJUnitTest
> * LonerDMJUnitTest
> * TXJUnitTest
> * TXWriterTestCase



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (GEODE-4150) DistributedSystemDUnitTest should not call CacheFactory.getInstance

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund resolved GEODE-4150.
--
Resolution: Duplicate

Closing this ticket as duplicating GEODE-4469 which specifies removal of all 
singleton calls from all test files in org.apache.geode.distributed package.

> DistributedSystemDUnitTest should not call CacheFactory.getInstance
> ---
>
> Key: GEODE-4150
> URL: https://issues.apache.org/jira/browse/GEODE-4150
> Project: Geode
>  Issue Type: Sub-task
>  Components: messaging, tests
>Reporter: Galen O'Sullivan
>Priority: Major
>
> let's use a method that's not deprecated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (GEODE-4150) DistributedSystemDUnitTest should not call CacheFactory.getInstance

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund closed GEODE-4150.


> DistributedSystemDUnitTest should not call CacheFactory.getInstance
> ---
>
> Key: GEODE-4150
> URL: https://issues.apache.org/jira/browse/GEODE-4150
> Project: Geode
>  Issue Type: Sub-task
>  Components: messaging, tests
>Reporter: Galen O'Sullivan
>Priority: Major
>
> let's use a method that's not deprecated.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4502) Remove singleton calls from all tests in org.apache.geode.internal.cache.functions

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4502:


 Summary: Remove singleton calls from all tests in 
org.apache.geode.internal.cache.functions
 Key: GEODE-4502
 URL: https://issues.apache.org/jira/browse/GEODE-4502
 Project: Geode
  Issue Type: Sub-task
  Components: functions, tests
Reporter: Kirk Lund


These tests in org.apache.geode.internal.cache.functions invoke singleton 
getters.

InternalDistributedSystem.getAnyInstance():
* FireAndForgetFunctionOnAllServers
* TestFunction



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4468) Remove singleton calls from all tests in org.apache.geode.internal.jta

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4468:
-
Description: 
These tests in org.apache.geode.internal.jta invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* CacheUtils

InternalDistributedSystem.getAnyInstance():
* BlockingTimeOutJUnitTest
* JtaIntegrationJUnitTest

InternalDistributedSystem.getConnectedInstance():
* BlockingTimeOutJUnitTest
* DataSourceJTAJUnitTest

  was:
These tests in org.apache.geode.internal.jta invoke singleton getters.

CacheFactory.getExisting(DistributedSystem):
* CacheUtils

InternalDistributedSystem.getAnyInstance():
* BlockingTimeOutJUnitTest
* JtaIntegrationJUnitTest


> Remove singleton calls from all tests in org.apache.geode.internal.jta
> --
>
> Key: GEODE-4468
> URL: https://issues.apache.org/jira/browse/GEODE-4468
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests, transactions
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.internal.jta invoke singleton getters.
> CacheFactory.getExisting(DistributedSystem):
> * CacheUtils
> InternalDistributedSystem.getAnyInstance():
> * BlockingTimeOutJUnitTest
> * JtaIntegrationJUnitTest
> InternalDistributedSystem.getConnectedInstance():
> * BlockingTimeOutJUnitTest
> * DataSourceJTAJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-4509) change the InternalCache interface to use InternalRegion instead of LocalRegion

2018-02-02 Thread Darrel Schneider (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Darrel Schneider reassigned GEODE-4509:
---

Assignee: Darrel Schneider

> change the InternalCache interface to use InternalRegion instead of 
> LocalRegion
> ---
>
> Key: GEODE-4509
> URL: https://issues.apache.org/jira/browse/GEODE-4509
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>
> The InternalCache interface should not expose or use LocalRegion. It should 
> use InternalRegion instead.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (GEODE-4510) Remove singleton calls from all tests in org.apache.geode.test.dunit.rules

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund reassigned GEODE-4510:


Assignee: Kirk Lund

> Remove singleton calls from all tests in org.apache.geode.test.dunit.rules
> --
>
> Key: GEODE-4510
> URL: https://issues.apache.org/jira/browse/GEODE-4510
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.test.dunit.rules invoke singleton getters.
> InternalDistributedSystem.getConnectedInstance():
> * DistributedDisconnectRule



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4457) Remove singleton calls from all tests in org.apache.geode.rest.internal.web.controllers

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4457:
-
Description: 
These tests in org.apache.geode.rest.internal.web.controllers invoke singleton 
getters.

CacheFactory.getAnyInstance():
* AddFreeItemToOrders
* GetDeliveredOrders
* GetRegions
* GetValueForKey
* RestAPIOnRegionFunctionExecutionDUnitTest
* RestQueryAndFunctionIntegrationTest

GemFireCacheImpl.getInstance():
* RestAPIsAndInterOpsDUnitTest
* RestAPIsWithSSLDUnitTest

InternalDistributedSystem.getAnyInstance():
* RestAPIOnRegionFunctionExecutionDUnitTest

InternalDistributedSystem.getConnectedInstance():
* RestAPIsOnGroupsFunctionExecutionDUnitTest
* RestAPIsWithSSLDUnitTest

  was:
These tests in org.apache.geode.rest.internal.web.controllers invoke singleton 
getters.

CacheFactory.getAnyInstance():
* AddFreeItemToOrders
* GetDeliveredOrders
* GetRegions
* GetValueForKey
* RestAPIOnRegionFunctionExecutionDUnitTest
* RestQueryAndFunctionIntegrationTest

GemFireCacheImpl.getInstance():
* RestAPIsAndInterOpsDUnitTest
* RestAPIsWithSSLDUnitTest

InternalDistributedSystem.getAnyInstance():
* RestAPIOnRegionFunctionExecutionDUnitTest



> Remove singleton calls from all tests in 
> org.apache.geode.rest.internal.web.controllers
> ---
>
> Key: GEODE-4457
> URL: https://issues.apache.org/jira/browse/GEODE-4457
> Project: Geode
>  Issue Type: Sub-task
>  Components: rest (dev), tests
>Reporter: Kirk Lund
>Priority: Major
>
> These tests in org.apache.geode.rest.internal.web.controllers invoke 
> singleton getters.
> CacheFactory.getAnyInstance():
> * AddFreeItemToOrders
> * GetDeliveredOrders
> * GetRegions
> * GetValueForKey
> * RestAPIOnRegionFunctionExecutionDUnitTest
> * RestQueryAndFunctionIntegrationTest
> GemFireCacheImpl.getInstance():
> * RestAPIsAndInterOpsDUnitTest
> * RestAPIsWithSSLDUnitTest
> InternalDistributedSystem.getAnyInstance():
> * RestAPIOnRegionFunctionExecutionDUnitTest
> InternalDistributedSystem.getConnectedInstance():
> * RestAPIsOnGroupsFunctionExecutionDUnitTest
> * RestAPIsWithSSLDUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-4270) [CI Failure] org.apache.geode.cache.query.cq.dunit.CqSecurityAuthorizedUserDUnitTest > cqExecuteWithInitialResultsWithMethodInvocationWithUnpopulatedRegionAndFollowedBy

2018-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350867#comment-16350867
 ] 

ASF subversion and git services commented on GEODE-4270:


Commit 80ad2d70435fb255a8a2d08c8866fbb30a7bedd3 in geode's branch 
refs/heads/develop from [~WireBaron]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=80ad2d7 ]

GEODE-4270: remove race condition where CacheClientProxy could be asked to 
(#1378)

authorize a message prior to receiving its security subject.

> [CI Failure] 
> org.apache.geode.cache.query.cq.dunit.CqSecurityAuthorizedUserDUnitTest > 
> cqExecuteWithInitialResultsWithMethodInvocationWithUnpopulatedRegionAndFollowedByAPutShouldTriggerCqError[0]
>  FAILED
> --
>
> Key: GEODE-4270
> URL: https://issues.apache.org/jira/browse/GEODE-4270
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, security
>Reporter: nabarun
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 40m
>  Remaining Estimate: 0h
>
> {noformat}
> org.apache.geode.cache.query.cq.dunit.CqSecurityAuthorizedUserDUnitTest > 
> cqExecuteWithInitialResultsWithMethodInvocationWithUnpopulatedRegionAndFollowedByAPutShouldTriggerCqError[0]
>  FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.security.query.QuerySecurityBase$$Lambda$50/1990038369.run 
> in VM 1 running on Host 6b888a694193 with 4 VMs
> at org.apache.geode.test.dunit.VM.invoke(VM.java:393)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:363)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:308)
> at 
> org.apache.geode.security.query.QuerySecurityBase.putIntoRegion(QuerySecurityBase.java:202)
> at 
> org.apache.geode.cache.query.cq.dunit.CqSecurityAuthorizedUserDUnitTest.cqExecuteWithInitialResultsWithMethodInvocationWithUnpopulatedRegionAndFollowedByAPutShouldTriggerCqError(CqSecurityAuthorizedUserDUnitTest.java:138)
> Caused by:
> org.apache.geode.cache.client.ServerOperationException: remote server 
> on 6b888a694193(153:loner):32936:ced4ccdc: 
> org.apache.geode.security.GemFireSecurityException: Error: Anonymous User
> Caused by:
> org.apache.geode.security.GemFireSecurityException: Error: 
> Anonymous User
> {noformat}
> *+Test logs+*
> https://concourse.apachegeode-ci.info/teams/main/pipelines/develop/jobs/DistributedTest/builds/70#L5a4ed7fc:654



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4512) Remove singleton calls from transaction tests in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4512:


 Summary: Remove singleton calls from transaction tests in 
org.apache.geode
 Key: GEODE-4512
 URL: https://issues.apache.org/jira/browse/GEODE-4512
 Project: Geode
  Issue Type: Sub-task
  Components: tests, transactions
Reporter: Kirk Lund


These transaction tests in org.apache.geode invoke singleton getters.

InternalDistributedSystem.getAnyInstance():
* JtaNoninvolvementJUnitTest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4509) change the InternalCache interface to use InternalRegion instead of LocalRegion

2018-02-02 Thread ASF GitHub Bot (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-4509:
--
Labels: pull-request-available  (was: )

> change the InternalCache interface to use InternalRegion instead of 
> LocalRegion
> ---
>
> Key: GEODE-4509
> URL: https://issues.apache.org/jira/browse/GEODE-4509
> Project: Geode
>  Issue Type: Improvement
>  Components: regions
>Reporter: Darrel Schneider
>Assignee: Darrel Schneider
>Priority: Major
>  Labels: pull-request-available
>
> The InternalCache interface should not expose or use LocalRegion. It should 
> use InternalRegion instead.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (GEODE-4423) Convert PdxFieldTypes to enum class

2018-02-02 Thread ASF subversion and git services (JIRA)

[ 
https://issues.apache.org/jira/browse/GEODE-4423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350935#comment-16350935
 ] 

ASF subversion and git services commented on GEODE-4423:


Commit 27fb576c6dadfac7bb05755ed4bd90fad2b10ed6 in geode-native's branch 
refs/heads/develop from Jacob Barrett
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=27fb576 ]

GEODE-4423: Fixes runtime failure on Solaris SPARC.


> Convert PdxFieldTypes to enum class
> ---
>
> Key: GEODE-4423
> URL: https://issues.apache.org/jira/browse/GEODE-4423
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Jacob S. Barrett
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4162) Remove all singleton calls from JUnit4CacheTestCase

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4162:
-
Description: 

GemFireCacheImpl.getInstance()

  was:
{code:title=JUnit4CacheTestCase.java}
 public final InternalCache getCache(final boolean client, final CacheFactory 
factory) {
synchronized (JUnit4CacheTestCase.class) {
  InternalCache gemFireCache = GemFireCacheImpl.getInstance();
  if (gemFireCache != null && !gemFireCache.isClosed()
  && gemFireCache.getCancelCriterion().isCancelInProgress()) {
Awaitility.await("waiting for cache to close").atMost(30, 
TimeUnit.SECONDS)
.until(gemFireCache::isClosed);
  }
  if (cache == null || cache.isClosed()) {
cache = null;
createCache(client, factory);
  }
  if (client && cache != null) {
IgnoredException.addIgnoredException("java.net.ConnectException");
  }
  return cache;
}
  }

public final ClientCache getClientCache(final ClientCacheFactory factory) {
synchronized (JUnit4CacheTestCase.class) {
  InternalCache gemFireCache = GemFireCacheImpl.getInstance();
  if (gemFireCache != null && !gemFireCache.isClosed()
  && gemFireCache.getCancelCriterion().isCancelInProgress()) {
Awaitility.await("waiting for cache to close").atMost(30, 
TimeUnit.SECONDS)
.until(gemFireCache::isClosed);
  }
  if (cache == null || cache.isClosed()) {
cache = null;
disconnectFromDS();
cache = (InternalCache) factory.create();
  }
  if (cache != null) {
IgnoredException.addIgnoredException("java.net.ConnectException");
  }
  return (ClientCache) cache;
}
  }

public static final synchronized void closeCache() {
// Workaround for the fact that some classes are now extending
// CacheTestCase but not using it properly.
if (cache == null) {
  cache = GemFireCacheImpl.getInstance();
}


{code}


> Remove all singleton calls from JUnit4CacheTestCase
> ---
>
> Key: GEODE-4162
> URL: https://issues.apache.org/jira/browse/GEODE-4162
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: nabarun
>Assignee: Kirk Lund
>Priority: Major
>
> GemFireCacheImpl.getInstance()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4162) Remove all instances of GemFireCacheImpl.getInstance() call from JUnit4CacheTestCase

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4162:
-
Summary: Remove all instances of GemFireCacheImpl.getInstance() call from 
JUnit4CacheTestCase  (was: GEODE-4162 : Remove all instances of 
GemFireCacheImpl.getInstance() call from JUnit4CacheTestCase)

> Remove all instances of GemFireCacheImpl.getInstance() call from 
> JUnit4CacheTestCase
> 
>
> Key: GEODE-4162
> URL: https://issues.apache.org/jira/browse/GEODE-4162
> Project: Geode
>  Issue Type: Sub-task
>  Components: tests
>Reporter: nabarun
>Assignee: Kirk Lund
>Priority: Major
>
> {code:title=JUnit4CacheTestCase.java}
>  public final InternalCache getCache(final boolean client, final CacheFactory 
> factory) {
> synchronized (JUnit4CacheTestCase.class) {
>   InternalCache gemFireCache = GemFireCacheImpl.getInstance();
>   if (gemFireCache != null && !gemFireCache.isClosed()
>   && gemFireCache.getCancelCriterion().isCancelInProgress()) {
> Awaitility.await("waiting for cache to close").atMost(30, 
> TimeUnit.SECONDS)
> .until(gemFireCache::isClosed);
>   }
>   if (cache == null || cache.isClosed()) {
> cache = null;
> createCache(client, factory);
>   }
>   if (client && cache != null) {
> IgnoredException.addIgnoredException("java.net.ConnectException");
>   }
>   return cache;
> }
>   }
> public final ClientCache getClientCache(final ClientCacheFactory factory) {
> synchronized (JUnit4CacheTestCase.class) {
>   InternalCache gemFireCache = GemFireCacheImpl.getInstance();
>   if (gemFireCache != null && !gemFireCache.isClosed()
>   && gemFireCache.getCancelCriterion().isCancelInProgress()) {
> Awaitility.await("waiting for cache to close").atMost(30, 
> TimeUnit.SECONDS)
> .until(gemFireCache::isClosed);
>   }
>   if (cache == null || cache.isClosed()) {
> cache = null;
> disconnectFromDS();
> cache = (InternalCache) factory.create();
>   }
>   if (cache != null) {
> IgnoredException.addIgnoredException("java.net.ConnectException");
>   }
>   return (ClientCache) cache;
> }
>   }
> public static final synchronized void closeCache() {
> // Workaround for the fact that some classes are now extending
> // CacheTestCase but not using it properly.
> if (cache == null) {
>   cache = GemFireCacheImpl.getInstance();
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4518) make DSCODE an enum

2018-02-02 Thread Galen O'Sullivan (JIRA)
Galen O'Sullivan created GEODE-4518:
---

 Summary: make DSCODE an enum
 Key: GEODE-4518
 URL: https://issues.apache.org/jira/browse/GEODE-4518
 Project: Geode
  Issue Type: Improvement
  Components: serialization
Reporter: Galen O'Sullivan


>From DSCODE:
{color:#629755}/**
{color}{color:#629755} * An interface that contains a bunch of static final 
values used for the implementation of
{color}{color:#629755} * {{color}{color:#629755}@link 
{color}{color:#629755}DataSerializer}. It is basically an Enum and could be 
changed to one once we drop 1.4. The
{color}{color:#629755} * allowed range of these codes is -128..127 inclusive 
(i.e. byte).
{color}{color:#629755} *
{color}{color:#629755} * {color}{color:#629755}@since 
{color}{color:#629755}GemFire 5.7{color}

{color:#33}Since we no longer support Java 4, let's make this an 
enum.{color}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4515) Remove singleton calls from product code in org.apache.geode.management.internal.beans

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4515:
-
Description: 
These product classes in org.apache.geode.management.internal.beans invoke 
singleton getters.

CacheFactory.getAnyInstance():
* BeanUtilFuncs
* CacheServerBridge
* QueryDataFunction
* QueryDataFunction$LocalQueryFunction


  was:
These product classes in org.apache.geode.management.internal.beans invoke 
singleton getters.

CacheFactory.getAnyInstance():
* BeanUtilFuncs
* CliUtil
* QueryDataFunction
* QueryDataFunction$LocalQueryFunction



> Remove singleton calls from product code in 
> org.apache.geode.management.internal.beans
> --
>
> Key: GEODE-4515
> URL: https://issues.apache.org/jira/browse/GEODE-4515
> Project: Geode
>  Issue Type: Sub-task
>  Components: jmx
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.management.internal.beans invoke 
> singleton getters.
> CacheFactory.getAnyInstance():
> * BeanUtilFuncs
> * CacheServerBridge
> * QueryDataFunction
> * QueryDataFunction$LocalQueryFunction



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4517) Remove singleton calls from product code in org.apache.geode.management.internal.cli

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4517:
-
Component/s: jmx

> Remove singleton calls from product code in 
> org.apache.geode.management.internal.cli
> 
>
> Key: GEODE-4517
> URL: https://issues.apache.org/jira/browse/GEODE-4517
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.management.internal.cli invoke 
> singleton getters.
> CacheFactory.getAnyInstance():
> * CliUtil



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4517) Remove singleton calls from product code in org.apache.geode.management.internal.cli

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4517:
-
Component/s: gfsh

> Remove singleton calls from product code in 
> org.apache.geode.management.internal.cli
> 
>
> Key: GEODE-4517
> URL: https://issues.apache.org/jira/browse/GEODE-4517
> Project: Geode
>  Issue Type: Sub-task
>  Components: gfsh
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.management.internal.cli invoke 
> singleton getters.
> CacheFactory.getAnyInstance():
> * CliUtil



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4520) Remove singleton calls from product code in org.apache.geode.management.internal.configuration.callbacks

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4520:


 Summary: Remove singleton calls from product code in 
org.apache.geode.management.internal.configuration.callbacks
 Key: GEODE-4520
 URL: https://issues.apache.org/jira/browse/GEODE-4520
 Project: Geode
  Issue Type: Sub-task
  Components: management
Reporter: Kirk Lund


These product classes in 
org.apache.geode.management.internal.configuration.callbacks invoke singleton 
getters.

CacheFactory.getAnyInstance():
* ConfigurationChangeListener



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4521) Remove singleton calls from product code in org.apache.geode

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4521:


 Summary: Remove singleton calls from product code in 
org.apache.geode
 Key: GEODE-4521
 URL: https://issues.apache.org/jira/browse/GEODE-4521
 Project: Geode
  Issue Type: Sub-task
  Components: serialization
Reporter: Kirk Lund


These product classes in org.apache.geode invoke singleton getters.

CacheFactory.getAnyInstance():
* DataSerializer



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4534) Remove singleton calls from product code in org.apache.geode.cache.client.internal

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4534?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4534:
-
Description: 
These product classes in org.apache.geode.cache.client.internal invoke 
singleton getters.

CacheFactory.getAnyInstance():
* PoolImpl

CacheFactory.getInstance(DistributedSystem):
* PoolImpl

  was:
These product classes in org.apache.geode.cache.client.internal invoke 
singleton getters.

CacheFactory.getAnyInstance():
* PoolImpl


> Remove singleton calls from product code in 
> org.apache.geode.cache.client.internal
> --
>
> Key: GEODE-4534
> URL: https://issues.apache.org/jira/browse/GEODE-4534
> Project: Geode
>  Issue Type: Sub-task
>  Components: client/server
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.cache.client.internal invoke 
> singleton getters.
> CacheFactory.getAnyInstance():
> * PoolImpl
> CacheFactory.getInstance(DistributedSystem):
> * PoolImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4531) Remove singleton calls from product code in org.apache.geode.admin.internal

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4531:
-
Description: 
These product classes in org.apache.geode.admin.internal invoke singleton 
getters.

CacheFactory.getAnyInstance():
* MemberHealthEvaluator

CacheFactory.getInstance(DistributedSystem):
* CacheHealthEvaluator

  was:
These product classes in org.apache.geode.admin.internal invoke singleton 
getters.

CacheFactory.getAnyInstance():
* MemberHealthEvaluator


> Remove singleton calls from product code in org.apache.geode.admin.internal
> ---
>
> Key: GEODE-4531
> URL: https://issues.apache.org/jira/browse/GEODE-4531
> Project: Geode
>  Issue Type: Sub-task
>  Components: core
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.admin.internal invoke singleton 
> getters.
> CacheFactory.getAnyInstance():
> * MemberHealthEvaluator
> CacheFactory.getInstance(DistributedSystem):
> * CacheHealthEvaluator



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4541) Remove singleton calls from product code in org.apache.geode.internal.cache

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4541:


 Summary: Remove singleton calls from product code in 
org.apache.geode.internal.cache
 Key: GEODE-4541
 URL: https://issues.apache.org/jira/browse/GEODE-4541
 Project: Geode
  Issue Type: Sub-task
  Components: transactions
Reporter: Kirk Lund


These product classes in org.apache.geode.internal.cache invoke singleton 
getters.

GemFireCacheImpl.getExisting(String):
* TXCommitMessage



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4548) Remove singleton calls from transaction product code in org.apache.geode.internal.cache

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4548:


 Summary: Remove singleton calls from transaction product code in 
org.apache.geode.internal.cache
 Key: GEODE-4548
 URL: https://issues.apache.org/jira/browse/GEODE-4548
 Project: Geode
  Issue Type: Sub-task
  Components: transactions
Reporter: Kirk Lund


These transaction product classes in org.apache.geode.internal.cache invoke 
singleton getters.

GemFireCacheImpl.getExisting(String):
* TXCommitMessage

GemFireCacheImpl.getInstance():
* TXCommitMessage$RegionCommit$FarSideEntryOp
* RemoteOperationMessage
* TXRegionLockRequestImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4541) Remove singleton calls from product code in org.apache.geode.internal.cache

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4541:
-
Description: 
These product classes in org.apache.geode.internal.cache invoke singleton 
getters.

GemFireCacheImpl.getExisting(String):
* TXCommitMessage

GemFireCacheImpl.getInstance():
* CacheServerLauncher
* DistributedRegionFunctionStreamingMessage
* EntryEventImpl
* TXCommitMessage$RegionCommit$FarSideEntryOp
* FilterProfile
* FilterRoutingInfo
* FindDurableQueueProcessor
* GemFireCacheImpl
* MemberFunctionStreamingMessage
* PoolFactoryImpl
* PRQueryProcessor
* DistributedPutAllOperation
* RemoteOperationMessage
* TXRegionLockRequestImpl

  was:
These product classes in org.apache.geode.internal.cache invoke singleton 
getters.

GemFireCacheImpl.getExisting(String):
* TXCommitMessage


> Remove singleton calls from product code in org.apache.geode.internal.cache
> ---
>
> Key: GEODE-4541
> URL: https://issues.apache.org/jira/browse/GEODE-4541
> Project: Geode
>  Issue Type: Sub-task
>  Components: transactions
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.internal.cache invoke singleton 
> getters.
> GemFireCacheImpl.getExisting(String):
> * TXCommitMessage
> GemFireCacheImpl.getInstance():
> * CacheServerLauncher
> * DistributedRegionFunctionStreamingMessage
> * EntryEventImpl
> * TXCommitMessage$RegionCommit$FarSideEntryOp
> * FilterProfile
> * FilterRoutingInfo
> * FindDurableQueueProcessor
> * GemFireCacheImpl
> * MemberFunctionStreamingMessage
> * PoolFactoryImpl
> * PRQueryProcessor
> * DistributedPutAllOperation
> * RemoteOperationMessage
> * TXRegionLockRequestImpl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4541) Remove singleton calls from core product code in org.apache.geode.internal.cache

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4541:
-
Summary: Remove singleton calls from core product code in 
org.apache.geode.internal.cache  (was: Remove singleton calls from product code 
in org.apache.geode.internal.cache)

> Remove singleton calls from core product code in 
> org.apache.geode.internal.cache
> 
>
> Key: GEODE-4541
> URL: https://issues.apache.org/jira/browse/GEODE-4541
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Kirk Lund
>Priority: Major
>
> These product classes in org.apache.geode.internal.cache invoke singleton 
> getters.
> GemFireCacheImpl.getInstance():
> * CacheServerLauncher
> * EntryEventImpl
> * GemFireCacheImpl
> * DistributedPutAllOperation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4541) Remove singleton calls from core product code in org.apache.geode.internal.cache

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4541:
-
Description: 
These core product classes in org.apache.geode.internal.cache invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* CacheServerLauncher
* EntryEventImpl
* GemFireCacheImpl
* DistributedPutAllOperation


  was:
These product classes in org.apache.geode.internal.cache invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* CacheServerLauncher
* EntryEventImpl
* GemFireCacheImpl
* DistributedPutAllOperation



> Remove singleton calls from core product code in 
> org.apache.geode.internal.cache
> 
>
> Key: GEODE-4541
> URL: https://issues.apache.org/jira/browse/GEODE-4541
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Kirk Lund
>Priority: Major
>
> These core product classes in org.apache.geode.internal.cache invoke 
> singleton getters.
> GemFireCacheImpl.getInstance():
> * CacheServerLauncher
> * EntryEventImpl
> * GemFireCacheImpl
> * DistributedPutAllOperation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4552) Remove singleton calls from client/server product code in org.apache.geode.internal.cache

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4552:


 Summary: Remove singleton calls from client/server product code in 
org.apache.geode.internal.cache
 Key: GEODE-4552
 URL: https://issues.apache.org/jira/browse/GEODE-4552
 Project: Geode
  Issue Type: Sub-task
  Components: client/server
Reporter: Kirk Lund


These client/server product classes in org.apache.geode.internal.cache invoke 
singleton getters.

GemFireCacheImpl.getInstance():
* PoolFactoryImpl




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (GEODE-4541) Remove singleton calls from regions product code in org.apache.geode.internal.cache

2018-02-02 Thread Kirk Lund (JIRA)

 [ 
https://issues.apache.org/jira/browse/GEODE-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk Lund updated GEODE-4541:
-
Component/s: (was: transactions)
 regions

> Remove singleton calls from regions product code in 
> org.apache.geode.internal.cache
> ---
>
> Key: GEODE-4541
> URL: https://issues.apache.org/jira/browse/GEODE-4541
> Project: Geode
>  Issue Type: Sub-task
>  Components: regions
>Reporter: Kirk Lund
>Priority: Major
>
> These core product classes in org.apache.geode.internal.cache invoke 
> singleton getters.
> GemFireCacheImpl.getInstance():
> * CacheServerLauncher
> * EntryEventImpl
> * GemFireCacheImpl
> * DistributedPutAllOperation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (GEODE-4555) Remove singleton calls from product code in org.apache.geode.internal.admin

2018-02-02 Thread Kirk Lund (JIRA)
Kirk Lund created GEODE-4555:


 Summary: Remove singleton calls from product code in 
org.apache.geode.internal.admin
 Key: GEODE-4555
 URL: https://issues.apache.org/jira/browse/GEODE-4555
 Project: Geode
  Issue Type: Sub-task
  Components: core
Reporter: Kirk Lund


These product classes in org.apache.geode.internal.admin invoke singleton 
getters.

GemFireCacheImpl.getInstance():
* ClientStatsManager
* ShutdownAllRequest



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   >