[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083361#comment-14083361 ] Hudson commented on HBASE-11640: FAILURE: Integrated in HBase-TRUNK #5364 (See [https://builds.apache.org/job/HBase-TRUNK/5364/]) HBASE-11640 Add syntax highlighting support to HBase Ref Guide programlistings ADDENDUM (stack: rev db15d6e6a7d8c0448c7791a634ce2b97806a4bb8) * pom.xml > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch, Screen > Shot 2014-08-02 at 9.19.24 am.png > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083255#comment-14083255 ] Hadoop QA commented on HBASE-11640: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12659271/HBASE-11640_pom.patch against trunk revision . ATTACHMENT ID: 12659271 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+0 tests included{color}. The patch appears to be a documentation patch that doesn't require tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10271//console This message is automatically generated. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch, Screen > Shot 2014-08-02 at 9.19.24 am.png > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083177#comment-14083177 ] stack commented on HBASE-11640: --- Yes. I have that over here. Its beautiful. Thanks [~misty] > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch, Screen > Shot 2014-08-02 at 9.19.24 am.png > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083163#comment-14083163 ] Misty Stanley-Jones commented on HBASE-11640: - For instance, I see in file:///Users/misty/git/hbase/target/docbkx/book.html#appendix_contributing_to_documentation (fix up the URL for your own system of course) in listing A.7, the elements in the XML are blue and attributes are orange. I just verified it against master (I see you pushed the changes ) > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083159#comment-14083159 ] stack commented on HBASE-11640: --- Hmm... still don't see it. Paste an example so I know what I am looking for? > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083146#comment-14083146 ] stack commented on HBASE-11640: --- [~misty] your best bet is blame me. That is best place to start... > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083143#comment-14083143 ] Misty Stanley-Jones commented on HBASE-11640: - Odd, it was in the original patch -- I just checked it. Can you let me know what I should have done better on this one, [~stack]? > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083144#comment-14083144 ] stack commented on HBASE-11640: --- I applied the addendum. It was probably my fault the pom changes didn't go in. Let me see if I see the diff now. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083135#comment-14083135 ] Misty Stanley-Jones commented on HBASE-11640: - Somehow my changes to the POM itself didn't make it in. That was supposed to be the point of my first patch but I must have done soemthing wrong. Let me add an addendum. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_pom.patch, HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083124#comment-14083124 ] Misty Stanley-Jones commented on HBASE-11640: - Let me see if I can figure out why it isn't working for you. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082810#comment-14082810 ] Hudson commented on HBASE-11640: FAILURE: Integrated in HBase-TRUNK #5361 (See [https://builds.apache.org/job/HBase-TRUNK/5361/]) HBASE-11640 Add syntax highlighting support to HBase Ref Guide programlistings (Misty Stanley-Jones) (stack: rev 24b5fa7f0c442b54157d961bf47d912455275151) * src/main/docbkx/security.xml * src/main/docbkx/schema_design.xml * src/main/docbkx/performance.xml * src/main/docbkx/preface.xml * src/main/docbkx/troubleshooting.xml * src/main/docbkx/customization.xsl * src/main/docbkx/developer.xml * src/main/docbkx/case_studies.xml * src/main/docbkx/appendix_contributing_to_documentation.xml * src/main/docbkx/ops_mgt.xml * src/main/docbkx/cp.xml * src/main/docbkx/upgrading.xml * src/main/docbkx/book.xml * src/main/docbkx/getting_started.xml * src/main/docbkx/hbase_apis.xml * src/main/docbkx/zookeeper.xml * src/main/docbkx/tracing.xml * src/main/docbkx/thrift_filter_language.xml * src/main/docbkx/configuration.xml > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Fix For: 2.0.0 > > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082459#comment-14082459 ] stack commented on HBASE-11640: --- Hmm... I don't see any difference in display still. Committing anyways because [~misty] knows what she is doing. FYI, see '2.5.3.4. Better Mean Time to Recover (MTTR)'. The paragraph that follows is messed up. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14082182#comment-14082182 ] Hadoop QA commented on HBASE-11640: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12659112/HBASE-11640_syntax_highlighting_applied.patch against trunk revision . ATTACHMENT ID: 12659112 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 7 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: +$ mvn clean install -DskipTests # Builds HBase +$ mvn clean site -DskipTests # Builds the website and documentation +$ git diff --no-prefix origin/master > HBASE-123456.patch + language=LANGUAGE_OF_CHOICE + + $ HADOOP_CLASSPATH=`${HBASE_HOME}/bin/hbase classpath` ${HADOOP_HOME}/bin/hadoop jar ${HBASE_HOME}/hbase-0.90.0.jar rowcounter usertable +$ HADOOP_CLASSPATH=${HBASE_HOME}/target/hbase-0.90.0-SNAPSHOT.jar:`${HBASE_HOME}/bin/hbase classpath` ${HADOOP_HOME}/bin/hadoop jar ${HBASE_HOME}/target/hbase-0.90.0-SNAPSHOT.jar rowcounter usertable + $ ${HADOOP_HOME}/bin/hadoop jar ${HBASE_HOME}/hbase-0.90.0-SNAPSHOT.jar + $ ${HADOOP_HOME}/bin/hadoop jar ${HBASE_HOME}/hbase-0.90.0-SNAPSHOT.jar rowcounter myTable +public class MyMapper extends TableMapper{ {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestRestartCluster org.apache.hadoop.hbase.regionserver.TestRegionReplicas org.apache.hadoop.hbase.TestIOFencing org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.client.TestReplicasClient {color:red}-1 core zombie tests{color}. There are 1 zombie test(s): Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/10257//console This message is automatically generated. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Attachments: HBASE-11640-add_highlighting_support.patch, > HBASE-11640_syntax_highlighting_applied.patch > > -- This message was sent by Atlassian JIRA (v6
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081989#comment-14081989 ] Misty Stanley-Jones commented on HBASE-11640: - Wait for the next part of my patch where I add the language attribute to the relevant elements. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Attachments: HBASE-11640-add_highlighting_support.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081940#comment-14081940 ] stack commented on HBASE-11640: --- What is supposed to be different? I built it but don't see currently. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > Attachments: HBASE-11640-add_highlighting_support.patch > > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081905#comment-14081905 ] Nick Dimiduk commented on HBASE-11640: -- Fancy! > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11640) Add syntax highlighting support to HBase Ref Guide programlistings
[ https://issues.apache.org/jira/browse/HBASE-11640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14081906#comment-14081906 ] Misty Stanley-Jones commented on HBASE-11640: - This will come in two parts -- the first patch will add the support itself and the second patch will enable it for programlisting and screen output throughout the guide. > Add syntax highlighting support to HBase Ref Guide programlistings > -- > > Key: HBASE-11640 > URL: https://issues.apache.org/jira/browse/HBASE-11640 > Project: HBase > Issue Type: Bug > Components: documentation >Reporter: Misty Stanley-Jones >Assignee: Misty Stanley-Jones > -- This message was sent by Atlassian JIRA (v6.2#6252)