[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269451#comment-14269451 ] Hadoop QA commented on HBASE-12796: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690843/HBASE-12796-v7.patch against master branch at commit 645fbd7d87450b31b67b1e535cdb9c1cf50ffd16. ATTACHMENT ID: 12690843 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 545 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:red}-1 release audit{color}. The applied patch generated 1 release audit warnings (more than the master's current 0 warnings). {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:green}+1 core tests{color}. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//testReport/ Release audit warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/patchReleaseAuditWarnings.txt Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12363//console This message is automatically generated. Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Assignee: Jurriaan Mous Attachments: HBASE-12796-v1.patch, HBASE-12796-v2.patch, HBASE-12796-v3.patch, HBASE-12796-v4.patch, HBASE-12796-v5.patch, HBASE-12796-v6.patch, HBASE-12796-v7.patch, HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269462#comment-14269462 ] Ted Yu commented on HBASE-12796: Don't know how hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java.rej got into the patch - removed upon commit. Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Assignee: Jurriaan Mous Attachments: HBASE-12796-v1.patch, HBASE-12796-v2.patch, HBASE-12796-v3.patch, HBASE-12796-v4.patch, HBASE-12796-v5.patch, HBASE-12796-v6.patch, HBASE-12796-v7.patch, HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269594#comment-14269594 ] Hudson commented on HBASE-12796: FAILURE: Integrated in HBase-TRUNK #6003 (See [https://builds.apache.org/job/HBase-TRUNK/6003/]) HBASE-12796 Clean up HTable and HBaseAdmin deprecated constructor usage (Jurriaan Mous) (tedyu: rev 9246af8dac5e80be92ba25ff7ee8b736f9e78924) * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRolling.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestNamespace.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotFromClient.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestLoadIncrementalHFilesSplitRecovery.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TableSnapshotInputFormatTestBase.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/MultiThreadedReaderWithACL.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestMultiSlaveReplication.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin2.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientTimeouts.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController2.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/handler/TestTableDeleteFamilyHandler.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/HFileOutputFormat2.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapred/TableInputFormatBase.java * hbase-server/src/test/java/org/apache/hadoop/hbase/TestAcidGuarantees.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientOperationInterrupt.java * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/FilterTestingCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilterWrapper.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestLogRollPeriod.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverBypass.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSCVFWithMiniCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java * hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestLoadAndSwitchEncodeOnDisk.java * hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsckEncryption.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestFlushSnapshotFromClient.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide3.java * hbase-server/src/test/java/org/apache/hadoop/hbase/snapshot/TestRestoreFlushSnapshotFromClient.java * hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/WALPlayer.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestCompactionState.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestAdmin1.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestNamespaceCommands.java * hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestSnapshotMetadata.java * hbase-server/src/test/java/org/apache/hadoop/hbase/replication/TestReplicationSyncUpTool.java * hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java * hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestScanRowPrefix.java * hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionOnCluster.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java * hbase-server/src/test/java/org/apache/hadoop/hbase/ScanPerformanceEvaluation.java * hbase-server/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportTSVWithVisibilityLabels.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsReplication.java * hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithACL.java * hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionServerCoprocessorEndpoint.java *
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14269464#comment-14269464 ] Jurriaan Mous commented on HBASE-12796: --- Oh it seems I missed deleting one reject after merging the patch with the latest master and fixing those... Thanks for noticing it! :) Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Assignee: Jurriaan Mous Attachments: HBASE-12796-v1.patch, HBASE-12796-v2.patch, HBASE-12796-v3.patch, HBASE-12796-v4.patch, HBASE-12796-v5.patch, HBASE-12796-v6.patch, HBASE-12796-v7.patch, HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14266186#comment-14266186 ] Hadoop QA commented on HBASE-12796: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690350/HBASE-12796-v6.patch against master branch at commit 26e3e1b300670d6c3f9f4853aa937226592b9537. ATTACHMENT ID: 12690350 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 548 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12330//console This message is automatically generated. Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Assignee: Jurriaan Mous Attachments: HBASE-12796-v1.patch, HBASE-12796-v2.patch, HBASE-12796-v3.patch, HBASE-12796-v4.patch, HBASE-12796-v5.patch, HBASE-12796-v6.patch, HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264399#comment-14264399 ] Hadoop QA commented on HBASE-12796: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690053/HBASE-12796-v3.patch against master branch at commit ac95cc1fbb951bb9db96f2738f621d1d7cd45739. ATTACHMENT ID: 12690053 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 555 new or modified tests. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12301//console This message is automatically generated. Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Assignee: Jurriaan Mous Attachments: HBASE-12796-v1.patch, HBASE-12796-v2.patch, HBASE-12796-v3.patch, HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264539#comment-14264539 ] Hadoop QA commented on HBASE-12796: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690060/HBASE-12796-v4.patch against master branch at commit ac95cc1fbb951bb9db96f2738f621d1d7cd45739. ATTACHMENT ID: 12690060 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 544 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12302//console This message is automatically generated. Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Assignee: Jurriaan Mous Attachments: HBASE-12796-v1.patch, HBASE-12796-v2.patch, HBASE-12796-v3.patch, HBASE-12796-v4.patch, HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264609#comment-14264609 ] Hadoop QA commented on HBASE-12796: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12690071/HBASE-12796-v5.patch against master branch at commit ac95cc1fbb951bb9db96f2738f621d1d7cd45739. ATTACHMENT ID: 12690071 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 544 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool org.apache.hadoop.hbase.master.TestRestartCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12303//console This message is automatically generated. Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Assignee: Jurriaan Mous Attachments: HBASE-12796-v1.patch, HBASE-12796-v2.patch, HBASE-12796-v3.patch, HBASE-12796-v4.patch, HBASE-12796-v5.patch, HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14264715#comment-14264715 ] stack commented on HBASE-12796: --- That is a mountain of work that you've done in this issue [~jurmous] Skimmed it and looks good. Just has to pass hadoopqa, the arbitrator when it comes to changes in tests. Thanks (I still owe perf figures on the new client -- on it). Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Assignee: Jurriaan Mous Attachments: HBASE-12796-v1.patch, HBASE-12796-v2.patch, HBASE-12796-v3.patch, HBASE-12796-v4.patch, HBASE-12796-v5.patch, HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14262865#comment-14262865 ] Hadoop QA commented on HBASE-12796: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12689784/HBASE-12796.patch against master branch at commit a90e64c6373437e109e6d84adbf11ea8bf296e53. ATTACHMENT ID: 12689784 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 555 new or modified tests. {color:red}-1 javac{color}. The patch appears to cause mvn compile goal to fail. Compilation errors resume: [ERROR] COMPILATION ERROR : [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java:[527,37] incompatible types [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/target/generated-sources/java/org/apache/hadoop/hbase/generated/master/table_jsp.java:[194,47] cannot find symbol [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.2:compile (default-compile) on project hbase-server: Compilation failure: Compilation failure: [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java:[527,37] incompatible types [ERROR] required: org.apache.hadoop.hbase.client.HBaseAdmin [ERROR] found:org.apache.hadoop.hbase.client.Admin [ERROR] /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/target/generated-sources/java/org/apache/hadoop/hbase/generated/master/table_jsp.java:[194,47] cannot find symbol [ERROR] symbol: method getRegionLocations() [ERROR] location: variable table of type org.apache.hadoop.hbase.client.Table [ERROR] - [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn goals -rf :hbase-server Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12283//console This message is automatically generated. Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Attachments: HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14262920#comment-14262920 ] Hadoop QA commented on HBASE-12796: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12689787/HBASE-12796-v1.patch against master branch at commit a90e64c6373437e109e6d84adbf11ea8bf296e53. ATTACHMENT ID: 12689787 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 555 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + public int loadTable(final Table t, final byte[][] f, byte[] value, boolean writeToWAL) throws IOException { +HRegionLocation hloc = connection.getRegionLocator(TableName.META_TABLE_NAME).getRegionLocation(Bytes.toBytes()); {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.security.access.TestNamespaceCommands org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildBase org.apache.hadoop.hbase.security.access.TestCellACLWithMultipleVersions org.apache.hadoop.hbase.security.visibility.TestEnforcingScanLabelGenerator org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDistributedLogReplay org.apache.hadoop.hbase.mapreduce.TestSecureLoadIncrementalHFiles org.apache.hadoop.hbase.security.access.TestScanEarlyTermination org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint org.apache.hadoop.hbase.replication.TestReplicationSmallTests org.apache.hadoop.hbase.replication.TestMasterReplication org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat2 org.apache.hadoop.hbase.security.access.TestCellACLs org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildHole org.apache.hadoop.hbase.util.TestHBaseFsck org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithACL org.apache.hadoop.hbase.security.visibility.TestDefaultScanLabelGeneratorStack org.apache.hadoop.hbase.util.hbck.TestOfflineMetaRebuildOverlap org.apache.hadoop.hbase.security.access.TestAccessController org.apache.hadoop.hbase.security.visibility.TestVisibilityLabelsWithDefaultVisLabelService org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths org.apache.hadoop.hbase.security.access.TestAccessControlFilter Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12284//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12284//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12284//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12284//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12284//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12284//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12284//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12284//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings:
[jira] [Commented] (HBASE-12796) Clean up HTable and HBaseAdmin deprecated constructor usage
[ https://issues.apache.org/jira/browse/HBASE-12796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14263234#comment-14263234 ] Hadoop QA commented on HBASE-12796: --- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12689868/HBASE-12796-v2.patch against master branch at commit a90e64c6373437e109e6d84adbf11ea8bf296e53. ATTACHMENT ID: 12689868 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 555 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 checkstyle{color}. The applied patch does not increase the total number of checkstyle errors {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 lineLengths{color}. The patch does not introduce lines longer than 100 {color:green}+1 site{color}. The mvn site goal succeeds with this patch. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.regionserver.TestEndToEndSplitTransaction org.apache.hadoop.hbase.security.visibility.TestVisibilityWithCheckAuths org.apache.hadoop.hbase.replication.TestReplicationSyncUpTool org.apache.hadoop.hbase.master.TestRestartCluster Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//artifact/patchprocess/checkstyle-aggregate.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/12287//console This message is automatically generated. Clean up HTable and HBaseAdmin deprecated constructor usage --- Key: HBASE-12796 URL: https://issues.apache.org/jira/browse/HBASE-12796 Project: HBase Issue Type: Improvement Reporter: Jurriaan Mous Attachments: HBASE-12796-v1.patch, HBASE-12796-v2.patch, HBASE-12796.patch The are a lot of calls to the deprecated calls to HBaseAdmin and HTable constructors in many tests and even some in production code. This issue is about removing most of them so most code does not create redundant Connections and underlying pools and RPC clients. Hopefully making the tests more lightweight. -- This message was sent by Atlassian JIRA (v6.3.4#6332)