[jira] [Commented] (HBASE-15586) Unify human readable numbers in the web UI
[ https://issues.apache.org/jira/browse/HBASE-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15237513#comment-15237513 ] Nick Dimiduk commented on HBASE-15586: -- Lovely work [~enis]. My operator hat would love to have this in 1.1/1.2. Technically it is an enhancement though, so I think it's best to pass. Unfortunate it took us so long to fix this up. > Unify human readable numbers in the web UI > --- > > Key: HBASE-15586 > URL: https://issues.apache.org/jira/browse/HBASE-15586 > Project: HBase > Issue Type: Improvement >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: Screen Shot 2016-04-01 at 3.52.00 PM.png, Screen Shot > 2016-04-01 at 3.52.12 PM.png, Screen Shot 2016-04-01 at 3.52.32 PM.png, > Screen Shot 2016-04-01 at 3.52.38 PM.png, Screen Shot 2016-04-01 at 3.52.49 > PM.png, hbase-15586-v1.patch, hbase-15586-v1.patch, hbase-15586-v2.patch > > > I was looking at something else in the regionserver web ui trying to > understand the WAL size, and we are reporting that as raw bytes, not in MB / > GB range. Did a quick sweep to unify all the human-readable representations > in the UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15586) Unify human readable numbers in the web UI
[ https://issues.apache.org/jira/browse/HBASE-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235572#comment-15235572 ] Sean Busbey commented on HBASE-15586: - Thanks for the ping. Unless [~ndimiduk] strongly wants it in 1.1.z, I'd just as soon leave it in 1.3+. > Unify human readable numbers in the web UI > --- > > Key: HBASE-15586 > URL: https://issues.apache.org/jira/browse/HBASE-15586 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: Screen Shot 2016-04-01 at 3.52.00 PM.png, Screen Shot > 2016-04-01 at 3.52.12 PM.png, Screen Shot 2016-04-01 at 3.52.32 PM.png, > Screen Shot 2016-04-01 at 3.52.38 PM.png, Screen Shot 2016-04-01 at 3.52.49 > PM.png, hbase-15586-v1.patch, hbase-15586-v1.patch, hbase-15586-v2.patch > > > I was looking at something else in the regionserver web ui trying to > understand the WAL size, and we are reporting that as raw bytes, not in MB / > GB range. Did a quick sweep to unify all the human-readable representations > in the UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15586) Unify human readable numbers in the web UI
[ https://issues.apache.org/jira/browse/HBASE-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231691#comment-15231691 ] Hudson commented on HBASE-15586: SUCCESS: Integrated in HBase-1.4 #76 (See [https://builds.apache.org/job/HBase-1.4/76/]) HBASE-15586 Unify human readable numbers in the web UI (enis: rev d94c18a0e72443da0857a473f9b1ff9d2bb40854) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon > Unify human readable numbers in the web UI > --- > > Key: HBASE-15586 > URL: https://issues.apache.org/jira/browse/HBASE-15586 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: Screen Shot 2016-04-01 at 3.52.00 PM.png, Screen Shot > 2016-04-01 at 3.52.12 PM.png, Screen Shot 2016-04-01 at 3.52.32 PM.png, > Screen Shot 2016-04-01 at 3.52.38 PM.png, Screen Shot 2016-04-01 at 3.52.49 > PM.png, hbase-15586-v1.patch, hbase-15586-v1.patch, hbase-15586-v2.patch > > > I was looking at something else in the regionserver web ui trying to > understand the WAL size, and we are reporting that as raw bytes, not in MB / > GB range. Did a quick sweep to unify all the human-readable representations > in the UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15586) Unify human readable numbers in the web UI
[ https://issues.apache.org/jira/browse/HBASE-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231635#comment-15231635 ] Hudson commented on HBASE-15586: FAILURE: Integrated in HBase-Trunk_matrix #830 (See [https://builds.apache.org/job/HBase-Trunk_matrix/830/]) HBASE-15586 Unify human readable numbers in the web UI (enis: rev 2dcd08bc3d8ab2f26da85128102926c68a95186f) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon > Unify human readable numbers in the web UI > --- > > Key: HBASE-15586 > URL: https://issues.apache.org/jira/browse/HBASE-15586 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: Screen Shot 2016-04-01 at 3.52.00 PM.png, Screen Shot > 2016-04-01 at 3.52.12 PM.png, Screen Shot 2016-04-01 at 3.52.32 PM.png, > Screen Shot 2016-04-01 at 3.52.38 PM.png, Screen Shot 2016-04-01 at 3.52.49 > PM.png, hbase-15586-v1.patch, hbase-15586-v1.patch, hbase-15586-v2.patch > > > I was looking at something else in the regionserver web ui trying to > understand the WAL size, and we are reporting that as raw bytes, not in MB / > GB range. Did a quick sweep to unify all the human-readable representations > in the UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15586) Unify human readable numbers in the web UI
[ https://issues.apache.org/jira/browse/HBASE-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231501#comment-15231501 ] Hudson commented on HBASE-15586: SUCCESS: Integrated in HBase-1.3 #638 (See [https://builds.apache.org/job/HBase-1.3/638/]) HBASE-15586 Unify human readable numbers in the web UI (enis: rev 2fc7c8bbc5424c6291dc6ca0eac9d5605f607617) * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/ServerMetricsTmpl.jamon * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/master/RegionServerListTmpl.jamon * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/BlockCacheTmpl.jamon * hbase-server/src/main/jamon/org/apache/hadoop/hbase/tmpl/regionserver/RegionListTmpl.jamon > Unify human readable numbers in the web UI > --- > > Key: HBASE-15586 > URL: https://issues.apache.org/jira/browse/HBASE-15586 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: Screen Shot 2016-04-01 at 3.52.00 PM.png, Screen Shot > 2016-04-01 at 3.52.12 PM.png, Screen Shot 2016-04-01 at 3.52.32 PM.png, > Screen Shot 2016-04-01 at 3.52.38 PM.png, Screen Shot 2016-04-01 at 3.52.49 > PM.png, hbase-15586-v1.patch, hbase-15586-v1.patch, hbase-15586-v2.patch > > > I was looking at something else in the regionserver web ui trying to > understand the WAL size, and we are reporting that as raw bytes, not in MB / > GB range. Did a quick sweep to unify all the human-readable representations > in the UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15586) Unify human readable numbers in the web UI
[ https://issues.apache.org/jira/browse/HBASE-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231352#comment-15231352 ] Enis Soztutar commented on HBASE-15586: --- Thanks Stack. Test failure is due to HBASE-15613. [~busbey], [~ndimiduk] do you want this in 1.1 / 1.2? > Unify human readable numbers in the web UI > --- > > Key: HBASE-15586 > URL: https://issues.apache.org/jira/browse/HBASE-15586 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: Screen Shot 2016-04-01 at 3.52.00 PM.png, Screen Shot > 2016-04-01 at 3.52.12 PM.png, Screen Shot 2016-04-01 at 3.52.32 PM.png, > Screen Shot 2016-04-01 at 3.52.38 PM.png, Screen Shot 2016-04-01 at 3.52.49 > PM.png, hbase-15586-v1.patch, hbase-15586-v1.patch, hbase-15586-v2.patch > > > I was looking at something else in the regionserver web ui trying to > understand the WAL size, and we are reporting that as raw bytes, not in MB / > GB range. Did a quick sweep to unify all the human-readable representations > in the UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15586) Unify human readable numbers in the web UI
[ https://issues.apache.org/jira/browse/HBASE-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231230#comment-15231230 ] Hadoop QA commented on HBASE-15586: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 39s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 17s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 32s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 47s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 18s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 29m 29s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 36s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 98m 34s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 135m 47s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Timed out junit tests | org.apache.hadoop.hbase.security.access.TestNamespaceCommands | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12797591/hbase-15586-v2.patch | | JIRA Issue | HBASE-15586 | | Optional Tests | asflicense javac javadoc unit | | uname | Linux asf901.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build@2/component/dev-support/hbase-personality.sh | | git revision | master / ac8cd37 | | Default Java | 1.7.0_79 | | Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/1332/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/1332/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/1332/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1332/console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > Unify human readable numbers in the web UI > --- > > Key: HBASE-15586 > URL: https://issues.apache.org/jira/browse/HBASE-15586 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: Screen Shot 2016-04-01 at 3.52.00 PM.png, Screen Shot > 2016-04-01 at 3.52.12 PM.png, Screen Shot 2016-04-01 at 3.52.32 PM.png, > Screen Shot 2016-04-01 at 3.52.38 PM.png, Screen Shot 2016-04-01 at 3.52.49 > PM.png, hbase-15586-v1.patch, hbase-15586-v1.patch, hbase-15586-v2.patch > > > I was looking at something else in the regionserver web ui trying to > understand the WAL size, and we are reporting that as raw bytes, not in MB / > GB range. Did a quick sweep to unify all the human
[jira] [Commented] (HBASE-15586) Unify human readable numbers in the web UI
[ https://issues.apache.org/jira/browse/HBASE-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15230995#comment-15230995 ] stack commented on HBASE-15586: --- Go for it [~enis] LGTM If any remaining, can fix in new issue. Backport it too please sir. > Unify human readable numbers in the web UI > --- > > Key: HBASE-15586 > URL: https://issues.apache.org/jira/browse/HBASE-15586 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: Screen Shot 2016-04-01 at 3.52.00 PM.png, Screen Shot > 2016-04-01 at 3.52.12 PM.png, Screen Shot 2016-04-01 at 3.52.32 PM.png, > Screen Shot 2016-04-01 at 3.52.38 PM.png, Screen Shot 2016-04-01 at 3.52.49 > PM.png, hbase-15586-v1.patch, hbase-15586-v1.patch, hbase-15586-v2.patch > > > I was looking at something else in the regionserver web ui trying to > understand the WAL size, and we are reporting that as raw bytes, not in MB / > GB range. Did a quick sweep to unify all the human-readable representations > in the UI. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-15586) Unify human readable numbers in the web UI
[ https://issues.apache.org/jira/browse/HBASE-15586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222660#comment-15222660 ] Hadoop QA commented on HBASE-15586: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 25s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 18s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 37s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 49s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 19s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s {color} | {color:red} The patch has 12 line(s) that end in whitespace. Use git apply --whitespace=fix. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 32m 21s {color} | {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.1 2.6.2 2.6.3 2.7.1. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 41s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 142m 31s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s {color} | {color:green} Patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 182m 53s {color} | {color:black} {color} | \\ \\ || Reason || Tests || | Failed junit tests | hadoop.hbase.master.procedure.TestMasterFailoverWithProcedures | | Timed out junit tests | org.apache.hadoop.hbase.security.access.TestNamespaceCommands | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12796623/hbase-15586-v1.patch | | JIRA Issue | HBASE-15586 | | Optional Tests | asflicense javac javadoc unit | | uname | Linux asf910.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 25419d8 | | Default Java | 1.7.0_79 | | Multi-JDK versions | /home/jenkins/tools/java/jdk1.8.0:1.8.0 /usr/local/jenkins/java/jdk1.7.0_79:1.7.0_79 | | whitespace | https://builds.apache.org/job/PreCommit-HBASE-Build/1272/artifact/patchprocess/whitespace-eol.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/1272/artifact/patchprocess/patch-unit-hbase-server.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/1272/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/1272/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1272/console | | Powered by | Apache Yetus 0.2.0 http://yetus.apache.org | This message was automatically generated. > Unify human readable numbers in the web UI > --- > > Key: HBASE-15586 > URL: https://issues.apache.org/jira/browse/HBASE-15586 > Project: HBase > Issue Type: Bug >Reporter: Enis Soztutar >Assignee: Enis Soztutar > Fix For: 2.0.0, 1.3.0, 1.4.0 > > Attachments: Screen Shot 2016-04-01 at 3.52.00 PM.png, Screen Shot > 2016-04-01 at 3.52.12 PM.png, Screen Shot 2016-04-01 at 3.52.32 PM.png, > Screen Shot 2016-04-01 at 3.52.38 PM.png, Screen Shot 2016-04-01 at 3.52.49 > PM.png, hbase-15586-v1.patch, hbas