[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469302#comment-13469302 ] Hudson commented on HBASE-6439: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #207 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/207/]) HBASE-6439 Ignore .archive directory as a table (Revision 1393916) Result = SUCCESS stack : Files : * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HFileLink.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HFileArchiveUtil.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/example/TestZooKeeperTableArchiveClient.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestHFileCleaner.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHFileArchiveUtil.java > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Labels: newbie > Fix For: 0.96.0 > > Attachments: hbase-6439-r0.patch > > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469179#comment-13469179 ] Hudson commented on HBASE-6439: --- Integrated in HBase-TRUNK #3420 (See [https://builds.apache.org/job/HBase-TRUNK/3420/]) HBASE-6439 Ignore .archive directory as a table (Revision 1393916) Result = FAILURE stack : Files : * /hbase/trunk/hbase-common/src/main/java/org/apache/hadoop/hbase/HConstants.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/io/HFileLink.java * /hbase/trunk/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HFileArchiveUtil.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/backup/example/TestZooKeeperTableArchiveClient.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/master/cleaner/TestHFileCleaner.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestFSTableDescriptors.java * /hbase/trunk/hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestHFileArchiveUtil.java > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Labels: newbie > Fix For: 0.96.0 > > Attachments: hbase-6439-r0.patch > > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469039#comment-13469039 ] Jesse Yates commented on HBASE-6439: [~stack] nope, that test is flapping independent of this patch. See latest comment on HBASE-6707. Means this patch should be good to go. > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Labels: newbie > Attachments: hbase-6439-r0.patch > > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469026#comment-13469026 ] Jesse Yates commented on HBASE-6439: [~stack] I think this test failure is due to this patch, not due to it flapping (again). I'll look into it. But yeah, it should remove that warning. > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Labels: newbie > Attachments: hbase-6439-r0.patch > > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468985#comment-13468985 ] stack commented on HBASE-6439: -- Otherwise, +1 on patch. This gets rid of this issue Jesse when I start up hbase? {code} 2012-10-03 12:34:28,515 DEBUG org.apache.hadoop.hbase.util.FSTableDescriptors: Exception during readTableDecriptor. Current table name = .archive org.apache.hadoop.hbase.TableInfoMissingException: No .tableinfo file under file:/Users/Stack/Downloads/hbase-stack/hbase/.archive {code} What you reckon of the test failure? > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Labels: newbie > Attachments: hbase-6439-r0.patch > > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468982#comment-13468982 ] stack commented on HBASE-6439: -- [~jesse_yates] Did this test org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient fail? > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Labels: newbie > Attachments: hbase-6439-r0.patch > > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468969#comment-13468969 ] Hadoop QA commented on HBASE-6439: -- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12547613/hbase-6439-r0.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 12 new or modified tests. {color:green}+1 hadoop2.0{color}. The patch compiles against the hadoop 2.0 profile. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 81 warning messages. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 findbugs{color}. The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests: org.apache.hadoop.hbase.backup.example.TestZooKeeperTableArchiveClient Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2995//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2995//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2995//console This message is automatically generated. > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Jesse Yates > Labels: newbie > Attachments: hbase-6439-r0.patch > > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465200#comment-13465200 ] Jesse Yates commented on HBASE-6439: [~sameerv] hfile archiving puts the hfiles in a directory comparable to the one its current in, just under the .archive directory. So an hile: {quote} /hbase/table/region/family/some_hfile {quote} would get archived to: {quote} /hbase/.archive/table/region/family/some_hfile {quote} no recovery issues. The problem here is that the '.archive' directory is currently configurable, but should just be a constant. > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Sameer Vaishampayan > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465189#comment-13465189 ] Sameer Vaishampayan commented on HBASE-6439: So even for the HFile archiving use a single common directory ? Would this cause an issue with recovery ? > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Sameer Vaishampayan > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465002#comment-13465002 ] Jesse Yates commented on HBASE-6439: yeah, it was configurable, but stack was saying that we should just make .archive the directory we always archive files. This patch then becomes the removal of the configuration element, fixing all the places it looks in the conf for archive directory (more that getStoreArchivePath, but not too many places), adding a constant value for the .archive directory and then, finally, updating the non-table-dirs constant. Make sense? > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Sameer Vaishampayan > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13465000#comment-13465000 ] Sameer Vaishampayan commented on HBASE-6439: Here's the review: https://reviews.apache.org/r/7225/ [~jesse_yates] [~saint@gmail.com] - Say what ? I am misunderstanding this bug then. I figured that there are log lines because some directories are not deletable. Also that it was to be made configurable from what was a constant. Aren't some archive dirs created under region dirs: as in HFileArchiveUtil >> getStoreArchivePath method ? and therefore not a constant ? > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Sameer Vaishampayan > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464980#comment-13464980 ] Jesse Yates commented on HBASE-6439: [~stack] +1 that sounds good Sameer would you mind rolling that into your patch? > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Sameer Vaishampayan > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464951#comment-13464951 ] stack commented on HBASE-6439: -- bq. Yeah, but its technically configurable, so that's not so nice... Lets undo the fact that its configurable. [~sameerv] Want to add a link to your review here? Thanks. > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Sameer Vaishampayan > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462148#comment-13462148 ] Sameer Vaishampayan commented on HBASE-6439: Yes I created a review. Sorry for the misunderstanding. > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Sameer Vaishampayan > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13461944#comment-13461944 ] Lars Hofhansl commented on HBASE-6439: -- Did you mean to remove the patch again, Sameer? > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates >Assignee: Sameer Vaishampayan > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420342#comment-13420342 ] Jesse Yates commented on HBASE-6439: Yeah, but its technically configurable, so that's not so nice... > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-6439) Ignore .archive directory as a table
[ https://issues.apache.org/jira/browse/HBASE-6439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420340#comment-13420340 ] stack commented on HBASE-6439: -- Add it to HConstants#HBASE_NON_USER_TABLE_DIRS > Ignore .archive directory as a table > > > Key: HBASE-6439 > URL: https://issues.apache.org/jira/browse/HBASE-6439 > Project: HBase > Issue Type: Bug > Components: io, regionserver >Affects Versions: 0.96.0 >Reporter: Jesse Yates > Labels: newbie > > From a recent test run: > {quote} > 2012-07-22 02:27:30,699 WARN [IPC Server handler 0 on 47087] > util.FSTableDescriptors(168): The following folder is in HBase's root > directory and doesn't contain a table descriptor, do consider deleting it: > .archive > {quote} > With the addition of HBASE-5547, table-level folders are no-longer all table > folders. FSTableDescriptors needs to then have a 'gold-list' that we can > update with directories that aren't tables so we don't have this kind of > thing showing up in the logs. > Currently, we have the following block: > {quote} > invocations++; > if (HTableDescriptor.ROOT_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.ROOT_TABLEDESC; > } > if (HTableDescriptor.META_TABLEDESC.getNameAsString().equals(tablename)) { > cachehits++; > return HTableDescriptor.META_TABLEDESC; > } > {quote} > to handle special cases, but that's a bit clunky and not clean in terms of > table-level directories that need to be ignored. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira