[jira] [Commented] (HBASE-10795) TestHBaseFsck#testHBaseFsck() should drop the table it creates

2014-03-19 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941172#comment-13941172
 ] 

stack commented on HBASE-10795:
---

Why?  Doesn't the cluster get shut down irrespective and then the dirs removed? 
 Why do more work?

 TestHBaseFsck#testHBaseFsck() should drop the table it creates
 --

 Key: HBASE-10795
 URL: https://issues.apache.org/jira/browse/HBASE-10795
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
 Attachments: 10795-v1.txt


 When investigating TestHBaseFsck test failures, I often saw the following 
 (https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/223/testReport/junit/org.apache.hadoop.hbase.util/TestHBaseFsck/testSplitDaughtersNotInMeta/):
 {code}
 Number of Tables: 3
   Table: tableBadMetaAssign   rw   families: 1
   Table: hbase:namespace  rw   families: 1
   Table: testSplitdaughtersNotInMeta  rw   families: 1
 {code}
 TestHBaseFsck#testHBaseFsck() should drop the table it creates.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10795) TestHBaseFsck#testHBaseFsck() should drop the table it creates

2014-03-19 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941178#comment-13941178
 ] 

Ted Yu commented on HBASE-10795:


Looking at other tests in TestHBaseFsck, such as testHBaseFsckClean(), the 
pattern is:
{code}
try {
  HBaseFsck hbck = doFsck(conf, false);
  assertNoErrors(hbck);

  setupTable(table);
...
} finally {
  deleteTable(table);
}
{code}
TestHBaseFsck#testHBaseFsck() should be consistent with the other tests.

 TestHBaseFsck#testHBaseFsck() should drop the table it creates
 --

 Key: HBASE-10795
 URL: https://issues.apache.org/jira/browse/HBASE-10795
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Trivial
 Attachments: 10795-v1.txt


 When investigating TestHBaseFsck test failures, I often saw the following 
 (https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/223/testReport/junit/org.apache.hadoop.hbase.util/TestHBaseFsck/testSplitDaughtersNotInMeta/):
 {code}
 Number of Tables: 3
   Table: tableBadMetaAssign   rw   families: 1
   Table: hbase:namespace  rw   families: 1
   Table: testSplitdaughtersNotInMeta  rw   families: 1
 {code}
 TestHBaseFsck#testHBaseFsck() should drop the table it creates.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10795) TestHBaseFsck#testHBaseFsck() should drop the table it creates

2014-03-19 Thread stack (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941198#comment-13941198
 ] 

stack commented on HBASE-10795:
---

Is this responsible for the test failure?

 TestHBaseFsck#testHBaseFsck() should drop the table it creates
 --

 Key: HBASE-10795
 URL: https://issues.apache.org/jira/browse/HBASE-10795
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Trivial
 Attachments: 10795-v1.txt


 When investigating TestHBaseFsck test failures, I often saw the following 
 (https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/223/testReport/junit/org.apache.hadoop.hbase.util/TestHBaseFsck/testSplitDaughtersNotInMeta/):
 {code}
 Number of Tables: 3
   Table: tableBadMetaAssign   rw   families: 1
   Table: hbase:namespace  rw   families: 1
   Table: testSplitdaughtersNotInMeta  rw   families: 1
 {code}
 TestHBaseFsck#testHBaseFsck() should drop the table it creates.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10795) TestHBaseFsck#testHBaseFsck() should drop the table it creates

2014-03-19 Thread Ted Yu (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941203#comment-13941203
 ] 

Ted Yu commented on HBASE-10795:


I mentioned the test failure since the Standard Output led me to 
TestHBaseFsck#testHBaseFsck().

This JIRA aligns TestHBaseFsck#testHBaseFsck() with rest of the tests.

Investigation of test failure of TestHBaseFsck#testSplitDaughtersNotInMeta is 
on-going.

 TestHBaseFsck#testHBaseFsck() should drop the table it creates
 --

 Key: HBASE-10795
 URL: https://issues.apache.org/jira/browse/HBASE-10795
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Trivial
 Attachments: 10795-v1.txt


 When investigating TestHBaseFsck test failures, I often saw the following 
 (https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/223/testReport/junit/org.apache.hadoop.hbase.util/TestHBaseFsck/testSplitDaughtersNotInMeta/):
 {code}
 Number of Tables: 3
   Table: tableBadMetaAssign   rw   families: 1
   Table: hbase:namespace  rw   families: 1
   Table: testSplitdaughtersNotInMeta  rw   families: 1
 {code}
 TestHBaseFsck#testHBaseFsck() should drop the table it creates.



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (HBASE-10795) TestHBaseFsck#testHBaseFsck() should drop the table it creates

2014-03-19 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/HBASE-10795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13941292#comment-13941292
 ] 

Hadoop QA commented on HBASE-10795:
---

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12635676/10795-v1.txt
  against trunk revision .
  ATTACHMENT ID: 12635676

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 3 new 
or modified tests.

{color:red}-1 hadoop1.0{color}.  The patch failed to compile against the 
hadoop 1.0 profile.
Here is snippet of errors:
{code}{code}

{color:red}-1 hadoop1.1{color}.  The patch failed to compile against the 
hadoop 1.1 profile.

{color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

{color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/9050//console

This message is automatically generated.

 TestHBaseFsck#testHBaseFsck() should drop the table it creates
 --

 Key: HBASE-10795
 URL: https://issues.apache.org/jira/browse/HBASE-10795
 Project: HBase
  Issue Type: Test
Reporter: Ted Yu
Assignee: Ted Yu
Priority: Trivial
 Attachments: 10795-v1.txt


 When investigating TestHBaseFsck test failures, I often saw the following 
 (https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/223/testReport/junit/org.apache.hadoop.hbase.util/TestHBaseFsck/testSplitDaughtersNotInMeta/):
 {code}
 Number of Tables: 3
   Table: tableBadMetaAssign   rw   families: 1
   Table: hbase:namespace  rw   families: 1
   Table: testSplitdaughtersNotInMeta  rw   families: 1
 {code}
 TestHBaseFsck#testHBaseFsck() should drop the table it creates.



--
This message was sent by Atlassian JIRA
(v6.2#6252)