[jira] [Commented] (HIVE-12944) Support SUM(DISTINCT) for partitioning query.
[ https://issues.apache.org/jira/browse/HIVE-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119717#comment-15119717 ] Aihua Xu commented on HIVE-12944: - [~szehon] Can you help review the code? Thanks. > Support SUM(DISTINCT) for partitioning query. > - > > Key: HIVE-12944 > URL: https://issues.apache.org/jira/browse/HIVE-12944 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12944.patch > > > We need to support avg(distinct), count(distinct), sum(distinct) for the > parent jira HIVE-9534. Separate the work for sum(distinct) in this subtask. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12944) Support SUM(DISTINCT) for partitioning query.
[ https://issues.apache.org/jira/browse/HIVE-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119964#comment-15119964 ] Szehon Ho commented on HIVE-12944: -- +1, some very minor codestyle nit, you can fix on commit. Yes the refactoring to wait for another JIRA is also fine with me. > Support SUM(DISTINCT) for partitioning query. > - > > Key: HIVE-12944 > URL: https://issues.apache.org/jira/browse/HIVE-12944 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12944.patch > > > We need to support avg(distinct), count(distinct), sum(distinct) for the > parent jira HIVE-9534. Separate the work for sum(distinct) in this subtask. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12944) Support SUM(DISTINCT) for partitioning query.
[ https://issues.apache.org/jira/browse/HIVE-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120070#comment-15120070 ] Szehon Ho commented on HIVE-12944: -- +1 thanks Aihua > Support SUM(DISTINCT) for partitioning query. > - > > Key: HIVE-12944 > URL: https://issues.apache.org/jira/browse/HIVE-12944 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12944.2.patch, HIVE-12944.patch > > > We need to support avg(distinct), count(distinct), sum(distinct) for the > parent jira HIVE-9534. Separate the work for sum(distinct) in this subtask. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12944) Support SUM(DISTINCT) for partitioning query.
[ https://issues.apache.org/jira/browse/HIVE-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121047#comment-15121047 ] Hive QA commented on HIVE-12944: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12784701/HIVE-12944.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 10007 tests executed *Failed tests:* {noformat} TestParseNegative - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_windowing_distinct org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_invalid_sum_syntax org.apache.hive.jdbc.TestSSL.testSSLVersion {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6775/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6775/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6775/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 5 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12784701 - PreCommit-HIVE-TRUNK-Build > Support SUM(DISTINCT) for partitioning query. > - > > Key: HIVE-12944 > URL: https://issues.apache.org/jira/browse/HIVE-12944 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12944.2.patch, HIVE-12944.patch > > > We need to support avg(distinct), count(distinct), sum(distinct) for the > parent jira HIVE-9534. Separate the work for sum(distinct) in this subtask. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12944) Support SUM(DISTINCT) for partitioning query.
[ https://issues.apache.org/jira/browse/HIVE-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122105#comment-15122105 ] Aihua Xu commented on HIVE-12944: - Attach patch-3 to fix the test failures. > Support SUM(DISTINCT) for partitioning query. > - > > Key: HIVE-12944 > URL: https://issues.apache.org/jira/browse/HIVE-12944 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12944.2.patch, HIVE-12944.3.patch, HIVE-12944.patch > > > We need to support avg(distinct), count(distinct), sum(distinct) for the > parent jira HIVE-9534. Separate the work for sum(distinct) in this subtask. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-12944) Support SUM(DISTINCT) for partitioning query.
[ https://issues.apache.org/jira/browse/HIVE-12944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15124842#comment-15124842 ] Hive QA commented on HIVE-12944: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12784994/HIVE-12944.3.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 10031 tests executed *Failed tests:* {noformat} TestSparkCliDriver-timestamp_lazy.q-bucketsortoptimize_insert_4.q-date_udf.q-and-12-more - did not produce a TEST-*.xml file org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_uri_import org.apache.hive.jdbc.TestSSL.testSSLVersion org.apache.hive.service.cli.TestEmbeddedThriftBinaryCLIService.testExecuteStatementAsync {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6797/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/6797/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-6797/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12784994 - PreCommit-HIVE-TRUNK-Build > Support SUM(DISTINCT) for partitioning query. > - > > Key: HIVE-12944 > URL: https://issues.apache.org/jira/browse/HIVE-12944 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing >Affects Versions: 2.1.0 >Reporter: Aihua Xu >Assignee: Aihua Xu > Attachments: HIVE-12944.2.patch, HIVE-12944.3.patch, HIVE-12944.patch > > > We need to support avg(distinct), count(distinct), sum(distinct) for the > parent jira HIVE-9534. Separate the work for sum(distinct) in this subtask. -- This message was sent by Atlassian JIRA (v6.3.4#6332)