[jira] [Commented] (HIVE-18510) Enable running checkstyle on test sources as well
[ https://issues.apache.org/jira/browse/HIVE-18510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350509#comment-16350509 ] Zoltan Haindrich commented on HIVE-18510: - I'm not entirely sure that this will help making the codebase better...I feel that people are already kinda overwhelmed with these checkstyle things...people are rarely even write real unit testsso I feel that demanding checkstyle quality on tests will just probably take away peoples appetite to even start writing one... > Enable running checkstyle on test sources as well > - > > Key: HIVE-18510 > URL: https://issues.apache.org/jira/browse/HIVE-18510 > Project: Hive > Issue Type: Improvement >Reporter: Adam Szita >Assignee: Adam Szita >Priority: Minor > Fix For: 3.0.0 > > Attachments: HIVE-18510.0.patch > > > Currently only source files are in the scope of checkstyle testing. We should > expand the scope to include our testing code as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18510) Enable running checkstyle on test sources as well
[ https://issues.apache.org/jira/browse/HIVE-18510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16337159#comment-16337159 ] Adam Szita commented on HIVE-18510: --- Thanks for reviewing and committing Peter! > Enable running checkstyle on test sources as well > - > > Key: HIVE-18510 > URL: https://issues.apache.org/jira/browse/HIVE-18510 > Project: Hive > Issue Type: Improvement >Reporter: Adam Szita >Assignee: Adam Szita >Priority: Minor > Fix For: 3.0.0 > > Attachments: HIVE-18510.0.patch > > > Currently only source files are in the scope of checkstyle testing. We should > expand the scope to include our testing code as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18510) Enable running checkstyle on test sources as well
[ https://issues.apache.org/jira/browse/HIVE-18510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335376#comment-16335376 ] Hive QA commented on HIVE-18510: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12907126/HIVE-18510.0.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 26 failed/errored test(s), 11633 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[auto_sortmerge_join_2] (batchId=48) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[ppd_join5] (batchId=35) org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver[encryption_move_tbl] (batchId=173) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[llap_smb] (batchId=151) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[bucket_map_join_tez1] (batchId=170) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=165) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid] (batchId=169) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[llap_acid_fast] (batchId=160) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=160) org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[bucketizedhiveinputformat] (batchId=178) org.apache.hadoop.hive.cli.TestNegativeCliDriver.testCliDriver[authorization_part] (batchId=94) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ppd_join5] (batchId=121) org.apache.hadoop.hive.cli.TestTezPerfCliDriver.testCliDriver[query64] (batchId=246) org.apache.hadoop.hive.ql.io.TestDruidRecordWriter.testWrite (batchId=254) org.apache.hive.jdbc.TestSSL.testConnectionMismatch (batchId=232) org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN (batchId=232) org.apache.hive.jdbc.TestSSL.testMetastoreConnectionWrongCertCN (batchId=232) org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testCancelRenewTokenFlow (batchId=247) org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testConnection (batchId=247) org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testIsValid (batchId=247) org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testIsValidNeg (batchId=247) org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testNegativeProxyAuth (batchId=247) org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testNegativeTokenAuth (batchId=247) org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testProxyAuth (batchId=247) org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testRenewDelegationToken (batchId=247) org.apache.hive.minikdc.TestJdbcWithDBTokenStoreNoDoAs.testTokenAuth (batchId=247) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8766/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8766/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8766/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 26 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12907126 - PreCommit-HIVE-Build > Enable running checkstyle on test sources as well > - > > Key: HIVE-18510 > URL: https://issues.apache.org/jira/browse/HIVE-18510 > Project: Hive > Issue Type: Improvement >Reporter: Adam Szita >Assignee: Adam Szita >Priority: Minor > Attachments: HIVE-18510.0.patch > > > Currently only source files are in the scope of checkstyle testing. We should > expand the scope to include our testing code as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18510) Enable running checkstyle on test sources as well
[ https://issues.apache.org/jira/browse/HIVE-18510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16335365#comment-16335365 ] Hive QA commented on HIVE-18510: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 1s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 34s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 50s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 24s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 29s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 19s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 5m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 5m 31s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 5s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 46s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 12s{color} | {color:red} The patch generated 9 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 39m 5s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc xml compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh | | git revision | master / 3bbf35f | | Default Java | 1.8.0_111 | | asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-8766/yetus/patch-asflicense-problems.txt | | modules | C: storage-api standalone-metastore . testutils/ptest2 U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-8766/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Enable running checkstyle on test sources as well > - > > Key: HIVE-18510 > URL: https://issues.apache.org/jira/browse/HIVE-18510 > Project: Hive > Issue Type: Improvement >Reporter: Adam Szita >Assignee: Adam Szita >Priority: Minor > Attachments: HIVE-18510.0.patch > > > Currently only source files are in the scope of checkstyle testing. We should > expand the scope to include our testing code as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18510) Enable running checkstyle on test sources as well
[ https://issues.apache.org/jira/browse/HIVE-18510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16334376#comment-16334376 ] Peter Vary commented on HIVE-18510: --- +1 > Enable running checkstyle on test sources as well > - > > Key: HIVE-18510 > URL: https://issues.apache.org/jira/browse/HIVE-18510 > Project: Hive > Issue Type: Improvement >Reporter: Adam Szita >Assignee: Adam Szita >Priority: Minor > Attachments: HIVE-18510.0.patch > > > Currently only source files are in the scope of checkstyle testing. We should > expand the scope to include our testing code as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)