[jira] [Commented] (HIVE-18766) Race condition during shutdown of RemoteDriver, error messages aren't always sent
[ https://issues.apache.org/jira/browse/HIVE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503753#comment-16503753 ] Hive QA commented on HIVE-18766: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12926636/HIVE-18766.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 14467 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/11564/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/11564/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-11564/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12926636 - PreCommit-HIVE-Build > Race condition during shutdown of RemoteDriver, error messages aren't always > sent > - > > Key: HIVE-18766 > URL: https://issues.apache.org/jira/browse/HIVE-18766 > Project: Hive > Issue Type: Sub-task > Components: Spark >Reporter: Sahil Takiar >Assignee: Aihua Xu >Priority: Major > Attachments: HIVE-18766.1.patch, HIVE-18766.2.patch > > > When we send an error during shutdown of the {{RemoteDriver}}, we don't wait > for the error message to be sent. We just send it and then close the RPC > channel. For a graceful shutdown, that doesn't seem ideal. We should at least > wait a bit for the RPC message to be sent before shutting things down. I ran > some tests locally and its pretty easy to hit a situation where the error > message doesn't even get sent to the {{SparkClientImpl}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18766) Race condition during shutdown of RemoteDriver, error messages aren't always sent
[ https://issues.apache.org/jira/browse/HIVE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503696#comment-16503696 ] Hive QA commented on HIVE-18766: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 26s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 22s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 29s{color} | {color:blue} common in master has 62 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 22s{color} | {color:blue} spark-client in master has 10 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 7s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 29s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 27s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 9s{color} | {color:red} spark-client: The patch generated 3 new + 32 unchanged - 0 fixed = 35 total (was 32) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 20s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 11s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 12m 5s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-11564/dev-support/hive-personality.sh | | git revision | master / 9615f24 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-11564/yetus/diff-checkstyle-spark-client.txt | | modules | C: common spark-client U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-11564/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > Race condition during shutdown of RemoteDriver, error messages aren't always > sent > - > > Key: HIVE-18766 > URL: https://issues.apache.org/jira/browse/HIVE-18766 > Project: Hive > Issue Type: Sub-task > Components: Spark >Reporter: Sahil Takiar >Assignee: Aihua Xu >Priority: Major > Attachments: HIVE-18766.1.patch, HIVE-18766.2.patch > > > When we send an error during shutdown of the {{RemoteDriver}}, we don't wait > for the error message to be sent. We just send it and then close the RPC > channel. For a graceful shutdown, that doesn't seem ideal. We should at least > wait a bit for the RPC message to be sent before shutting things down. I ran > some tests locally and its pretty easy to hit a situation where the error > message doesn't even get sent to the {{SparkClientImpl}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18766) Race condition during shutdown of RemoteDriver, error messages aren't always sent
[ https://issues.apache.org/jira/browse/HIVE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16503492#comment-16503492 ] Sahil Takiar commented on HIVE-18766: - +1 LGTM pending Hive QA > Race condition during shutdown of RemoteDriver, error messages aren't always > sent > - > > Key: HIVE-18766 > URL: https://issues.apache.org/jira/browse/HIVE-18766 > Project: Hive > Issue Type: Sub-task > Components: Spark >Reporter: Sahil Takiar >Assignee: Aihua Xu >Priority: Major > Attachments: HIVE-18766.1.patch, HIVE-18766.2.patch > > > When we send an error during shutdown of the {{RemoteDriver}}, we don't wait > for the error message to be sent. We just send it and then close the RPC > channel. For a graceful shutdown, that doesn't seem ideal. We should at least > wait a bit for the RPC message to be sent before shutting things down. I ran > some tests locally and its pretty easy to hit a situation where the error > message doesn't even get sent to the {{SparkClientImpl}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18766) Race condition during shutdown of RemoteDriver, error messages aren't always sent
[ https://issues.apache.org/jira/browse/HIVE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502439#comment-16502439 ] Aihua Xu commented on HIVE-18766: - [~stakiar] I don't see another RpcConfiguration object gets created there. Can you check the patch-2 if it makes sense? > Race condition during shutdown of RemoteDriver, error messages aren't always > sent > - > > Key: HIVE-18766 > URL: https://issues.apache.org/jira/browse/HIVE-18766 > Project: Hive > Issue Type: Sub-task > Components: Spark >Reporter: Sahil Takiar >Assignee: Aihua Xu >Priority: Major > Attachments: HIVE-18766.1.patch, HIVE-18766.2.patch > > > When we send an error during shutdown of the {{RemoteDriver}}, we don't wait > for the error message to be sent. We just send it and then close the RPC > channel. For a graceful shutdown, that doesn't seem ideal. We should at least > wait a bit for the RPC message to be sent before shutting things down. I ran > some tests locally and its pretty easy to hit a situation where the error > message doesn't even get sent to the {{SparkClientImpl}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-18766) Race condition during shutdown of RemoteDriver, error messages aren't always sent
[ https://issues.apache.org/jira/browse/HIVE-18766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16502337#comment-16502337 ] Sahil Takiar commented on HIVE-18766: - Few minor comments, overall LGTM: * Line 138 of {{RemoteDriver}} is already creating a {{RpcConfiguration}} object, so no need to create another one for {{getFutureTimeoutMs}} * Instead of swallowing an exception from {{sendError}} can we just log it at WARN level > Race condition during shutdown of RemoteDriver, error messages aren't always > sent > - > > Key: HIVE-18766 > URL: https://issues.apache.org/jira/browse/HIVE-18766 > Project: Hive > Issue Type: Sub-task > Components: Spark >Reporter: Sahil Takiar >Assignee: Aihua Xu >Priority: Major > Attachments: HIVE-18766.1.patch > > > When we send an error during shutdown of the {{RemoteDriver}}, we don't wait > for the error message to be sent. We just send it and then close the RPC > channel. For a graceful shutdown, that doesn't seem ideal. We should at least > wait a bit for the RPC message to be sent before shutting things down. I ran > some tests locally and its pretty easy to hit a situation where the error > message doesn't even get sent to the {{SparkClientImpl}} -- This message was sent by Atlassian JIRA (v7.6.3#76005)