[jira] [Commented] (HIVE-20746) HiveProtoHookLogger does not close file at end of day.
[ https://issues.apache.org/jira/browse/HIVE-20746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16653164#comment-16653164 ] anishek commented on HIVE-20746: +1 > HiveProtoHookLogger does not close file at end of day. > -- > > Key: HIVE-20746 > URL: https://issues.apache.org/jira/browse/HIVE-20746 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Major > Attachments: HIVE-20746.01.patch, HIVE-20746.02.patch > > > The file rotation happens with an event currently. If there are no queries > fired for a long time, then the file rotation does not happen and we do not > close the file. This causes the clients to poll for the file for an > indeterminate amount of time. If there are multiple hiveservers there is no > way to tell which file will get more data. Fix this to close at end of day. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20746) HiveProtoHookLogger does not close file at end of day.
[ https://issues.apache.org/jira/browse/HIVE-20746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652066#comment-16652066 ] Hive QA commented on HIVE-20746: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12944058/HIVE-20746.02.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15086 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniSparkOnYarnCliDriver.testCliDriver[schemeAuthority] (batchId=190) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14501/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14501/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14501/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12944058 - PreCommit-HIVE-Build > HiveProtoHookLogger does not close file at end of day. > -- > > Key: HIVE-20746 > URL: https://issues.apache.org/jira/browse/HIVE-20746 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Major > Attachments: HIVE-20746.01.patch, HIVE-20746.02.patch > > > The file rotation happens with an event currently. If there are no queries > fired for a long time, then the file rotation does not happen and we do not > close the file. This causes the clients to poll for the file for an > indeterminate amount of time. If there are multiple hiveservers there is no > way to tell which file will get more data. Fix this to close at end of day. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20746) HiveProtoHookLogger does not close file at end of day.
[ https://issues.apache.org/jira/browse/HIVE-20746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16652024#comment-16652024 ] Hive QA commented on HIVE-20746: | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 43s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 45s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 23s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 34s{color} | {color:blue} common in master has 65 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 57s{color} | {color:blue} ql in master has 2318 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 54s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 10s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 28s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14501/dev-support/hive-personality.sh | | git revision | master / 0f2f999 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | modules | C: common ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14501/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > HiveProtoHookLogger does not close file at end of day. > -- > > Key: HIVE-20746 > URL: https://issues.apache.org/jira/browse/HIVE-20746 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Major > Attachments: HIVE-20746.01.patch, HIVE-20746.02.patch > > > The file rotation happens with an event currently. If there are no queries > fired for a long time, then the file rotation does not happen and we do not > close the file. This causes the clients to poll for the file for an > indeterminate amount of time. If there are multiple hiveservers there is no > way to tell which file will get more data. Fix this to close at end of day. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20746) HiveProtoHookLogger does not close file at end of day.
[ https://issues.apache.org/jira/browse/HIVE-20746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651179#comment-16651179 ] Harish Jaiprakash commented on HIVE-20746: -- Updated patch with FindBugs fix. Test case failure not related. > HiveProtoHookLogger does not close file at end of day. > -- > > Key: HIVE-20746 > URL: https://issues.apache.org/jira/browse/HIVE-20746 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Major > Attachments: HIVE-20746.01.patch, HIVE-20746.02.patch > > > The file rotation happens with an event currently. If there are no queries > fired for a long time, then the file rotation does not happen and we do not > close the file. This causes the clients to poll for the file for an > indeterminate amount of time. If there are multiple hiveservers there is no > way to tell which file will get more data. Fix this to close at end of day. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20746) HiveProtoHookLogger does not close file at end of day.
[ https://issues.apache.org/jira/browse/HIVE-20746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650217#comment-16650217 ] Hive QA commented on HIVE-20746: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12943881/HIVE-20746.01.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 15082 tests executed *Failed tests:* {noformat} org.apache.hive.jdbc.TestJdbcWithMiniLlapArrow.testComplexQuery (batchId=253) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14473/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14473/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14473/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12943881 - PreCommit-HIVE-Build > HiveProtoHookLogger does not close file at end of day. > -- > > Key: HIVE-20746 > URL: https://issues.apache.org/jira/browse/HIVE-20746 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Major > Attachments: HIVE-20746.01.patch > > > The file rotation happens with an event currently. If there are no queries > fired for a long time, then the file rotation does not happen and we do not > close the file. This causes the clients to poll for the file for an > indeterminate amount of time. If there are multiple hiveservers there is no > way to tell which file will get more data. Fix this to close at end of day. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20746) HiveProtoHookLogger does not close file at end of day.
[ https://issues.apache.org/jira/browse/HIVE-20746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650162#comment-16650162 ] Hive QA commented on HIVE-20746: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 35s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 31s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 21s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 53s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 31s{color} | {color:blue} common in master has 65 extant Findbugs warnings. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 55s{color} | {color:blue} ql in master has 2318 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 11s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 56s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 18s{color} | {color:red} ql generated 1 new + 2318 unchanged - 0 fixed = 2319 total (was 2318) {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 27m 7s{color} | {color:black} {color} | \\ \\ || Reason || Tests || | FindBugs | module:ql | | | Nullcheck of HiveProtoLoggingHook$EventLogger.writer at line 307 of value previously dereferenced in org.apache.hadoop.hive.ql.hooks.HiveProtoLoggingHook$EventLogger.writeEvent(HiveHookEvents$HiveHookEventProto) At HiveProtoLoggingHook.java:307 of value previously dereferenced in org.apache.hadoop.hive.ql.hooks.HiveProtoLoggingHook$EventLogger.writeEvent(HiveHookEvents$HiveHookEventProto) At HiveProtoLoggingHook.java:[line 305] | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14473/dev-support/hive-personality.sh | | git revision | master / 15c53c4 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-14473/yetus/new-findbugs-ql.html | | modules | C: common ql U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14473/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > HiveProtoHookLogger does not close file at end of day. > -- > > Key: HIVE-20746 > URL: https://issues.apache.org/jira/browse/HIVE-20746 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Major > Attachments: HIVE-20746.01.patch > > > The file rotation happens with an event currently. If there are no queries > fired for a long time, then the file rotation does not happen and we do
[jira] [Commented] (HIVE-20746) HiveProtoHookLogger does not close file at end of day.
[ https://issues.apache.org/jira/browse/HIVE-20746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649766#comment-16649766 ] Harish Jaiprakash commented on HIVE-20746: -- Review board link: https://reviews.apache.org/r/69021/ > HiveProtoHookLogger does not close file at end of day. > -- > > Key: HIVE-20746 > URL: https://issues.apache.org/jira/browse/HIVE-20746 > Project: Hive > Issue Type: Bug > Components: HiveServer2 >Reporter: Harish Jaiprakash >Assignee: Harish Jaiprakash >Priority: Major > Attachments: HIVE-20746.01.patch > > > The file rotation happens with an event currently. If there are no queries > fired for a long time, then the file rotation does not happen and we do not > close the file. This causes the clients to poll for the file for an > indeterminate amount of time. If there are multiple hiveservers there is no > way to tell which file will get more data. Fix this to close at end of day. -- This message was sent by Atlassian JIRA (v7.6.3#76005)