[jira] [Commented] (HIVE-20787) MapJoinBytesTableContainer dummyRow case doesn't handle reuse
[ https://issues.apache.org/jira/browse/HIVE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684709#comment-16684709 ] Hive QA commented on HIVE-20787: Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12947901/HIVE-20787.02.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:green}SUCCESS:{color} +1 due to 15539 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/14899/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/14899/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-14899/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase {noformat} This message is automatically generated. ATTACHMENT ID: 12947901 - PreCommit-HIVE-Build > MapJoinBytesTableContainer dummyRow case doesn't handle reuse > - > > Key: HIVE-20787 > URL: https://issues.apache.org/jira/browse/HIVE-20787 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Attachments: HIVE-20787.01.patch, HIVE-20787.02.patch, > HIVE-20787.patch > > > Discovered while investigating some (probably) unrelated issue. > MapJoinBytesTableContainer was not intended to be reused, but it looks like > some code might reuse it. If that happens, the dummyRow case will not work > correctly (dummyRow is cleared on first(), so another call to first() will > behave differently). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20787) MapJoinBytesTableContainer dummyRow case doesn't handle reuse
[ https://issues.apache.org/jira/browse/HIVE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16684684#comment-16684684 ] Hive QA commented on HIVE-20787: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 36s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 3m 42s{color} | {color:blue} ql in master has 2316 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 54s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 1s{color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 37s{color} | {color:red} ql: The patch generated 2 new + 13 unchanged - 0 fixed = 15 total (was 13) {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 55s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 22m 25s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense javac javadoc findbugs checkstyle compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-14899/dev-support/hive-personality.sh | | git revision | master / af40170 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-14899/yetus/diff-checkstyle-ql.txt | | modules | C: ql U: ql | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-14899/yetus.txt | | Powered by | Apache Yetushttp://yetus.apache.org | This message was automatically generated. > MapJoinBytesTableContainer dummyRow case doesn't handle reuse > - > > Key: HIVE-20787 > URL: https://issues.apache.org/jira/browse/HIVE-20787 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Attachments: HIVE-20787.01.patch, HIVE-20787.02.patch, > HIVE-20787.patch > > > Discovered while investigating some (probably) unrelated issue. > MapJoinBytesTableContainer was not intended to be reused, but it looks like > some code might reuse it. If that happens, the dummyRow case will not work > correctly (dummyRow is cleared on first(), so another call to first() will > behave differently). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20787) MapJoinBytesTableContainer dummyRow case doesn't handle reuse
[ https://issues.apache.org/jira/browse/HIVE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669328#comment-16669328 ] Jason Dere commented on HIVE-20787: --- +1 pending test results > MapJoinBytesTableContainer dummyRow case doesn't handle reuse > - > > Key: HIVE-20787 > URL: https://issues.apache.org/jira/browse/HIVE-20787 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Attachments: HIVE-20787.01.patch, HIVE-20787.patch > > > Discovered while investigating some (probably) unrelated issue. > MapJoinBytesTableContainer was not intended to be reused, but it looks like > some code might reuse it. If that happens, the dummyRow case will not work > correctly (dummyRow is cleared on first(), so another call to first() will > behave differently). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (HIVE-20787) MapJoinBytesTableContainer dummyRow case doesn't handle reuse
[ https://issues.apache.org/jira/browse/HIVE-20787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16669271#comment-16669271 ] Sergey Shelukhin commented on HIVE-20787: - [~jdere] maybe you can take a look? :) > MapJoinBytesTableContainer dummyRow case doesn't handle reuse > - > > Key: HIVE-20787 > URL: https://issues.apache.org/jira/browse/HIVE-20787 > Project: Hive > Issue Type: Bug >Reporter: Sergey Shelukhin >Assignee: Sergey Shelukhin >Priority: Major > Attachments: HIVE-20787.01.patch, HIVE-20787.patch > > > Discovered while investigating some (probably) unrelated issue. > MapJoinBytesTableContainer was not intended to be reused, but it looks like > some code might reuse it. If that happens, the dummyRow case will not work > correctly (dummyRow is cleared on first(), so another call to first() will > behave differently). -- This message was sent by Atlassian JIRA (v7.6.3#76005)