[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409751#comment-15409751 ] Vihang Karajgaonkar commented on HIVE-11943: Thanks for the confirmation. Created HIVE-14440 to address this > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394907#comment-15394907 ] Ferdinand Xu commented on HIVE-11943: - Good catch. I should be correct to true in cli.cmd. Feel free to file a ticket addressing that. Thank you! > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394681#comment-15394681 ] Vihang Karajgaonkar commented on HIVE-11943: Hi [~Ferd] I am trying to understand the patch for this issue. In the patch the cli.sh is modified such that if USE_DEPRECATED_CLI is not set it is set to true but in cli.cmd file it is set to true {code} +# Set old CLI as the default client +if [ -n '$USE_DEPRECATED_CLI' ]; then + USE_DEPRECATED_CLI="true" +fi + {code} {code} + if [%USE_DEPRECATED_CLI%] == [] ( + set USE_DEPRECATED_CLI=false + ) + {code} Is that intentional? or it should be set to true in cli.cmd also? > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910097#comment-14910097 ] Ferdinand Xu commented on HIVE-11943: - Thanks :) > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910092#comment-14910092 ] Lefty Leverenz commented on HIVE-11943: --- You're right, I just slipped a cog when I saw the merge committed to master. Thanks for reminding me. Removed the TODOC2.0 label. (The link to HIVE-10810 can remain.) > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910069#comment-14910069 ] Ferdinand Xu commented on HIVE-11943: - Hi [~leftylev], where else do we need to edit this? Seems I have already added it to HIVE wiki. > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Labels: TODOC2.0 > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14910041#comment-14910041 ] Lefty Leverenz commented on HIVE-11943: --- I'm linking this to HIVE-10810 so it will be documented for 2.0.0 with the rest of the beeline-cli issues. > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Labels: TODOC2.0 > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907728#comment-14907728 ] Ferdinand Xu commented on HIVE-11943: - Thanks [~leftylev] > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907722#comment-14907722 ] Lefty Leverenz commented on HIVE-11943: --- Looks, good, [~Ferd], thanks. I tinkered with the wording a bit. > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907677#comment-14907677 ] Ferdinand Xu commented on HIVE-11943: - Thanks [~leftylev] for figuring it out. I have updated the related section in the wiki. Please help me review it. Thank you! > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14907654#comment-14907654 ] Lefty Leverenz commented on HIVE-11943: --- This should be documented in the wiki when it is merged to master (unless the default gets changed by then). * [Replacing the Implementation of Hive CLI Using Beeline | https://cwiki.apache.org/confluence/display/Hive/Replacing+the+Implementation+of+Hive+CLI+Using+Beeline] Now that the doc-tracking jira HIVE-10810 is closed, we don't have a way to flag doc issues for the beeline-cli branch. > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Fix For: beeline-cli-branch > > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906611#comment-14906611 ] Xuefu Zhang commented on HIVE-11943: +1 > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HIVE-11943) Set old CLI as the default Client when using hive script
[ https://issues.apache.org/jira/browse/HIVE-11943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906198#comment-14906198 ] Hive QA commented on HIVE-11943: {color:red}Overall{color}: -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12762067/HIVE-11943.1-beeline-cli.patch {color:red}ERROR:{color} -1 due to 3 failed/errored test(s), 9446 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_auto_sortmerge_join_2 org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver_auto_sortmerge_join_8 org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation {noformat} Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-BEELINE-Build/45/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-BEELINE-Build/45/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-BEELINE-Build-45/ Messages: {noformat} Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12762067 - PreCommit-HIVE-BEELINE-Build > Set old CLI as the default Client when using hive script > > > Key: HIVE-11943 > URL: https://issues.apache.org/jira/browse/HIVE-11943 > Project: Hive > Issue Type: Sub-task > Components: CLI >Affects Versions: beeline-cli-branch >Reporter: Ferdinand Xu >Assignee: Ferdinand Xu > Attachments: HIVE-11943.1-beeline-cli.patch > > > Since we have some concerns about deprecating the current CLI, we will set > the old CLI as default. Once we resolve the problems, we will set the new CLI > as default. -- This message was sent by Atlassian JIRA (v6.3.4#6332)