[jira] [Commented] (HIVE-14942) HS2 UI: Canceled queries show up in "Open Queries"

2016-10-13 Thread Tao Li (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572679#comment-15572679
 ] 

Tao Li commented on HIVE-14942:
---

cc: [~thejas]

I was trying to add some unit tests in 
org.apache.hive.service.cli.session.TestQueryDisplay.testQueryDisplay(). But it 
looks like that test method is involving dummy queries only. To test the query 
cancelation I will need some relatively long running queries to be canceled. 
Given that this change is small and it only affects HS2 UI, I did not spend 
time setting up a more full-fledged test that involves real queries (like a 
itest).

> HS2 UI: Canceled queries show up in "Open Queries"
> --
>
> Key: HIVE-14942
> URL: https://issues.apache.org/jira/browse/HIVE-14942
> Project: Hive
>  Issue Type: Bug
>Reporter: Tao Li
>Assignee: Tao Li
> Attachments: HIVE-14942.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-14942) HS2 UI: Canceled queries show up in "Open Queries"

2016-10-13 Thread Hive QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15572883#comment-15572883
 ] 

Hive QA commented on HIVE-14942:




Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12833162/HIVE-14942.1.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 10530 tests 
executed
*Failed tests:*
{noformat}
TestMiniLlapLocalCliDriver-orc_llap.q-delete_where_non_partitioned.q-vector_groupby_mapjoin.q-and-27-more
 - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[reloadJar]
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1533/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1533/console
Test logs: 
http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-Build-1533/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12833162 - PreCommit-HIVE-Build

> HS2 UI: Canceled queries show up in "Open Queries"
> --
>
> Key: HIVE-14942
> URL: https://issues.apache.org/jira/browse/HIVE-14942
> Project: Hive
>  Issue Type: Bug
>Reporter: Tao Li
>Assignee: Tao Li
> Attachments: HIVE-14942.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-14942) HS2 UI: Canceled queries show up in "Open Queries"

2016-10-13 Thread Thejas M Nair (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573018#comment-15573018
 ] 

Thejas M Nair commented on HIVE-14942:
--

[~vgumashta] Can you please review this ?


> HS2 UI: Canceled queries show up in "Open Queries"
> --
>
> Key: HIVE-14942
> URL: https://issues.apache.org/jira/browse/HIVE-14942
> Project: Hive
>  Issue Type: Bug
>Reporter: Tao Li
>Assignee: Tao Li
> Attachments: HIVE-14942.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-14942) HS2 UI: Canceled queries show up in "Open Queries"

2016-10-13 Thread Mohit Sabharwal (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573060#comment-15573060
 ] 

Mohit Sabharwal commented on HIVE-14942:


LGTM, +1. Looks like I missed this case in HIVE-13099

> HS2 UI: Canceled queries show up in "Open Queries"
> --
>
> Key: HIVE-14942
> URL: https://issues.apache.org/jira/browse/HIVE-14942
> Project: Hive
>  Issue Type: Bug
>Reporter: Tao Li
>Assignee: Tao Li
> Attachments: HIVE-14942.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (HIVE-14942) HS2 UI: Canceled queries show up in "Open Queries"

2016-10-13 Thread Tao Li (JIRA) 

[ 
https://issues.apache.org/jira/browse/HIVE-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15573164#comment-15573164
 ] 

Tao Li commented on HIVE-14942:
---

[~mohitsabharwal] Thanks for the review. Can you please commit it?

> HS2 UI: Canceled queries show up in "Open Queries"
> --
>
> Key: HIVE-14942
> URL: https://issues.apache.org/jira/browse/HIVE-14942
> Project: Hive
>  Issue Type: Bug
>Reporter: Tao Li
>Assignee: Tao Li
> Attachments: HIVE-14942.1.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)