[jira] [Commented] (HIVE-18377) avoid explicitly setting HIVE_SUPPORT_CONCURRENCY in JUnit tests
[
https://issues.apache.org/jira/browse/HIVE-18377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16313819#comment-16313819
]
Eugene Koifman commented on HIVE-18377:
---
This won't work because doing this also enabled the default ZK based lock
manager which wedges a lot of these tests.
> avoid explicitly setting HIVE_SUPPORT_CONCURRENCY in JUnit tests
>
>
> Key: HIVE-18377
> URL: https://issues.apache.org/jira/browse/HIVE-18377
> Project: Hive
> Issue Type: Sub-task
> Components: Test, Transactions
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
> Attachments: HIVE-18377.02.patch
>
>
> many UTs (e.g. TestHCatMultiOutputFormat,
> BeelineWithHS2ConnectionFileTestBase, TestOperationLoggingAPIWithMr,
> HCatBaseTest and many others)
> explicitly set
> {{hiveConf.set(HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY.varname, "false");}}
> It would be better if they picked up the settings from
> data/conf/hive-site.xml.
> It adds consistency and makes it possible to run all tests with known config
> (at least approach this).
> The outline of the process is:
> 1. build copies {{\*-site.xml files from data/conf/\*\*/\*-site.xml}} to
> target/testconf/
> 2. HiveConf picks up target/testconf/hive-site.xml
> 3. Various forms of *CliDriver may explicitly specify (e.g.
> MiniLlapLocalCliConfig) which hive-site.xml to use
>
> The first step is to see how many explicit settings of
> HIVE_SUPPORT_CONCURRENCY can be removed w/o breaking the tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (HIVE-18377) avoid explicitly setting HIVE_SUPPORT_CONCURRENCY in JUnit tests
[
https://issues.apache.org/jira/browse/HIVE-18377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312973#comment-16312973
]
Hive QA commented on HIVE-18377:
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12904688/HIVE-18377.02.patch
{color:green}SUCCESS:{color} +1 due to 79 test(s) being added or modified.
{color:red}ERROR:{color} -1 due to 179 failed/errored test(s), 10505 tests
executed
*Failed tests:*
{noformat}
TestAddResource - did not produce a TEST-*.xml file (likely timed out)
(batchId=288)
TestAuthorizationPreEventListener - did not produce a TEST-*.xml file (likely
timed out) (batchId=226)
TestAuthzApiEmbedAuthorizerInRemote - did not produce a TEST-*.xml file (likely
timed out) (batchId=221)
TestAvroGenericRecordReader - did not produce a TEST-*.xml file (likely timed
out) (batchId=268)
TestAvroHCatLoader - did not produce a TEST-*.xml file (likely timed out)
(batchId=190)
TestAvroHCatStorer - did not produce a TEST-*.xml file (likely timed out)
(batchId=190)
TestBeeLineWithArgs - did not produce a TEST-*.xml file (likely timed out)
(batchId=228)
TestBeelineConnectionUsingHiveSite - did not produce a TEST-*.xml file (likely
timed out) (batchId=228)
TestBeelinePasswordOption - did not produce a TEST-*.xml file (likely timed
out) (batchId=228)
TestBeelineWithUserHs2ConnectionFile - did not produce a TEST-*.xml file
(likely timed out) (batchId=228)
TestCLIAuthzSessionContext - did not produce a TEST-*.xml file (likely timed
out) (batchId=235)
TestClientSideAuthorizationProvider - did not produce a TEST-*.xml file (likely
timed out) (batchId=227)
TestColumnAccess - did not produce a TEST-*.xml file (likely timed out)
(batchId=273)
TestCommands - did not produce a TEST-*.xml file (likely timed out)
(batchId=187)
TestCopyUtils - did not produce a TEST-*.xml file (likely timed out)
(batchId=225)
TestCreateMacroDesc - did not produce a TEST-*.xml file (likely timed out)
(batchId=289)
TestCreateUdfEntities - did not produce a TEST-*.xml file (likely timed out)
(batchId=225)
TestCustomAuthentication - did not produce a TEST-*.xml file (likely timed out)
(batchId=228)
TestDDLWithRemoteMetastoreSecondNamenode - did not produce a TEST-*.xml file
(likely timed out) (batchId=225)
TestDFSErrorHandling - did not produce a TEST-*.xml file (likely timed out)
(batchId=232)
TestDbNotificationListener - did not produce a TEST-*.xml file (likely timed
out) (batchId=239)
TestDefaultHCatRecord - did not produce a TEST-*.xml file (likely timed out)
(batchId=198)
TestDynamicMultiDimeCollection - did not produce a TEST-*.xml file (likely
timed out) (batchId=273)
TestE2EScenarios - did not produce a TEST-*.xml file (likely timed out)
(batchId=190)
TestEmbeddedThriftBinaryCLIService - did not produce a TEST-*.xml file (likely
timed out) (batchId=229)
TestExecutionEngineWorkConcurrency - did not produce a TEST-*.xml file (likely
timed out) (batchId=289)
TestEximReplicationTasks - did not produce a TEST-*.xml file (likely timed out)
(batchId=187)
TestExportImport - did not produce a TEST-*.xml file (likely timed out)
(batchId=225)
TestFilterHooks - did not produce a TEST-*.xml file (likely timed out)
(batchId=212)
TestGenMapRedUtilsUsePartitionColumnsPositive - did not produce a TEST-*.xml
file (likely timed out) (batchId=273)
TestHCatClient - did not produce a TEST-*.xml file (likely timed out)
(batchId=187)
TestHCatClientNotification - did not produce a TEST-*.xml file (likely timed
out) (batchId=239)
TestHCatDynamicPartitioned - did not produce a TEST-*.xml file (likely timed
out) (batchId=194)
TestHCatExternalDynamicPartitioned - did not produce a TEST-*.xml file (likely
timed out) (batchId=196)
TestHCatExternalNonPartitioned - did not produce a TEST-*.xml file (likely
timed out) (batchId=197)
TestHCatExternalPartitioned - did not produce a TEST-*.xml file (likely timed
out) (batchId=193)
TestHCatHiveCompatibility - did not produce a TEST-*.xml file (likely timed
out) (batchId=239)
TestHCatHiveThriftCompatibility - did not produce a TEST-*.xml file (likely
timed out) (batchId=239)
TestHCatInputFormat - did not produce a TEST-*.xml file (likely timed out)
(batchId=197)
TestHCatInputFormatMethods - did not produce a TEST-*.xml file (likely timed
out) (batchId=197)
TestHCatLoaderComplexSchema - did not produce a TEST-*.xml file (likely timed
out) (batchId=190)
TestHCatLoaderEncryption - did not produce a TEST-*.xml file (likely timed out)
(batchId=190)
TestHCatLoaderStorer - did not produce a TEST-*.xml file (likely timed out)
(batchId=190)
TestHCatMultiOutputFormat - did not produce a TEST-*.xml file (likely timed
out) (batchId=197)
TestHCatMutableDynamicPartitioned - did not produce a TEST-*.xml file (likely
timed out) (batchId=191)
TestHCatMutableNonPartitioned - did not produce a TEST-*.xml file (likely timed
out) (batchId=197)
[jira] [Commented] (HIVE-18377) avoid explicitly setting HIVE_SUPPORT_CONCURRENCY in JUnit tests
[
https://issues.apache.org/jira/browse/HIVE-18377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16312775#comment-16312775
]
Hive QA commented on HIVE-18377:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m
0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m
29s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m
39s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
52s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
56s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
33s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m
20s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 3m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 3m
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m
50s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m
0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m
29s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m
12s{color} | {color:green} The patch does not generate ASF License warnings.
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 15s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian
3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh |
| git revision | master / 20c9a39 |
| Default Java | 1.8.0_111 |
| modules | C: ql service hcatalog/core hcatalog/hcatalog-pig-adapter
hcatalog/server-extensions hcatalog/webhcat/java-client itests/hcatalog-unit
itests/hive-minikdc itests/hive-unit U: . |
| Console output |
http://104.198.109.242/logs//PreCommit-HIVE-Build-8455/yetus.txt |
| Powered by | Apache Yetushttp://yetus.apache.org |
This message was automatically generated.
> avoid explicitly setting HIVE_SUPPORT_CONCURRENCY in JUnit tests
>
>
> Key: HIVE-18377
> URL: https://issues.apache.org/jira/browse/HIVE-18377
> Project: Hive
> Issue Type: Sub-task
> Components: Test, Transactions
>Reporter: Eugene Koifman
>Assignee: Eugene Koifman
> Attachments: HIVE-18377.02.patch
>
>
> many UTs (e.g. TestHCatMultiOutputFormat,
> BeelineWithHS2ConnectionFileTestBase, TestOperationLoggingAPIWithMr,
> HCatBaseTest and many others)
> explicitly set
> {{hiveConf.set(HiveConf.ConfVars.HIVE_SUPPORT_CONCURRENCY.varname, "false");}}
> It would be better if they picked up the settings from
> data/conf/hive-site.xml.
> It adds consistency and makes it possible to run all tests with known config
> (at least approach this).
> The outline of the process is:
> 1. build copies {{\*-site.xml files from data/conf/\*\*/\*-site.xml}} to
> target/testconf/
> 2. HiveConf picks up target/testconf/hive-site.xml
> 3. Various forms of *CliDriver may explicitly specify (e.g.
> MiniLlapLocalCliConfig) which hive-site.xml to use
>
> The first step is to see how many explicit settings of
> HIVE_SUPPORT_CONCURRENCY can be removed w/o breaking the tests.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
