[jira] [Work logged] (HIVE-26288) NPE in CompactionTxnHandler.markFailed()

2022-07-27 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-26288?focusedWorklogId=795631&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795631
 ]

ASF GitHub Bot logged work on HIVE-26288:
-

Author: ASF GitHub Bot
Created on: 27/Jul/22 12:17
Start Date: 27/Jul/22 12:17
Worklog Time Spent: 10m 
  Work Description: deniskuzZ merged PR #3451:
URL: https://github.com/apache/hive/pull/3451




Issue Time Tracking
---

Worklog Id: (was: 795631)
Time Spent: 0.5h  (was: 20m)

> NPE in CompactionTxnHandler.markFailed()
> 
>
> Key: HIVE-26288
> URL: https://issues.apache.org/jira/browse/HIVE-26288
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: László Végh
>Assignee: Zsolt Miskolczi
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Unhandled exceptions in 
> IMetaStoreClient.findNextCompact(FindNextCompactRequest) handled incorrectly 
> in worker. I these cases the CompcationInfo remains null, but the catch block 
> passes it to CompactionTxnHandler.markFailed() which causes an NPE.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (HIVE-26288) NPE in CompactionTxnHandler.markFailed()

2022-07-27 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-26288?focusedWorklogId=795546&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795546
 ]

ASF GitHub Bot logged work on HIVE-26288:
-

Author: ASF GitHub Bot
Created on: 27/Jul/22 07:55
Start Date: 27/Jul/22 07:55
Worklog Time Spent: 10m 
  Work Description: InvisibleProgrammer commented on code in PR #3451:
URL: https://github.com/apache/hive/pull/3451#discussion_r930738558


##
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##
@@ -600,6 +602,10 @@ public CompactorMR getMrCompactor() {
   }
 
   private void markFailed(CompactionInfo ci, String errorMessage) {
+if (ci == null) {
+  LOG.warn("CompactionInfo client was null. Could not mark failed: {}", 
ci);

Review Comment:
   Removed the parameter. Now it is: `LOG.warn("CompactionInfo client was null. 
Could not mark failed");`





Issue Time Tracking
---

Worklog Id: (was: 795546)
Time Spent: 20m  (was: 10m)

> NPE in CompactionTxnHandler.markFailed()
> 
>
> Key: HIVE-26288
> URL: https://issues.apache.org/jira/browse/HIVE-26288
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: László Végh
>Assignee: Zsolt Miskolczi
>Priority: Major
>  Labels: pull-request-available
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> Unhandled exceptions in 
> IMetaStoreClient.findNextCompact(FindNextCompactRequest) handled incorrectly 
> in worker. I these cases the CompcationInfo remains null, but the catch block 
> passes it to CompactionTxnHandler.markFailed() which causes an NPE.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

[jira] [Work logged] (HIVE-26288) NPE in CompactionTxnHandler.markFailed()

2022-07-26 Thread ASF GitHub Bot (Jira) 


 [ 
https://issues.apache.org/jira/browse/HIVE-26288?focusedWorklogId=795303&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-795303
 ]

ASF GitHub Bot logged work on HIVE-26288:
-

Author: ASF GitHub Bot
Created on: 26/Jul/22 15:08
Start Date: 26/Jul/22 15:08
Worklog Time Spent: 10m 
  Work Description: deniskuzZ commented on code in PR #3451:
URL: https://github.com/apache/hive/pull/3451#discussion_r930086597


##
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Worker.java:
##
@@ -600,6 +602,10 @@ public CompactorMR getMrCompactor() {
   }
 
   private void markFailed(CompactionInfo ci, String errorMessage) {
+if (ci == null) {
+  LOG.warn("CompactionInfo client was null. Could not mark failed: {}", 
ci);

Review Comment:
   why are you passing ci to the log if it's null? `Could not mark failed: {}", 
ci` - just remove this part of log





Issue Time Tracking
---

Worklog Id: (was: 795303)
Remaining Estimate: 0h
Time Spent: 10m

> NPE in CompactionTxnHandler.markFailed()
> 
>
> Key: HIVE-26288
> URL: https://issues.apache.org/jira/browse/HIVE-26288
> Project: Hive
>  Issue Type: Bug
>  Components: Hive
>Reporter: László Végh
>Assignee: Zsolt Miskolczi
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Unhandled exceptions in 
> IMetaStoreClient.findNextCompact(FindNextCompactRequest) handled incorrectly 
> in worker. I these cases the CompcationInfo remains null, but the catch block 
> passes it to CompactionTxnHandler.markFailed() which causes an NPE.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)