[jira] [Commented] (IGNITE-7047) NPE at org.jsr166.ConcurrentLinkedHashMap.replace
[ https://issues.apache.org/jira/browse/IGNITE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270716#comment-16270716 ] Alexey Popov commented on IGNITE-7047: -- Changes: 1. GridDhtTxOnePhaseCommitAckRequest msg should not be processed in stripped pool (it does not read/update cache). It is moved to system pool. 2. asserts are replaced by warning in {{removeTxReturn}} 3. NPE with {{ConcurrentLinkedHashMap.replace}} is fixed 4. Unit test for possible NPE (assert) added > NPE at org.jsr166.ConcurrentLinkedHashMap.replace > - > > Key: IGNITE-7047 > URL: https://issues.apache.org/jira/browse/IGNITE-7047 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Alexey Popov > > NPE happens sometimes at heavy load after receiving > GridDhtTxOnePhaseCommitAckRequest, no more details > ERROR 11/25/17 17:39:28 [::sys-stripe-2-#3%null%] cache.GridCacheIoManager> > Failed processing message [senderId=0393e394-09a9-4c02-b33e-fb4d99c3539f, > msg=GridDhtTxOnePhaseCommitAckRequest [vers=[GridCacheVersi > on [topVer=123129570, order=1511649564004, nodeOrder=2]], > super=GridCacheMessage [msgId=95, depInfo=null, err=null, skipPrepare=false]]] > java.lang.NullPointerException > at > org.jsr166.ConcurrentLinkedHashMap.replace(ConcurrentLinkedHashMap.java:1517) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager.removeTxReturn(IgniteTxManager.java:1043) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.processDhtTxOnePhaseCommitAckRequest(IgniteTxHandler.java:1070) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.access$700(IgniteTxHandler.java:95) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:183) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:181) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.processMessage(GridCacheIoManager.java:1042) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.onMessage0(GridCacheIoManager.java:561) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:378) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:304) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.access$100(GridCacheIoManager.java:99) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager$1.onMessage(GridCacheIoManager.java:293) > at > org.apache.ignite.internal.managers.communication.GridIoManager.invokeListener(GridIoManager.java:1556) > at > org.apache.ignite.internal.managers.communication.GridIoManager.processRegularMessage0(GridIoManager.java:1184) > at > org.apache.ignite.internal.managers.communication.GridIoManager.access$4200(GridIoManager.java:126) > at > org.apache.ignite.internal.managers.communication.GridIoManager$9.run(GridIoManager.java:1097) > at > org.apache.ignite.internal.util.StripedExecutor$Stripe.run(StripedExecutor.java:483) > at java.lang.Thread.run(Thread.java:745) > ERROR 11/25/17 17:39:28 [::sys-stripe-14-#15%null%] cache.GridCacheIoManager> > Failed processing message [senderId=52c4ced0-49f3-4075-9b2f-7d619adf6d33, > msg=GridDhtTxOnePhaseCommitAckRequest [vers=[GridCacheVersion > [topVer=123129570, order=1511649564004, nodeOrder=4]], super=GridCacheMessage > [msgId=97, depInfo=null, err=null, skipPrepare=false]]] > java.lang.NullPointerException > at > org.jsr166.ConcurrentLinkedHashMap.replace(ConcurrentLinkedHashMap.java:1517) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager.removeTxReturn(IgniteTxManager.java:1043) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.processDhtTxOnePhaseCommitAckRequest(IgniteTxHandler.java:1070) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.access$700(IgniteTxHandler.java:95) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:183) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:181) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.processMessage(GridCacheIoManager.java:1042) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.onMessage0(GridCacheIoManager.java:561) > at > org.apache.ignite.inter
[jira] [Commented] (IGNITE-7047) NPE at org.jsr166.ConcurrentLinkedHashMap.replace
[ https://issues.apache.org/jira/browse/IGNITE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270717#comment-16270717 ] Alexey Popov commented on IGNITE-7047: -- [~avinogradov], please review > NPE at org.jsr166.ConcurrentLinkedHashMap.replace > - > > Key: IGNITE-7047 > URL: https://issues.apache.org/jira/browse/IGNITE-7047 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Alexey Popov > > NPE happens sometimes at heavy load after receiving > GridDhtTxOnePhaseCommitAckRequest, no more details > ERROR 11/25/17 17:39:28 [::sys-stripe-2-#3%null%] cache.GridCacheIoManager> > Failed processing message [senderId=0393e394-09a9-4c02-b33e-fb4d99c3539f, > msg=GridDhtTxOnePhaseCommitAckRequest [vers=[GridCacheVersi > on [topVer=123129570, order=1511649564004, nodeOrder=2]], > super=GridCacheMessage [msgId=95, depInfo=null, err=null, skipPrepare=false]]] > java.lang.NullPointerException > at > org.jsr166.ConcurrentLinkedHashMap.replace(ConcurrentLinkedHashMap.java:1517) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager.removeTxReturn(IgniteTxManager.java:1043) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.processDhtTxOnePhaseCommitAckRequest(IgniteTxHandler.java:1070) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.access$700(IgniteTxHandler.java:95) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:183) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:181) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.processMessage(GridCacheIoManager.java:1042) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.onMessage0(GridCacheIoManager.java:561) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:378) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:304) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.access$100(GridCacheIoManager.java:99) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager$1.onMessage(GridCacheIoManager.java:293) > at > org.apache.ignite.internal.managers.communication.GridIoManager.invokeListener(GridIoManager.java:1556) > at > org.apache.ignite.internal.managers.communication.GridIoManager.processRegularMessage0(GridIoManager.java:1184) > at > org.apache.ignite.internal.managers.communication.GridIoManager.access$4200(GridIoManager.java:126) > at > org.apache.ignite.internal.managers.communication.GridIoManager$9.run(GridIoManager.java:1097) > at > org.apache.ignite.internal.util.StripedExecutor$Stripe.run(StripedExecutor.java:483) > at java.lang.Thread.run(Thread.java:745) > ERROR 11/25/17 17:39:28 [::sys-stripe-14-#15%null%] cache.GridCacheIoManager> > Failed processing message [senderId=52c4ced0-49f3-4075-9b2f-7d619adf6d33, > msg=GridDhtTxOnePhaseCommitAckRequest [vers=[GridCacheVersion > [topVer=123129570, order=1511649564004, nodeOrder=4]], super=GridCacheMessage > [msgId=97, depInfo=null, err=null, skipPrepare=false]]] > java.lang.NullPointerException > at > org.jsr166.ConcurrentLinkedHashMap.replace(ConcurrentLinkedHashMap.java:1517) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager.removeTxReturn(IgniteTxManager.java:1043) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.processDhtTxOnePhaseCommitAckRequest(IgniteTxHandler.java:1070) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.access$700(IgniteTxHandler.java:95) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:183) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:181) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.processMessage(GridCacheIoManager.java:1042) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.onMessage0(GridCacheIoManager.java:561) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:378) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:304) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManage
[jira] [Commented] (IGNITE-7047) NPE at org.jsr166.ConcurrentLinkedHashMap.replace
[ https://issues.apache.org/jira/browse/IGNITE-7047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16270686#comment-16270686 ] ASF GitHub Bot commented on IGNITE-7047: GitHub user apopovgg opened a pull request: https://github.com/apache/ignite/pull/3109 IGNITE-7047 NPE at org.jsr166.ConcurrentLinkedHashMap.replace You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-7047 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/3109.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3109 commit 37af9454221a057d8af4a57bda1c77ae9e4f771e Author: apopov Date: 2017-11-29T12:51:24Z IGNITE-7047 NPE at org.jsr166.ConcurrentLinkedHashMap.replace > NPE at org.jsr166.ConcurrentLinkedHashMap.replace > - > > Key: IGNITE-7047 > URL: https://issues.apache.org/jira/browse/IGNITE-7047 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 2.1 >Reporter: Alexey Popov >Assignee: Alexey Popov > > NPE happens sometimes at heavy load after receiving > GridDhtTxOnePhaseCommitAckRequest, no more details > ERROR 11/25/17 17:39:28 [::sys-stripe-2-#3%null%] cache.GridCacheIoManager> > Failed processing message [senderId=0393e394-09a9-4c02-b33e-fb4d99c3539f, > msg=GridDhtTxOnePhaseCommitAckRequest [vers=[GridCacheVersi > on [topVer=123129570, order=1511649564004, nodeOrder=2]], > super=GridCacheMessage [msgId=95, depInfo=null, err=null, skipPrepare=false]]] > java.lang.NullPointerException > at > org.jsr166.ConcurrentLinkedHashMap.replace(ConcurrentLinkedHashMap.java:1517) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager.removeTxReturn(IgniteTxManager.java:1043) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.processDhtTxOnePhaseCommitAckRequest(IgniteTxHandler.java:1070) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.access$700(IgniteTxHandler.java:95) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:183) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler$8.apply(IgniteTxHandler.java:181) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.processMessage(GridCacheIoManager.java:1042) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.onMessage0(GridCacheIoManager.java:561) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:378) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.handleMessage(GridCacheIoManager.java:304) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager.access$100(GridCacheIoManager.java:99) > at > org.apache.ignite.internal.processors.cache.GridCacheIoManager$1.onMessage(GridCacheIoManager.java:293) > at > org.apache.ignite.internal.managers.communication.GridIoManager.invokeListener(GridIoManager.java:1556) > at > org.apache.ignite.internal.managers.communication.GridIoManager.processRegularMessage0(GridIoManager.java:1184) > at > org.apache.ignite.internal.managers.communication.GridIoManager.access$4200(GridIoManager.java:126) > at > org.apache.ignite.internal.managers.communication.GridIoManager$9.run(GridIoManager.java:1097) > at > org.apache.ignite.internal.util.StripedExecutor$Stripe.run(StripedExecutor.java:483) > at java.lang.Thread.run(Thread.java:745) > ERROR 11/25/17 17:39:28 [::sys-stripe-14-#15%null%] cache.GridCacheIoManager> > Failed processing message [senderId=52c4ced0-49f3-4075-9b2f-7d619adf6d33, > msg=GridDhtTxOnePhaseCommitAckRequest [vers=[GridCacheVersion > [topVer=123129570, order=1511649564004, nodeOrder=4]], super=GridCacheMessage > [msgId=97, depInfo=null, err=null, skipPrepare=false]]] > java.lang.NullPointerException > at > org.jsr166.ConcurrentLinkedHashMap.replace(ConcurrentLinkedHashMap.java:1517) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxManager.removeTxReturn(IgniteTxManager.java:1043) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.processDhtTxOnePhaseCommitAckRequest(IgniteTxHandler.java:1070) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHandler.access$700(IgniteTxHandler.java:95) > at > org.apache.ignite.internal.processors.cache.transactions.IgniteTxHand