[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-02-06 Thread Ilya Kasnacheev (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761847#comment-16761847
 ] 

Ilya Kasnacheev commented on IGNITE-10978:
--

[~kbolyandra] thank you for keeping Ignite code clean! I have merged your pull 
request.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-02-06 Thread Konstantin Bolyandra (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761804#comment-16761804
 ] 

Konstantin Bolyandra commented on IGNITE-10978:
---

[~ilyak], files wer restored
 # GridCacheOnCopyFlagTxPartitionedSelfTest
 # GridCacheOnCopyFlagReplicatedSelfTest
 # GridCacheOnCopyFlagLocalSelfTest
 # GridCacheOnCopyFlagAtomicSelfTest
 # GridCacheOnCopyFlagAbstractSelfTest

Rebase have beed done.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-31 Thread Ilya Kasnacheev (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16757437#comment-16757437
 ] 

Ilya Kasnacheev commented on IGNITE-10978:
--

[~kbolyandra] can you please rebase this change on top of current master? They 
seem to have diverged?

Can you please also avoid deleting GridCacheOnCopyFlag*SelfTest classes and 
reference to them from suite? It seems that there are still test cases there 
that we don't have in other places.


> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-28 Thread Konstantin Bolyandra (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753939#comment-16753939
 ] 

Konstantin Bolyandra commented on IGNITE-10978:
---

[~ilyak]

Done

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-28 Thread Ilya Kasnacheev (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753918#comment-16753918
 ] 

Ilya Kasnacheev commented on IGNITE-10978:
--

[~kbolyandra] Test classes run test methods from its parent abstract class.

Yes, please remove GridCacheOnCopyFlagAbstractSelfTest also as [~agoncharuk] 
doesn't see any need for it.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-28 Thread Konstantin Bolyandra (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16753805#comment-16753805
 ] 

Konstantin Bolyandra commented on IGNITE-10978:
---

[~ilyak], you tell about parent abstract class 
GridCacheOnCopyFlagAbstractSelfTest.

I did not remove this class. I know that it will not have descendants after 
removing of 4 classes.

I can remove it too, if need.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-25 Thread Alexey Goncharuk (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16752443#comment-16752443
 ] 

Alexey Goncharuk commented on IGNITE-10978:
---

[~dpavlov], yes, unless I am missing something, the scenarios that were covered 
by these tests are not supported since Ignite 2.0, so I am ok with removing 
these tests.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-24 Thread Dmitriy Pavlov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751294#comment-16751294
 ] 

Dmitriy Pavlov commented on IGNITE-10978:
-

[~agoncharuk] could you please confirm you are comfortable with the removal of 
these ^ tests?

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-24 Thread Ilya Kasnacheev (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16751230#comment-16751230
 ] 

Ilya Kasnacheev commented on IGNITE-10978:
--

[~kbolyandra]
"Classes did not contain test cases" I can see test cases in those classes, 
what's wrong?

testCopyOnReadFlagP2PDisbaled and testCopyOnReadFlagP2PEnabled

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-22 Thread Konstantin Bolyandra (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748805#comment-16748805
 ] 

Konstantin Bolyandra commented on IGNITE-10978:
---

[~ilyak]

Classes did not contain test cases and have been removed:
 # GridCacheOnCopyFlagTxPartitionedSelfTest
 # GridCacheOnCopyFlagReplicatedSelfTest
 # GridCacheOnCopyFlagLocalSelfTest
 # GridCacheOnCopyFlagAtomicSelfTest

*GridCacheDeploymentSelfTest* - Class is removed according to issue reporter 
suggestion "these tests were testing peer class loading for cache entry 
(key/value). This case is not to be supported in the nearest future".
*GridCacheDeploymentOffHeapSelfTest* - Class file is absent already.
*GridCacheDeploymentOffHeapValuesSelfTest* - Class file is absent already.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-22 Thread Ilya Kasnacheev (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16748573#comment-16748573
 ] 

Ilya Kasnacheev commented on IGNITE-10978:
--

[~kbolyandra]
"Tests that cache value is copied for get, interceptor and invoke closure." why 
do we remove those tests? Sounds like a legitimate scenario. Do we have this 
kind of test in other place?

Same question about deployment. It also seems to test task deployment. Do we 
have those tested in other place? Please explain it on per file basis.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-21 Thread Konstantin Bolyandra (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747927#comment-16747927
 ] 

Konstantin Bolyandra commented on IGNITE-10978:
---

5 classes have been removed.

2 classes are not found.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
>  Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-21 Thread Dmitriy Pavlov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747886#comment-16747886
 ] 

Dmitriy Pavlov commented on IGNITE-10978:
-

[~ilyak], yes I agree. We should remove classes to avoid them to become lost 
tests without correct explanation why the code is not running on CI server.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-21 Thread Ilya Kasnacheev (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747883#comment-16747883
 ] 

Ilya Kasnacheev commented on IGNITE-10978:
--

[~dpavlov] then at least test classes themself have to be removed too, with 
justification.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-21 Thread Ilya Kasnacheev (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747882#comment-16747882
 ] 

Ilya Kasnacheev commented on IGNITE-10978:
--

Test classes exist. They need to be uncommented and made sure they run without 
errors.

Please assign IGNITE-9218 to yourself if you want to make it work, and do the 
abovementioned.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-21 Thread Dmitriy Pavlov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747858#comment-16747858
 ] 

Dmitriy Pavlov commented on IGNITE-10978:
-

[~SomeFire] I absolutely agree with you in general, this approach is always 
preferred. 

But in this particular case, these tests were testing peer class loading for 
cache entry (key/value). This case is not to be supported in the nearest 
future, so we can remove tests for now. If later somebody will support this 
case, VCS will have tests code in it.

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-10978) Remove unused tests marked with unclear todo

2019-01-21 Thread Ryabov Dmitrii (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-10978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16747764#comment-16747764
 ] 

Ryabov Dmitrii commented on IGNITE-10978:
-

[~kbolyandra], [~dpavlov], hello,

I think we should uncomment tests instead of removing. As I see, we have some 
of these classes in the codebase, so, I propose to uncomment existing tests and 
run [TeamCity|https://ci.ignite.apache.org/].

As for nonexisting tests - they could be renamed. Konstantin, please, find a 
commit where they were removed or renamed?

> Remove unused tests marked with unclear todo
> 
>
> Key: IGNITE-10978
> URL: https://issues.apache.org/jira/browse/IGNITE-10978
> Project: Ignite
>  Issue Type: Task
>Affects Versions: 2.7
>Reporter: Dmitriy Pavlov
>Assignee: Konstantin Bolyandra
>Priority: Major
>  Labels: newbie
> Fix For: 2.8
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> {noformat}
> IgniteCacheTestSuite3
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheDeploymentOffHeapValuesSelfTest.class,
>  ignoredTests);
> IgniteCacheInterceptorSelfTestSuite
> // TODO GG-11141.
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagTxPartitionedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagReplicatedSelfTest.class,
>  ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagLocalSelfTest.class, 
> ignoredTests);
> //
> GridTestUtils.addTestIfNeeded(suite,GridCacheOnCopyFlagAtomicSelfTest.class, 
> ignoredTests);
> {noformat}
> Test classes not used, so there is no reason to keep it



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)