[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-09-12 Thread Maxim Muzafarov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611660#comment-16611660
 ] 

Maxim Muzafarov commented on IGNITE-9311:
-

[~roman_s]

Thank you for your help!

> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
> Fix For: 2.7
>
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-09-11 Thread Roman Shtykh (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611594#comment-16611594
 ] 

Roman Shtykh commented on IGNITE-9311:
--

[~Mmuzaf] Synched now after other guys pushed a new commit. Now you can close 
the issue.

> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-09-11 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611558#comment-16611558
 ] 

ASF GitHub Bot commented on IGNITE-9311:


Github user asfgit closed the pull request at:

https://github.com/apache/ignite/pull/4618


> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-09-11 Thread Roman Shtykh (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611451#comment-16611451
 ] 

Roman Shtykh commented on IGNITE-9311:
--

[~Mmuzaf] Merged.

It's on [https://git-wip-us.apache.org/repos/asf/ignite,] but not synched with 
[https://github.com/apache/ignite.git] – probably takes time (I had it before).

{{$ git log apache/master }}
{{commit 8f52344bfde4a39c1c43a365dcd7619e497c4360 (HEAD -> master, 
apache/master)}}
{{Author: Maxim Muzafarov }}
{{Date:   Wed Sep 12 10:23:13 2018 +0900}}

{{    IGNITE-9311: add override annotation - Fixes #4618.}}

> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-09-11 Thread Maxim Muzafarov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610515#comment-16610515
 ] 

Maxim Muzafarov commented on IGNITE-9311:
-

[~roman_s] 

Thank you for the review and your time! 
Will you merge it or I should ask someone else?

> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-09-09 Thread Roman Shtykh (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608628#comment-16608628
 ] 

Roman Shtykh commented on IGNITE-9311:
--

[~Mmuzaf] Review site is offline, so I reviewed on github.

Looks good to me, and errors in tests seem to be unrelated.

> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-09-04 Thread Roman Shtykh (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602908#comment-16602908
 ] 

Roman Shtykh commented on IGNITE-9311:
--

[~Mmuzaf] Thanks! Please give me a couple of days (being pretty busy right now).

> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-09-04 Thread Maxim Muzafarov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602872#comment-16602872
 ] 

Maxim Muzafarov commented on IGNITE-9311:
-

[~roman_s]

Can you review my changes?
Upsource -- 
[IGNT-CR-744|https://reviews.ignite.apache.org/ignite/review/IGNT-CR-744]

I've run TC and seems everything is as usual -- [#4075 (02 Sep 18 
19:05)|https://ci.ignite.apache.org/viewLog.html?buildId=1780066=buildResultsDiv=IgniteTests24Java8_RunAll]
{{IgnitePdsDynamicCacheTest.testRestartAndCreate}} looks a bit suspicious, but 
I've checked it additionally -- [Ignite Tests 2.4+ (Java 8) - PDS 
1|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Pds1_IgniteTests24Java8=pull%2F4618%2Fhead=buildTypeStatusDiv]

> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-08-24 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16592026#comment-16592026
 ] 

ASF GitHub Bot commented on IGNITE-9311:


GitHub user Mmuzaf opened a pull request:

https://github.com/apache/ignite/pull/4618

IGNITE-9311: add override annotation



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Mmuzaf/ignite ignite-9311

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/ignite/pull/4618.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #4618


commit d1397505b91db09281951d292e42508a410c01d6
Author: Maxim Muzafarov 
Date:   2018-08-24T18:19:50Z

IGNITE-9311: add override annotation




> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-08-24 Thread Roman Shtykh (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591446#comment-16591446
 ] 

Roman Shtykh commented on IGNITE-9311:
--

[~Mmuzaf] Yes, sure. Please ping me when done ;)

> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (IGNITE-9311) Add missing @Override annotation

2018-08-24 Thread Maxim Muzafarov (JIRA) 


[ 
https://issues.apache.org/jira/browse/IGNITE-9311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591429#comment-16591429
 ] 

Maxim Muzafarov commented on IGNITE-9311:
-

[~roman_s] 

I plan to complete it. Can you help me with further review and merge here?

> Add missing @Override annotation
> 
>
> Key: IGNITE-9311
> URL: https://issues.apache.org/jira/browse/IGNITE-9311
> Project: Ignite
>  Issue Type: Bug
>Reporter: Maxim Muzafarov
>Assignee: Maxim Muzafarov
>Priority: Minor
>
> New `Code Inspections` profile can be found 
> {{\idea\ignite_inspections.xml}}.
> We will need to fix all methods with missed {{@Override}} annotation 
> regarding this inscpetion profile.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)