[GitHub] [kylin] codecov-io edited a comment on issue #740: KYLIN-4010 Improve real-time streaming

[GitBox]

codecov-io edited a comment on issue #740: KYLIN-4010 Improve real-time 
streaming
URL: https://github.com/apache/kylin/pull/740#issuecomment-511280553
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/740?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@38737f1`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `41.23%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/740/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/740?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #740   +/-   ##
   =
 Coverage  ?   25.75%   
 Complexity? 6046   
   =
 Files ? 1393   
 Lines ?83002   
 Branches  ?11610   
   =
 Hits  ?21380   
 Misses?59570   
 Partials  ? 2052
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/740?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...re/storage/columnar/TimeDerivedColumnEncoding.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvVGltZURlcml2ZWRDb2x1bW5FbmNvZGluZy5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...am/core/storage/columnar/ColumnarStoreDimDesc.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZURpbURlc2MuamF2YQ==)
 | `56% <ø> (ø)` | `8 <0> (?)` | |
   | 
[...lin/stream/source/kafka/TimedJsonStreamParser.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLXNvdXJjZS1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RyZWFtL3NvdXJjZS9rYWZrYS9UaW1lZEpzb25TdHJlYW1QYXJzZXIuamF2YQ==)
 | `71.76% <ø> (ø)` | `12 <0> (?)` | |
   | 
[...n/stream/core/query/StreamingDataQueryPlanner.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3F1ZXJ5L1N0cmVhbWluZ0RhdGFRdWVyeVBsYW5uZXIuamF2YQ==)
 | `58.97% <ø> (ø)` | `7 <0> (?)` | |
   | 
[.../apache/kylin/dimension/TimeDerivedColumnType.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vZGltZW5zaW9uL1RpbWVEZXJpdmVkQ29sdW1uVHlwZS5qYXZh)
 | `87.5% <ø> (ø)` | `9 <0> (?)` | |
   | 
[...tream/core/util/CompareFilterTimeRangeChecker.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3V0aWwvQ29tcGFyZUZpbHRlclRpbWVSYW5nZUNoZWNrZXIuamF2YQ==)
 | `25% <ø> (ø)` | `7 <0> (?)` | |
   | 
[...lin/stream/core/query/StreamingTupleConverter.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3F1ZXJ5L1N0cmVhbWluZ1R1cGxlQ29udmVydGVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...che/kylin/storage/gtrecord/CubeTupleConverter.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0N1YmVUdXBsZUNvbnZlcnRlci5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
 | `12.82% <0%> (ø)` | `42 <0> (?)` | |
   | 
[...rg/apache/kylin/stream/server/StreamingServer.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLXJlY2VpdmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vc2VydmVyL1N0cmVhbWluZ1NlcnZlci5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | ... and [2 
more](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree-more) | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/740?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/740?src=pr=footer). Last 
update 
[38737f1...f6986d6](https://codecov.io/gh/apache/kylin/pull/740?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from 

[GitHub] [kylin] codecov-io edited a comment on issue #751: KYLIN-4057 Don't merge the job that has been discarded manually before.

[GitBox]

codecov-io edited a comment on issue #751: KYLIN-4057 Don't merge the job that 
has been discarded manually before.
URL: https://github.com/apache/kylin/pull/751#issuecomment-512342390
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@38737f1`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/751/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/751?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #751   +/-   ##
   =
 Coverage  ?   25.76%   
 Complexity? 6047   
   =
 Files ? 1393   
 Lines ?82979   
 Branches  ?11607   
   =
 Hits  ?21377   
 Misses?59548   
 Partials  ? 2054
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/751?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ain/java/org/apache/kylin/engine/mr/CubingJob.java](https://codecov.io/gh/apache/kylin/pull/751/diff?src=pr=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQ3ViaW5nSm9iLmphdmE=)
 | `1.86% <0%> (ø)` | `2 <0> (?)` | |
   | 
[...ava/org/apache/kylin/rest/service/CubeService.java](https://codecov.io/gh/apache/kylin/pull/751/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=footer). Last 
update 
[38737f1...6e8aab9](https://codecov.io/gh/apache/kylin/pull/751?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #751: KYLIN-4057 Don't merge the job that has been discarded manually before.

[GitBox]

codecov-io edited a comment on issue #751: KYLIN-4057 Don't merge the job that 
has been discarded manually before.
URL: https://github.com/apache/kylin/pull/751#issuecomment-512342390
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@38737f1`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/751/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/751?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #751   +/-   ##
   =
 Coverage  ?   25.76%   
 Complexity? 6048   
   =
 Files ? 1393   
 Lines ?82978   
 Branches  ?11607   
   =
 Hits  ?21381   
 Misses?59545   
 Partials  ? 2052
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/751?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ava/org/apache/kylin/rest/service/CubeService.java](https://codecov.io/gh/apache/kylin/pull/751/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=footer). Last 
update 
[38737f1...457848a](https://codecov.io/gh/apache/kylin/pull/751?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (KYLIN-3989) Invalid temporary table path for kylin_metadata

[Yaqian Zhang (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896706#comment-16896706
 ] 

Yaqian Zhang commented on KYLIN-3989:
-

Hi Frederic,

Sorry for late. You answered yourself question very well. Now do you have any 
other questions?

> Invalid temporary table path for kylin_metadata
> ---
>
> Key: KYLIN-3989
> URL: https://issues.apache.org/jira/browse/KYLIN-3989
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.5.2
> Environment: MapR 6.1
> Hive 2.3
>Reporter: Frederic Souchu
>Priority: Major
>
> How to reproduce:
>  * create a mode
>  * define a cube
>  * build the cube
> The cube building will fail with the following Hive logs:
> {code:java}
> USE default;
> No rows affected (0.067 seconds)
> 0: jdbc:hive2://x.com>
> 0: jdbc:hive2://x.com> DROP TABLE IF EXISTS 
> kylin_intermediate_txn_cube_99023bdd_79e8_1186_2480_28b1d352d09e;
> No rows affected (0.023 seconds)
> 0: jdbc:hive2://x.com> CREATE EXTERNAL TABLE IF NOT EXISTS 
> kylin_intermediate_txn_cube_99023bdd_79e8_1186_2480_28b1d352d09
> e
> . . . . . . . . . . . . . . . . . . . . . . .> (
> . . . . . . . . . . . . . . . . . . . . . . .> PAYMENTS_GLOBALMERCHANTUID int
> . . . . . . . . . . . . . . . . . . . . . . .> )
> . . . . . . . . . . . . . . . . . . . . . . .> STORED AS SEQUENCEFILE
> . . . . . . . . . . . . . . . . . . . . . . .> LOCATION 
> 'maprfs:///apps/kylin_metadata/kylin-15b76d79-29ce-5782-d84e-bd33c305fc6f/kylin_intermedia
> te_txn_cube_99023bdd_79e8_1186_2480_28b1d352d09e';
> Error: org.apache.hive.service.cli.HiveSQLException: Error while processing 
> statement: FAILED: Execution Error, return code 1 from 
> org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:Got exception: 
> java.io.IOException Error: Not a directory(20), file: 
> kylin_intermediate_txn_cube_99023bdd_79e8_1186_2480_28b1d352d09e, user name: 
> mapr, ID: 5000)
> {code}
> using metastore.sh to list content gives:
> {code}
> 2019-04-26 15:25:54,231 INFO  [main] common.KylinConfig:100 : Loading 
> kylin-defaults.properties from 
> file:/opt/apache-kylin-2.5.2-bin-hbase1x/tool/kylin-tool-2.5.2.jar!/kylin-defaults.properties
> 2019-04-26 15:25:54,257 DEBUG [main] common.KylinConfig:327 : KYLIN_CONF 
> property was not set, will seek KYLIN_HOME env variable
> 2019-04-26 15:25:54,263 INFO  [main] common.KylinConfig:135 : Initialized a 
> new KylinConfig from getInstanceFromEnv : 453523494
> 2019-04-26 15:25:54,376 INFO  [main] persistence.ResourceStore:88 : Using 
> metadata url /apps/kylin_metadata@hbase for resource store
> 2019-04-26 15:25:55,684 DEBUG [main] hbase.HBaseConnection:180 : Using the 
> working dir FS for HBase: maprfs:///
> 2019-04-26 15:25:55,684 INFO  [main] hbase.HBaseConnection:257 : connection 
> is null or closed, creating a new one
> 2019-04-26 15:25:55,719 INFO  [main] client.ConnectionFactory:272 : 
> ConnectionFactory receives mapr.hbase.default.db(maprdb), set 
> clusterType(MAPR_ONLY), user(mapr), hbase_admin_connect_at_construction(false)
> 2019-04-26 15:25:55,899 DEBUG [main] hbase.HBaseConnection:306 : HTable 
> '/apps/kylin_metadata' already exists
> null
> 2019-04-26 15:25:56,400 INFO  [close-hbase-conn] hbase.HBaseConnection:136 : 
> Closing HBase connections...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [kylin] codecov-io edited a comment on issue #751: KYLIN-4057 Don't merge the job that has been discarded manually before.

[GitBox]

codecov-io edited a comment on issue #751: KYLIN-4057 Don't merge the job that 
has been discarded manually before.
URL: https://github.com/apache/kylin/pull/751#issuecomment-512342390
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@38737f1`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/751/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/751?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #751   +/-   ##
   =
 Coverage  ?   25.76%   
 Complexity? 6048   
   =
 Files ? 1393   
 Lines ?82978   
 Branches  ?11607   
   =
 Hits  ?21381   
 Misses?59545   
 Partials  ? 2052
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/751?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ava/org/apache/kylin/rest/service/CubeService.java](https://codecov.io/gh/apache/kylin/pull/751/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=footer). Last 
update 
[38737f1...457848a](https://codecov.io/gh/apache/kylin/pull/751?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io edited a comment on issue #751: KYLIN-4057 Don't merge the job that has been discarded manually before.

[GitBox]

codecov-io edited a comment on issue #751: KYLIN-4057 Don't merge the job that 
has been discarded manually before.
URL: https://github.com/apache/kylin/pull/751#issuecomment-512342390
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@38737f1`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/751/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/751?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #751   +/-   ##
   =
 Coverage  ?   25.76%   
 Complexity? 6047   
   =
 Files ? 1393   
 Lines ?82978   
 Branches  ?11607   
   =
 Hits  ?21379   
 Misses?59546   
 Partials  ? 2053
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/751?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...ava/org/apache/kylin/rest/service/CubeService.java](https://codecov.io/gh/apache/kylin/pull/751/diff?src=pr=tree#diff-c2VydmVyLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3Jlc3Qvc2VydmljZS9DdWJlU2VydmljZS5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/751?src=pr=footer). Last 
update 
[38737f1...457848a](https://codecov.io/gh/apache/kylin/pull/751?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (KYLIN-4105) use spark engine to build cube on step Convert Cuboid Data to HFile failed

[xiangakun (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896677#comment-16896677
 ] 

xiangakun commented on KYLIN-4105:
--

Could anyone help answer "KYLIN_HOME or KYLIN_CONF  set in yarn cluster" is a 
must?  And how to resolve the error "fail to locate kylin.properties" ?

> use spark engine to build cube on step Convert Cuboid Data to HFile failed
> --
>
> Key: KYLIN-4105
> URL: https://issues.apache.org/jira/browse/KYLIN-4105
> Project: Kylin
>  Issue Type: Improvement
>  Components: Job Engine
>Affects Versions: v2.4.0, v2.4.1, v2.5.0, v2.6.0, v2.6.1, v2.6.2
>Reporter: dockj
>Priority: Minor
>
> use spark engine to build cube on step Convert Cuboid Data to HFile。visit 
> yarn logs has this exception:
> 19/05/05 17:36:42 WARN scheduler.TaskSetManager: Lost task 0.0 in stage 0.0 
> (TID 0, spslave4.bigdata.ly, executor 1): 
> java.lang.ExceptionInInitializerError
>  at org.apache.kylin.metadata.datatype.DataType.(DataType.java:134)
>  at java.io.ObjectStreamClass.hasStaticInitializer(Native Method)
>  at java.io.ObjectStreamClass.computeDefaultSUID(ObjectStreamClass.java:1787)
>  at java.io.ObjectStreamClass.access$100(ObjectStreamClass.java:72)
>  at java.io.ObjectStreamClass$1.run(ObjectStreamClass.java:253)
>  at java.io.ObjectStreamClass$1.run(ObjectStreamClass.java:251)
>  at java.security.AccessController.doPrivileged(Native Method)
>  at java.io.ObjectStreamClass.getSerialVersionUID(ObjectStreamClass.java:250)
>  at java.io.ObjectStreamClass.initNonProxy(ObjectStreamClass.java:611)
>  at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1630)
>  at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1521)
>  at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1781)
>  at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1353)
>  at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2018)
>  at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1942)
>  at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1808)
>  at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1353)
>  at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1714)
>  at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1347)
>  at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2018)
>  at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1942)
>  at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1808)
>  at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1353)
>  at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2018)
>  at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1942)
>  at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1808)
>  at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1353)
>  at java.io.ObjectInputStream.readObject(ObjectInputStream.java:373)
>  at java.util.HashSet.readObject(HashSet.java:333)
>  at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>  at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>  at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  at java.lang.reflect.Method.invoke(Method.java:498)
>  at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1058)
>  at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1909)
>  at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1808)
>  at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1353)
>  at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2018)
>  at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1942)
>  at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1808)
>  at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1353)
>  at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2018)
>  at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1942)
>  at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1808)
>  at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1353)
>  at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2018)
>  at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1942)
>  at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1808)
>  at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1353)
>  at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:2018)
>  at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1942)
>  at 

[jira] [Commented] (KYLIN-4113) Remove the surplus allCubes field

[Shaofeng SHI (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896615#comment-16896615
 ] 

Shaofeng SHI commented on KYLIN-4113:
-

The PR is [https://github.com/apache/kylin/pull/780]

 

[~bob123] guosheng, can you help to reviwe this? Thanks!

> Remove the surplus allCubes field
> -
>
> Key: KYLIN-4113
> URL: https://issues.apache.org/jira/browse/KYLIN-4113
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web , Website
>Affects Versions: v2.6.1
> Environment: computery：macOS Mojave 10.14.5
>Reporter: 陈伟双
>Assignee: 陈伟双
>Priority: Major
>  Labels: easyfix
> Attachments: image-2019-07-25-15-26-05-703.png, 
> image-2019-07-25-15-42-39-130.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> After selecting the project-name, it will go to the backend to get the cube 
> under the current project, but there will be a request to get all the cubes, 
> even if the backend does not succeed in the permission control, but this is 
> superfluous. I checked and found that all the cubes were obtained only 
> because I need to judge whether there is a cube with the same name when 
> editing or creating the cube. This should not be done in the front end, but 
> the information is submitted to the back end when the cube is created. A 
> unified judgment is made by the back end. Otherwise, there will be a 
> situation where the number of cubes that can be viewed by the current 
> logged-in user's privilege is limited, so it is not complete to determine 
> whether the cube is renamed at the time of creation. This leads to the fact 
> that even if the cube with the same name is created, you can see two cubes 
> with the same name when you can view all cube users (admin). . .
>  The extra code path to get the cube request:
>  
> {code:java}
> webapp/app/js/controllers/cubeSchema.js{code}
>  
> In this position ：
> !image-2019-07-25-15-42-39-130.png!
>  
> This code should not be written directly in the CubeSchemaCtrl controller, 
> otherwise it will trigger the execution of this code when a page references 
> the controller, and there is a case of repeated request to initiate the 
> request. I don't know why. Perhaps it is because the other properties or 
> methods under this controller change to trigger the execution of this code.
>  
> I pass the check backend
>  
> {code:java}
> server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java{code}
> The file found that there is a ready-made check interface, and I don't know 
> why it is not connected. I refer it to the front end for the request and 
> delete the other redundant code.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Assigned] (KYLIN-4113) Remove the surplus allCubes field

[Shaofeng SHI (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI reassigned KYLIN-4113:
---

Assignee: 陈伟双

> Remove the surplus allCubes field
> -
>
> Key: KYLIN-4113
> URL: https://issues.apache.org/jira/browse/KYLIN-4113
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web , Website
>Affects Versions: v2.6.1
> Environment: computery：macOS Mojave 10.14.5
>Reporter: 陈伟双
>Assignee: 陈伟双
>Priority: Major
>  Labels: easyfix
> Attachments: image-2019-07-25-15-26-05-703.png, 
> image-2019-07-25-15-42-39-130.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> After selecting the project-name, it will go to the backend to get the cube 
> under the current project, but there will be a request to get all the cubes, 
> even if the backend does not succeed in the permission control, but this is 
> superfluous. I checked and found that all the cubes were obtained only 
> because I need to judge whether there is a cube with the same name when 
> editing or creating the cube. This should not be done in the front end, but 
> the information is submitted to the back end when the cube is created. A 
> unified judgment is made by the back end. Otherwise, there will be a 
> situation where the number of cubes that can be viewed by the current 
> logged-in user's privilege is limited, so it is not complete to determine 
> whether the cube is renamed at the time of creation. This leads to the fact 
> that even if the cube with the same name is created, you can see two cubes 
> with the same name when you can view all cube users (admin). . .
>  The extra code path to get the cube request:
>  
> {code:java}
> webapp/app/js/controllers/cubeSchema.js{code}
>  
> In this position ：
> !image-2019-07-25-15-42-39-130.png!
>  
> This code should not be written directly in the CubeSchemaCtrl controller, 
> otherwise it will trigger the execution of this code when a page references 
> the controller, and there is a case of repeated request to initiate the 
> request. I don't know why. Perhaps it is because the other properties or 
> methods under this controller change to trigger the execution of this code.
>  
> I pass the check backend
>  
> {code:java}
> server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java{code}
> The file found that there is a ready-made check interface, and I don't know 
> why it is not connected. I refer it to the front end for the request and 
> delete the other redundant code.
>  
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Closed] (KYLIN-4039) ZookeeperDistributedLock may not release lock when unlock operation was interrupted

[Shaofeng SHI (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-4039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI closed KYLIN-4039.
---
Resolution: Fixed

Resolved in release 3.0.0-alpha2 (2019-07-30)

> ZookeeperDistributedLock may not release lock when unlock operation was 
> interrupted
> ---
>
> Key: KYLIN-4039
> URL: https://issues.apache.org/jira/browse/KYLIN-4039
> Project: Kylin
>  Issue Type: Bug
>Reporter: PENG Zhengshuai
>Assignee: PENG Zhengshuai
>Priority: Major
> Fix For: v3.0.0-alpha2
>
>
> ZookeeperDistributedLock may hold the lock and not release it when the unlock 
> operation was interrupted.
> Because the unlock operation contains two steps: 
> 1. peekLock: get the owner of the lock
> 2. purgeLock: purge the lock if the owner of the lock is the current client.
> If the peekLock step is interrupted, the purgeLock step won't be executed. 
> Thus the lock won't be released.
> Meanwhile, the lock operation should also consider the interrupt cases.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Closed] (KYLIN-3981) Auto Merge Job failed to execute on windows

[Shaofeng SHI (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-3981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI closed KYLIN-3981.
---
Resolution: Fixed

Resolved in release 3.0.0-alpha2 (2019-07-30)

> Auto Merge Job failed to execute on windows
> ---
>
> Key: KYLIN-3981
> URL: https://issues.apache.org/jira/browse/KYLIN-3981
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.6.1
>Reporter: Na Zhai
>Assignee: Na Zhai
>Priority: Major
> Fix For: v3.0.0-alpha2
>
>
> Auto Merge Job failed to execute on windows. It will throw the following 
> errors.
> {code:none}
> java.lang.IllegalStateException: Metadata uri : 
> C:\Users\NAD096~1.ZHA\AppData\Local\Temp\kylin_job_meta1467762575939435363\meta
>  is not recognized
>  at org.apache.kylin.common.KylinConfig.decideUriType(KylinConfig.java:211)
>  at 
> org.apache.kylin.common.KylinConfig.createInstanceFromUri(KylinConfig.java:221)
>  at 
> org.apache.kylin.engine.mr.common.JobRelatedMetaUtil.dumpResources(JobRelatedMetaUtil.java:68)
>  at 
> org.apache.kylin.engine.mr.common.JobRelatedMetaUtil.dumpAndUploadKylinPropsAndMetadata(JobRelatedMetaUtil.java:87)
>  at 
> org.apache.kylin.engine.mr.common.AbstractHadoopJob.attachSegmentsMetadataWithDict(AbstractHadoopJob.java:572)
>  at 
> org.apache.kylin.engine.mr.steps.MergeDictionaryJob.run(MergeDictionaryJob.java:104)
>  at 
> org.apache.kylin.engine.mr.common.MapReduceExecutable.doWork(MapReduceExecutable.java:131)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:179)
>  at 
> org.apache.kylin.job.execution.DefaultChainedExecutable.doWork(DefaultChainedExecutable.java:71)
>  at 
> org.apache.kylin.job.execution.AbstractExecutable.execute(AbstractExecutable.java:179)
>  at 
> org.apache.kylin.job.impl.threadpool.DefaultScheduler$JobRunner.run(DefaultScheduler.java:114)
>  at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>  at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>  at java.lang.Thread.run(Thread.java:748)
>  Suppressed: java.io.FileNotFoundException: File does not exist: 
> C:\Users\NAD096~1.ZHA\AppData\Local\Temp\kylin_job_meta1467762575939435363\meta
>  at org.apache.commons.io.FileUtils.forceDelete(FileUtils.java:2275)
>  at 
> org.apache.kylin.common.persistence.AutoDeleteDirectory.close(AutoDeleteDirectory.java:56)
>  at 
> org.apache.kylin.engine.mr.common.JobRelatedMetaUtil.dumpAndUploadKylinPropsAndMetadata(JobRelatedMetaUtil.java:103)
>  ... 10 more
> Caused by: java.lang.IllegalStateException: Metadata uri : 
> C:\Users\NAD096~1.ZHA\AppData\Local\Temp\kylin_job_meta1467762575939435363\meta
>  is not a valid REST URI address
>  at org.apache.kylin.common.KylinConfig.decideUriType(KylinConfig.java:208)
>  ... 13 more 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (KYLIN-3843) List kylin instances with their server mode on web

[Shaofeng SHI (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Shaofeng SHI resolved KYLIN-3843.
-
Resolution: Fixed

> List kylin instances with their server mode on web
> --
>
> Key: KYLIN-3843
> URL: https://issues.apache.org/jira/browse/KYLIN-3843
> Project: Kylin
>  Issue Type: New Feature
>  Components: REST Service, Web 
>Reporter: nichunen
>Assignee: Jiatao Tao
>Priority: Major
> Fix For: v3.0.0-alpha2
>
>
> As Curator-based scheduler is available now, so Kylin can list all nodes with 
> the same metadata url.
> This task should include some rest apis to fetch nodes information on ZK, and 
> front page on System page to display the nodes information.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [kylin] codecov-io edited a comment on issue #740: KYLIN-4010 Improve real-time streaming

[GitBox]

codecov-io edited a comment on issue #740: KYLIN-4010 Improve real-time 
streaming
URL: https://github.com/apache/kylin/pull/740#issuecomment-511280553
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/740?src=pr=h1) Report
   > :exclamation: No coverage uploaded for pull request base 
(`master@38737f1`). [Click here to learn what that 
means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
   > The diff coverage is `41.23%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/740/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/740?src=pr=tree)
   
   ```diff
   @@Coverage Diff@@
   ## master #740   +/-   ##
   =
 Coverage  ?   25.75%   
 Complexity? 6045   
   =
 Files ? 1393   
 Lines ?83002   
 Branches  ?11610   
   =
 Hits  ?21381   
 Misses?59569   
 Partials  ? 2052
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/740?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...re/storage/columnar/TimeDerivedColumnEncoding.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvVGltZURlcml2ZWRDb2x1bW5FbmNvZGluZy5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (?)` | |
   | 
[...am/core/storage/columnar/ColumnarStoreDimDesc.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvQ29sdW1uYXJTdG9yZURpbURlc2MuamF2YQ==)
 | `56% <ø> (ø)` | `8 <0> (?)` | |
   | 
[...lin/stream/source/kafka/TimedJsonStreamParser.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLXNvdXJjZS1rYWZrYS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vc3RyZWFtL3NvdXJjZS9rYWZrYS9UaW1lZEpzb25TdHJlYW1QYXJzZXIuamF2YQ==)
 | `71.76% <ø> (ø)` | `12 <0> (?)` | |
   | 
[...n/stream/core/query/StreamingDataQueryPlanner.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3F1ZXJ5L1N0cmVhbWluZ0RhdGFRdWVyeVBsYW5uZXIuamF2YQ==)
 | `58.97% <ø> (ø)` | `7 <0> (?)` | |
   | 
[.../apache/kylin/dimension/TimeDerivedColumnType.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vZGltZW5zaW9uL1RpbWVEZXJpdmVkQ29sdW1uVHlwZS5qYXZh)
 | `87.5% <ø> (ø)` | `9 <0> (?)` | |
   | 
[...tream/core/util/CompareFilterTimeRangeChecker.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3V0aWwvQ29tcGFyZUZpbHRlclRpbWVSYW5nZUNoZWNrZXIuamF2YQ==)
 | `25% <ø> (ø)` | `7 <0> (?)` | |
   | 
[...lin/stream/core/query/StreamingTupleConverter.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3F1ZXJ5L1N0cmVhbWluZ1R1cGxlQ29udmVydGVyLmphdmE=)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[...che/kylin/storage/gtrecord/CubeTupleConverter.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-Y29yZS1zdG9yYWdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdG9yYWdlL2d0cmVjb3JkL0N1YmVUdXBsZUNvbnZlcnRlci5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | 
[.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==)
 | `12.82% <0%> (ø)` | `42 <0> (?)` | |
   | 
[...rg/apache/kylin/stream/server/StreamingServer.java](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree#diff-c3RyZWFtLXJlY2VpdmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vc2VydmVyL1N0cmVhbWluZ1NlcnZlci5qYXZh)
 | `0% <0%> (ø)` | `0 <0> (?)` | |
   | ... and [2 
more](https://codecov.io/gh/apache/kylin/pull/740/diff?src=pr=tree-more) | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/740?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/740?src=pr=footer). Last 
update 
[38737f1...6fbcc7c](https://codecov.io/gh/apache/kylin/pull/740?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from 

[jira] [Commented] (KYLIN-4010) TimeZone is hard-coded in function makeSegmentName for class CubeSegment

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896308#comment-16896308
 ] 

ASF GitHub Bot commented on KYLIN-4010:
---

hit-lacus commented on pull request #740: KYLIN-4010 Improve real-time streaming
URL: https://github.com/apache/kylin/pull/740
 
 
   1. Update event time by timezone, which help to solve fix timezone not align 
problem
   2. Add streaming metrics option, such as console/csv/jmx, which help to 
collect real-time streaming metrics
   3. Improve code smell
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> TimeZone is hard-coded in function makeSegmentName for class CubeSegment
> 
>
> Key: KYLIN-4010
> URL: https://issues.apache.org/jira/browse/KYLIN-4010
> Project: Kylin
>  Issue Type: Improvement
>  Components: Others
>Affects Versions: v3.0.0-alpha
>Reporter: zengrui
>Assignee: Xiaoxiang Yu
>Priority: Minor
> Attachments: image-2019-07-15-17-15-31-209.png, 
> image-2019-07-15-17-17-04-029.png, image-2019-07-15-17-17-39-568.png
>
>
> In Real-Time Streaming Cube when I send some records to kafka topic, the 
> tmestamp for the record is 2019-01-01 00:00:00.000, but kylin create a 
> segment named 2018123116_2018123117.
> Then I found that TimeZone is hard-coded to "GMT" in function makeSegmentName 
> for class CubeSegment. I think that it should be config in kylin.properties.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [kylin] hit-lacus opened a new pull request #740: KYLIN-4010 Improve real-time streaming

[GitBox]

hit-lacus opened a new pull request #740: KYLIN-4010 Improve real-time streaming
URL: https://github.com/apache/kylin/pull/740
 
 
   1. Update event time by timezone, which help to solve fix timezone not align 
problem
   2. Add streaming metrics option, such as console/csv/jmx, which help to 
collect real-time streaming metrics
   3. Improve code smell


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen commented on a change in pull request #758: KYLIN-4095: Add RESOURCE_PATH_PREFIX option in ResourceTool

[GitBox]

nichunen commented on a change in pull request #758: KYLIN-4095: Add 
RESOURCE_PATH_PREFIX option in ResourceTool
URL: https://github.com/apache/kylin/pull/758#discussion_r308751638
 
 

 ##
 File path: 
core-common/src/main/java/org/apache/kylin/common/persistence/ResourceStore.java
 ##
 @@ -474,7 +474,7 @@ public Object call() throws IOException {
  * delete a resource, does nothing on a folder
  */
 final public void deleteResource(String resPath) throws IOException {
-logger.trace("Deleting resource {} (Store {})", resPath, 
kylinConfig.getMetadataUrl());
+logger.info("Deleting resource " + resPath + " (Store " + 
kylinConfig.getMetadataUrl() + ")");
 
 Review comment:
   I doubt there will be too much log of this one


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen commented on issue #759: KYLIN-4096: Make cube metadata validator rules configuable

[GitBox]

nichunen commented on issue #759: KYLIN-4096: Make cube metadata validator 
rules configuable
URL: https://github.com/apache/kylin/pull/759#issuecomment-516440417
 
 
   @lshmouse Hi, would you please submit another pr of blog about how to use 
this feature?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen commented on issue #756: KYLIN-3901: Use multi threads to speed up the storage cleanup job

[GitBox]

nichunen commented on issue #756: KYLIN-3901: Use multi threads to speed up the 
storage cleanup job
URL: https://github.com/apache/kylin/pull/756#issuecomment-516413791
 
 
   Hi @lshmouse Seems this pr has failed test cases


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (KYLIN-4092) Support setting seperate jvm params for kylin backgroud tools

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896081#comment-16896081
 ] 

ASF subversion and git services commented on KYLIN-4092:


Commit 38737f164f53cb8863113956ae76a6dce3b58339 in kylin's branch 
refs/heads/master from Liu Shaohui
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=38737f1 ]

KYLIN-4092: Support setting seperate jvm params for kylin backgroud tools


> Support setting seperate jvm params for kylin backgroud tools
> -
>
> Key: KYLIN-4092
> URL: https://issues.apache.org/jira/browse/KYLIN-4092
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Liu Shaohui
>Priority: Major
>
> Usually, the memory set in setenv.sh for query server is larger then 8G, 
> which is not suitable for kylin background tools (meta cleaup, storage 
> cleanup, health check) 
> So It's better to have a seperate env for kylin tools



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (KYLIN-4092) Support setting seperate jvm params for kylin backgroud tools

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896080#comment-16896080
 ] 

ASF GitHub Bot commented on KYLIN-4092:
---

nichunen commented on pull request #753: KYLIN-4092: Support setting seperate 
jvm params for kylin backgroud tools
URL: https://github.com/apache/kylin/pull/753
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support setting seperate jvm params for kylin backgroud tools
> -
>
> Key: KYLIN-4092
> URL: https://issues.apache.org/jira/browse/KYLIN-4092
> Project: Kylin
>  Issue Type: Improvement
>Reporter: Liu Shaohui
>Priority: Major
>
> Usually, the memory set in setenv.sh for query server is larger then 8G, 
> which is not suitable for kylin background tools (meta cleaup, storage 
> cleanup, health check) 
> So It's better to have a seperate env for kylin tools



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [kylin] nichunen merged pull request #753: KYLIN-4092: Support setting seperate jvm params for kylin backgroud tools

[GitBox]

nichunen merged pull request #753: KYLIN-4092: Support setting seperate jvm 
params for kylin backgroud tools
URL: https://github.com/apache/kylin/pull/753
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen commented on issue #753: KYLIN-4092: Support setting seperate jvm params for kylin backgroud tools

[GitBox]

nichunen commented on issue #753: KYLIN-4092: Support setting seperate jvm 
params for kylin backgroud tools
URL: https://github.com/apache/kylin/pull/753#issuecomment-516398224
 
 
   LGTM


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen commented on a change in pull request #752: KYLIN-4091 support fast mode and simple mode for running CI

[GitBox]

nichunen commented on a change in pull request #752: KYLIN-4091 support fast 
mode and simple mode for running CI
URL: https://github.com/apache/kylin/pull/752#discussion_r308674485
 
 

 ##
 File path: 
kylin-it/src/test/java/org/apache/kylin/provision/BuildCubeWithEngine.java
 ##
 @@ -398,15 +431,53 @@ private Boolean mergeSegment(String cubeName, long 
startDate, long endDate) thro
 return Boolean.valueOf(ExecutableState.SUCCEED == state);
 }
 
-private Boolean buildSegment(String cubeName, long startDate, long 
endDate) throws Exception {
+private Boolean buildSegment(String cubeName, long startDate, long 
endDate, Boolean isEmpty) throws Exception {
 CubeInstance cubeInstance = cubeManager.getCube(cubeName);
 CubeSegment segment = cubeManager.appendSegment(cubeInstance, new 
TSRange(0L, endDate));
 DefaultChainedExecutable job = 
EngineFactory.createBatchCubingJob(segment, "TEST");
 jobService.addJob(job);
+if (fastBuildMode) {
+jobSegmentMap.put(job.getId(), segment);
+jobCheckActionMap.put(job.getId(), isEmpty ? 
"checkEmptySegRangeInfo": "checkNormalSegRangeInfo");
+return true;
+}
 ExecutableState state = waitForJob(job.getId());
 return Boolean.valueOf(ExecutableState.SUCCEED == state);
 }
+private Boolean buildSegment(String cubeName, long startDate, long 
endDate) throws Exception {
+return buildSegment(cubeName, startDate, endDate, false);
+}
 
+private Boolean checkJobState() throws Exception {
+List jobIds = jobService.getAllJobIds();
+while (true) {
+if (jobIds.size() == 0) {
+return true;
+}
+for (int i = jobIds.size() - 1; i >= 0; i--) {
+AbstractExecutable job = jobService.getJob(jobIds.get(i));
 
 Review comment:
   use "getOutputDigest" is better


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen commented on a change in pull request #752: KYLIN-4091 support fast mode and simple mode for running CI

[GitBox]

nichunen commented on a change in pull request #752: KYLIN-4091 support fast 
mode and simple mode for running CI
URL: https://github.com/apache/kylin/pull/752#discussion_r308664131
 
 

 ##
 File path: 
kylin-it/src/test/java/org/apache/kylin/provision/BuildCubeWithEngine.java
 ##
 @@ -398,15 +431,53 @@ private Boolean mergeSegment(String cubeName, long 
startDate, long endDate) thro
 return Boolean.valueOf(ExecutableState.SUCCEED == state);
 }
 
-private Boolean buildSegment(String cubeName, long startDate, long 
endDate) throws Exception {
+private Boolean buildSegment(String cubeName, long startDate, long 
endDate, Boolean isEmpty) throws Exception {
 CubeInstance cubeInstance = cubeManager.getCube(cubeName);
 CubeSegment segment = cubeManager.appendSegment(cubeInstance, new 
TSRange(0L, endDate));
 DefaultChainedExecutable job = 
EngineFactory.createBatchCubingJob(segment, "TEST");
 jobService.addJob(job);
+if (fastBuildMode) {
+jobSegmentMap.put(job.getId(), segment);
+jobCheckActionMap.put(job.getId(), isEmpty ? 
"checkEmptySegRangeInfo": "checkNormalSegRangeInfo");
+return true;
+}
 ExecutableState state = waitForJob(job.getId());
 return Boolean.valueOf(ExecutableState.SUCCEED == state);
 }
+private Boolean buildSegment(String cubeName, long startDate, long 
endDate) throws Exception {
+return buildSegment(cubeName, startDate, endDate, false);
+}
 
+private Boolean checkJobState() throws Exception {
+List jobIds = jobService.getAllJobIds();
 
 Review comment:
   why not use "getAllJobIdsInCache" to speed up?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen commented on a change in pull request #752: KYLIN-4091 support fast mode and simple mode for running CI

[GitBox]

nichunen commented on a change in pull request #752: KYLIN-4091 support fast 
mode and simple mode for running CI
URL: https://github.com/apache/kylin/pull/752#discussion_r308657494
 
 

 ##
 File path: 
kylin-it/src/test/java/org/apache/kylin/provision/BuildCubeWithEngine.java
 ##
 @@ -398,15 +431,53 @@ private Boolean mergeSegment(String cubeName, long 
startDate, long endDate) thro
 return Boolean.valueOf(ExecutableState.SUCCEED == state);
 }
 
-private Boolean buildSegment(String cubeName, long startDate, long 
endDate) throws Exception {
+private Boolean buildSegment(String cubeName, long startDate, long 
endDate, Boolean isEmpty) throws Exception {
 CubeInstance cubeInstance = cubeManager.getCube(cubeName);
 CubeSegment segment = cubeManager.appendSegment(cubeInstance, new 
TSRange(0L, endDate));
 DefaultChainedExecutable job = 
EngineFactory.createBatchCubingJob(segment, "TEST");
 jobService.addJob(job);
+if (fastBuildMode) {
+jobSegmentMap.put(job.getId(), segment);
+jobCheckActionMap.put(job.getId(), isEmpty ? 
"checkEmptySegRangeInfo": "checkNormalSegRangeInfo");
+return true;
+}
 ExecutableState state = waitForJob(job.getId());
 return Boolean.valueOf(ExecutableState.SUCCEED == state);
 }
+private Boolean buildSegment(String cubeName, long startDate, long 
endDate) throws Exception {
+return buildSegment(cubeName, startDate, endDate, false);
+}
 
+private Boolean checkJobState() throws Exception {
 
 Review comment:
   Return primitive type of "boolean" is more reasonable


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] nichunen commented on a change in pull request #752: KYLIN-4091 support fast mode and simple mode for running CI

[GitBox]

nichunen commented on a change in pull request #752: KYLIN-4091 support fast 
mode and simple mode for running CI
URL: https://github.com/apache/kylin/pull/752#discussion_r308668535
 
 

 ##
 File path: 
kylin-it/src/test/java/org/apache/kylin/provision/BuildCubeWithEngine.java
 ##
 @@ -484,40 +555,56 @@ private void checkHFilesInHBase(CubeSegment segment) 
throws IOException {
 }
 }
 
-private void checkEmptySegRangeInfo(CubeInstance cube) {
-CubeSegment segment = getLastModifiedSegment(cube);
-for (String colId : segment.getDimensionRangeInfoMap().keySet()) {
-DimensionRangeInfo range = 
segment.getDimensionRangeInfoMap().get(colId);
-if (!(range.getMax() == null && range.getMin() == null)) {
-throw new RuntimeException("Empty segment must have null 
info.");
+private void checkEmptySegRangeInfo(CubeSegment segment) {
+if (segment != null) {
+segment = 
cubeManager.getCube(segment.getCubeDesc().getName()).getSegmentById(segment.getUuid());
+for (String colId : segment.getDimensionRangeInfoMap().keySet()) {
+DimensionRangeInfo range = 
segment.getDimensionRangeInfoMap().get(colId);
+if (!(range.getMax() == null && range.getMin() == null)) {
+throw new RuntimeException("Empty segment must have null 
info.");
+}
 }
 }
 }
-
-private void checkNormalSegRangeInfo(CubeInstance cube) {
+private void checkEmptySegRangeInfo(CubeInstance cube) {
 CubeSegment segment = getLastModifiedSegment(cube);
-if (segment.getModel().getPartitionDesc().isPartitioned()) {
+checkEmptySegRangeInfo(segment);
+}
+
+private void checkNormalSegRangeInfo(CubeSegment segment) throws 
IOException {
+if (segment != null && 
segment.getModel().getPartitionDesc().isPartitioned()) {
+segment = 
cubeManager.getCube(segment.getCubeDesc().getName()).getSegmentById(segment.getUuid());
 TblColRef colRef = 
segment.getModel().getPartitionDesc().getPartitionDateColumnRef();
 DimensionRangeInfo dmRangeInfo = 
segment.getDimensionRangeInfoMap().get(colRef.getIdentity());
-long min_v = DateFormat.stringToMillis(dmRangeInfo.getMin());
-long max_v = DateFormat.stringToMillis(dmRangeInfo.getMax());
-long ts_range_start = segment.getTSRange().start.v;
-long ts_range_end = segment.getTSRange().end.v;
-if (!(ts_range_start <= min_v && max_v <= ts_range_end - 1)) {
-throw new RuntimeException(String.format(Locale.ROOT,
-"Build cube failed, wrong partition column min/max 
value."
-+ " Segment: %s, min value: %s, TsRange.start: 
%s, max value: %s, TsRange.end: %s",
-segment, min_v, ts_range_start, max_v, ts_range_end));
+if (dmRangeInfo != null) {
+long min_v = DateFormat.stringToMillis(dmRangeInfo.getMin());
+long max_v = DateFormat.stringToMillis(dmRangeInfo.getMax());
+long ts_range_start = segment.getTSRange().start.v;
+long ts_range_end = segment.getTSRange().end.v;
+if (!(ts_range_start <= min_v && max_v <= ts_range_end - 1)) {
+throw new RuntimeException(String.format(Locale.ROOT,
+"Build cube failed, wrong partition column min/max 
value."
++ " Segment: %s, min value: %s, 
TsRange.start: %s, max value: %s, TsRange.end: %s",
+segment, min_v, ts_range_start, max_v, 
ts_range_end));
+}
 }
 }
 }
+private void checkNormalSegRangeInfo(CubeInstance cube) throws IOException 
{
+CubeSegment segment = getLastModifiedSegment(cube);
+checkNormalSegRangeInfo(segment);
+}
 
 private CubeSegment getLastModifiedSegment(CubeInstance cube) {
-return Collections.max(cube.getSegments(), new 
Comparator() {
-@Override
-public int compare(CubeSegment o1, CubeSegment o2) {
-return Long.compare(o1.getLastBuildTime(), 
o2.getLastBuildTime());
-}
-});
+Segments segments = cube.getSegments();
+if (segments.size()>0) {
 
 Review comment:
   Seems not formatted


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (KYLIN-4060) "Garbage Collection on HDFS" step failed because of hdfs path not exists

[WangSheng (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895966#comment-16895966
 ] 

WangSheng commented on KYLIN-4060:
--

Hi, [~wangrupeng], thanks for your advice,  and I've already seen the code you 
pasted in kylin-2.6.x, it's clearly that this problem has been solved, so I 
will close this jira. Anyway, thanks for your kind.

> "Garbage Collection on HDFS" step failed because of hdfs path not exists
> 
>
> Key: KYLIN-4060
> URL: https://issues.apache.org/jira/browse/KYLIN-4060
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.4.1
>Reporter: WangSheng
>Priority: Minor
>
> We found a bug recently when we used streaming cube on last job step "Garbage 
> Collection on HDFS", the proplem is as blow:
>  
> {code:java}
> Drop HDFS path on FileSystem: "hdfs://kylin-cluster" 
> HDFS path 
> /user/kylin/kylin_home/kylin_metadata/kylin-03c04b31-5d40-441a-a0df-289f5977b733/cube_test/fact_distinct_columns
>  not exists.
> File 
> /user/kylin/kylin_home/kylin_metadata/kylin-03c04b31-5d40-441a-a0df-289f5977b733/cube_test
>  does not exist.
> {code}
> When I check the code and log, I found that the main reason is:
>  
>  # A build job first submitted, and on step "Update Cube Info", segment 
> became "READY";
>  # Then a merge job submitted automatically by kylin, include segment on 
> step1. The merge job finished quickly, and deleted input segments hdfs path;
>  # After merge job finished, the build job continue build, "Hive Cleanup" and 
> "Garbage Collection on HBase", failed at last step because the hdfs path is 
> deleted on step2.
> Our version is 2.4.x, I'm not sure this if this bug fixed on latest 2.6.x 
> version. If not, please assign this Jira to me, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Closed] (KYLIN-4060) "Garbage Collection on HDFS" step failed because of hdfs path not exists

[WangSheng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-4060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

WangSheng closed KYLIN-4060.

   Resolution: Fixed
Fix Version/s: v2.6.1

> "Garbage Collection on HDFS" step failed because of hdfs path not exists
> 
>
> Key: KYLIN-4060
> URL: https://issues.apache.org/jira/browse/KYLIN-4060
> Project: Kylin
>  Issue Type: Bug
>  Components: Job Engine
>Affects Versions: v2.4.1
>Reporter: WangSheng
>Priority: Minor
> Fix For: v2.6.1
>
>
> We found a bug recently when we used streaming cube on last job step "Garbage 
> Collection on HDFS", the proplem is as blow:
>  
> {code:java}
> Drop HDFS path on FileSystem: "hdfs://kylin-cluster" 
> HDFS path 
> /user/kylin/kylin_home/kylin_metadata/kylin-03c04b31-5d40-441a-a0df-289f5977b733/cube_test/fact_distinct_columns
>  not exists.
> File 
> /user/kylin/kylin_home/kylin_metadata/kylin-03c04b31-5d40-441a-a0df-289f5977b733/cube_test
>  does not exist.
> {code}
> When I check the code and log, I found that the main reason is:
>  
>  # A build job first submitted, and on step "Update Cube Info", segment 
> became "READY";
>  # Then a merge job submitted automatically by kylin, include segment on 
> step1. The merge job finished quickly, and deleted input segments hdfs path;
>  # After merge job finished, the build job continue build, "Hive Cleanup" and 
> "Garbage Collection on HBase", failed at last step because the hdfs path is 
> deleted on step2.
> Our version is 2.4.x, I'm not sure this if this bug fixed on latest 2.6.x 
> version. If not, please assign this Jira to me, thanks!



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Resolved] (KYLIN-3974) confused about the megering segments forcely function, can not work when there exists gaps

[wangrupeng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wangrupeng resolved KYLIN-3974.
---
Resolution: Not A Bug

> confused about the megering segments forcely function, can not work when 
> there exists gaps
> --
>
> Key: KYLIN-3974
> URL: https://issues.apache.org/jira/browse/KYLIN-3974
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.4.0
>Reporter: hejian
>Assignee: wangrupeng
>Priority: Major
> Attachments: image-2019-04-23-18-57-01-878.png, 
> image-2019-04-23-19-02-05-743.png, image-2019-04-23-19-02-53-396.png, 
> image-2019-07-30-17-16-16-037.png, image-2019-07-30-17-24-08-430.png, 
> web_request_log2.png
>
>
> forcely
> !image-2019-04-23-19-02-05-743.png!!image-2019-04-23-19-02-53-396.png!  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (KYLIN-3974) confused about the megering segments forcely function, can not work when there exists gaps

[wangrupeng (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895951#comment-16895951
 ] 

wangrupeng commented on KYLIN-3974:
---

Hi, hejian, it's not a bug actually. When you done select merge segments and 
click submit button, front end will send a put request with json data as the 
first image below, you can see that the parameter "forceMergeEmptySegment" is 
false, then kylin will throw an exception because there are gaps between you 
segments,  when front end receive this response, brower will alert as your 
first image uploaded.Then if you click "OK" button(means you want to try again 
to force merge segments which have gaps between them), the request is shown as 
the second image below, you can see the parameter " forceMergeEmptySegment" 
become true, and then kylin will forcely merge the segments as your wish. So 
it's not a bug :).

!image-2019-07-30-17-16-16-037.png!

 

!image-2019-07-30-17-24-08-430.png!

 

> confused about the megering segments forcely function, can not work when 
> there exists gaps
> --
>
> Key: KYLIN-3974
> URL: https://issues.apache.org/jira/browse/KYLIN-3974
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.4.0
>Reporter: hejian
>Assignee: wangrupeng
>Priority: Major
> Attachments: image-2019-04-23-18-57-01-878.png, 
> image-2019-04-23-19-02-05-743.png, image-2019-04-23-19-02-53-396.png, 
> image-2019-07-30-17-16-16-037.png, image-2019-07-30-17-24-08-430.png, 
> web_request_log2.png
>
>
> forcely
> !image-2019-04-23-19-02-05-743.png!!image-2019-04-23-19-02-53-396.png!  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (KYLIN-3974) confused about the megering segments forcely function, can not work when there exists gaps

[wangrupeng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wangrupeng updated KYLIN-3974:
--
Attachment: image-2019-07-30-17-24-08-430.png

> confused about the megering segments forcely function, can not work when 
> there exists gaps
> --
>
> Key: KYLIN-3974
> URL: https://issues.apache.org/jira/browse/KYLIN-3974
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.4.0
>Reporter: hejian
>Assignee: wangrupeng
>Priority: Major
> Attachments: image-2019-04-23-18-57-01-878.png, 
> image-2019-04-23-19-02-05-743.png, image-2019-04-23-19-02-53-396.png, 
> image-2019-07-30-17-16-16-037.png, image-2019-07-30-17-24-08-430.png, 
> web_request_log2.png
>
>
> forcely
> !image-2019-04-23-19-02-05-743.png!!image-2019-04-23-19-02-53-396.png!  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (KYLIN-3974) confused about the megering segments forcely function, can not work when there exists gaps

[wangrupeng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wangrupeng updated KYLIN-3974:
--
Attachment: web_request_log2.png

> confused about the megering segments forcely function, can not work when 
> there exists gaps
> --
>
> Key: KYLIN-3974
> URL: https://issues.apache.org/jira/browse/KYLIN-3974
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.4.0
>Reporter: hejian
>Assignee: wangrupeng
>Priority: Major
> Attachments: image-2019-04-23-18-57-01-878.png, 
> image-2019-04-23-19-02-05-743.png, image-2019-04-23-19-02-53-396.png, 
> image-2019-07-30-17-16-16-037.png, image-2019-07-30-17-24-08-430.png, 
> web_request_log2.png
>
>
> forcely
> !image-2019-04-23-19-02-05-743.png!!image-2019-04-23-19-02-53-396.png!  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (KYLIN-3974) confused about the megering segments forcely function, can not work when there exists gaps

[wangrupeng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wangrupeng updated KYLIN-3974:
--
Attachment: (was: web_request_log2.png)

> confused about the megering segments forcely function, can not work when 
> there exists gaps
> --
>
> Key: KYLIN-3974
> URL: https://issues.apache.org/jira/browse/KYLIN-3974
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.4.0
>Reporter: hejian
>Assignee: wangrupeng
>Priority: Major
> Attachments: image-2019-04-23-18-57-01-878.png, 
> image-2019-04-23-19-02-05-743.png, image-2019-04-23-19-02-53-396.png, 
> image-2019-07-30-17-16-16-037.png
>
>
> forcely
> !image-2019-04-23-19-02-05-743.png!!image-2019-04-23-19-02-53-396.png!  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (KYLIN-3974) confused about the megering segments forcely function, can not work when there exists gaps

[wangrupeng (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KYLIN-3974?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

wangrupeng updated KYLIN-3974:
--
Attachment: web_request_log2.png

> confused about the megering segments forcely function, can not work when 
> there exists gaps
> --
>
> Key: KYLIN-3974
> URL: https://issues.apache.org/jira/browse/KYLIN-3974
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v2.4.0
>Reporter: hejian
>Assignee: wangrupeng
>Priority: Major
> Attachments: image-2019-04-23-18-57-01-878.png, 
> image-2019-04-23-19-02-05-743.png, image-2019-04-23-19-02-53-396.png, 
> image-2019-07-30-17-16-16-037.png
>
>
> forcely
> !image-2019-04-23-19-02-05-743.png!!image-2019-04-23-19-02-53-396.png!  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (KYLIN-1856) Kylin shows old error in job step output after resume - specifically in #4 Step Name: Build Dimension Dictionary

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895946#comment-16895946
 ] 

ASF subversion and git services commented on KYLIN-1856:


Commit 09fd0f62d4cc3a8a9c592daf22786ccfffbbd5c3 in kylin's branch 
refs/heads/master from yaqian.zhang
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=09fd0f6 ]

KYLIN-1856 Clean up old error in step output immediately after resume job


> Kylin shows old error in job step output after resume - specifically in #4 
> Step Name: Build Dimension Dictionary
> 
>
> Key: KYLIN-1856
> URL: https://issues.apache.org/jira/browse/KYLIN-1856
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v1.5.2, v1.5.2.1
>Reporter: Richard Calaba
>Assignee: Yaqian Zhang
>Priority: Minor
>
> I have realized that if my job stops with error and I try to recover the 
> error and resume the job - then the latest step starts again from scratch. 
> This is fine but in my opinion the log of the Step should clear as well - now 
> it is showing the error from my previous attempt.
> Specifically observed in #4 Step Name: Build Dimension Dictionary - but is 
> probbaly generic issue.
> To correct this: clear the log of the Build Step after the job Step is 
> resumed. Already when the job step is restarted, not after it is completed.
> (if Kylin fails i.e. for out of memory - it silently dies and analyzing the 
> step log shows wrong error (from previous run) - if it would be empty -> I 
> would know that most probable cause was that Kylin died)



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (KYLIN-1856) Kylin shows old error in job step output after resume - specifically in #4 Step Name: Build Dimension Dictionary

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-1856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895945#comment-16895945
 ] 

ASF GitHub Bot commented on KYLIN-1856:
---

nichunen commented on pull request #779: KYLIN-1856 Clean up old error in step 
output immediately after resume…
URL: https://github.com/apache/kylin/pull/779
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Kylin shows old error in job step output after resume - specifically in #4 
> Step Name: Build Dimension Dictionary
> 
>
> Key: KYLIN-1856
> URL: https://issues.apache.org/jira/browse/KYLIN-1856
> Project: Kylin
>  Issue Type: Bug
>Affects Versions: v1.5.2, v1.5.2.1
>Reporter: Richard Calaba
>Assignee: Yaqian Zhang
>Priority: Minor
>
> I have realized that if my job stops with error and I try to recover the 
> error and resume the job - then the latest step starts again from scratch. 
> This is fine but in my opinion the log of the Step should clear as well - now 
> it is showing the error from my previous attempt.
> Specifically observed in #4 Step Name: Build Dimension Dictionary - but is 
> probbaly generic issue.
> To correct this: clear the log of the Build Step after the job Step is 
> resumed. Already when the job step is restarted, not after it is completed.
> (if Kylin fails i.e. for out of memory - it silently dies and analyzing the 
> step log shows wrong error (from previous run) - if it would be empty -> I 
> would know that most probable cause was that Kylin died)



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Updated] (KYLIN-4113) Remove the surplus allCubes field

[JIRA]

 [ 
https://issues.apache.org/jira/browse/KYLIN-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

陈伟双 updated KYLIN-4113:
---
Description: 
After selecting the project-name, it will go to the backend to get the cube 
under the current project, but there will be a request to get all the cubes, 
even if the backend does not succeed in the permission control, but this is 
superfluous. I checked and found that all the cubes were obtained only because 
I need to judge whether there is a cube with the same name when editing or 
creating the cube. This should not be done in the front end, but the 
information is submitted to the back end when the cube is created. A unified 
judgment is made by the back end. Otherwise, there will be a situation where 
the number of cubes that can be viewed by the current logged-in user's 
privilege is limited, so it is not complete to determine whether the cube is 
renamed at the time of creation. This leads to the fact that even if the cube 
with the same name is created, you can see two cubes with the same name when 
you can view all cube users (admin). . .

 The extra code path to get the cube request:

 
{code:java}
webapp/app/js/controllers/cubeSchema.js{code}
 

In this position ：

!image-2019-07-25-15-42-39-130.png!

 

This code should not be written directly in the CubeSchemaCtrl controller, 
otherwise it will trigger the execution of this code when a page references the 
controller, and there is a case of repeated request to initiate the request. I 
don't know why. Perhaps it is because the other properties or methods under 
this controller change to trigger the execution of this code.

 

I pass the check backend

 
{code:java}
server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java{code}
The file found that there is a ready-made check interface, and I don't know why 
it is not connected. I refer it to the front end for the request and delete the 
other redundant code.

 

 

 

  was:
After selecting the project-name, it will go to the backend to get the cube 
under the current project, but there will be a request to get all the cubes, 
even if the backend does not succeed in the permission control, but this is 
superfluous. I checked and found that all the cubes were obtained only because 
I need to judge whether there is a cube with the same name when editing or 
creating the cube. This should not be done in the front end, but the 
information is submitted to the back end when the cube is created. A unified 
judgment is made by the back end. Otherwise, there will be a situation where 
the number of cubes that can be viewed by the current logged-in user's 
privilege is limited, so it is not complete to determine whether the cube is 
renamed at the time of creation. This leads to the fact that even if the cube 
with the same name is created, you can see two cubes with the same name when 
you can view all cube users (admin). . .

 The extra code path to get the cube request:

 
{code:java}
webapp/app/js/controllers/cubeSchema.js{code}
 

In this position ：

!image-2019-07-25-15-42-39-130.png!

 

This code should not be written directly in the CubeSchemaCtrl controller, 
otherwise it will trigger the execution of this code when a page references the 
controller, and there is a case of repeated request to initiate the request. I 
don't know why. Perhaps it is because the other properties or methods under 
this controller change to trigger the execution of this code.

My suggestion is to leave the judgment of whether the cube name is duplicated 
to the backend, and add an interface to the backend, specifically when calling 
this method on the front end:
{code:java}
webapp/app/js/controllers/cubeSchema.js{code}
!image-2019-07-25-15-26-05-703.png!

The last condition in this judgment should be removed. As long as the remaining 
conditions are true, you should internally initiate an ajax to the backend to 
get the result of whether the cube is duplicated, like this:
{code:java}
$scope.check_cube_info = function () {
  if (($scope.state.mode === "edit") && $scope.cubeMode == "addNewCube") {
$http.post('/cubesNameIsExists', {cubeName: 
$scope.cubeMetaFrame.name}).success(function (data) {
  if (data.result) {
SweetAlert.swal('Oops...', "The cube named [" + 
$scope.cubeMetaFrame.name.toUpperCase() + "] already exists", 'warning');
return false;
  } 
})
  }
}{code}
It is not accurate for the front end to determine whether the cube name is 
duplicated, because the permissions may not be able to get all the cubes, and 
should be done by the backend.


> Remove the surplus allCubes field
> -
>
> Key: KYLIN-4113
> URL: https://issues.apache.org/jira/browse/KYLIN-4113
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web , Website
>Affects Versions: v2.6.1
> 

[jira] [Updated] (KYLIN-4113) Remove the surplus allCubes field

[JIRA]

 [ 
https://issues.apache.org/jira/browse/KYLIN-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

陈伟双 updated KYLIN-4113:
---
Summary: Remove the surplus allCubes field  (was:  Whether the cube name 
should be given to the backend to judge)

> Remove the surplus allCubes field
> -
>
> Key: KYLIN-4113
> URL: https://issues.apache.org/jira/browse/KYLIN-4113
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web , Website
>Affects Versions: v2.6.1
> Environment: computery：macOS Mojave 10.14.5
>Reporter: 陈伟双
>Priority: Major
>  Labels: easyfix
> Attachments: image-2019-07-25-15-26-05-703.png, 
> image-2019-07-25-15-42-39-130.png
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> After selecting the project-name, it will go to the backend to get the cube 
> under the current project, but there will be a request to get all the cubes, 
> even if the backend does not succeed in the permission control, but this is 
> superfluous. I checked and found that all the cubes were obtained only 
> because I need to judge whether there is a cube with the same name when 
> editing or creating the cube. This should not be done in the front end, but 
> the information is submitted to the back end when the cube is created. A 
> unified judgment is made by the back end. Otherwise, there will be a 
> situation where the number of cubes that can be viewed by the current 
> logged-in user's privilege is limited, so it is not complete to determine 
> whether the cube is renamed at the time of creation. This leads to the fact 
> that even if the cube with the same name is created, you can see two cubes 
> with the same name when you can view all cube users (admin). . .
>  The extra code path to get the cube request:
>  
> {code:java}
> webapp/app/js/controllers/cubeSchema.js{code}
>  
> In this position ：
> !image-2019-07-25-15-42-39-130.png!
>  
> This code should not be written directly in the CubeSchemaCtrl controller, 
> otherwise it will trigger the execution of this code when a page references 
> the controller, and there is a case of repeated request to initiate the 
> request. I don't know why. Perhaps it is because the other properties or 
> methods under this controller change to trigger the execution of this code.
> My suggestion is to leave the judgment of whether the cube name is duplicated 
> to the backend, and add an interface to the backend, specifically when 
> calling this method on the front end:
> {code:java}
> webapp/app/js/controllers/cubeSchema.js{code}
> !image-2019-07-25-15-26-05-703.png!
> The last condition in this judgment should be removed. As long as the 
> remaining conditions are true, you should internally initiate an ajax to the 
> backend to get the result of whether the cube is duplicated, like this:
> {code:java}
> $scope.check_cube_info = function () {
>   if (($scope.state.mode === "edit") && $scope.cubeMode == "addNewCube") {
> $http.post('/cubesNameIsExists', {cubeName: 
> $scope.cubeMetaFrame.name}).success(function (data) {
>   if (data.result) {
> SweetAlert.swal('Oops...', "The cube named [" + 
> $scope.cubeMetaFrame.name.toUpperCase() + "] already exists", 'warning');
> return false;
>   } 
> })
>   }
> }{code}
> It is not accurate for the front end to determine whether the cube name is 
> duplicated, because the permissions may not be able to get all the cubes, and 
> should be done by the backend.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (KYLIN-4067) Speed up response of kylin cube page

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895860#comment-16895860
 ] 

ASF subversion and git services commented on KYLIN-4067:


Commit 47a744141045bde0455fa0708fda1cfda4ea8177 in kylin's branch 
refs/heads/master from zhaojintaozhao
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=47a7441 ]

KYLIN-4067 optimize the kylin cube page loading mechanism. (#728)

* KYLIN-4067 optimize the kylin cube page loading mechanism. Get all 
information of cubes only when adding a new cube.

* format js code.

* formatted code style.

* add a new API to check the duplicate cube name

* KYLIN-4067 delete unused code: .cubeService


> Speed up response of kylin cube page
> 
>
> Key: KYLIN-4067
> URL: https://issues.apache.org/jira/browse/KYLIN-4067
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v3.0.0-beta
>Reporter: zhao jintao
>Assignee: zhao jintao
>Priority: Minor
> Fix For: Future
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Hi Team：
> My Kylin project has more than 100 cubes. It is very slowly when open kylin 
> web page.
> I find that kylin load all information of cubes  when open cube page. It load 
> all information of all cubes at every cube in kylin project. The url of 
> request is "http://ip:port/kylin/api/cubes?limit=65535=0;. For 
> example, if one project has 10 cubes, this request will be called by 10 
> times.  But this information is only be used to determine whether the name is 
> duplicated when adding a new cube. 
> This page loading mechanism can be optimized. Getting all the information of 
> all cube only needs to be called when adding a new cube.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (KYLIN-4067) Speed up response of kylin cube page

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895859#comment-16895859
 ] 

ASF subversion and git services commented on KYLIN-4067:


Commit 47a744141045bde0455fa0708fda1cfda4ea8177 in kylin's branch 
refs/heads/master from zhaojintaozhao
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=47a7441 ]

KYLIN-4067 optimize the kylin cube page loading mechanism. (#728)

* KYLIN-4067 optimize the kylin cube page loading mechanism. Get all 
information of cubes only when adding a new cube.

* format js code.

* formatted code style.

* add a new API to check the duplicate cube name

* KYLIN-4067 delete unused code: .cubeService


> Speed up response of kylin cube page
> 
>
> Key: KYLIN-4067
> URL: https://issues.apache.org/jira/browse/KYLIN-4067
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v3.0.0-beta
>Reporter: zhao jintao
>Assignee: zhao jintao
>Priority: Minor
> Fix For: Future
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Hi Team：
> My Kylin project has more than 100 cubes. It is very slowly when open kylin 
> web page.
> I find that kylin load all information of cubes  when open cube page. It load 
> all information of all cubes at every cube in kylin project. The url of 
> request is "http://ip:port/kylin/api/cubes?limit=65535=0;. For 
> example, if one project has 10 cubes, this request will be called by 10 
> times.  But this information is only be used to determine whether the name is 
> duplicated when adding a new cube. 
> This page loading mechanism can be optimized. Getting all the information of 
> all cube only needs to be called when adding a new cube.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (KYLIN-4067) Speed up response of kylin cube page

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895861#comment-16895861
 ] 

ASF subversion and git services commented on KYLIN-4067:


Commit 47a744141045bde0455fa0708fda1cfda4ea8177 in kylin's branch 
refs/heads/master from zhaojintaozhao
[ https://gitbox.apache.org/repos/asf?p=kylin.git;h=47a7441 ]

KYLIN-4067 optimize the kylin cube page loading mechanism. (#728)

* KYLIN-4067 optimize the kylin cube page loading mechanism. Get all 
information of cubes only when adding a new cube.

* format js code.

* formatted code style.

* add a new API to check the duplicate cube name

* KYLIN-4067 delete unused code: .cubeService


> Speed up response of kylin cube page
> 
>
> Key: KYLIN-4067
> URL: https://issues.apache.org/jira/browse/KYLIN-4067
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v3.0.0-beta
>Reporter: zhao jintao
>Assignee: zhao jintao
>Priority: Minor
> Fix For: Future
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Hi Team：
> My Kylin project has more than 100 cubes. It is very slowly when open kylin 
> web page.
> I find that kylin load all information of cubes  when open cube page. It load 
> all information of all cubes at every cube in kylin project. The url of 
> request is "http://ip:port/kylin/api/cubes?limit=65535=0;. For 
> example, if one project has 10 cubes, this request will be called by 10 
> times.  But this information is only be used to determine whether the name is 
> duplicated when adding a new cube. 
> This page loading mechanism can be optimized. Getting all the information of 
> all cube only needs to be called when adding a new cube.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[jira] [Commented] (KYLIN-4067) Speed up response of kylin cube page

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KYLIN-4067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16895857#comment-16895857
 ] 

ASF GitHub Bot commented on KYLIN-4067:
---

nichunen commented on pull request #728: KYLIN-4067 optimize the kylin cube 
page loading mechanism.
URL: https://github.com/apache/kylin/pull/728
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Speed up response of kylin cube page
> 
>
> Key: KYLIN-4067
> URL: https://issues.apache.org/jira/browse/KYLIN-4067
> Project: Kylin
>  Issue Type: Improvement
>  Components: Web 
>Affects Versions: v3.0.0-beta
>Reporter: zhao jintao
>Assignee: zhao jintao
>Priority: Minor
> Fix For: Future
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Hi Team：
> My Kylin project has more than 100 cubes. It is very slowly when open kylin 
> web page.
> I find that kylin load all information of cubes  when open cube page. It load 
> all information of all cubes at every cube in kylin project. The url of 
> request is "http://ip:port/kylin/api/cubes?limit=65535=0;. For 
> example, if one project has 10 cubes, this request will be called by 10 
> times.  But this information is only be used to determine whether the name is 
> duplicated when adding a new cube. 
> This page loading mechanism can be optimized. Getting all the information of 
> all cube only needs to be called when adding a new cube.
>  



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

[GitHub] [kylin] nichunen merged pull request #728: KYLIN-4067 optimize the kylin cube page loading mechanism.

[GitBox]

nichunen merged pull request #728: KYLIN-4067 optimize the kylin cube page 
loading mechanism.
URL: https://github.com/apache/kylin/pull/728
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #780: Remove the surplus allCubes field

[GitBox]

codecov-io commented on issue #780: Remove the surplus allCubes field
URL: https://github.com/apache/kylin/pull/780#issuecomment-516301691
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/780?src=pr=h1) Report
   > Merging [#780](https://codecov.io/gh/apache/kylin/pull/780?src=pr=desc) 
into 
[master](https://codecov.io/gh/apache/kylin/commit/ed2092616211e3306d35aeaa0296e6d41b55b273?src=pr=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/kylin/pull/780/graphs/tree.svg?width=650=JawVgbgsVo=150=pr)](https://codecov.io/gh/apache/kylin/pull/780?src=pr=tree)
   
   ```diff
   @@ Coverage Diff  @@
   ## master #780  +/-   ##
   
   - Coverage 25.76%   25.76%   -0.01% 
   + Complexity 6048 6047   -1 
   
 Files  1393 1393  
 Lines 8296982969  
 Branches  1160511605  
   
   - Hits  2138021379   -1 
   - Misses5953659537   +1 
 Partials   2053 2053
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/kylin/pull/780?src=pr=tree) | Coverage Δ 
| Complexity Δ | |
   |---|---|---|---|
   | 
[...he/kylin/dict/lookup/cache/RocksDBLookupTable.java](https://codecov.io/gh/apache/kylin/pull/780/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L2xvb2t1cC9jYWNoZS9Sb2Nrc0RCTG9va3VwVGFibGUuamF2YQ==)
 | `72.97% <0%> (-5.41%)` | `6% <0%> (-1%)` | |
   | 
[...core/storage/columnar/GeneralColumnDataReader.java](https://codecov.io/gh/apache/kylin/pull/780/diff?src=pr=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvR2VuZXJhbENvbHVtbkRhdGFSZWFkZXIuamF2YQ==)
 | `89.47% <0%> (-5.27%)` | `6% <0%> (-1%)` | |
   | 
[...rg/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://codecov.io/gh/apache/kylin/pull/780/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2lubWVtY3ViaW5nL01lbURpc2tTdG9yZS5qYXZh)
 | `69.3% <0%> (-0.31%)` | `7% <0%> (ø)` | |
   | 
[...a/org/apache/kylin/dict/Number2BytesConverter.java](https://codecov.io/gh/apache/kylin/pull/780/diff?src=pr=tree#diff-Y29yZS1kaWN0aW9uYXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9kaWN0L051bWJlcjJCeXRlc0NvbnZlcnRlci5qYXZh)
 | `82.53% <0%> (+0.79%)` | `18% <0%> (+1%)` | :arrow_up: |
   | 
[.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/780/diff?src=pr=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=)
 | `66.15% <0%> (+2.3%)` | `0% <0%> (ø)` | :arrow_down: |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/kylin/pull/780?src=pr=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/kylin/pull/780?src=pr=footer). Last 
update 
[ed20926...661fa6b](https://codecov.io/gh/apache/kylin/pull/780?src=pr=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] ClausClaus opened a new pull request #780: Remove the surplus allCubes field

[GitBox]

ClausClaus opened a new pull request #780: Remove the surplus allCubes field
URL: https://github.com/apache/kylin/pull/780
 
 
   The allCubes field is redundant, and the corresponding authentication 
interface already exists on the back end.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services