[GitHub] [maven] michael-o commented on pull request #408: [MNG-7045] - Drop useless and outdated cdi-api from maven
michael-o commented on pull request #408: URL: https://github.com/apache/maven/pull/408#issuecomment-748651915 I asked for an IT for good reason. I ran the suite multiple times from a fresh clone and see this failing: ``` java.lang.AssertionError: Compile goal was expected to run once Expected: is <1> but: was <2> at org.apache.maven.it.MavenITmng6566ExecuteAnnotationShouldNotReExecuteGoalsTest.assertCompiledOnce(MavenITmng6566ExecuteAnnotationShouldNotReExecuteGoalsTest.java:100) at org.apache.maven.it.MavenITmng6566ExecuteAnnotationShouldNotReExecuteGoalsTest.testRunsCompileGoalOnceWithPhaseExecution(MavenITmng6566ExecuteAnnotationShouldNotReExecuteGoalsTest.java:84) ``` Output: ``` mosipov@bsd1srv:/usr/home/mosipov/var/Projekte/mit/core-it-suite/target/test-classes/mng-6566-execute-annotation-should-not-re-execute-goals/consumer (MNG-7045=) $ less log-phase-execution.txt [INFO] Error stacktraces are turned on. [INFO] Scanning for projects... [INFO] [INFO] ---< org.apache.maven.its.mng6566:consumer > [INFO] Building consumer 1.0-SNAPSHOT [INFO] [ jar ]- [WARNING] Version not locked for default bindings plugins [maven-resources-plugin], you should define versions in pluginManagement section of your pom.xml or parent [INFO] [INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ consumer --- [WARNING] File encoding has not been set, using platform encoding UTF-8. Build is platform dependent! [WARNING] See https://maven.apache.org/general.html#encoding-warning [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent! [INFO] Using 'null' encoding to copy filtered properties files. [INFO] skip non existing resourceDirectory /var/mosipov/Projekte/mit/core-it-suite/target/test-classes/mng-6566-execute-annotation-should-not-re-execute-goals/consumer/src/main/resources [INFO] skip non existing resourceDirectory /var/mosipov/Projekte/mit/core-it-suite/target/test-classes/mng-6566-execute-annotation-should-not-re-execute-goals/consumer/src/main/resources-filtered [INFO] [INFO] --- maven-compiler-plugin:0.1-stub-SNAPSHOT:compile (default-compile) @ consumer --- [INFO] [MAVEN-CORE-IT-LOG] Using output file path: target/compiler-compile.txt [INFO] [MAVEN-CORE-IT-LOG] Creating output file: /var/mosipov/Projekte/mit/core-it-suite/target/test-classes/mng-6566-execute-annotation-should-not-re-execute-goals/consumer/target/compiler-compile.txt [INFO] [MAVEN-CORE-IT-LOG] Created output file: /var/mosipov/Projekte/mit/core-it-suite/target/test-classes/mng-6566-execute-annotation-should-not-re-execute-goals/consumer/target/compiler-compile.txt [INFO] [INFO] >>> plugin:1.0-SNAPSHOT:require-compile-phase (default) > compile @ consumer >>> [INFO] [INFO] --- maven-resources-plugin:3.2.0:resources (default-resources) @ consumer --- [WARNING] File encoding has not been set, using platform encoding UTF-8. Build is platform dependent! [WARNING] See https://maven.apache.org/general.html#encoding-warning [WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent! [INFO] Using 'null' encoding to copy filtered properties files. [INFO] skip non existing resourceDirectory /var/mosipov/Projekte/mit/core-it-suite/target/test-classes/mng-6566-execute-annotation-should-not-re-execute-goals/consumer/src/main/resources [INFO] skip non existing resourceDirectory /var/mosipov/Projekte/mit/core-it-suite/target/test-classes/mng-6566-execute-annotation-should-not-re-execute-goals/consumer/src/main/resources-filtered [INFO] [INFO] --- maven-compiler-plugin:0.1-stub-SNAPSHOT:compile (default-compile) @ consumer --- [INFO] [MAVEN-CORE-IT-LOG] Using output file path: target/compiler-compile.txt [INFO] [MAVEN-CORE-IT-LOG] Creating output file: /var/mosipov/Projekte/mit/core-it-suite/target/test-classes/mng-6566-execute-annotation-should-not-re-execute-goals/consumer/target/compiler-compile.txt [INFO] [MAVEN-CORE-IT-LOG] Created output file: /var/mosipov/Projekte/mit/core-it-suite/target/test-classes/mng-6566-execute-annotation-should-not-re-execute-goals/consumer/target/compiler-compile.txt [INFO] [INFO] <<< plugin:1.0-SNAPSHOT:require-compile-phase (default) < compile @ consumer <<< [INFO] [INFO] [INFO] --- plugin:1.0-SNAPSHOT:require-compile-phase (default) @ consumer --- [INFO] MNG-6566 plugin require-compile-phase goal executed [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 0.148 s [INFO] Finished at: 2020-12-20T20:04:27+01:00 [INFO]
[GitHub] [maven-ear-plugin] mabrarov opened a new pull request #31: [MEAR-294] skinnyWars & removal of provided artifacts from the Class-Path entry of MANIFEST.mf
mabrarov opened a new pull request #31: URL: https://github.com/apache/maven-ear-plugin/pull/31 [MEAR-294] - Removal of provided artifacts from Class-Path entry of MANIFEST.mf if skinnyWars / skinnyModules options are turned on. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MEAR-294) JAR with provided scope should be removed from Class-Path in case of skinnyWars
Marat Abrarov created MEAR-294:
--
Summary: JAR with provided scope should be removed from Class-Path
in case of skinnyWars
Key: MEAR-294
URL: https://issues.apache.org/jira/browse/MEAR-294
Project: Maven EAR Plugin
Issue Type: Bug
Affects Versions: 3.1.0
Reporter: Marat Abrarov
JAR dependency of EAR with provided scope should be removed from {{Class-Path}}
entry of MANIFEST.mf of EAR module if {{skinnyWars}} or {{skinnyModules}}
option is turned on. This issue looks to be a bug of solution of MEAR-243 bug.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on a change in pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546406382 ## File path: src/it/skinny-wars-javaee5/ear-module/pom.xml ## @@ -33,9 +33,26 @@ under the License. commons-lang Review comment: Changed version to 2.6 in 83fd4ff This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on pull request #88: Drop CDI API from Maven
michael-o commented on pull request #88: URL: https://github.com/apache/maven-integration-testing/pull/88#issuecomment-748634359 Going through now... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #408: [MNG-7045] - Drop useless and outdated cdi-api from maven
michael-o commented on pull request #408: URL: https://github.com/apache/maven/pull/408#issuecomment-748634338 Going through now... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
elharo commented on a change in pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546401678 ## File path: src/it/skinny-wars-javaee5/ear-module/pom.xml ## @@ -33,9 +33,26 @@ under the License. commons-lang Review comment: That's commons-lang3, not commons-lang This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on a change in pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546397158 ## File path: src/it/skinny-wars-javaee5/ear-module/pom.xml ## @@ -33,9 +33,26 @@ under the License. commons-lang Review comment: The latest version of Apache Commons Lang which supports Java 7 is [3.8.1](https://commons.apache.org/proper/commons-lang/changes-report.html#a3.9) but not 2.6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on a change in pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546397158 ## File path: src/it/skinny-wars-javaee5/ear-module/pom.xml ## @@ -33,9 +33,26 @@ under the License. commons-lang Review comment: The latest version of Apache Commons Lang which supports Java 7 is [3.8.1](https://commons.apache.org/proper/commons-lang/changes-report.html#a3.9) and not 2.6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-1868) writing to System.outwriting to System.errwriting to System.outwriting to System.errwriting
Tilman Hausherr created SUREFIRE-1868:
-
Summary: writing to System.outwriting to System.errwriting to
System.outwriting to System.errwriting
Key: SUREFIRE-1868
URL: https://issues.apache.org/jira/browse/SUREFIRE-1868
Project: Maven Surefire
Issue Type: Bug
Components: Maven Surefire Plugin
Affects Versions: 3.0.0-M5
Environment: W10, oracle jdk8.0_202, mvn 3.6.3
Reporter: Tilman Hausherr
I'm getting this text at the end of the tests
"Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0 s - in
org.apache.tika.utils.ServiceLoaderUtilsTest
writing to System.outwriting to System.errwriting to System.outwriting to
System.errwriting to System.outwriting to System.errwriting to
System.outwriting to System.errwriting to System.outwriting to System.err"
How to reproduce:
- get the Apache Tika project ("main" branch) from
https://github.com/apache/tika/
- change "3.0.0-M4" to "3.0.0-M5" in the pom.xml of the parent subproject
- build
- it happens with the first subproject (tika-core)
The build doesn't stop, but in my IDE it appears in red so it's probably a
warning or an error.
It does not happen with 3.0.0-M4.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
elharo commented on a change in pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546391171 ## File path: src/it/skinny-wars-javaee5/ear-module/pom.xml ## @@ -33,9 +33,26 @@ under the License. commons-lang Review comment: Probably doesn't matter a great deal here, but we try to converge on the latest versions of dependencies that support Java 7 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on a change in pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546387830 ## File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java ## @@ -816,12 +816,15 @@ private void changeManifestClasspath( EarModule module, File original, JavaEEVer Attribute classPath = mf.getMainSection().getAttribute( "Class-Path" ); List classPathElements = new ArrayList(); +boolean classPathExisted; Review comment: Renamed to `classPathExists` in 3b0e65e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on a change in pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546387718 ## File path: src/it/skinny-wars-javaee5/ear-module/pom.xml ## @@ -33,9 +33,26 @@ under the License. commons-lang 2.5 + + org.apache.commons + commons-lang3 + 3.11 Review comment: Replaced with `org.apache.commons:commons-collections4:4.2` in 3b0e65e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on a change in pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546385292 ## File path: src/it/skinny-wars-javaee5/ear-module/pom.xml ## @@ -33,9 +33,26 @@ under the License. commons-lang Review comment: Why should version be 2.6? According to [Apache Commons Lang Release Notes](https://commons.apache.org/proper/commons-lang/changes-report.html) 2.5 version supports Java 7 and 2.6 version doesn't differ from 2.5 version in terms of supported Java version. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MEAR-293) skinnyModules option doesn't work if skinnyWars is false
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252433#comment-17252433
]
Hudson commented on MEAR-293:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-ear-plugin » master #51
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/51/
> skinnyModules option doesn't work if skinnyWars is false
>
>
> Key: MEAR-293
> URL: https://issues.apache.org/jira/browse/MEAR-293
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Windows 10 x64, Red Hat JDK 1.8 update 252 x64
>Reporter: Marat Abrarov
>Priority: Blocker
>
> If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
> off (default value) then WARs are not skinny. It looks to be a
> [bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
> introduced by [pull request
> #26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to
> [failed integration
> test|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
> in the Jenkins builds of master branch:
> {noformat}
> [ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
> [ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
> elapsed: 19.103 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
> of module [eartest-war-sample-three-1.0.war] manifest: array lengths
> differed, expected.length=3 actual.length=1; arrays first differed at element
> [0]; expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> Caused by: org.junit.ComparisonFailure:
> expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
elharo commented on a change in pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#discussion_r546379504 ## File path: src/it/skinny-wars-javaee5/ear-module/pom.xml ## @@ -33,9 +33,26 @@ under the License. commons-lang 2.5 + + org.apache.commons + commons-lang3 + 3.11 Review comment: This requires Java 8. I think 3.8.1 is the last one we can use. ## File path: src/it/skinny-wars-javaee5/ear-module/pom.xml ## @@ -33,9 +33,26 @@ under the License. commons-lang Review comment: weird to have both commons-lang and commons-lang3. This version should be 2.6, fwiw. ## File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java ## @@ -816,12 +816,15 @@ private void changeManifestClasspath( EarModule module, File original, JavaEEVer Attribute classPath = mf.getMainSection().getAttribute( "Class-Path" ); List classPathElements = new ArrayList(); +boolean classPathExisted; Review comment: why past tense? i.e. existed instead of exists? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MEAR-293) skinnyModules option doesn't work if skinnyWars is false
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MEAR-293.
Resolution: Fixed
> skinnyModules option doesn't work if skinnyWars is false
>
>
> Key: MEAR-293
> URL: https://issues.apache.org/jira/browse/MEAR-293
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Windows 10 x64, Red Hat JDK 1.8 update 252 x64
>Reporter: Marat Abrarov
>Priority: Blocker
>
> If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
> off (default value) then WARs are not skinny. It looks to be a
> [bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
> introduced by [pull request
> #26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to
> [failed integration
> test|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
> in the Jenkins builds of master branch:
> {noformat}
> [ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
> [ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
> elapsed: 19.103 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
> of module [eartest-war-sample-three-1.0.war] manifest: array lengths
> differed, expected.length=3 actual.length=1; arrays first differed at element
> [0]; expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> Caused by: org.junit.ComparisonFailure:
> expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MEAR-293) skinnyModules option doesn't work if skinnyWars is false
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold closed MEAR-293.
--
> skinnyModules option doesn't work if skinnyWars is false
>
>
> Key: MEAR-293
> URL: https://issues.apache.org/jira/browse/MEAR-293
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Windows 10 x64, Red Hat JDK 1.8 update 252 x64
>Reporter: Marat Abrarov
>Priority: Blocker
>
> If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
> off (default value) then WARs are not skinny. It looks to be a
> [bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
> introduced by [pull request
> #26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to
> [failed integration
> test|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
> in the Jenkins builds of master branch:
> {noformat}
> [ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
> [ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
> elapsed: 19.103 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
> of module [eartest-war-sample-three-1.0.war] manifest: array lengths
> differed, expected.length=3 actual.length=1; arrays first differed at element
> [0]; expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> Caused by: org.junit.ComparisonFailure:
> expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] elharo merged pull request #30: [MEAR-293] skinnyModules to work even if skinnyWars is false
elharo merged pull request #30: URL: https://github.com/apache/maven-ear-plugin/pull/30 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#issuecomment-748597912 @hboutemy This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #30: [MEAR-293] skinnyModules to work even if skinnyWars is false
mabrarov commented on pull request #30: URL: https://github.com/apache/maven-ear-plugin/pull/30#issuecomment-748597658 @elharo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MEAR-293) skinnyModules option doesn't work if skinnyWars is false
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-293:
---
Description:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off (default value) then WARs are not skinny. Its looks to be a
[bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
introduced by [pull request
#26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to [failed
integration
tests|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
in the Jenkins builds of master branch:
{noformat}
[ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
[ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
elapsed: 19.103 s <<< FAILURE!
org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
of module [eartest-war-sample-three-1.0.war] manifest: array lengths differed,
expected.length=3 actual.length=1; arrays first differed at element [0];
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
Caused by: org.junit.ComparisonFailure:
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
{noformat}
was:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off (default value) then no WARs are not skinny. Its looks to be a
[bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
introduced by [pull request
#26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to [failed
integration
tests|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
in the Jenkins builds of master branch:
{noformat}
[ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
[ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
elapsed: 19.103 s <<< FAILURE!
org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
of module [eartest-war-sample-three-1.0.war] manifest: array lengths differed,
expected.length=3 actual.length=1; arrays first differed at element [0];
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
Caused by: org.junit.ComparisonFailure:
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
{noformat}
> skinnyModules option doesn't work if skinnyWars is false
>
>
> Key: MEAR-293
> URL: https://issues.apache.org/jira/browse/MEAR-293
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Windows 10 x64, Red Hat JDK 1.8 update 252 x64
>Reporter: Marat Abrarov
>Priority: Blocker
>
> If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
> off (default value) then WARs are not skinny. Its looks to be a
> [bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
> introduced by [pull request
> #26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to
> [failed integration
> tests|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
> in the Jenkins builds of master branch:
> {noformat}
> [ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
> [ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
> elapsed: 19.103 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
> of module [eartest-war-sample-three-1.0.war] manifest: array lengths
> differed, expected.length=3 actual.length=1; arrays first differed at element
> [0]; expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> Caused by: org.junit.ComparisonFailure:
> expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MEAR-293) skinnyModules option doesn't work if skinnyWars is false
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-293:
---
Description:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off (default value) then WARs are not skinny. It looks to be a
[bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
introduced by [pull request
#26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to [failed
integration
test|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
in the Jenkins builds of master branch:
{noformat}
[ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
[ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
elapsed: 19.103 s <<< FAILURE!
org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
of module [eartest-war-sample-three-1.0.war] manifest: array lengths differed,
expected.length=3 actual.length=1; arrays first differed at element [0];
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
Caused by: org.junit.ComparisonFailure:
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
{noformat}
was:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off (default value) then WARs are not skinny. It looks to be a
[bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
introduced by [pull request
#26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to [failed
integration
tests|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
in the Jenkins builds of master branch:
{noformat}
[ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
[ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
elapsed: 19.103 s <<< FAILURE!
org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
of module [eartest-war-sample-three-1.0.war] manifest: array lengths differed,
expected.length=3 actual.length=1; arrays first differed at element [0];
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
Caused by: org.junit.ComparisonFailure:
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
{noformat}
> skinnyModules option doesn't work if skinnyWars is false
>
>
> Key: MEAR-293
> URL: https://issues.apache.org/jira/browse/MEAR-293
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Windows 10 x64, Red Hat JDK 1.8 update 252 x64
>Reporter: Marat Abrarov
>Priority: Blocker
>
> If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
> off (default value) then WARs are not skinny. It looks to be a
> [bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
> introduced by [pull request
> #26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to
> [failed integration
> test|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
> in the Jenkins builds of master branch:
> {noformat}
> [ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
> [ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
> elapsed: 19.103 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
> of module [eartest-war-sample-three-1.0.war] manifest: array lengths
> differed, expected.length=3 actual.length=1; arrays first differed at element
> [0]; expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> Caused by: org.junit.ComparisonFailure:
> expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MEAR-293) skinnyModules option doesn't work if skinnyWars is false
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-293:
---
Description:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off (default value) then WARs are not skinny. It looks to be a
[bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
introduced by [pull request
#26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to [failed
integration
tests|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
in the Jenkins builds of master branch:
{noformat}
[ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
[ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
elapsed: 19.103 s <<< FAILURE!
org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
of module [eartest-war-sample-three-1.0.war] manifest: array lengths differed,
expected.length=3 actual.length=1; arrays first differed at element [0];
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
Caused by: org.junit.ComparisonFailure:
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
{noformat}
was:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off (default value) then WARs are not skinny. Its looks to be a
[bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
introduced by [pull request
#26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to [failed
integration
tests|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
in the Jenkins builds of master branch:
{noformat}
[ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
[ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
elapsed: 19.103 s <<< FAILURE!
org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
of module [eartest-war-sample-three-1.0.war] manifest: array lengths differed,
expected.length=3 actual.length=1; arrays first differed at element [0];
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
Caused by: org.junit.ComparisonFailure:
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
{noformat}
> skinnyModules option doesn't work if skinnyWars is false
>
>
> Key: MEAR-293
> URL: https://issues.apache.org/jira/browse/MEAR-293
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Windows 10 x64, Red Hat JDK 1.8 update 252 x64
>Reporter: Marat Abrarov
>Priority: Blocker
>
> If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
> off (default value) then WARs are not skinny. It looks to be a
> [bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
> introduced by [pull request
> #26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to
> [failed integration
> tests|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
> in the Jenkins builds of master branch:
> {noformat}
> [ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
> [ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
> elapsed: 19.103 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
> of module [eartest-war-sample-three-1.0.war] manifest: array lengths
> differed, expected.length=3 actual.length=1; arrays first differed at element
> [0]; expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> Caused by: org.junit.ComparisonFailure:
> expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #26: replace deprecated method no longer needed in Java 7+
mabrarov commented on a change in pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546360290
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -480,9 +482,10 @@ private void copyModules( final JavaEEVersion
javaEEVersion,
if ( sourceFile.lastModified() >
destinationFile.lastModified() )
{
getLog().info( "Copying artifact [" + module + "] to
[" + module.getUri() + "]" );
-FileUtils.copyFile( sourceFile, destinationFile );
-
-if ( module.changeManifestClasspath() )
+createParentIfNecessary( destinationFile );
+Files.copy( sourceFile.toPath(),
destinationFile.toPath(),
+LinkOption.NOFOLLOW_LINKS,
StandardCopyOption.REPLACE_EXISTING );
+if ( module.changeManifestClasspath() && ( skinnyWars
|| module.getLibDir() == null ) )
Review comment:
Refer to pull request #30 for the fix of this bug.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov opened a new pull request #30: [MEAR-293] skinnyModules to work even if skinnyWars is false
mabrarov opened a new pull request #30: URL: https://github.com/apache/maven-ear-plugin/pull/30 [MEAR-293] - skinnyModules option working even if skinnyWars option is turned off (or has default value). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #26: replace deprecated method no longer needed in Java 7+
mabrarov commented on a change in pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546359981
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -480,9 +482,10 @@ private void copyModules( final JavaEEVersion
javaEEVersion,
if ( sourceFile.lastModified() >
destinationFile.lastModified() )
{
getLog().info( "Copying artifact [" + module + "] to
[" + module.getUri() + "]" );
-FileUtils.copyFile( sourceFile, destinationFile );
-
-if ( module.changeManifestClasspath() )
+createParentIfNecessary( destinationFile );
+Files.copy( sourceFile.toPath(),
destinationFile.toPath(),
+LinkOption.NOFOLLOW_LINKS,
StandardCopyOption.REPLACE_EXISTING );
+if ( module.changeManifestClasspath() && ( skinnyWars
|| module.getLibDir() == null ) )
Review comment:
I opened [MEAR-293](https://issues.apache.org/jira/browse/MEAR-293) bug
for this issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #26: replace deprecated method no longer needed in Java 7+
mabrarov commented on a change in pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546359981
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -480,9 +482,10 @@ private void copyModules( final JavaEEVersion
javaEEVersion,
if ( sourceFile.lastModified() >
destinationFile.lastModified() )
{
getLog().info( "Copying artifact [" + module + "] to
[" + module.getUri() + "]" );
-FileUtils.copyFile( sourceFile, destinationFile );
-
-if ( module.changeManifestClasspath() )
+createParentIfNecessary( destinationFile );
+Files.copy( sourceFile.toPath(),
destinationFile.toPath(),
+LinkOption.NOFOLLOW_LINKS,
StandardCopyOption.REPLACE_EXISTING );
+if ( module.changeManifestClasspath() && ( skinnyWars
|| module.getLibDir() == null ) )
Review comment:
I opened
[MEAR-293](https://issues.apache.org/jira/projects/MEAR/issues/MEAR-293) bug
for this issue.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MEAR-293) skinnyModules option doesn't work if skinnyWars is false
[
https://issues.apache.org/jira/browse/MEAR-293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-293:
---
Description:
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off (default value) then no WARs are not skinny. Its looks to be a
[bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
introduced by [pull request
#26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to [failed
integration
tests|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
in the Jenkins builds of master branch:
{noformat}
[ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
[ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
elapsed: 19.103 s <<< FAILURE!
org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
of module [eartest-war-sample-three-1.0.war] manifest: array lengths differed,
expected.length=3 actual.length=1; arrays first differed at element [0];
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
Caused by: org.junit.ComparisonFailure:
expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
was:<[]jar-sample-two-1.0.j...>
at
org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
{noformat}
was:If {{skinnyModules}} option is turned on and {{skinnyWars}} option is
turned off (default value) then no WARs are not skinny. Its looks to be a
[bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
introduced by [pull request
#26|https://github.com/apache/maven-ear-plugin/pull/26].
> skinnyModules option doesn't work if skinnyWars is false
>
>
> Key: MEAR-293
> URL: https://issues.apache.org/jira/browse/MEAR-293
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Windows 10 x64, Red Hat JDK 1.8 update 252 x64
>Reporter: Marat Abrarov
>Priority: Blocker
>
> If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
> off (default value) then no WARs are not skinny. Its looks to be a
> [bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
> introduced by [pull request
> #26|https://github.com/apache/maven-ear-plugin/pull/26]. This leads to
> [failed integration
> tests|https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/49/console]
> in the Jenkins builds of master branch:
> {noformat}
> [ERROR] Tests run: 94, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
> 416.522 s <<< FAILURE! - in org.apache.maven.plugins.ear.it.EarMojoIT
> [ERROR] testProject092(org.apache.maven.plugins.ear.it.EarMojoIT) Time
> elapsed: 19.103 s <<< FAILURE!
> org.junit.internal.ArrayComparisonFailure: Wrong elements of Class-Path entry
> of module [eartest-war-sample-three-1.0.war] manifest: array lengths
> differed, expected.length=3 actual.length=1; arrays first differed at element
> [0]; expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> Caused by: org.junit.ComparisonFailure:
> expected:<[libs/eartest-]jar-sample-two-1.0.j...> but
> was:<[]jar-sample-two-1.0.j...>
> at
> org.apache.maven.plugins.ear.it.EarMojoIT.testProject092(EarMojoIT.java:1035)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MEAR-293) skinnyModules option doesn't work if skinnyWars is false
Marat Abrarov created MEAR-293:
--
Summary: skinnyModules option doesn't work if skinnyWars is false
Key: MEAR-293
URL: https://issues.apache.org/jira/browse/MEAR-293
Project: Maven EAR Plugin
Issue Type: Bug
Affects Versions: 3.1.0
Environment: Windows 10 x64, Red Hat JDK 1.8 update 252 x64
Reporter: Marat Abrarov
If {{skinnyModules}} option is turned on and {{skinnyWars}} option is turned
off (default value) then no WARs are not skinny. Its looks to be a
[bug|https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822]
introduced by [pull request
#26|https://github.com/apache/maven-ear-plugin/pull/26].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MEAR-292) skipClassPathModification option should prevent adding Class-Path entry into MANIFEST.mf
[
https://issues.apache.org/jira/browse/MEAR-292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Marat Abrarov updated MEAR-292:
---
Description: It looks like there is a bug in implementation of
{{skipClassPathModification}} option introduced in MEAR-182 - if
{{skipClassPathModification}} is {{true}} and original MANIFEST.mf of EAR
module artifact has no {{Class-Path}} entry, then empty {{Class-Path}} entry is
added into EAR module. I believe that {{Class-Path}} entry should not be added
in this case. (was: It looks like there is a bug in implementation of
{{skipClassPathModification}} option introduced in MEAR-182 - if
{{skipClassPathModification}} is {{true}} and original MANIFEST.mf of EAR
module artifact has no {{Class-Path}} entry, then empty {{Class-Path}} entry is
added into EAR module.)
> skipClassPathModification option should prevent adding Class-Path entry into
> MANIFEST.mf
>
>
> Key: MEAR-292
> URL: https://issues.apache.org/jira/browse/MEAR-292
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Windows 10 x64
>Reporter: Marat Abrarov
>Priority: Major
>
> It looks like there is a bug in implementation of
> {{skipClassPathModification}} option introduced in MEAR-182 - if
> {{skipClassPathModification}} is {{true}} and original MANIFEST.mf of EAR
> module artifact has no {{Class-Path}} entry, then empty {{Class-Path}} entry
> is added into EAR module. I believe that {{Class-Path}} entry should not be
> added in this case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29#issuecomment-748590385 Note that Jenkins build can fail due to [the bug](https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822) introduced by pull request #26. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #28: [MEAR-182] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov commented on pull request #28: URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-748590280 Declining in favor of pull request #29 with fixed source branch name. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov closed pull request #28: [MEAR-182] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov closed pull request #28: URL: https://github.com/apache/maven-ear-plugin/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov opened a new pull request #29: [MEAR-292] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
mabrarov opened a new pull request #29: URL: https://github.com/apache/maven-ear-plugin/pull/29 [MEAR-292] - Don't add MANFIEST.mf Class-Path entry for EAR module if skipClassPathModification is true and original MANFIEST.mf of EAR module artifact doesn't contain Class-Path entry. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MEAR-292) skipClassPathModification option should prevent adding Class-Path entry into MANIFEST.mf
Marat Abrarov created MEAR-292:
--
Summary: skipClassPathModification option should prevent adding
Class-Path entry into MANIFEST.mf
Key: MEAR-292
URL: https://issues.apache.org/jira/browse/MEAR-292
Project: Maven EAR Plugin
Issue Type: Bug
Affects Versions: 3.1.0
Environment: Windows 10 x64
Reporter: Marat Abrarov
It looks like there is a bug in implementation of {{skipClassPathModification}}
option introduced in MEAR-182 - if {{skipClassPathModification}} is {{true}}
and original MANIFEST.mf of EAR module artifact has no {{Class-Path}} entry,
then empty {{Class-Path}} entry is added into EAR module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #26: replace deprecated method no longer needed in Java 7+
mabrarov commented on a change in pull request #26:
URL: https://github.com/apache/maven-ear-plugin/pull/26#discussion_r546355822
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -480,9 +482,10 @@ private void copyModules( final JavaEEVersion
javaEEVersion,
if ( sourceFile.lastModified() >
destinationFile.lastModified() )
{
getLog().info( "Copying artifact [" + module + "] to
[" + module.getUri() + "]" );
-FileUtils.copyFile( sourceFile, destinationFile );
-
-if ( module.changeManifestClasspath() )
+createParentIfNecessary( destinationFile );
+Files.copy( sourceFile.toPath(),
destinationFile.toPath(),
+LinkOption.NOFOLLOW_LINKS,
StandardCopyOption.REPLACE_EXISTING );
+if ( module.changeManifestClasspath() && ( skinnyWars
|| module.getLibDir() == null ) )
Review comment:
This line looks to be modified by mistake. It should remain:
```java
if ( module.changeManifestClasspath() )
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #26: replace deprecated method no longer needed in Java 7+
mabrarov edited a comment on pull request #26: URL: https://github.com/apache/maven-ear-plugin/pull/26#issuecomment-748588430 @elharo and @hboutemy, It feels like this PR has introduced a bug. Please checkout merge commit of this PR and execute integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov edited a comment on pull request #26: replace deprecated method no longer needed in Java 7+
mabrarov edited a comment on pull request #26: URL: https://github.com/apache/maven-ear-plugin/pull/26#issuecomment-748588430 @elharo and @hboutemy, It feels like this PR has introduced a bug. Please, execute integration tests and ensure that merge commit of this PR passes all tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #26: replace deprecated method no longer needed in Java 7+
mabrarov commented on pull request #26: URL: https://github.com/apache/maven-ear-plugin/pull/26#issuecomment-748588430 @elharo, It feels like this PR has introduced a bug. Please, execute integration tests and ensure that merge commit of this PR passes all tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MEAR-216) Unable to include dependencies of type test-jar
[
https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17252379#comment-17252379
]
Hudson commented on MEAR-216:
-
Build unstable in Jenkins: Maven » Maven TLP » maven-ear-plugin » master #50
See
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/master/50/
> Unable to include dependencies of type test-jar
> ---
>
> Key: MEAR-216
> URL: https://issues.apache.org/jira/browse/MEAR-216
> Project: Maven EAR Plugin
> Issue Type: Improvement
>Affects Versions: 2.10
>Reporter: Maxim Frolov
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: test-jar-in-ear-2.zip, test-jar-in-ear.zip
>
>
> Please implement support for artifacts of type *test-jar*.
> One of the use cases would be to build a test EAR as a mix of production and
> test JARs where the test JARs are used to set up the test data used to test
> the production code.
> Currently including one or more dependencies of type test-jar causes
> *LifecycleExecutionException*:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml
> (default-generate-application-xml) on project suite-systemtests-common-ear:
> Failed to initialize ear modules: Unknown artifact type[test-jar] for
> artifact_id -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml
> (default-generate-application-xml) on project suite-systemtests-common-ear:
> Failed to initialize ear modules
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to
> initialize ear modules
> at
> org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:260)
> at
> org.apache.maven.plugin.ear.GenerateApplicationXmlMojo.execute(GenerateApplicationXmlMojo.java:162)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: org.apache.maven.plugin.ear.UnknownArtifactTypeException: Unknown
> artifact type[test-jar] for common-domain-impl
> at
> org.apache.maven.plugin.ear.EarModuleFactory.newEarModule(EarModuleFactory.java:88)
> at
> org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:250)
> ... 22 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] hboutemy commented on pull request #28: [MEAR-182] skipClassPathModification in case of undefined Class-Path entry of MANFIEST.mf
hboutemy commented on pull request #28: URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-748584851 MEAR-182 https://issues.apache.org/jira/browse/MEAR-182 is an old issue closed for release 2.10 please create a new issue (we'll link it to MEAR-182), and update the commit (with rebasing, please, to have a simpler Git history) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MEAR-221) SNAPSHOT included with timestamp in skinnyWars but not removed from war(s)
[ https://issues.apache.org/jira/browse/MEAR-221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated MEAR-221: --- Fix Version/s: waiting-for-feedback > SNAPSHOT included with timestamp in skinnyWars but not removed from war(s) > -- > > Key: MEAR-221 > URL: https://issues.apache.org/jira/browse/MEAR-221 > Project: Maven EAR Plugin > Issue Type: Bug >Affects Versions: 2.10.1 > Environment: Windows 7, Maven 3.0.4, IBM JDK 7.1 >Reporter: Anders Hammar >Priority: Major > Fix For: waiting-for-feedback > > > When configuring ear for skinnyWars and adding a SNAPSHOT dependency, that > jar artifact is added with (with snapshot timestamp identifier) in ear's lib > folder but the SNAPSHOT jar artifact is not removed from skinny wars. (The > jar artifact in the war is not using timestamp identifier but -SNAPSHOT > version in file name.) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MEAR-289) skinnyWars issue with finalName for Jar module
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MEAR-289:
---
Fix Version/s: waiting-for-feedback
> skinnyWars issue with finalName for Jar module
> --
>
> Key: MEAR-289
> URL: https://issues.apache.org/jira/browse/MEAR-289
> Project: Maven EAR Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
>Reporter: Stefan Schmidt
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: maven-ear-example.zip
>
>
> When a finalName is given for a Jar module in a War it is not found by
> filename @\{artifactId}@-@\{version}@.@\{extension}@ for deletion in
> maven-ear-plugin.
> Example as attached:
> * module-jar
> * module-jar2 (with finalName)
> * module-war (has jar and jar2 as dependency)
> * module-ear (has jar as dependency)
> #> ./mvnw clean install
> The module-ear-0-SNAPSHOT.ear contains the
> com.example-module-war-0-SNAPSHOT.war. In this war both jar's are in folder
> WEB-INF/lib module-jar-0-SNAPSHOT.jar and module-jar2-0-SNAPSHOT.jar.
> On debugging maven-ear-plugin 3.1.0 it is checking only the finalName.jar and
> the name com.example-module-jar-0-SNAPSHOT.jar.
> Debugging -> EarMojo.java line 816 to 838
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MEAR-216) Unable to include dependencies of type test-jar
[
https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy closed MEAR-216.
--
Resolution: Fixed
PR #22 merged
thank you
> Unable to include dependencies of type test-jar
> ---
>
> Key: MEAR-216
> URL: https://issues.apache.org/jira/browse/MEAR-216
> Project: Maven EAR Plugin
> Issue Type: Improvement
>Affects Versions: 2.10
>Reporter: Maxim Frolov
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: test-jar-in-ear-2.zip, test-jar-in-ear.zip
>
>
> Please implement support for artifacts of type *test-jar*.
> One of the use cases would be to build a test EAR as a mix of production and
> test JARs where the test JARs are used to set up the test data used to test
> the production code.
> Currently including one or more dependencies of type test-jar causes
> *LifecycleExecutionException*:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml
> (default-generate-application-xml) on project suite-systemtests-common-ear:
> Failed to initialize ear modules: Unknown artifact type[test-jar] for
> artifact_id -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml
> (default-generate-application-xml) on project suite-systemtests-common-ear:
> Failed to initialize ear modules
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to
> initialize ear modules
> at
> org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:260)
> at
> org.apache.maven.plugin.ear.GenerateApplicationXmlMojo.execute(GenerateApplicationXmlMojo.java:162)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: org.apache.maven.plugin.ear.UnknownArtifactTypeException: Unknown
> artifact type[test-jar] for common-domain-impl
> at
> org.apache.maven.plugin.ear.EarModuleFactory.newEarModule(EarModuleFactory.java:88)
> at
> org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:250)
> ... 22 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] hboutemy commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs
hboutemy commented on pull request #22: URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-748583938 you're right, merged thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MEAR-216) Unable to include dependencies of type test-jar
[
https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MEAR-216:
---
Fix Version/s: (was: waiting-for-feedback)
> Unable to include dependencies of type test-jar
> ---
>
> Key: MEAR-216
> URL: https://issues.apache.org/jira/browse/MEAR-216
> Project: Maven EAR Plugin
> Issue Type: Improvement
>Affects Versions: 2.10
>Reporter: Maxim Frolov
>Priority: Major
> Fix For: 3.2.0
>
> Attachments: test-jar-in-ear-2.zip, test-jar-in-ear.zip
>
>
> Please implement support for artifacts of type *test-jar*.
> One of the use cases would be to build a test EAR as a mix of production and
> test JARs where the test JARs are used to set up the test data used to test
> the production code.
> Currently including one or more dependencies of type test-jar causes
> *LifecycleExecutionException*:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml
> (default-generate-application-xml) on project suite-systemtests-common-ear:
> Failed to initialize ear modules: Unknown artifact type[test-jar] for
> artifact_id -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-ear-plugin:2.10:generate-application-xml
> (default-generate-application-xml) on project suite-systemtests-common-ear:
> Failed to initialize ear modules
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:606)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to
> initialize ear modules
> at
> org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:260)
> at
> org.apache.maven.plugin.ear.GenerateApplicationXmlMojo.execute(GenerateApplicationXmlMojo.java:162)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: org.apache.maven.plugin.ear.UnknownArtifactTypeException: Unknown
> artifact type[test-jar] for common-domain-impl
> at
> org.apache.maven.plugin.ear.EarModuleFactory.newEarModule(EarModuleFactory.java:88)
> at
> org.apache.maven.plugin.ear.AbstractEarMojo.execute(AbstractEarMojo.java:250)
> ... 22 more
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-ear-plugin] hboutemy merged pull request #22: [MEAR-216] Handling test JARs as regular JARs
hboutemy merged pull request #22: URL: https://github.com/apache/maven-ear-plugin/pull/22 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MARCHETYPES-68) make build Reproducible
[ https://issues.apache.org/jira/browse/MARCHETYPES-68?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy closed MARCHETYPES-68. Resolution: Fixed > make build Reproducible > --- > > Key: MARCHETYPES-68 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-68 > Project: Maven Archetype Bundles > Issue Type: Improvement >Affects Versions: 1.4 >Reporter: Herve Boutemy >Assignee: Herve Boutemy >Priority: Major > Fix For: 1.5 > > > updating parent pom is not sufficient: requires archetype:jar Reproducible > Builds support from ARCHETYPE-590 -- This message was sent by Atlassian Jira (v8.3.4#803005)
