[GitHub] [maven-site] dependabot[bot] closed pull request #409: Bump maven-site-plugin from 4.0.0-M6 to 4.0.0-M7

2023-04-20 Thread via GitHub


dependabot[bot] closed pull request #409: Bump maven-site-plugin from 4.0.0-M6 
to 4.0.0-M7
URL: https://github.com/apache/maven-site/pull/409


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] dependabot[bot] commented on pull request #409: Bump maven-site-plugin from 4.0.0-M6 to 4.0.0-M7

2023-04-20 Thread via GitHub


dependabot[bot] commented on PR #409:
URL: https://github.com/apache/maven-site/pull/409#issuecomment-1517333418

   Looks like org.apache.maven.plugins:maven-site-plugin is up-to-date now, so 
this is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] olamy commented on pull request #409: Bump maven-site-plugin from 4.0.0-M6 to 4.0.0-M7

2023-04-20 Thread via GitHub


olamy commented on PR #409:
URL: https://github.com/apache/maven-site/pull/409#issuecomment-1517332995

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] olamy merged pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub


olamy merged PR #410:
URL: https://github.com/apache/maven-site/pull/410


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] dependabot[bot] merged pull request #411: Bump plantuml from 1.2023.5 to 1.2023.6

2023-04-20 Thread via GitHub


dependabot[bot] merged PR #411:
URL: https://github.com/apache/maven-site/pull/411


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Support for Java 9+

2023-04-20 Thread Rodrigo Bourbon
Hi, I'm currently working with Java 11 and my project relies upon the
maven-model  and
maven-model-builder
 artifacts.
The problem is that both have the package org.apache.maven.model.merge, hence
giving a split package issue when compiling with Java 9+. Is there any plan
on being compatible with Java 9+ in the short term? What alternatives do
you suggest?

Thanks in advance, Rodrigo.


[GitHub] [maven-site] michael-o commented on a diff in pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub


michael-o commented on code in PR #410:
URL: https://github.com/apache/maven-site/pull/410#discussion_r1173329710


##
content/markdown/docs/history.md.vm:
##
@@ -61,6 +61,13 @@ $b_
 
 ## Maven Releases History
 
+The Apache Maven team maintains the last version of the last two series of GA 
releases.
+If last release is 3.9.1, the Apache Maven team project will maintains core 
versions:

Review Comment:
   will maintain



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-compiler-plugin] marquiswang opened a new pull request, #186: [MCOMPILER-333] Clean generatedSourcesDirectory along with outputDirectory

2023-04-20 Thread via GitHub


marquiswang opened a new pull request, #186:
URL: https://github.com/apache/maven-compiler-plugin/pull/186

   The generatedSourcesDirectory (by default
   target/generated-sources/annotations) contains source code generated by 
annotation processors. These generated sources are also outputs of the 
compiler, and thus should be cleaned along with the class files in the 
outputDirectory, in order to correctly do incremental compilations.
   
   If this isn't done, then javac may not correctly compile the generated code, 
since it was there before. See
   
https://docs.oracle.com/en/java/javase/17/docs/specs/man/javac.html#annotation-processing
   
   See https://github.com/marquiswang/incremental-compile-dagger-test for a 
reproducing example.
   
   The bulk of the change here is in maven-shared-incremental, this just passes 
in the generated-sources directory to the call to the IncrementalBuildHelper.
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MCOMPILER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line 
and body.
- [X] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] elharo commented on a diff in pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub


elharo commented on code in PR #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r1173130660


##
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt:
##
@@ -826,12 +826,14 @@ Introduction to the Dependency Mechanism
 
  <<>>
 
- Dependencies with the scope  are always available and are not looked
- up in repository. They are usually used to tell Maven about dependencies which
- are provided by the JDK or the VM. Thus, system dependencies are especially
- useful for resolving dependencies on artifacts which are now provided by the
- JDK, but were available as separate downloads earlier. Typical examples are
- the JDBC standard extensions or the Java Authentication and Authorization
+ Dependencies with the scope  are not looked up in the Maven 
repository system.
+ Instead the `dependency` element contains a `systemPath` pointing to a jar on 
the local
+ file system.
+ 
+ The system scope is commonly used to tell Maven about dependencies provided 
by the JDK or the VM. 
+ System dependencies are especially useful for resolving dependencies on 
artifacts which
+ are now provided by the JDK, but were available as separate downloads 
earlier. Typical
+ examples are the JDBC standard extensions or the Java Authentication and 
Authorization

Review Comment:
   I think it is. Per Oracle docs, "The Java Authentication and Authorization 
Service (JAAS) was introduced as an optional package (extension) to the Java 2 
SDK, Standard Edition (J2SDK), v 1.3. JAAS was integrated into the J2SDK 1.4." 
Unless Oracle decides to remove it again, this statement seems likely to be 
true for the indefinite future. 
   
   Though now that I think about it, I don't really see how this helps to to 
tell Maven about dependencies provided by the JDK or the VM. If you're in a VM 
that includes them, this is unnecessary and if you're not then a system 
dependency doesn't help since it's not there. Maybe if you're compiling with 
JDK 1.5 but targeting 1.3 or something like that? 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MCOMPILER-333) Incremental compilation causes "mvn clean compile compile" to fail

2023-04-20 Thread Marquis Wang (Jira)


[ 
https://issues.apache.org/jira/browse/MCOMPILER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714763#comment-17714763
 ] 

Marquis Wang commented on MCOMPILER-333:


I have an example project that shows this:

https://github.com/marquiswang/incremental-compile-dagger-test

> Incremental compilation causes "mvn clean compile compile" to fail
> --
>
> Key: MCOMPILER-333
> URL: https://issues.apache.org/jira/browse/MCOMPILER-333
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Anthony Vanelverdinghe
>Priority: Major
>
> With true, my build 
> fails if I do "mvn clean compile compile". From the 
> [comment|https://issues.apache.org/jira/browse/MCOMPILER-205?focusedCommentId=16390065&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16390065]
>  in MCOMPILER-205, I understand that incremental compilation deletes the 
> "classes" directory. But it seems that it doesn't delete the 
> "generated-sources" directory.
> When I do "mvn clean compile" and "mvn compile", the second build fails. 
> However, if I delete the "generated-sources" directory between the 2 builds, 
> they both succeed.
> So I guess the bug here is that incremental compilation doesn't delete the 
> "generated-sources" directory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-site] olamy commented on pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub


olamy commented on PR #410:
URL: https://github.com/apache/maven-site/pull/410#issuecomment-1516945897

   thanks for review. changes applied


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shared-utils] slawekjaranowski commented on pull request #113: [MSHARED-1072] fix blocking in StreamFeeder

2023-04-20 Thread via GitHub


slawekjaranowski commented on PR #113:
URL: 
https://github.com/apache/maven-shared-utils/pull/113#issuecomment-1516939873

   @michael-o refresh with current master, conflict resolved
   Tomorrow I would to check again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] michael-o commented on a diff in pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub


michael-o commented on code in PR #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r1173019092


##
pom.xml:
##
@@ -55,7 +55,8 @@
 
   
 maven-site
-x

Review Comment:
   Spotless 1🤣



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] elharo commented on a diff in pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub


elharo commented on code in PR #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r1173015288


##
pom.xml:
##
@@ -55,7 +55,8 @@
 
   
 maven-site
-x

Review Comment:
   Yes, but necessary or the build breaks. I am less find of how spotless has 
been integrated every day. :-(



##
pom.xml:
##
@@ -55,7 +55,8 @@
 
   
 maven-site
-x

Review Comment:
   Yes, but necessary or the build breaks. I am less fond of how spotless has 
been integrated every day. :-(



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-shared-utils] michael-o commented on pull request #113: [MSHARED-1072] fix blocking in StreamFeeder

2023-04-20 Thread via GitHub


michael-o commented on PR #113:
URL: 
https://github.com/apache/maven-shared-utils/pull/113#issuecomment-1516826066

   @slawekjaranowski Do you want to pick this up? I want to relase Maven 
Release with this fix.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-remote-resources-plugin] michael-o commented on pull request #26: [MRRESOURCES-126] Get rid of legacy

2023-04-20 Thread via GitHub


michael-o commented on PR #26:
URL: 
https://github.com/apache/maven-remote-resources-plugin/pull/26#issuecomment-1516824599

   > As I see discussion here is about:
   > 
   > * what version will be next
   > 
   > * what name of goal should be
   > 
   > 
   > can we take such simple decision?
   > 
   > I hope gola name like `aggregate-process` will be ok - @michael-o ?
   
   I guess so.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] michael-o commented on a diff in pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub


michael-o commented on code in PR #410:
URL: https://github.com/apache/maven-site/pull/410#discussion_r1172990673


##
content/markdown/docs/history.md.vm:
##
@@ -61,6 +61,13 @@ $b_
 
 ## Maven Releases History
 
+Apache Maven supports the last version of the last two series of GA releases.
+If last release is 3.9.1, Apache Maven project will support core versions:

Review Comment:
   team



##
content/markdown/docs/history.md.vm:
##
@@ -61,6 +61,13 @@ $b_
 
 ## Maven Releases History
 
+Apache Maven supports the last version of the last two series of GA releases.
+If last release is 3.9.1, Apache Maven project will support core versions:

Review Comment:
   maintain



##
content/markdown/docs/history.md.vm:
##
@@ -61,6 +61,13 @@ $b_
 
 ## Maven Releases History
 
+Apache Maven supports the last version of the last two series of GA releases.

Review Comment:
   The Apache Maven team...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] michael-o commented on a diff in pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub


michael-o commented on code in PR #191:
URL: https://github.com/apache/maven-site/pull/191#discussion_r1172989881


##
content/apt/guides/introduction/introduction-to-dependency-mechanism.apt:
##
@@ -826,12 +826,14 @@ Introduction to the Dependency Mechanism
 
  <<>>
 
- Dependencies with the scope  are always available and are not looked
- up in repository. They are usually used to tell Maven about dependencies which
- are provided by the JDK or the VM. Thus, system dependencies are especially
- useful for resolving dependencies on artifacts which are now provided by the
- JDK, but were available as separate downloads earlier. Typical examples are
- the JDBC standard extensions or the Java Authentication and Authorization
+ Dependencies with the scope  are not looked up in the Maven 
repository system.
+ Instead the `dependency` element contains a `systemPath` pointing to a jar on 
the local
+ file system.
+ 
+ The system scope is commonly used to tell Maven about dependencies provided 
by the JDK or the VM. 
+ System dependencies are especially useful for resolving dependencies on 
artifacts which
+ are now provided by the JDK, but were available as separate downloads 
earlier. Typical
+ examples are the JDBC standard extensions or the Java Authentication and 
Authorization

Review Comment:
   I don't even know whether the cae with JDBC and JAAS is still true. I'd try 
to avoid giving example which are invalid in a couple of years.



##
pom.xml:
##
@@ -55,7 +55,8 @@
 
   
 maven-site
-x

Review Comment:
   Unrelated change



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MASSEMBLY-984) Refresh download page

2023-04-20 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MASSEMBLY-984:
-

 Summary: Refresh download page
 Key: MASSEMBLY-984
 URL: https://issues.apache.org/jira/browse/MASSEMBLY-984
 Project: Maven Assembly Plugin
  Issue Type: Task
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.5.1






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-site] rfscholte commented on pull request #191: docs: system dependencies are not always available

2023-04-20 Thread via GitHub


rfscholte commented on PR #191:
URL: https://github.com/apache/maven-site/pull/191#issuecomment-1516706265

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-compiler-plugin] slawekjaranowski commented on a diff in pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-04-20 Thread via GitHub


slawekjaranowski commented on code in PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#discussion_r1172841557


##
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##
@@ -1584,42 +1605,91 @@ private List resolveProcessorPathEntries() 
throws MojoExecutionException
 return null;
 }
 
-Set elements = new LinkedHashSet<>();
 try {
-List dependencies = 
convertToDependencies(annotationProcessorPaths);
+List dependencies = 
convertToDependencies(annotationProcessorPaths);
+List managedDependencies =
+getManagedDependenciesForAnnotationProcessorPaths();
 CollectRequest collectRequest =
-new CollectRequest(dependencies, Collections.emptyList(), 
project.getRemoteProjectRepositories());
+new CollectRequest(dependencies, managedDependencies, 
project.getRemoteProjectRepositories());
 DependencyRequest dependencyRequest = new DependencyRequest();
 dependencyRequest.setCollectRequest(collectRequest);
 DependencyResult dependencyResult =
 
repositorySystem.resolveDependencies(session.getRepositorySession(), 
dependencyRequest);
 
-for (ArtifactResult resolved : 
dependencyResult.getArtifactResults()) {
-
elements.add(resolved.getArtifact().getFile().getAbsolutePath());
-}
-return new ArrayList<>(elements);
+return dependencyResult.getArtifactResults().stream()
+.map(resolved -> 
resolved.getArtifact().getFile().getAbsolutePath())
+.collect(Collectors.toList());
 } catch (Exception e) {
 throw new MojoExecutionException(
 "Resolution of annotationProcessorPath dependencies 
failed: " + e.getLocalizedMessage(), e);
 }
 }
 
-private List convertToDependencies(List 
annotationProcessorPaths) {
-List dependencies = new ArrayList<>();
+private List convertToDependencies(
+List annotationProcessorPaths) throws 
MojoExecutionException {
+List dependencies = new 
ArrayList<>();
 for (DependencyCoordinate annotationProcessorPath : 
annotationProcessorPaths) {
 ArtifactHandler handler = 
artifactHandlerManager.getArtifactHandler(annotationProcessorPath.getType());
+String version = 
getAnnotationProcessorPathVersion(annotationProcessorPath);
 Artifact artifact = new DefaultArtifact(
 annotationProcessorPath.getGroupId(),
 annotationProcessorPath.getArtifactId(),
 annotationProcessorPath.getClassifier(),
 handler.getExtension(),
-annotationProcessorPath.getVersion());
+version);
 Set exclusions = 
convertToAetherExclusions(annotationProcessorPath.getExclusions());
-dependencies.add(new Dependency(artifact, JavaScopes.RUNTIME, 
false, exclusions));
+dependencies.add(new org.eclipse.aether.graph.Dependency(artifact, 
JavaScopes.RUNTIME, false, exclusions));
 }
 return dependencies;
 }
 
+private String getAnnotationProcessorPathVersion(DependencyCoordinate 
annotationProcessorPath)
+throws MojoExecutionException {
+String configuredVersion = annotationProcessorPath.getVersion();
+if (configuredVersion != null) {
+return configuredVersion;
+} else {
+List managedDependencies = 
getProjectManagedDependencies();
+return findManagedVersion(annotationProcessorPath, 
managedDependencies)
+.orElseThrow(() -> new 
MojoExecutionException(String.format(
+"Cannot find version for annotation processor path 
'%s'. The version needs to be either"
++ " provided directly in the plugin 
configuration or via dependency management.",
+annotationProcessorPath)));
+}
+}
+
+private Optional findManagedVersion(
+DependencyCoordinate dependencyCoordinate, List 
managedDependencies) {
+return managedDependencies.stream()
+.filter(dep -> Objects.equals(dep.getGroupId(), 
dependencyCoordinate.getGroupId())
+&& Objects.equals(dep.getArtifactId(), 
dependencyCoordinate.getArtifactId())
+&& Objects.equals(dep.getClassifier(), 
dependencyCoordinate.getClassifier())
+&& Objects.equals(dep.getType(), 
dependencyCoordinate.getType()))
+.findAny()
+.map(org.apache.maven.model.Dependency::getVersion);
+}

Review Comment:
   ok, we can go as is - if we need we can tray with `parallelStream` next time 
😄 



-- 
This is an automated message from the Apache Git Se

[GitHub] [maven-compiler-plugin] psiroky commented on pull request #180: [MCOMPILER-391] Use dep mgmt when resolving annotation processors and their deps

2023-04-20 Thread via GitHub


psiroky commented on PR #180:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/180#issuecomment-1516621512

   I can update the docs, based on the comments above. Besides that, the PR 
should be ready from my point of view. Please let me know if there is anything 
else that would need changing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-dist-tool] dependabot[bot] closed pull request #30: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M6

2023-04-20 Thread via GitHub


dependabot[bot] closed pull request #30: Bump maven-reporting-exec from 
2.0.0-M1 to 2.0.0-M6
URL: https://github.com/apache/maven-dist-tool/pull/30


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-dist-tool] dependabot[bot] commented on pull request #30: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M6

2023-04-20 Thread via GitHub


dependabot[bot] commented on PR #30:
URL: https://github.com/apache/maven-dist-tool/pull/30#issuecomment-1516282008

   Superseded by #33.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-dist-tool] dependabot[bot] opened a new pull request, #33: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M7

2023-04-20 Thread via GitHub


dependabot[bot] opened a new pull request, #33:
URL: https://github.com/apache/maven-dist-tool/pull/33

   Bumps [maven-reporting-exec](https://github.com/apache/maven-reporting-exec) 
from 2.0.0-M1 to 2.0.0-M7.
   
   Commits
   
   https://github.com/apache/maven-reporting-exec/commit/699d9f91d69ed4b2a8ad3d3e21acb369875b4b59";>699d9f9
 [maven-release-plugin] prepare release maven-reporting-exec-2.0.0-M7
   https://github.com/apache/maven-reporting-exec/commit/fd7bcfe0ecc584e54e52c48885d380ca5fff0929";>fd7bcfe
 Improve log messages for consistency
   https://github.com/apache/maven-reporting-exec/commit/371597fe1f3fd5e0e7de1c1618c1c82d065f0d63";>371597f
 [MSHARED-1242] Upgrade to Doxia Sitetools 2.0.0-M8
   https://github.com/apache/maven-reporting-exec/commit/a920df84fe5836dc9111291bfed9a117fd6c3587";>a920df8
 [MSHARED-1241] Upgrade plugins and components in ITs
   https://github.com/apache/maven-reporting-exec/commit/12d9399f7776c40f7d610654a19a4e7ec5416173";>12d9399
 [MSHARED-1236] Supply execution id of caller (Maven Site Plugin) to 
MavenRepo...
   https://github.com/apache/maven-reporting-exec/commit/df1da619a4567bf18ac48c6eaf4ecac6c51ac4c9";>df1da61
 [MSHARED-1235] Upgrade to Maven Reporting API 4.0.0-M6
   https://github.com/apache/maven-reporting-exec/commit/04e4df278204dba5b83589bb98375a658d9bcb16";>04e4df2
 [maven-release-plugin] prepare for next development iteration
   https://github.com/apache/maven-reporting-exec/commit/1ad10a49b596b691e053bd47c6ab59d9369552f8";>1ad10a4
 [maven-release-plugin] prepare release maven-reporting-exec-2.0.0-M6
   https://github.com/apache/maven-reporting-exec/commit/fdc238b52ddac19ee7d24c4409bd191ff08ae4ac";>fdc238b
 [MSHARED-1223] Upgrade to Maven Reporting Impl 4.0.0-M6 in ITs
   https://github.com/apache/maven-reporting-exec/commit/51918ff1092bcb347d60a6fbe8f7becbd3bab5c1";>51918ff
 [MSHARED-1222] Upgrade to Doxia Sitetools 2.0.0-M7
   Additional commits viewable in https://github.com/apache/maven-reporting-exec/compare/maven-reporting-exec-2.0.0-M1...maven-reporting-exec-2.0.0-M7";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.reporting:maven-reporting-exec&package-manager=maven&previous-version=2.0.0-M1&new-version=2.0.0-M7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-assembly-plugin] slawekjaranowski opened a new pull request, #132: [MASSEMBLY-974] Drop deprecated repository element from documentation

2023-04-20 Thread via GitHub


slawekjaranowski opened a new pull request, #132:
URL: https://github.com/apache/maven-assembly-plugin/pull/132

   Code was removed in 6c7b43c4e5a96bef884131e87b00942e5cd901dc 
   We should update documentation according to change.
   
   ---
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [x] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MASSEMBLY) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line 
and body.
- [x] Format the pull request title like `[MASSEMBLY-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MASSEMBLY-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [x] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [x] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] cstamas commented on a diff in pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub


cstamas commented on code in PR #410:
URL: https://github.com/apache/maven-site/pull/410#discussion_r1172522941


##
content/markdown/docs/history.md.vm:
##
@@ -61,6 +61,13 @@ $b_
 
 ## Maven Releases History
 
+Apache Maven supports the last version of the last two series of GA releases.

Review Comment:
   supports -> maintains



##
content/markdown/docs/history.md.vm:
##
@@ -61,6 +61,13 @@ $b_
 
 ## Maven Releases History
 
+Apache Maven supports the last version of the last two series of GA releases.
+If last release is 3.9.1, Apache Maven project will support core versions:
+- 3.9.1
+- 3.8.7
+
+Currently, plugins support Maven API compatibility down to 3.2.5.

Review Comment:
   support -> provides



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] cstamas commented on pull request #410: document core is EOL before 3.8.8 (e.g we will not provide core release for bugs nor security issues).

2023-04-20 Thread via GitHub


cstamas commented on PR #410:
URL: https://github.com/apache/maven-site/pull/410#issuecomment-1516248064

   Agreed with @slawekjaranowski : we do not "support", we "maintain". 
Supporting something sounds to me like some contractual obligation, while we do 
not offer and "support contract" at all...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-pmd-plugin] elharo commented on pull request #124: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

2023-04-20 Thread via GitHub


elharo commented on PR #124:
URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1516150217

   In fact, now that I think about it, we should pause these changes until 
Moderne does sign the corporate CLA. An Individual CLA is insufficient given 
the co-authorship line. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-pmd-plugin] elharo commented on pull request #124: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

2023-04-20 Thread via GitHub


elharo commented on PR #124:
URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1516148340

   The "co-authored" message has the potential to cause licensing and ownership 
issues. Alternately, Moderne could assign the  corporate CLA: 
https://www.apache.org/licenses/cla-corporate.pdf


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-pmd-plugin] elharo commented on pull request #120: [MNG-6825] Replace StringUtils with Commons Lang3

2023-04-20 Thread via GitHub


elharo commented on PR #120:
URL: https://github.com/apache/maven-pmd-plugin/pull/120#issuecomment-1516145992

   sure, if this is still relevant, do it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-gpg-plugin] michael-o commented on a diff in pull request #45: extract FilesCollector

2023-04-20 Thread via GitHub


michael-o commented on code in PR #45:
URL: https://github.com/apache/maven-gpg-plugin/pull/45#discussion_r1172426963


##
src/main/java/org/apache/maven/plugins/gpg/FilesCollector.java:
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.gpg;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.MojoFailureException;
+import org.apache.maven.plugin.logging.Log;
+import org.apache.maven.project.MavenProject;
+import org.codehaus.plexus.util.FileUtils;
+import org.codehaus.plexus.util.SelectorUtils;
+
+/**
+ * Collects project artifact, the POM, and attached artifacts to be signed.
+ *
+ * @since 3.1.0
+ */
+public class FilesCollector {
+private final MavenProject project;
+
+private static final String DEFAULT_EXCLUDES[] =
+new String[] {"**/*.md5", "**/*.sha1", "**/*.sha256", 
"**/*.sha512", "**/*.asc"};

Review Comment:
   Since this is generic, maybe one needs to add `.sig` and `.crt` as well?



##
src/main/java/org/apache/maven/plugins/gpg/FilesCollector.java:
##
@@ -0,0 +1,178 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.gpg;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.MojoFailureException;
+import org.apache.maven.plugin.logging.Log;
+import org.apache.maven.project.MavenProject;
+import org.codehaus.plexus.util.FileUtils;
+import org.codehaus.plexus.util.SelectorUtils;
+
+/**
+ * Collects project artifact, the POM, and attached artifacts to be signed.
+ *
+ * @since 3.1.0
+ */
+public class FilesCollector {
+private final MavenProject project;
+
+private static final String DEFAULT_EXCLUDES[] =
+new String[] {"**/*.md5", "**/*.sha1", "**/*.sha256", 
"**/*.sha512", "**/*.asc"};
+
+private final String[] excludes;
+
+private final Log log;
+
+public FilesCollector(MavenProject project, String[] excludes, Log log) {
+this.project = project;
+this.log = log;
+if (excludes == null || excludes.length == 0) {
+this.excludes = DEFAULT_EXCLUDES;
+return;
+}
+String newExcludes[] = new String[excludes.length];
+for (int i = 0; i < excludes.length; i++) {
+String pattern;
+pattern = excludes[i].trim().replace('/', 
File.separatorChar).replace('\\', File.separatorChar);
+if (pattern.endsWith(File.separator)) {
+pattern += "**";
+}
+newExcludes[i] = pattern;
+}
+this.excludes = newExcludes;
+}
+
+public List collect() throws MojoExecutionException, 
MojoFailureException {
+List items = new ArrayList<>();
+
+if (!"pom".equals(project.getPackaging())) {
+// 

+// Project artifact
+// 

+
+Artifact artif

[jira] [Closed] (MNG-7038) Introduce public properties to point to the root and top directories of (multi-module) project

2023-04-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet closed MNG-7038.

Resolution: Fixed

> Introduce public properties to point to the root and top directories of 
> (multi-module) project
> --
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
>  Issue Type: Improvement
>Reporter: Envious Guest
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-6
>
>
> This issue introduces three properties:
>  * {{project.rootDirectory}}: {_}the project's directory or parent directory 
> containing a {{.mvn}} subdirectory or a {{pom.xml}} flagged with the 
> {{root="true"}} attribute{_}. If no such directory can be found, accessing 
> the rootDirectory property will throw an `IllegalStateException`.
>  * {{session.topDirectory}} : {_}the directory of the topmost project being 
> built, usually the current directory or the directory pointed at by the 
> {{\-f}}/{{\-\-file}} command line argument{_}. The {{topDirectory}} is 
> similar to the {{executionRootDirectory}} property available on the session, 
> but renamed to make it coherent with the new {{rootDirectory}} and to avoid 
> using _root_ in its name. The {{topDirectory}} property is computed by the 
> CLI as the directory pointed at by the {{\-f}}/{{\-\-file}} command line 
> argument, or the current directory if there's no such argument.
>  * {{session.rootDirectory}} : {_}the rootDirectory for the topDirectory 
> project{_}.
> The {{topDirectory}} and {{rootDirectory}} properties are made available on 
> the {{MavenSession}} / {{Session}} and deprecate the 
> {{executionRootDirectory}} and {{multiModuleProjectDirectory}} properties. 
> The {{rootDirectory}} should never change for a given project and is thus 
> made available for profile activation and model interpolation (without the 
> {{project.}} prefix, similar to {{basedir}}). The goal is also to make the 
> {{rootDirectory}} property also available during [command line arguments 
> interpolation|https://issues.apache.org/jira/browse/MNG-6303].
> A {{root}} boolean attribute is also added to the model to indicate that the 
> project is the root project. This attribute is only supported if the 
> _buildconsumer_ feature is active and removed before the pom is installed or 
> deployed. It can be used as an alternative mechanism to the {{.mvn}} 
> directory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNG-7038) Introduce public properties to point to the root and top directories of (multi-module) project

2023-04-20 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714542#comment-17714542
 ] 

ASF GitHub Bot commented on MNG-7038:
-

gnodet merged PR #1061:
URL: https://github.com/apache/maven/pull/1061




> Introduce public properties to point to the root and top directories of 
> (multi-module) project
> --
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
>  Issue Type: Improvement
>Reporter: Envious Guest
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-6
>
>
> This issue introduces three properties:
>  * {{project.rootDirectory}}: {_}the project's directory or parent directory 
> containing a {{.mvn}} subdirectory or a {{pom.xml}} flagged with the 
> {{root="true"}} attribute{_}. If no such directory can be found, accessing 
> the rootDirectory property will throw an `IllegalStateException`.
>  * {{session.topDirectory}} : {_}the directory of the topmost project being 
> built, usually the current directory or the directory pointed at by the 
> {{\-f}}/{{\-\-file}} command line argument{_}. The {{topDirectory}} is 
> similar to the {{executionRootDirectory}} property available on the session, 
> but renamed to make it coherent with the new {{rootDirectory}} and to avoid 
> using _root_ in its name. The {{topDirectory}} property is computed by the 
> CLI as the directory pointed at by the {{\-f}}/{{\-\-file}} command line 
> argument, or the current directory if there's no such argument.
>  * {{session.rootDirectory}} : {_}the rootDirectory for the topDirectory 
> project{_}.
> The {{topDirectory}} and {{rootDirectory}} properties are made available on 
> the {{MavenSession}} / {{Session}} and deprecate the 
> {{executionRootDirectory}} and {{multiModuleProjectDirectory}} properties. 
> The {{rootDirectory}} should never change for a given project and is thus 
> made available for profile activation and model interpolation (without the 
> {{project.}} prefix, similar to {{basedir}}). The goal is also to make the 
> {{rootDirectory}} property also available during [command line arguments 
> interpolation|https://issues.apache.org/jira/browse/MNG-6303].
> A {{root}} boolean attribute is also added to the model to indicate that the 
> project is the root project. This attribute is only supported if the 
> _buildconsumer_ feature is active and removed before the pom is installed or 
> deployed. It can be used as an alternative mechanism to the {{.mvn}} 
> directory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] gnodet merged pull request #1061: [MNG-7038] Introduce public property to point to a root directory of (multi-module) project

2023-04-20 Thread via GitHub


gnodet merged PR #1061:
URL: https://github.com/apache/maven/pull/1061


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-integration-testing] gnodet merged pull request #254: [MNG-7038] Introduce project.rootdir, session.topdir and session.rootdir

2023-04-20 Thread via GitHub


gnodet merged PR #254:
URL: https://github.com/apache/maven-integration-testing/pull/254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-compiler-plugin] olamy commented on pull request #185: Bump maven-invoker-plugin from 3.5.0 to 3.5.1

2023-04-20 Thread via GitHub


olamy commented on PR #185:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/185#issuecomment-1516112620

   @dependabot recreate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-compiler-plugin] dependabot[bot] commented on pull request #185: Bump maven-invoker-plugin from 3.5.0 to 3.5.1

2023-04-20 Thread via GitHub


dependabot[bot] commented on PR #185:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/185#issuecomment-151611

   Looks like this PR is already up-to-date with master! If you'd still like to 
recreate it from scratch, overwriting any edits, you can request `@dependabot 
recreate`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-compiler-plugin] olamy commented on pull request #185: Bump maven-invoker-plugin from 3.5.0 to 3.5.1

2023-04-20 Thread via GitHub


olamy commented on PR #185:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/185#issuecomment-1516112176

   @dependabot rebase


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-pmd-plugin] timtebeek commented on pull request #120: [MNG-6825] Replace StringUtils with Commons Lang3

2023-04-20 Thread via GitHub


timtebeek commented on PR #120:
URL: https://github.com/apache/maven-pmd-plugin/pull/120#issuecomment-1516024167

   Would you like to see this recreated now that we have 
https://github.com/apache/maven-pmd-plugin/commit/40feea805e76b77446742c4278fabd7aff51
 merged in? It'd swap even fewer imports, with no new dependency as 
commons-lang3 is already a dependency. 
https://github.com/apache/maven-pmd-plugin/blob/40feea805e76b77446742c4278fabd7aff51/pom.xml#L148-L150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MWRAPPER-108) mvnw script fails silently when download fails

2023-04-20 Thread selckin (Jira)
selckin created MWRAPPER-108:


 Summary: mvnw script fails silently when download fails
 Key: MWRAPPER-108
 URL: https://issues.apache.org/jira/browse/MWRAPPER-108
 Project: Maven Wrapper
  Issue Type: Bug
  Components: Maven Wrapper Scripts
Affects Versions: 3.2.0
Reporter: selckin


The wrapper only-mvnw script fail silently when the download fails, giving a 
cryptic error when trying to run mvn 

https://github.com/apache/maven-wrapper/pull/98



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-wrapper] selckin opened a new pull request, #98: only-mvnw add error checking when download or unpacking fails

2023-04-20 Thread via GitHub


selckin opened a new pull request, #98:
URL: https://github.com/apache/maven-wrapper/pull/98

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MWRAPPER-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MNG-7038) Introduce public properties to point to the root and top directories of (multi-module) project

2023-04-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7038:
-
Summary: Introduce public properties to point to the root and top 
directories of (multi-module) project  (was: Introduce public property to point 
to a root directory of (multi-module) project)

> Introduce public properties to point to the root and top directories of 
> (multi-module) project
> --
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
>  Issue Type: Improvement
>Reporter: Envious Guest
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-6
>
>
> This issue introduces three properties:
>  * {{project.rootDirectory}}: {_}the project's directory or parent directory 
> containing a {{.mvn}} subdirectory or a {{pom.xml}} flagged with the 
> {{root="true"}} attribute{_}. If no such directory can be found, accessing 
> the rootDirectory property will throw an `IllegalStateException`.
>  * {{session.topDirectory}} : {_}the directory of the topmost project being 
> built, usually the current directory or the directory pointed at by the 
> {{\-f}}/{{\-\-file}} command line argument{_}. The {{topDirectory}} is 
> similar to the {{executionRootDirectory}} property available on the session, 
> but renamed to make it coherent with the new {{rootDirectory}} and to avoid 
> using _root_ in its name. The {{topDirectory}} property is computed by the 
> CLI as the directory pointed at by the {{\-f}}/{{\-\-file}} command line 
> argument, or the current directory if there's no such argument.
>  * {{session.rootDirectory}} : {_}the rootDirectory for the topDirectory 
> project{_}.
> The {{topDirectory}} and {{rootDirectory}} properties are made available on 
> the {{MavenSession}} / {{Session}} and deprecate the 
> {{executionRootDirectory}} and {{multiModuleProjectDirectory}} properties. 
> The {{rootDirectory}} should never change for a given project and is thus 
> made available for profile activation and model interpolation (without the 
> {{project.}} prefix, similar to {{basedir}}). The goal is also to make the 
> {{rootDirectory}} property also available during [command line arguments 
> interpolation|https://issues.apache.org/jira/browse/MNG-6303].
> A {{root}} boolean attribute is also added to the model to indicate that the 
> project is the root project. This attribute is only supported if the 
> _buildconsumer_ feature is active and removed before the pom is installed or 
> deployed. It can be used as an alternative mechanism to the {{.mvn}} 
> directory.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MNG-7038) Introduce public property to point to a root directory of (multi-module) project

2023-04-20 Thread Guillaume Nodet (Jira)


 [ 
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Guillaume Nodet updated MNG-7038:
-
Description: 
This issue introduces three properties:
 * {{project.rootDirectory}}: {_}the project's directory or parent directory 
containing a {{.mvn}} subdirectory or a {{pom.xml}} flagged with the 
{{root="true"}} attribute{_}. If no such directory can be found, accessing the 
rootDirectory property will throw an `IllegalStateException`.

 * {{session.topDirectory}} : {_}the directory of the topmost project being 
built, usually the current directory or the directory pointed at by the 
{{\-f}}/{{\-\-file}} command line argument{_}. The {{topDirectory}} is similar 
to the {{executionRootDirectory}} property available on the session, but 
renamed to make it coherent with the new {{rootDirectory}} and to avoid using 
_root_ in its name. The {{topDirectory}} property is computed by the CLI as the 
directory pointed at by the {{\-f}}/{{\-\-file}} command line argument, or the 
current directory if there's no such argument.

 * {{session.rootDirectory}} : {_}the rootDirectory for the topDirectory 
project{_}.

The {{topDirectory}} and {{rootDirectory}} properties are made available on the 
{{MavenSession}} / {{Session}} and deprecate the {{executionRootDirectory}} and 
{{multiModuleProjectDirectory}} properties. The {{rootDirectory}} should never 
change for a given project and is thus made available for profile activation 
and model interpolation (without the {{project.}} prefix, similar to 
{{basedir}}). The goal is also to make the {{rootDirectory}} property also 
available during [command line arguments 
interpolation|https://issues.apache.org/jira/browse/MNG-6303].

A {{root}} boolean attribute is also added to the model to indicate that the 
project is the root project. This attribute is only supported if the 
_buildconsumer_ feature is active and removed before the pom is installed or 
deployed. It can be used as an alternative mechanism to the {{.mvn}} directory.

  was:
This is a request to expose a property *maven.multiModuleProjectDirectory* 
which is currently internal (or introduce a brand new one with analogous 
functionality).
 * For a single-module project, its value should be same as *project.basedir*
 * For multi-module project, its value should point to a project.basedir of a 
root module

Example:

multi-module // located at /home/me/sources
 +- module-a
 +- module B

Sample multi-module/pom.xml: 

{{}}
 {{    }}
 {{        com.acme}}
 {{        corp-parent}}
 {{        1.0.0-RELEASE}}
 {{    }}
 {{    com.acme}}
 {{        multi-module}}
 {{        0.5.2-SNAPSHOT}}
 {{    }}
 {{        module-a}}
 {{        module-b}}
 {{    }}
 {{}}

The property requested should return /home/me/sources/multi-module, regardless 
of whether it's referenced in any of the child modules (module-a, module-b) or 
in multi-module.

Note that multi-module itself has parent (e.g. installed in a local 
repository), so the new property should be smart enough to detect it and still 
point to /home/me/sources/multi-module instead of the local repository where 
the corp-parent is installed.

The use-case for such a property could be to have a directory for combined 
report of static analysis tools. Typical example - jacoco combined coverage 
reports.


> Introduce public property to point to a root directory of (multi-module) 
> project
> 
>
> Key: MNG-7038
> URL: https://issues.apache.org/jira/browse/MNG-7038
> Project: Maven
>  Issue Type: Improvement
>Reporter: Envious Guest
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-6
>
>
> This issue introduces three properties:
>  * {{project.rootDirectory}}: {_}the project's directory or parent directory 
> containing a {{.mvn}} subdirectory or a {{pom.xml}} flagged with the 
> {{root="true"}} attribute{_}. If no such directory can be found, accessing 
> the rootDirectory property will throw an `IllegalStateException`.
>  * {{session.topDirectory}} : {_}the directory of the topmost project being 
> built, usually the current directory or the directory pointed at by the 
> {{\-f}}/{{\-\-file}} command line argument{_}. The {{topDirectory}} is 
> similar to the {{executionRootDirectory}} property available on the session, 
> but renamed to make it coherent with the new {{rootDirectory}} and to avoid 
> using _root_ in its name. The {{topDirectory}} property is computed by the 
> CLI as the directory pointed at by the {{\-f}}/{{\-\-file}} command line 
> argument, or the current directory if there's no such argument.
>  * {{session.rootDirectory}} : {_}the rootDirectory for the topDirectory 
> project{_}.
> The {{topDirectory}} and {{rootDirectory}} properties are made available on 
>

[GitHub] [maven-pmd-plugin] timtebeek commented on pull request #124: [MNG-6829] Replace any StringUtils#isEmpty(String) and #isNotEmpty(String)

2023-04-20 Thread via GitHub


timtebeek commented on PR #124:
URL: https://github.com/apache/maven-pmd-plugin/pull/124#issuecomment-1515932350

   > You can assign these reviews to me. I might not get to all of them this 
quickly but they're not hard to review.
   
   Appreciate it! I'll start with the project that benefit the most; then work 
my way down to the long tail of incidental usage, as soon as we check off the 
following item:
   
   > I would like it if you can amend the commit messages so they no longer say 
"Co-authored-by: Moderne".
   
   The only way I can change this now would be to manually amend the commits, 
which I'd like to avoid given that I'd like to keep these changes automated as 
much as possible.
   
   Is there anything in particular you don't like about the co-authored?
   
   For what it's worth: from our users we hear that they like being able to 
distinguish between automated and manual changes. The former are broad sweeping 
changes with a typically narrow scope, whereas large manual changes can be more 
error-prone. Recording this as co-authored was then one of the few ways to 
capture this in GitHub.
   
   > Longer term, we might want to look into a flow analysis tool that can tell 
us when the null checks are unneeded, but baby steps for now.
   
   Agree with the approach at making gradual changes here; We have some 
capabilities and recipes in this space, that we can explore once we get this 
initial batch through. I'll likely do a write up on the mailinglist at some 
point with what's already been done, and what we can possibly do next, if 
there's interest in further changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-build-cache-extension] dependabot[bot] opened a new pull request, #71: Bump logback-classic from 1.3.6 to 1.3.7

2023-04-20 Thread via GitHub


dependabot[bot] opened a new pull request, #71:
URL: https://github.com/apache/maven-build-cache-extension/pull/71

   Bumps [logback-classic](https://github.com/qos-ch/logback) from 1.3.6 to 
1.3.7.
   
   Commits
   
   https://github.com/qos-ch/logback/commit/14d868a2cba2d0fb431e4d84bed10e307cf7d36c";>14d868a
 prepare release 1.3.7
   https://github.com/qos-ch/logback/commit/e3d271c6b6b0e5ca549e43304f8e87ff3746a691";>e3d271c
 javadoc edits in CoreConstants
   https://github.com/qos-ch/logback/commit/93d2acbe14771e062791b94efffd2454b8bbbfae";>93d2acb
 disable test using removed methods
   https://github.com/qos-ch/logback/commit/bcca7c00fa4f1c7cad6da377a101ce3a4a7de09c";>bcca7c0
 reenable tests
   https://github.com/qos-ch/logback/commit/08d71b18ed5e697e8d7a17d65fc86052c41c86b7";>08d71b1
 fix LOGBACK-1716 by adding a ThreadPoolExecutor in addition to the 
ScheduledE...
   https://github.com/qos-ch/logback/commit/4ba059492c60b48775fdac8061da7b5511b15334";>4ba0594
 Use preferred 'version_cleanup' BND macro instead of 'maven_version'
   https://github.com/qos-ch/logback/commit/d72cbb17b13adc653e8a2fae38f9195e78abd8e3";>d72cbb1
 Ensure proper version ranges of re-imported OSGi packages
   https://github.com/qos-ch/logback/commit/055aea0d8162eb0f262dc13edeeaeb1c1205bf7a";>055aea0
 Remove export of obsolete/removed package 'org.slf4j.impl' in OSGi
   https://github.com/qos-ch/logback/commit/1418273daec9f57d103729945a3aef0c30c839fe";>1418273
 Fix LOGBACK-1729: Add OSGi S.L.M. entries to load logback Configurators
   https://github.com/qos-ch/logback/commit/52cf6cd01f3a9ed6224338699deffbd06e5ae59d";>52cf6cd
 Fix LOGBACK-1728: Incorrect OSGi execution-environment requirements
   Additional commits viewable in https://github.com/qos-ch/logback/compare/v_1.3.6...v_1.3.7";>compare 
view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ch.qos.logback:logback-classic&package-manager=maven&previous-version=1.3.6&new-version=1.3.7)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MRELEASE-1103) Decryption of server password in settings.xml failed (works with 2.5.3)

2023-04-20 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRELEASE-1103.

  Assignee: Tamas Cservenak
Resolution: Fixed

Fixed with 
[24806642cb24469228c9a56f383ccab4af52c0cc|https://gitbox.apache.org/repos/asf?p=maven-release.git&a=commit&h=24806642cb24469228c9a56f383ccab4af52c0cc].

> Decryption of server password in settings.xml failed (works with 2.5.3)
> ---
>
> Key: MRELEASE-1103
> URL: https://issues.apache.org/jira/browse/MRELEASE-1103
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Robert Seidel
>Assignee: Tamas Cservenak
>Priority: Blocker
> Fix For: 3.0.1
>
>
> A server section was defined in the settings.xml at 
>  with id, username and password to connect to a 
> Bitbucket server.
> In the pom.xml the id was referenced in the properties via project.scm.id.
> With 2.5.3 the build is running fine, but with 3.0.06-M6 the following 
> happens:
> *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be 
> activated because it does not exist.
> *11:35:40* [INFO] 11/17 prepare:scm-commit-release
> *11:35:40* [INFO] Checking in modified POMs...
> *11:35:40* [WARNING] Failed to decrypt password/passphrase for server 
> bitbucket-prod, using auth token as is: decrypt failed
> and in the aftermath:
> *11:35:41* [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) 
> on project ExamplePom: Unable to commit files
> *11:35:41* [ERROR] Provider message:
> *11:35:41* [ERROR] The git-push command failed.
> *11:35:41* [ERROR] Command output:
> *11:35:41* [ERROR] fatal: Authentication failed for 
> '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]'
>  
> JDK used was Adoptium 17 (but with 11 the same problem occured).
> Maven used was 3.8.6.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-release] asfgit closed pull request #181: [MRELEASE-1103] Wrong file path used for master pw file

2023-04-20 Thread via GitHub


asfgit closed pull request #181: [MRELEASE-1103] Wrong file path used for 
master pw file
URL: https://github.com/apache/maven-release/pull/181


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MRELEASE-1103) Decryption of server password in settings.xml failed (works with 2.5.3)

2023-04-20 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MRELEASE-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRELEASE-1103:
-
Summary: Decryption of server password in settings.xml failed (works with 
2.5.3)  (was: decryption of server password in settings.xml failed (works with 
2.5.3))

> Decryption of server password in settings.xml failed (works with 2.5.3)
> ---
>
> Key: MRELEASE-1103
> URL: https://issues.apache.org/jira/browse/MRELEASE-1103
> Project: Maven Release Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Robert Seidel
>Priority: Blocker
> Fix For: 3.0.1
>
>
> A server section was defined in the settings.xml at 
>  with id, username and password to connect to a 
> Bitbucket server.
> In the pom.xml the id was referenced in the properties via project.scm.id.
> With 2.5.3 the build is running fine, but with 3.0.06-M6 the following 
> happens:
> *11:35:40* [INFO] [WARNING] The requested profile "distribute" could not be 
> activated because it does not exist.
> *11:35:40* [INFO] 11/17 prepare:scm-commit-release
> *11:35:40* [INFO] Checking in modified POMs...
> *11:35:40* [WARNING] Failed to decrypt password/passphrase for server 
> bitbucket-prod, using auth token as is: decrypt failed
> and in the aftermath:
> *11:35:41* [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-release-plugin:3.0.0-M6:prepare (default-cli) 
> on project ExamplePom: Unable to commit files
> *11:35:41* [ERROR] Provider message:
> *11:35:41* [ERROR] The git-push command failed.
> *11:35:41* [ERROR] Command output:
> *11:35:41* [ERROR] fatal: Authentication failed for 
> '[https://prod.bitbucket/scm/cp/examplepom.git/|https://git.aeb.com/bitbucket/scm/cp/aebparentpom.git/]'
>  
> JDK used was Adoptium 17 (but with 11 the same problem occured).
> Maven used was 3.8.6.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-release] asfgit closed pull request #182: [MRELEASE-851]: javaHome argument is now honored in InvokerMavenExecutor

2023-04-20 Thread via GitHub


asfgit closed pull request #182: [MRELEASE-851]: javaHome argument is now 
honored in InvokerMavenExecutor
URL: https://github.com/apache/maven-release/pull/182


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MCHECKSTYLE-425) Checkstyle runs fail with "Path contains invalid character" since 3.2.0

2023-04-20 Thread Magnus Reftel (Jira)


[ 
https://issues.apache.org/jira/browse/MCHECKSTYLE-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714459#comment-17714459
 ] 

Magnus Reftel commented on MCHECKSTYLE-425:
---

Thank you for the analysis! I´ve reported it as 
[https://github.com/checkstyle/checkstyle/issues/13012] .

> Checkstyle runs fail with "Path contains invalid character" since 3.2.0
> ---
>
> Key: MCHECKSTYLE-425
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-425
> Project: Maven Checkstyle Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.0
>Reporter: Magnus Reftel
>Priority: Major
> Attachments: maven-checkstyle-plugin_stacktrace.txt, testcase.zip
>
>
> The maven-checkstyle-plugin fails on maven projects whose file system path 
> contains the letter "ø" in versions 3.2.0, 3.2.1 and on master. Version 3.1.2 
> works fine.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)