[jira] Commented: (MECLIPSE-377) eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than once in a multi-project
[ http://jira.codehaus.org/browse/MECLIPSE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=157546#action_157546 ] Julien Renaut commented on MECLIPSE-377: Great work. But I insist that maybe this kind of information should be provided by the maven metadata. It doesn't seem too dfficult for the metadata to be aware of available attachments and provide some way to query that information programmaticaly. But that's not the responsability of the eclipse-plugin project. The solution you're implementing will do for now I guess. > eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than > once in a multi-project > --- > > Key: MECLIPSE-377 > URL: http://jira.codehaus.org/browse/MECLIPSE-377 > Project: Maven 2.x Eclipse Plugin > Issue Type: Bug > Components: Core : Dependencies resolution and build path > (.classpath), Core : Multi-projects >Affects Versions: 2.4 >Reporter: Steinar Bang >Assignee: Barrie Treloar > Fix For: 2.6 > > > If you run "mvn eclipse:eclipse -DdownloadSources=true" it attempts to > download source jars for all projects, even when it has tried (and failed) to > download the jars in earlier projects. This slows down the goal a lot on > slow network connections. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-377) eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than once in a multi-project
[ http://jira.codehaus.org/browse/MECLIPSE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=155733#action_155733 ] Julien Renaut commented on MECLIPSE-377: That is probably more interesting than dropping the entire artifact cache but it looks a bit trickier to implement. Getting the cache for a given artifact could be retrieved based on the artifact physical location. BUT, if that's the kind of information we want to retrieve from our artifacts (whether there is a source attachment, or a javadoc atachment, or even a custom attachment) then it's the maven metadata that should indicate the existence of given attachments. This way, the eclipse plugin would just query the metada about existing attachments and easily discover if a given source or javadoc can be retrieved instead of maintening the cache. > eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than > once in a multi-project > --- > > Key: MECLIPSE-377 > URL: http://jira.codehaus.org/browse/MECLIPSE-377 > Project: Maven 2.x Eclipse Plugin > Issue Type: Bug > Components: Core : Dependencies resolution and build path > (.classpath), Core : Multi-projects >Affects Versions: 2.4 >Reporter: Steinar Bang >Assignee: Barrie Treloar > Fix For: 2.6 > > > If you run "mvn eclipse:eclipse -DdownloadSources=true" it attempts to > download source jars for all projects, even when it has tried (and failed) to > download the jars in earlier projects. This slows down the goal a lot on > slow network connections. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-377) eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than once in a multi-project
[ http://jira.codehaus.org/browse/MECLIPSE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=155730#action_155730 ] Julien Renaut commented on MECLIPSE-377: I think both ways have their benefits. Common users probably don't want to know about the location of the cache, they just want it to work and eventually resetting it using the new mojo you're proposing in MECLIPSE-504. Still, i've often edited the cache myself to fix wrong entries due to incorrectly generated artifacts (without sources when they were supposed to have sources). Having it's location optionally configurable is just for ease of use. However, I agree it will work just the same way if you force it to be at the root of local repo. Having ACID properties on the file and configurable location would allow the cache to be stored on a network location. For large teams this could be helpful but probably not enough to justify the effort. > eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than > once in a multi-project > --- > > Key: MECLIPSE-377 > URL: http://jira.codehaus.org/browse/MECLIPSE-377 > Project: Maven 2.x Eclipse Plugin > Issue Type: Bug > Components: Core : Dependencies resolution and build path > (.classpath), Core : Multi-projects >Affects Versions: 2.4 >Reporter: Steinar Bang >Assignee: Barrie Treloar > Fix For: 2.6 > > > If you run "mvn eclipse:eclipse -DdownloadSources=true" it attempts to > download source jars for all projects, even when it has tried (and failed) to > download the jars in earlier projects. This slows down the goal a lot on > slow network connections. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-377) eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than once in a multi-project
[ http://jira.codehaus.org/browse/MECLIPSE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=155727#action_155727 ] Julien Renaut commented on MECLIPSE-377: I know i'm coming out of no where but there is a patch i sent in MECLIPSE-387 that allows users to specify which folder they want the cache to be in. Default could be changed from null int hat patch to ~/.m2 or the root of local repo. However, i'd like to be able to optionally configure it to my liking as the patch i sent permits. > eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than > once in a multi-project > --- > > Key: MECLIPSE-377 > URL: http://jira.codehaus.org/browse/MECLIPSE-377 > Project: Maven 2.x Eclipse Plugin > Issue Type: Bug > Components: Core : Dependencies resolution and build path > (.classpath), Core : Multi-projects >Affects Versions: 2.4 >Reporter: Steinar Bang >Assignee: Barrie Treloar > Fix For: 2.6 > > > If you run "mvn eclipse:eclipse -DdownloadSources=true" it attempts to > download source jars for all projects, even when it has tried (and failed) to > download the jars in earlier projects. This slows down the goal a lot on > slow network connections. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MECLIPSE-387) download source should accept exclusion of artifact
[ http://jira.codehaus.org/browse/MECLIPSE-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Julien Renaut updated MECLIPSE-387: --- Attachment: configurable-source-cache-dir-diff Hi, i've slightly modified the AbstractIdeSupportMojo for our use here at work. A "preferredSourceCacheDir" parameter has been added (defaults to null). This way the user can specify a location of choice for the source status cache. If none is provided it falls back to the default location (target dir). I've attached a patch for it if anyone's interested in that particular solution. > download source should accept exclusion of artifact > --- > > Key: MECLIPSE-387 > URL: http://jira.codehaus.org/browse/MECLIPSE-387 > Project: Maven 2.x Eclipse Plugin > Issue Type: New Feature > Components: Core : Dependencies resolution and build path >Affects Versions: 2.4 >Reporter: Dominique Jean-Prost > Attachments: configurable-source-cache-dir-diff > > > It would be nice to be possible to exclude specific group/artifact when > downloadSources is to true (in pom.xml for instance). > As the sources jar or the javadoc jar will never be available in repo, for > specific artifact, mvn eclipse:eclipse keep on trying to download them, and > it slows the process. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-377) eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than once in a multi-project
[ http://jira.codehaus.org/browse/MECLIPSE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=131116#action_131116 ] Julien Renaut commented on MECLIPSE-377: No need to patch this. Here is what i've done: Add the following to your root pom.xml (under build -> plugins): false maven-clean-plugin true The source status cache file is saved under the target dir of the your root pom. Unless you really need to delete it during clean goal you can skip it. That way you won't loose your source status file. Plus, this file is shared by all projects under your root pom. Hope this helps. > eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than > once in a multi-project > --- > > Key: MECLIPSE-377 > URL: http://jira.codehaus.org/browse/MECLIPSE-377 > Project: Maven 2.x Eclipse Plugin > Issue Type: Bug > Components: Core : Dependencies resolution and build path, Core : > Multi-projects >Affects Versions: 2.4 >Reporter: Steinar Bang > > If you run "mvn eclipse:eclipse -DdownloadSources=true" it attempts to > download source jars for all projects, even when it has tried (and failed) to > download the jars in earlier projects. This slows down the goal a lot on > slow network connections. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MECLIPSE-377) eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than once in a multi-project
[ http://jira.codehaus.org/browse/MECLIPSE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=130984#action_130984 ] Julien Renaut commented on MECLIPSE-377: Sharing the mvn-eclipse-cache.properties between projects would require to have some file location configured in your settings.xml and could be probably be done. I'll try to patch this. > eclipse:eclipse -DdownloadSources=true shouldn't attempt download more than > once in a multi-project > --- > > Key: MECLIPSE-377 > URL: http://jira.codehaus.org/browse/MECLIPSE-377 > Project: Maven 2.x Eclipse Plugin > Issue Type: Bug > Components: Core : Dependencies resolution and build path, Core : > Multi-projects >Affects Versions: 2.4 >Reporter: Steinar Bang > > If you run "mvn eclipse:eclipse -DdownloadSources=true" it attempts to > download source jars for all projects, even when it has tried (and failed) to > download the jars in earlier projects. This slows down the goal a lot on > slow network connections. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
