[jira] Updated: (SUREFIRE-31) support junit 4.0

[Tom Huybrechts (JIRA)]

 [ http://jira.codehaus.org/browse/SUREFIRE-31?page=all ]

Tom Huybrechts updated SUREFIRE-31:
---

Attachment: surefire-junit4.patch

previous patch was missing a pom...

> support junit 4.0
> -
>
> Key: SUREFIRE-31
> URL: http://jira.codehaus.org/browse/SUREFIRE-31
> Project: surefire
>  Issue Type: Improvement
>  Components: Junit 4.x support
>Reporter: John Didion
> Fix For: 2.1
>
> Attachments: SUREFIRE-31-maven-surefire-plugin.patch, 
> SUREFIRE-31-surefire-trunk.patch, surefire-junit4.patch, 
> surefire-junit4.patch, surefire-junit4.zip, 
> SUREFIRE31_karl_maven-surefire-plugin.patch, 
> SUREFIRE31_karl_surefire_surefire-providers_surefire-junit.patch, 
> SUREFIRE31_karl_surefire_surefire-providers_surefire-junit_2ndMethod.patch
>
>
> I know this is a pretty sizable task. I just wanted to get it in the system 
> now that 4.0 has officially been released. Hopefully this will generate some 
> discussion about how 4.0 will be handled - mainly if it will require a 
> completely seperate implemenation of surefire (keeping the same API so it can 
> easily be used by the maven plugin), or if use of 4.0 will be made a 
> configurable option of the current surefire.
> Here's some additional features I'd like to see:
> 1. Ability to categorize tests. Unfortunately, 4.0 doesn't include an 
> @Category annotation, or make category a parameter of @Test. However, the 
> filtering mechanism provided by 4.0 is sufficent to support categories given 
> the presense of such an annotation. I recommend putting the @Category 
> annotation in a seperate module (surefire-annotations?) and build support for 
> it into surefire. Hopefully the junit guys could be convinced to incorporate 
> it in a later version.
> 2. Similarly, support repeated tests via an @Repeated annotation. I'm not 
> sure how easy this would be to do external to junit.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (SUREFIRE-31) support junit 4.0

[Tom Huybrechts (JIRA)]

 [ http://jira.codehaus.org/browse/SUREFIRE-31?page=all ]

Tom Huybrechts updated SUREFIRE-31:
---

Attachment: surefire-junit4.patch

patch to the surefire trunk 
provides surefire-junit4 provider + patch for SurefirePlugin.java

> support junit 4.0
> -
>
> Key: SUREFIRE-31
> URL: http://jira.codehaus.org/browse/SUREFIRE-31
> Project: surefire
>  Issue Type: Improvement
>  Components: Junit 4.x support
>Reporter: John Didion
> Fix For: 2.1
>
> Attachments: SUREFIRE-31-maven-surefire-plugin.patch, 
> SUREFIRE-31-surefire-trunk.patch, surefire-junit4.patch, surefire-junit4.zip, 
> SUREFIRE31_karl_maven-surefire-plugin.patch, 
> SUREFIRE31_karl_surefire_surefire-providers_surefire-junit.patch, 
> SUREFIRE31_karl_surefire_surefire-providers_surefire-junit_2ndMethod.patch
>
>
> I know this is a pretty sizable task. I just wanted to get it in the system 
> now that 4.0 has officially been released. Hopefully this will generate some 
> discussion about how 4.0 will be handled - mainly if it will require a 
> completely seperate implemenation of surefire (keeping the same API so it can 
> easily be used by the maven plugin), or if use of 4.0 will be made a 
> configurable option of the current surefire.
> Here's some additional features I'd like to see:
> 1. Ability to categorize tests. Unfortunately, 4.0 doesn't include an 
> @Category annotation, or make category a parameter of @Test. However, the 
> filtering mechanism provided by 4.0 is sufficent to support categories given 
> the presense of such an annotation. I recommend putting the @Category 
> annotation in a seperate module (surefire-annotations?) and build support for 
> it into surefire. Hopefully the junit guys could be convinced to incorporate 
> it in a later version.
> 2. Similarly, support repeated tests via an @Repeated annotation. I'm not 
> sure how easy this would be to do external to junit.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (SUREFIRE-31) support junit 4.0

[Tom Huybrechts (JIRA)]

[ http://jira.codehaus.org/browse/SUREFIRE-31?page=comments#action_84196 ] 

Tom Huybrechts commented on SUREFIRE-31:


I took Karls code and added it to the current surefire trunk. I moved the 
junit4 code to its own surefire-junit4 provider.
SurefirePlugin.java is patched to use the new provider if a junit dependency 
with baseVersion.startsWith("4") is found. 
Since junit4 is backward compatible, both new-style (@Test) and old-style 
(extends TestCase) unit tests can be used in the same project.

The old junit3 provider is not touched and it is still the default.

Patch attached...


> support junit 4.0
> -
>
> Key: SUREFIRE-31
> URL: http://jira.codehaus.org/browse/SUREFIRE-31
> Project: surefire
>  Issue Type: Improvement
>  Components: Junit 4.x support
>Reporter: John Didion
> Fix For: 2.1
>
> Attachments: SUREFIRE-31-maven-surefire-plugin.patch, 
> SUREFIRE-31-surefire-trunk.patch, surefire-junit4.patch, surefire-junit4.zip, 
> SUREFIRE31_karl_maven-surefire-plugin.patch, 
> SUREFIRE31_karl_surefire_surefire-providers_surefire-junit.patch, 
> SUREFIRE31_karl_surefire_surefire-providers_surefire-junit_2ndMethod.patch
>
>
> I know this is a pretty sizable task. I just wanted to get it in the system 
> now that 4.0 has officially been released. Hopefully this will generate some 
> discussion about how 4.0 will be handled - mainly if it will require a 
> completely seperate implemenation of surefire (keeping the same API so it can 
> easily be used by the maven plugin), or if use of 4.0 will be made a 
> configurable option of the current surefire.
> Here's some additional features I'd like to see:
> 1. Ability to categorize tests. Unfortunately, 4.0 doesn't include an 
> @Category annotation, or make category a parameter of @Test. However, the 
> filtering mechanism provided by 4.0 is sufficent to support categories given 
> the presense of such an annotation. I recommend putting the @Category 
> annotation in a seperate module (surefire-annotations?) and build support for 
> it into surefire. Hopefully the junit guys could be convinced to incorporate 
> it in a later version.
> 2. Similarly, support repeated tests via an @Repeated annotation. I'm not 
> sure how easy this would be to do external to junit.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MRELEASE-122) Versionless Extension causes NullPointerException in release:prepare

[Tom Huybrechts (JIRA)]

[ http://jira.codehaus.org/browse/MRELEASE-122?page=comments#action_83153 ] 

Tom Huybrechts commented on MRELEASE-122:
-

I have this one too - and not in an extension.

In my dependencyManagement I have a declared a dependency to junit (with 
version off course)

In my dependencies (in the same POM) I repeat this, without version. This 
causes the NPE. If I put a version in the dependencies section, I can release 
without problems.



> Versionless Extension causes NullPointerException in release:prepare
> 
>
> Key: MRELEASE-122
> URL: http://jira.codehaus.org/browse/MRELEASE-122
> Project: Maven 2.x Release Plugin
>  Issue Type: Bug
>Affects Versions: 2.0-beta-5
>Reporter: Stefan Hübner
> Assigned To: Jason van Zyl
> Fix For: 2.0-beta-5
>
> Attachments: patch.txt
>
>
> I'm getting a NullPointerException when invoking "mvn release:prepare
> -DdryRun=true" (don't know, if the dryRun-parameter makes any
> difference). See the stack trace below.
> My POM does make use of the wagon-ssh-extension, but without declaring a 
> certain version of that extension - which is not necessary, as far as I know.
> A workaround to this is to declare a version to the extension.
> See this mail thread for a discussion on this issue: 
> 
> Stefan
> ava.lang.NullPointerException 
>at 
> org.apache.maven.plugins.release.phase.AbstractRewritePomsPhase.updateDomVersion(AbstractRewritePomsPhase.java:388)
>at 
> org.apache.maven.plugins.release.phase.AbstractRewritePomsPhase.rewriteExtensions(AbstractRewritePomsPhase.java:352)
>at 
> org.apache.maven.plugins.release.phase.AbstractRewritePomsPhase.transformDocument(AbstractRewritePomsPhase.java:230)
>at 
> org.apache.maven.plugins.release.phase.AbstractRewritePomsPhase.transformProject(AbstractRewritePomsPhase.java:165)
>at 
> org.apache.maven.plugins.release.phase.AbstractRewritePomsPhase.transform(AbstractRewritePomsPhase.java:102)
>at 
> org.apache.maven.plugins.release.phase.AbstractRewritePomsPhase.simulate(AbstractRewritePomsPhase.java:529)
>at 
> org.apache.maven.plugins.release.DefaultReleaseManager.prepare(DefaultReleaseManager.java:135)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MECLIPSE-201) add support for Import-Package in MakeArtifactsMojo

[Tom Huybrechts (JIRA)]

[ http://jira.codehaus.org/browse/MECLIPSE-201?page=comments#action_82613 ] 

Tom Huybrechts commented on MECLIPSE-201:
-

When you do make-artifacts, you should have a complete Eclipse install in which 
each bundle's dependencies are resolved. You can examine the package wirings 
and map the Maven dependencies accordingly. Off course this is just a snapshot 
in time, but it is enough for compilation.

> add support for Import-Package in MakeArtifactsMojo
> ---
>
> Key: MECLIPSE-201
> URL: http://jira.codehaus.org/browse/MECLIPSE-201
> Project: Maven 2.x Eclipse Plugin
>  Issue Type: New Feature
>  Components: PDE support
>Reporter: Tom Huybrechts
>
> When generating POMs, the plugin translates OSGi Require-Bundle dependencies 
> into Maven dependencies.
> It does not take Import-Package dependencies into account.
> If there is interest in this feature, I will write a patch to add it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MECLIPSE-201) add support for Import-Package in MakeArtifactsMojo

[Tom Huybrechts (JIRA)]

[ http://jira.codehaus.org/browse/MECLIPSE-201?page=comments#action_82403 ] 

Tom Huybrechts commented on MECLIPSE-201:
-

As an example of a POM that is incorrect because of this, look at 
org.eclipse.equinox.registry. Its manifest has Import-Package dependencies on 
various OSGi packages but these are not declared as a dependency in the POM.

> add support for Import-Package in MakeArtifactsMojo
> ---
>
> Key: MECLIPSE-201
> URL: http://jira.codehaus.org/browse/MECLIPSE-201
> Project: Maven 2.x Eclipse Plugin
>  Issue Type: New Feature
>  Components: PDE support
>Reporter: Tom Huybrechts
>
> When generating POMs, the plugin translates OSGi Require-Bundle dependencies 
> into Maven dependencies.
> It does not take Import-Package dependencies into account.
> If there is interest in this feature, I will write a patch to add it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Created: (MECLIPSE-201) add support for Import-Package in MakeArtifactsMojo

[Tom Huybrechts (JIRA)]

add support for Import-Package in MakeArtifactsMojo
---

 Key: MECLIPSE-201
 URL: http://jira.codehaus.org/browse/MECLIPSE-201
 Project: Maven 2.x Eclipse Plugin
  Issue Type: New Feature
  Components: PDE support
Reporter: Tom Huybrechts


When generating POMs, the plugin translates OSGi Require-Bundle dependencies 
into Maven dependencies.
It does not take Import-Package dependencies into account.

If there is interest in this feature, I will write a patch to add it.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Created: (MNG-2665) broken links on http://maven.apache.org/plugins

[Tom Huybrechts (JIRA)]

broken links on http://maven.apache.org/plugins
---

 Key: MNG-2665
 URL: http://jira.codehaus.org/browse/MNG-2665
 Project: Maven 2
  Issue Type: Bug
  Components: Documentation:  General
Reporter: Tom Huybrechts


a list of broken links on the maven site

http://maven.apache.org/plugins/maven-repository-plugin/faq.html
http://maven.apache.org/plugins/maven-war-plugin/faq.html
http://maven.apache.org/plugins/maven-dependency-plugin/faq.html
http://maven.apache.org/plugins/maven-docck-plugin/taglist.html
http://maven.apache.org/plugins/maven-repository-plugin/usage.html
http://maven.apache.org/plugins/maven-jxr-plugin/faq.html
http://maven.apache.org/plugins/maven-checkstyle-plugin/dependencies.html
http://maven.apache.org/plugins/maven-verifier-plugin/faq.html
http://maven.apache.org/plugins/maven-doap-plugin/examples/options.html
http://maven.apache.org/plugins/maven-ejb-plugin/usage.html
http://maven.apache.org/plugins/maven-ejb-plugin/faq.html


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Updated: (MRM-226) indexer throws exception on test-sources jar

[Tom Huybrechts (JIRA)]

 [ http://jira.codehaus.org/browse/MRM-226?page=all ]

Tom Huybrechts updated MRM-226:
---

Attachment: archiva-discoverer-226-patch.txt

attached a patch - explicit check for test-sources
junit test included

> indexer throws exception on test-sources jar
> 
>
> Key: MRM-226
> URL: http://jira.codehaus.org/browse/MRM-226
> Project: Archiva
>  Issue Type: Bug
>  Components: indexing
> Environment: Windows
>Reporter: Tom Huybrechts
> Attachments: archiva-discoverer-226-patch.txt
>
>
> While indexing a repo for the first time, Archiva throws this exception and 
> indexing stops.
> The exception refers to a -test.jar. The repository contains many artifacts 
> in this directory, but not with classifier test. The closest things are 
> -tests and -test-sources.
> edu.emory.mathcs.backport.java.util.concurrent.ExecutionException: 
> java.lang.IllegalStateException: Couldn't find artifact  
> C:\maven-repo\group\artifact\1.0.0.v20060823\artifact-1.0.0.v20060823-test.jar
> at 
> edu.emory.mathcs.backport.java.util.concurrent.FutureTask.getResult(FutureTask.java:299)
> at 
> edu.emory.mathcs.backport.java.util.concurrent.FutureTask.get(FutureTask.java:118)
> at 
> org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.waitForTask(ThreadedTaskQueueExecutor.java:159)
> at 
> org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.run(ThreadedTaskQueueExecutor.java:127)
> Caused by: java.lang.IllegalStateException: Couldn't find artifact 
> C:\maven-repo\group\artifact\1.0.0.v20060823\artifact-1.0.0.v20060823-test.jar
> at 
> org.apache.maven.archiva.reporting.LocationArtifactReportProcessor.processArtifact(LocationArtifactReportProcessor.java:143)
> at 
> org.apache.maven.archiva.reporting.AbstractReportGroup.processArtifact(AbstractReportGroup.java:53)
> at 
> org.apache.maven.archiva.reporting.DefaultReportExecutor.runArtifactR...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MRM-226) indexer throws exception on test-sources jar

[Tom Huybrechts (JIRA)]

[ http://jira.codehaus.org/browse/MRM-226?page=comments#action_80344 ] 

Tom Huybrechts commented on MRM-226:


DefaultArtifactDiscoverer:90 thinks anything ending with -sources has 
classifier sources.

> indexer throws exception on test-sources jar
> 
>
> Key: MRM-226
> URL: http://jira.codehaus.org/browse/MRM-226
> Project: Archiva
>  Issue Type: Bug
>  Components: indexing
> Environment: Windows
>Reporter: Tom Huybrechts
>
> While indexing a repo for the first time, Archiva throws this exception and 
> indexing stops.
> The exception refers to a -test.jar. The repository contains many artifacts 
> in this directory, but not with classifier test. The closest things are 
> -tests and -test-sources.
> edu.emory.mathcs.backport.java.util.concurrent.ExecutionException: 
> java.lang.IllegalStateException: Couldn't find artifact  
> C:\maven-repo\group\artifact\1.0.0.v20060823\artifact-1.0.0.v20060823-test.jar
> at 
> edu.emory.mathcs.backport.java.util.concurrent.FutureTask.getResult(FutureTask.java:299)
> at 
> edu.emory.mathcs.backport.java.util.concurrent.FutureTask.get(FutureTask.java:118)
> at 
> org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.waitForTask(ThreadedTaskQueueExecutor.java:159)
> at 
> org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.run(ThreadedTaskQueueExecutor.java:127)
> Caused by: java.lang.IllegalStateException: Couldn't find artifact 
> C:\maven-repo\group\artifact\1.0.0.v20060823\artifact-1.0.0.v20060823-test.jar
> at 
> org.apache.maven.archiva.reporting.LocationArtifactReportProcessor.processArtifact(LocationArtifactReportProcessor.java:143)
> at 
> org.apache.maven.archiva.reporting.AbstractReportGroup.processArtifact(AbstractReportGroup.java:53)
> at 
> org.apache.maven.archiva.reporting.DefaultReportExecutor.runArtifactR...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Created: (MRM-226) indexer throws exception on test-sources jar

[Tom Huybrechts (JIRA)]

indexer throws exception on test-sources jar


 Key: MRM-226
 URL: http://jira.codehaus.org/browse/MRM-226
 Project: Archiva
  Issue Type: Bug
  Components: indexing
 Environment: Windows
Reporter: Tom Huybrechts


While indexing a repo for the first time, Archiva throws this exception and 
indexing stops.

The exception refers to a -test.jar. The repository contains many artifacts in 
this directory, but not with classifier test. The closest things are -tests and 
-test-sources.

edu.emory.mathcs.backport.java.util.concurrent.ExecutionException: 
java.lang.IllegalStateException: Couldn't find artifact  
C:\maven-repo\group\artifact\1.0.0.v20060823\artifact-1.0.0.v20060823-test.jar
at 
edu.emory.mathcs.backport.java.util.concurrent.FutureTask.getResult(FutureTask.java:299)
at 
edu.emory.mathcs.backport.java.util.concurrent.FutureTask.get(FutureTask.java:118)
at 
org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.waitForTask(ThreadedTaskQueueExecutor.java:159)
at 
org.codehaus.plexus.taskqueue.execution.ThreadedTaskQueueExecutor$ExecutorRunnable.run(ThreadedTaskQueueExecutor.java:127)
Caused by: java.lang.IllegalStateException: Couldn't find artifact 
C:\maven-repo\group\artifact\1.0.0.v20060823\artifact-1.0.0.v20060823-test.jar
at 
org.apache.maven.archiva.reporting.LocationArtifactReportProcessor.processArtifact(LocationArtifactReportProcessor.java:143)
at 
org.apache.maven.archiva.reporting.AbstractReportGroup.processArtifact(AbstractReportGroup.java:53)
at 
org.apache.maven.archiva.reporting.DefaultReportExecutor.runArtifactR...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (CONTINUUM-640) Auto Building triggered by svn commit

[Tom Huybrechts (JIRA)]

[ http://jira.codehaus.org/browse/CONTINUUM-640?page=comments#action_71942 
] 

Tom Huybrechts commented on CONTINUUM-640:
--

CruiseControl regularly checks if your project has been changed in your SCM 
system, and builds it if it has.


> Auto Building triggered by svn commit
> -
>
> Key: CONTINUUM-640
> URL: http://jira.codehaus.org/browse/CONTINUUM-640
> Project: Continuum
>  Issue Type: Improvement
>  Components: SCM
>Affects Versions: 1.0.1
>Reporter: Kevin Wang
>
> Should we add the function to support auto build while subversion commit? 
> just like CruiseContril. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] Commented: (MNG-2316) Add info to the poms for dependencies that implement an API or provide other dependencies

[Tom Huybrechts (JIRA)]

[ http://jira.codehaus.org/browse/MNG-2316?page=comments#action_68091 ] 

Tom Huybrechts commented on MNG-2316:
-

This would also be useful when building OSGi bundles, which are wired to each 
other using Export-Package and Import-Package headers in the manifest.

> Add info to the poms for dependencies that implement an API or provide other 
> dependencies
> -
>
>  Key: MNG-2316
>  URL: http://jira.codehaus.org/browse/MNG-2316
>  Project: Maven 2
> Type: New Feature

>   Components: Dependencies
> Versions: 2.0.4
> Reporter: Carlos Sanchez
> Priority: Critical
>  Fix For: 2.1

>
>
> e.g.
> geronimo implementation of javamail could say
> 
>   
> javax.mail
> mail
> ...
>   
> 
> spring.jar pom could say
> 
>   
> org.springframework
> spring-webmvc
> ...
>   
>   
> org.springframework
> spring-context
> ...
>   
>   ...
> 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira