[jira] [Commented] (MSHARED-863) Possible NPEx in Maven30DependencyResolver.resolveDependencies
[ https://issues.apache.org/jira/browse/MSHARED-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059649#comment-17059649 ] Hudson commented on MSHARED-863: Build succeeded in Jenkins: Maven TLP » maven-artifact-transfer » master #57 See https://builds.apache.org/job/maven-box/job/maven-artifact-transfer/job/master/57/ > Possible NPEx in Maven30DependencyResolver.resolveDependencies > -- > > Key: MSHARED-863 > URL: https://issues.apache.org/jira/browse/MSHARED-863 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.13.0 >Reporter: Piotr Zygielo >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: maven-artifact-transfer-0.13.0 > > Time Spent: 10m > Remaining Estimate: 0h > > Possible NPEx in > [Maven30DependencyResolver.resolveDependencies|https://github.com/apache/maven-artifact-transfer/blob/dc0d6bd30b855e147576c4e9cdfacf1382d69f07/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/Maven30DependencyResolver.java#L156] > {code:java} > List aetherDependencies = new ArrayList( > mavenDependencies.size() ); > if ( mavenDependencies != null ) > { > aetherDependencies = new ArrayList( > mavenDependencies.size() ); > ... > {code} > Line 161 > {code:java} > if ( mavenDependencies != null ) > {code} > suggests that {{mavenDependencies}} can be {{null}}. > However in such case previous {{mavenDependencies.size()}} results in > {{NPEx}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-863) Possible NPEx in Maven30DependencyResolver.resolveDependencies
[ https://issues.apache.org/jira/browse/MSHARED-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059641#comment-17059641 ] Karl Heinz Marbaise commented on MSHARED-863: - Done in [3145488100f2a247414f692f2c9e1452631282fe|https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commitdiff;h=3145488100f2a247414f692f2c9e1452631282fe] > Possible NPEx in Maven30DependencyResolver.resolveDependencies > -- > > Key: MSHARED-863 > URL: https://issues.apache.org/jira/browse/MSHARED-863 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.13.0 >Reporter: Piotr Zygielo >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: maven-artifact-transfer-0.13.0 > > > Possible NPEx in > [Maven30DependencyResolver.resolveDependencies|https://github.com/apache/maven-artifact-transfer/blob/dc0d6bd30b855e147576c4e9cdfacf1382d69f07/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/Maven30DependencyResolver.java#L156] > {code:java} > List aetherDependencies = new ArrayList( > mavenDependencies.size() ); > if ( mavenDependencies != null ) > { > aetherDependencies = new ArrayList( > mavenDependencies.size() ); > ... > {code} > Line 161 > {code:java} > if ( mavenDependencies != null ) > {code} > suggests that {{mavenDependencies}} can be {{null}}. > However in such case previous {{mavenDependencies.size()}} results in > {{NPEx}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-863) Possible NPEx in Maven30DependencyResolver.resolveDependencies
[ https://issues.apache.org/jira/browse/MSHARED-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059637#comment-17059637 ] Karl Heinz Marbaise commented on MSHARED-863: - Separated the code refactoring into MSHARED-864 > Possible NPEx in Maven30DependencyResolver.resolveDependencies > -- > > Key: MSHARED-863 > URL: https://issues.apache.org/jira/browse/MSHARED-863 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.13.0 >Reporter: Piotr Zygielo >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: maven-artifact-transfer-0.13.0 > > > Possible NPEx in > [Maven30DependencyResolver.resolveDependencies|https://github.com/apache/maven-artifact-transfer/blob/dc0d6bd30b855e147576c4e9cdfacf1382d69f07/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/Maven30DependencyResolver.java#L156] > {code:java} > List aetherDependencies = new ArrayList( > mavenDependencies.size() ); > if ( mavenDependencies != null ) > { > aetherDependencies = new ArrayList( > mavenDependencies.size() ); > ... > {code} > Line 161 > {code:java} > if ( mavenDependencies != null ) > {code} > suggests that {{mavenDependencies}} can be {{null}}. > However in such case previous {{mavenDependencies.size()}} results in > {{NPEx}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-863) Possible NPEx in Maven30DependencyResolver.resolveDependencies
[ https://issues.apache.org/jira/browse/MSHARED-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17059020#comment-17059020 ] Karl Heinz Marbaise commented on MSHARED-863: - In the end they are going to call the constructor of [CollectRequest|https://github.com/apache/maven-artifact-transfer/blob/master/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/Maven30DependencyResolver.java#L190] which calls methods like {{setManagedDependencies}} which are implemented like this: {code:java} public CollectRequest setManagedDependencies( List managedDependencies ) { if ( managedDependencies == null ) { this.managedDependencies = Collections.emptyList(); } else { this.managedDependencies = managedDependencies; } return this; } {code} which would mean that we can prevent using {{null}} and use {{Collections.emptyList()}} instead and that should not change a thing. So first step is to prevent NPE... > Possible NPEx in Maven30DependencyResolver.resolveDependencies > -- > > Key: MSHARED-863 > URL: https://issues.apache.org/jira/browse/MSHARED-863 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.12.0 >Reporter: Piotr Zygielo >Priority: Major > > Possible NPEx in > [Maven30DependencyResolver.resolveDependencies|https://github.com/apache/maven-artifact-transfer/blob/dc0d6bd30b855e147576c4e9cdfacf1382d69f07/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/Maven30DependencyResolver.java#L156] > {code:java} > List aetherDependencies = new ArrayList( > mavenDependencies.size() ); > if ( mavenDependencies != null ) > { > aetherDependencies = new ArrayList( > mavenDependencies.size() ); > ... > {code} > Line 161 > {code:java} > if ( mavenDependencies != null ) > {code} > suggests that {{mavenDependencies}} can be {{null}}. > However in such case previous {{mavenDependencies.size()}} results in > {{NPEx}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-863) Possible NPEx in Maven30DependencyResolver.resolveDependencies
[ https://issues.apache.org/jira/browse/MSHARED-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056714#comment-17056714 ] Robert Scholte commented on MSHARED-863: Did I wrote that? I guess there's a good reason why I changed it from 'never' to 'can be'. Most likely related to how Aether code works. > Possible NPEx in Maven30DependencyResolver.resolveDependencies > -- > > Key: MSHARED-863 > URL: https://issues.apache.org/jira/browse/MSHARED-863 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.12.0 >Reporter: Piotr Zygielo >Priority: Major > > Possible NPEx in > [Maven30DependencyResolver.resolveDependencies|https://github.com/apache/maven-artifact-transfer/blob/dc0d6bd30b855e147576c4e9cdfacf1382d69f07/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/Maven30DependencyResolver.java#L156] > {code:java} > List aetherDependencies = new ArrayList( > mavenDependencies.size() ); > if ( mavenDependencies != null ) > { > aetherDependencies = new ArrayList( > mavenDependencies.size() ); > ... > {code} > Line 161 > {code:java} > if ( mavenDependencies != null ) > {code} > suggests that {{mavenDependencies}} can be {{null}}. > However in such case previous {{mavenDependencies.size()}} results in > {{NPEx}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-863) Possible NPEx in Maven30DependencyResolver.resolveDependencies
[ https://issues.apache.org/jira/browse/MSHARED-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056476#comment-17056476 ] Piotr Zygielo commented on MSHARED-863: --- {quote}Code can be simplified and javadoc should make clear these arguments should never be null. {quote} How about [https://github.com/apache/maven-artifact-transfer/commit/b5cc4be6c616c6a1be37dd8cbb183fb6710e409f], where author of change for DependencyResolver interface said: {quote}@param dependencies the dependencies to resolve, can be null {quote} > Possible NPEx in Maven30DependencyResolver.resolveDependencies > -- > > Key: MSHARED-863 > URL: https://issues.apache.org/jira/browse/MSHARED-863 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.12.0 >Reporter: Piotr Zygielo >Priority: Major > > Possible NPEx in > [Maven30DependencyResolver.resolveDependencies|https://github.com/apache/maven-artifact-transfer/blob/dc0d6bd30b855e147576c4e9cdfacf1382d69f07/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/Maven30DependencyResolver.java#L156] > {code:java} > List aetherDependencies = new ArrayList( > mavenDependencies.size() ); > if ( mavenDependencies != null ) > { > aetherDependencies = new ArrayList( > mavenDependencies.size() ); > ... > {code} > Line 161 > {code:java} > if ( mavenDependencies != null ) > {code} > suggests that {{mavenDependencies}} can be {{null}}. > However in such case previous {{mavenDependencies.size()}} results in > {{NPEx}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-863) Possible NPEx in Maven30DependencyResolver.resolveDependencies
[ https://issues.apache.org/jira/browse/MSHARED-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056432#comment-17056432 ] Robert Scholte commented on MSHARED-863: Collections and Maps should never be {{null}}, they should at least be an empty instance. Code can be simplified and javadoc should make clear these arguments should never be {{null}}. > Possible NPEx in Maven30DependencyResolver.resolveDependencies > -- > > Key: MSHARED-863 > URL: https://issues.apache.org/jira/browse/MSHARED-863 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.12.0 >Reporter: Piotr Zygielo >Priority: Major > > Possible NPEx in > [Maven30DependencyResolver.resolveDependencies|https://github.com/apache/maven-artifact-transfer/blob/dc0d6bd30b855e147576c4e9cdfacf1382d69f07/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/Maven30DependencyResolver.java#L156] > {code:java} > List aetherDependencies = new ArrayList( > mavenDependencies.size() ); > if ( mavenDependencies != null ) > { > aetherDependencies = new ArrayList( > mavenDependencies.size() ); > ... > {code} > Line 161 > {code:java} > if ( mavenDependencies != null ) > {code} > suggests that {{mavenDependencies}} can be {{null}}. > However in such case previous {{mavenDependencies.size()}} results in > {{NPEx}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-863) Possible NPEx in Maven30DependencyResolver.resolveDependencies
[ https://issues.apache.org/jira/browse/MSHARED-863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056428#comment-17056428 ] Michael Osipov commented on MSHARED-863: [~rfscholte], that is a good catch. WDYT? > Possible NPEx in Maven30DependencyResolver.resolveDependencies > -- > > Key: MSHARED-863 > URL: https://issues.apache.org/jira/browse/MSHARED-863 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.12.0 >Reporter: Piotr Zygielo >Priority: Major > > Possible NPEx in > [Maven30DependencyResolver.resolveDependencies|https://github.com/apache/maven-artifact-transfer/blob/dc0d6bd30b855e147576c4e9cdfacf1382d69f07/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/Maven30DependencyResolver.java#L156] > {code:java} > List aetherDependencies = new ArrayList( > mavenDependencies.size() ); > if ( mavenDependencies != null ) > { > aetherDependencies = new ArrayList( > mavenDependencies.size() ); > ... > {code} > Line 161 > {code:java} > if ( mavenDependencies != null ) > {code} > suggests that {{mavenDependencies}} can be {{null}}. > However in such case previous {{mavenDependencies.size()}} results in > {{NPEx}}. -- This message was sent by Atlassian Jira (v8.3.4#803005)