[jira] Commented: (MNG-2744) checksum comparison should be case-insensitive
[ http://jira.codehaus.org/browse/MNG-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126929 ] Benjamin Bentmann commented on MNG-2744: I forgot to mention: During creation of the IT I noticed that the build will pass if only the b.pom.sha1 uses the upper-case checksum (i.e. b.jar can be successfully verified), Maven 2.0.8 merely prints a warning about the checksum verification although the checksum policies in the POM are set to "fail". Is this intended behavior or something to create another issue for? > checksum comparison should be case-insensitive > -- > > Key: MNG-2744 > URL: http://jira.codehaus.org/browse/MNG-2744 > Project: Maven 2 > Issue Type: Bug > Components: Artifacts and Repositories >Affects Versions: 2.0.4 >Reporter: Ian Springer > Fix For: 2.0.9 > > Attachments: case-insensitive-checksums-2.0.x.patch, > case-insensitive-checksums-2.1.x.patch, > case-insensitive-checksums-2.1.x.patch, mng-2744-it.patch > > > Validation of MD5 and SHA1 checksums should be case-insensitive (since the > individual characters represent hexadecimal digits). For example: > [WARNING] *** CHECKSUM FAILED - Checksum failed on download: local = > '9657ed010cea89caa1e35ae326dfccf28ea007f5'; remote > = '9657ED010CEA89CAA1E35AE326DFCCF28EA007F5' - RETRYING -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2744) checksum comparison should be case-insensitive
[ http://jira.codehaus.org/browse/MNG-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126775 ] Brian Fox commented on MNG-2744: I never said I wouldn't fix it, I was just commenting that we need to consider testing when judging when something gets fixed. This functionality is been this way since 2.0 and with only two votes, it's not exactly screaming to be fixed now...however trivial it is. This particular issue happens to be in maven artifact, which i know has already been branched and is being rewritten. I can take your patch & unit test and apply it to the trunk, but without an IT that lives outside the code, there is no guarantee this won't come back in a month. The ITs are what we need to ensure that the refactoring doesn't overlook existing behavior. I'm hoping that your motivation now to get this in will get an IT test so I don't have to make a subtask that says "add test for..." because we all know that no one will ever come along and fix that issue. Besides, it's a lot easier to test the IT when you have handy the code that just fixed it so you can test that it fails appropriately. So there, I tipped my hand, I'm going to apply this no matter what you do, would you still make an IT for it? Pretty please? > checksum comparison should be case-insensitive > -- > > Key: MNG-2744 > URL: http://jira.codehaus.org/browse/MNG-2744 > Project: Maven 2 > Issue Type: Bug > Components: Artifacts and Repositories >Affects Versions: 2.0.4 >Reporter: Ian Springer > Fix For: 2.0.9 > > Attachments: case-insensitive-checksums-2.0.x.patch, > case-insensitive-checksums-2.1.x.patch, case-insensitive-checksums-2.1.x.patch > > > Validation of MD5 and SHA1 checksums should be case-insensitive (since the > individual characters represent hexadecimal digits). For example: > [WARNING] *** CHECKSUM FAILED - Checksum failed on download: local = > '9657ed010cea89caa1e35ae326dfccf28ea007f5'; remote > = '9657ED010CEA89CAA1E35AE326DFCCF28EA007F5' - RETRYING -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MNG-2744) checksum comparison should be case-insensitive
[ http://jira.codehaus.org/browse/MNG-2744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_126736 ] Brian Fox commented on MNG-2744: Ben, we need tests for these things so it's not just a one liner. A unit test at minimum, an IT test in addition would be better. > checksum comparison should be case-insensitive > -- > > Key: MNG-2744 > URL: http://jira.codehaus.org/browse/MNG-2744 > Project: Maven 2 > Issue Type: Bug > Components: Artifacts and Repositories >Affects Versions: 2.0.4 >Reporter: Ian Springer > Fix For: 2.0.9 > > Attachments: case-insensitive-checksums-2.0.x.patch, > case-insensitive-checksums-2.1.x.patch > > > Validation of MD5 and SHA1 checksums should be case-insensitive (since the > individual characters represent hexadecimal digits). For example: > [WARNING] *** CHECKSUM FAILED - Checksum failed on download: local = > '9657ed010cea89caa1e35ae326dfccf28ea007f5'; remote > = '9657ED010CEA89CAA1E35AE326DFCCF28EA007F5' - RETRYING -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
