[jira] [Commented] (MESOS-4143) Reserve/UnReserve Dynamic Reservation Endpoints allow reservations on non-existing roles
[ https://issues.apache.org/jira/browse/MESOS-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055566#comment-15055566 ] Yong Qiao Wang commented on MESOS-4143: --- In explicit roles(--roles is specified when Mesos master startup), this is a bug, but in implicit roles(--roles is NOT specified), this is not. Suggest to fix this issue after Implicit Roles(MESOS-4085) commit, then we can call Master::validRole to do check. > Reserve/UnReserve Dynamic Reservation Endpoints allow reservations on > non-existing roles > > > Key: MESOS-4143 > URL: https://issues.apache.org/jira/browse/MESOS-4143 > Project: Mesos > Issue Type: Bug > Components: general >Affects Versions: 0.25.0, 0.26.0 >Reporter: John Omernik > > When working with Dynamic reservations via the /reserve and /unreserve > endpoints, it is possible to reserve resources for roles that have not been > specified via the --roles flag on the master. However, these roles are not > usable because the roles have not been defined, nor are they added to the > list of roles available. > Per the mailing list, changing roles after the fact is not possible at this > time. (That may be another JIRA), more importantly, the /reserve and > /unreserve end points should not allow reservation of roles not specified by > --roles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-3709) Modulize the containerizer interface.
[ https://issues.apache.org/jira/browse/MESOS-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055538#comment-15055538 ] Deshi Xiao commented on MESOS-3709: --- @haosdent could you please involved in your pipeline, i can participate this work. > Modulize the containerizer interface. > - > > Key: MESOS-3709 > URL: https://issues.apache.org/jira/browse/MESOS-3709 > Project: Mesos > Issue Type: Bug >Reporter: Jie Yu >Assignee: haosdent > > So that people can implement their own containerizer as a module. That's more > efficient than having an external containerizer and shell out. The module > system also provides versioning support, this is definitely better than > unversioned external containerizer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-3709) Modulize the containerizer interface.
[ https://issues.apache.org/jira/browse/MESOS-3709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055538#comment-15055538 ] Deshi Xiao edited comment on MESOS-3709 at 12/14/15 7:01 AM: - @haosdent could you please let me involved in your pipeline, i can participate this work. was (Author: xds2000): @haosdent could you please involved in your pipeline, i can participate this work. > Modulize the containerizer interface. > - > > Key: MESOS-3709 > URL: https://issues.apache.org/jira/browse/MESOS-3709 > Project: Mesos > Issue Type: Bug >Reporter: Jie Yu >Assignee: haosdent > > So that people can implement their own containerizer as a module. That's more > efficient than having an external containerizer and shell out. The module > system also provides versioning support, this is definitely better than > unversioned external containerizer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2210) Disallow special characters in role.
[ https://issues.apache.org/jira/browse/MESOS-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055485#comment-15055485 ] haosdent commented on MESOS-2210: - Use Adam's proposal. > Disallow special characters in role. > > > Key: MESOS-2210 > URL: https://issues.apache.org/jira/browse/MESOS-2210 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: haosdent > Labels: mesosphere, newbie, persistent-volumes > > As we introduce persistent volumes in MESOS-1524, we will use roles as > directory names on the slave (https://reviews.apache.org/r/28562/). As a > result, the master should disallow special characters (like space and slash) > in role. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2210) Disallow special characters in role.
[ https://issues.apache.org/jira/browse/MESOS-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055480#comment-15055480 ] Liqiang Lin commented on MESOS-2210: I see your code diff, but not sure the patch is accepted. How about the visible characters "\ / : * ? & " ' ` < > | ~" in your previous append? Or just adopt Adam's proposal? Thanks. > Disallow special characters in role. > > > Key: MESOS-2210 > URL: https://issues.apache.org/jira/browse/MESOS-2210 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: haosdent > Labels: mesosphere, newbie, persistent-volumes > > As we introduce persistent volumes in MESOS-1524, we will use roles as > directory names on the slave (https://reviews.apache.org/r/28562/). As a > result, the master should disallow special characters (like space and slash) > in role. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2210) Disallow special characters in role.
[
https://issues.apache.org/jira/browse/MESOS-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055460#comment-15055460
]
haosdent commented on MESOS-2210:
-
{noformat}
if (role == ".") {
return Error("Role name '.' is invalid.");
} else if (role == "..") {
return Error("Role name '..' is invalid.");
} else if (strings::startsWith(role, "-")) {
return Error("Role name '" + role + "' is invalid "
"because it starts with a dash.");
}
// \x09 is horizontal tab (whitespace);
// \x0a is line feed (whitespace);
// \x0b is vertical tab (whitespace);
// \x0c is form feed (whitespace);
// \x0d is carriage return (whitespace);
// \x20 is space (whitespace);
// \x2f is slash ('/');
// \x7f is backspace (del);
{noformat}
> Disallow special characters in role.
>
>
> Key: MESOS-2210
> URL: https://issues.apache.org/jira/browse/MESOS-2210
> Project: Mesos
> Issue Type: Task
>Reporter: Jie Yu
>Assignee: haosdent
> Labels: mesosphere, newbie, persistent-volumes
>
> As we introduce persistent volumes in MESOS-1524, we will use roles as
> directory names on the slave (https://reviews.apache.org/r/28562/). As a
> result, the master should disallow special characters (like space and slash)
> in role.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-2210) Disallow special characters in role.
[ https://issues.apache.org/jira/browse/MESOS-2210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055448#comment-15055448 ] Liqiang Lin commented on MESOS-2210: Any new update about the patch? Is the character list which will be disallowed in role name finalized? Thanks. > Disallow special characters in role. > > > Key: MESOS-2210 > URL: https://issues.apache.org/jira/browse/MESOS-2210 > Project: Mesos > Issue Type: Task >Reporter: Jie Yu >Assignee: haosdent > Labels: mesosphere, newbie, persistent-volumes > > As we introduce persistent volumes in MESOS-1524, we will use roles as > directory names on the slave (https://reviews.apache.org/r/28562/). As a > result, the master should disallow special characters (like space and slash) > in role. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-4114) Add field VIP to message Port
[ https://issues.apache.org/jira/browse/MESOS-4114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Avinash Sridharan updated MESOS-4114: - Shepherd: Adam B > Add field VIP to message Port > - > > Key: MESOS-4114 > URL: https://issues.apache.org/jira/browse/MESOS-4114 > Project: Mesos > Issue Type: Wish >Reporter: Sargun Dhillon >Assignee: Avinash Sridharan >Priority: Trivial > Labels: mesosphere > > We would like to extend the Mesos protocol buffer 'Port' to include an > optional repeated string named "VIP" - to map it to a well known virtual IP, > or virtual hostname for discovery purposes. > We also want this field exposed in DiscoveryInfo in state.json. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MESOS-4143) Reserve/UnReserve Dynamic Reservation Endpoints allow reservations on non-existing roles
[ https://issues.apache.org/jira/browse/MESOS-4143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yong Qiao Wang updated MESOS-4143: -- Summary: Reserve/UnReserve Dynamic Reservation Endpoints allow reservations on non-existing roles (was: Reserse/UnReserve Dynamic Reservation Endpoints allow reservations on non-existing roles) > Reserve/UnReserve Dynamic Reservation Endpoints allow reservations on > non-existing roles > > > Key: MESOS-4143 > URL: https://issues.apache.org/jira/browse/MESOS-4143 > Project: Mesos > Issue Type: Bug > Components: general >Affects Versions: 0.25.0, 0.26.0 >Reporter: John Omernik > > When working with Dynamic reservations via the /reserve and /unreserve > endpoints, it is possible to reserve resources for roles that have not been > specified via the --roles flag on the master. However, these roles are not > usable because the roles have not been defined, nor are they added to the > list of roles available. > Per the mailing list, changing roles after the fact is not possible at this > time. (That may be another JIRA), more importantly, the /reserve and > /unreserve end points should not allow reservation of roles not specified by > --roles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-4130) Document how the fetcher can reach across a proxy connection.
[ https://issues.apache.org/jira/browse/MESOS-4130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shuai Lin reassigned MESOS-4130: Assignee: Shuai Lin > Document how the fetcher can reach across a proxy connection. > - > > Key: MESOS-4130 > URL: https://issues.apache.org/jira/browse/MESOS-4130 > Project: Mesos > Issue Type: Documentation > Components: fetcher >Reporter: Bernd Mathiske >Assignee: Shuai Lin > Labels: mesosphere, newbie > > The fetcher uses libcurl for downloading content from HTTP, HTTPS, etc. There > is no source code in the pertinent parts of "net.hpp" that deals with proxy > settings. However, libcurl automatically picks up certain environment > variables and adjusts its settings accordingly. See "man libcurl-tutorial" > for details. See section "Proxies", subsection "Environment Variables". If > you follow this recipe in your Mesos agent startup script, you can use a > proxy. > We should document this in the fetcher (cache) doc > (http://mesos.apache.org/documentation/latest/fetcher/). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4144) Allow for dynamic updating of --roles
[ https://issues.apache.org/jira/browse/MESOS-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055276#comment-15055276 ] Yong Qiao Wang edited comment on MESOS-4144 at 12/14/15 2:05 AM: - Currently, Implicit Roles Epic is used to change the behavior of the master when --roles flag is NOT specified. Previously, this would allow only the "*" role to be used if --roles is not specified. Now, omitting --roles means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and --roles flag will be removed in the future. was (Author: jamesyongqiaowang): Currently, Implicit Roles Epic is used to change the behavior of the master when --roles flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting --roles means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. > Allow for dynamic updating of --roles > - > > Key: MESOS-4144 > URL: https://issues.apache.org/jira/browse/MESOS-4144 > Project: Mesos > Issue Type: Bug > Components: master >Affects Versions: 0.25.0 >Reporter: John Omernik > > Roles must be specified at master run time. If the environment changes, and > more roles are needed, it requires a restart of masters. Instead, there > should be a way via API to add roles or remove roles to properly authorized > principles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4144) Allow for dynamic updating of --roles
[ https://issues.apache.org/jira/browse/MESOS-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055276#comment-15055276 ] Yong Qiao Wang edited comment on MESOS-4144 at 12/14/15 2:04 AM: - Currently, Implicit Roles Epic is used to change the behavior of the master when --roles flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting --roles means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. was (Author: jamesyongqiaowang): Currently, Implicit Roles Epic is used to change the behavior of the master when the roles flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting --roles means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. > Allow for dynamic updating of --roles > - > > Key: MESOS-4144 > URL: https://issues.apache.org/jira/browse/MESOS-4144 > Project: Mesos > Issue Type: Bug > Components: master >Affects Versions: 0.25.0 >Reporter: John Omernik > > Roles must be specified at master run time. If the environment changes, and > more roles are needed, it requires a restart of masters. Instead, there > should be a way via API to add roles or remove roles to properly authorized > principles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4144) Allow for dynamic updating of --roles
[ https://issues.apache.org/jira/browse/MESOS-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055276#comment-15055276 ] Yong Qiao Wang edited comment on MESOS-4144 at 12/14/15 2:03 AM: - Currently, Implicit Roles Epic is used to change the behavior of the master when the roles flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting --roles means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. was (Author: jamesyongqiaowang): Currently, Implicit Roles Epic is used to change the behavior of the master when the --roles flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting "--roles" means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. > Allow for dynamic updating of --roles > - > > Key: MESOS-4144 > URL: https://issues.apache.org/jira/browse/MESOS-4144 > Project: Mesos > Issue Type: Bug > Components: master >Affects Versions: 0.25.0 >Reporter: John Omernik > > Roles must be specified at master run time. If the environment changes, and > more roles are needed, it requires a restart of masters. Instead, there > should be a way via API to add roles or remove roles to properly authorized > principles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-4147) Diagram images broken in "Mesos Architecture" docs
Randy Gelhausen created MESOS-4147: -- Summary: Diagram images broken in "Mesos Architecture" docs Key: MESOS-4147 URL: https://issues.apache.org/jira/browse/MESOS-4147 Project: Mesos Issue Type: Bug Components: documentation Reporter: Randy Gelhausen Priority: Minor http://mesos.apache.org/documentation/latest/architecture/ The architecture diagrams on the page above don't load because of broken image links. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4144) Allow for dynamic updating of --roles
[ https://issues.apache.org/jira/browse/MESOS-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055276#comment-15055276 ] Yong Qiao Wang edited comment on MESOS-4144 at 12/14/15 2:03 AM: - Currently, Implicit Roles Epic is used to change the behavior of the master when the --roles flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting "--roles" means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. was (Author: jamesyongqiaowang): Currently, Implicit Roles Epic is used to change the behavior of the master when the '--roles' flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting "--roles" means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. > Allow for dynamic updating of --roles > - > > Key: MESOS-4144 > URL: https://issues.apache.org/jira/browse/MESOS-4144 > Project: Mesos > Issue Type: Bug > Components: master >Affects Versions: 0.25.0 >Reporter: John Omernik > > Roles must be specified at master run time. If the environment changes, and > more roles are needed, it requires a restart of masters. Instead, there > should be a way via API to add roles or remove roles to properly authorized > principles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4144) Allow for dynamic updating of --roles
[ https://issues.apache.org/jira/browse/MESOS-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055276#comment-15055276 ] Yong Qiao Wang edited comment on MESOS-4144 at 12/14/15 2:02 AM: - Currently, Implicit Roles Epic is used to change the behavior of the master when the '--roles' flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting "--roles" means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. was (Author: jamesyongqiaowang): Currently, Implicit Roles Epic is used to change the behavior of the master when the "--roles" flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting "--roles" means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. > Allow for dynamic updating of --roles > - > > Key: MESOS-4144 > URL: https://issues.apache.org/jira/browse/MESOS-4144 > Project: Mesos > Issue Type: Bug > Components: master >Affects Versions: 0.25.0 >Reporter: John Omernik > > Roles must be specified at master run time. If the environment changes, and > more roles are needed, it requires a restart of masters. Instead, there > should be a way via API to add roles or remove roles to properly authorized > principles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Comment Edited] (MESOS-4144) Allow for dynamic updating of --roles
[ https://issues.apache.org/jira/browse/MESOS-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055276#comment-15055276 ] Yong Qiao Wang edited comment on MESOS-4144 at 12/14/15 2:02 AM: - Currently, Implicit Roles Epic is used to change the behavior of the master when the "--roles" flag is NOT specified. Previously, this would allow only the "*" role to be used if "--roles" is not specified. Now, omitting "--roles" means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. was (Author: jamesyongqiaowang): Currently, Implicit Roles Epic is used to change the behavior of the master when the `--roles` flag is NOT specified. Previously, this would allow only the `*` role to be used if '--roles' is not specified. Now, omitting `--roles` means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. > Allow for dynamic updating of --roles > - > > Key: MESOS-4144 > URL: https://issues.apache.org/jira/browse/MESOS-4144 > Project: Mesos > Issue Type: Bug > Components: master >Affects Versions: 0.25.0 >Reporter: John Omernik > > Roles must be specified at master run time. If the environment changes, and > more roles are needed, it requires a restart of masters. Instead, there > should be a way via API to add roles or remove roles to properly authorized > principles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4144) Allow for dynamic updating of --roles
[ https://issues.apache.org/jira/browse/MESOS-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055276#comment-15055276 ] Yong Qiao Wang commented on MESOS-4144: --- Currently, Implicit Roles Epic is used to change the behavior of the master when the `--roles` flag is NOT specified. Previously, this would allow only the `*` role to be used if '--roles' is not specified. Now, omitting `--roles` means that any role can be used. This is called "implicit roles". So Implicit Roles does not be used to dynamic update --roles. Actually, this JIRA is duplicated by MESOS-3177(Dynamic Roles/Weights). But currently, we are using Implicit Roles to support dynamic roles implicitly, and '--roles' flag will be removed in the future. > Allow for dynamic updating of --roles > - > > Key: MESOS-4144 > URL: https://issues.apache.org/jira/browse/MESOS-4144 > Project: Mesos > Issue Type: Bug > Components: master >Affects Versions: 0.25.0 >Reporter: John Omernik > > Roles must be specified at master run time. If the environment changes, and > more roles are needed, it requires a restart of masters. Instead, there > should be a way via API to add roles or remove roles to properly authorized > principles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-4146) Distinguish usage slack and allocation slack revocable resources
Guangya Liu created MESOS-4146: -- Summary: Distinguish usage slack and allocation slack revocable resources Key: MESOS-4146 URL: https://issues.apache.org/jira/browse/MESOS-4146 Project: Mesos Issue Type: Bug Reporter: Guangya Liu Assignee: Guangya Liu The API revocable() can now return resources which are revocable including both allocation slack and usage slack, it is better add two new APIs to return revocable resources for both allocation slack and usage slack. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-4145) Update allocator to get allocation slack resources
[ https://issues.apache.org/jira/browse/MESOS-4145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055223#comment-15055223 ] Guangya Liu commented on MESOS-4145: WIP: https://reviews.apache.org/r/40632/ > Update allocator to get allocation slack resources > -- > > Key: MESOS-4145 > URL: https://issues.apache.org/jira/browse/MESOS-4145 > Project: Mesos > Issue Type: Bug >Reporter: Guangya Liu >Assignee: Guangya Liu > > The allocator should be updated to report allocation slack resources to be > used by launch tasks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-4145) Update allocator to get allocation slack resources
Guangya Liu created MESOS-4145: -- Summary: Update allocator to get allocation slack resources Key: MESOS-4145 URL: https://issues.apache.org/jira/browse/MESOS-4145 Project: Mesos Issue Type: Bug Reporter: Guangya Liu Assignee: Guangya Liu The allocator should be updated to report allocation slack resources to be used by launch tasks. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-4144) Allow for dynamic updating of --roles
John Omernik created MESOS-4144: --- Summary: Allow for dynamic updating of --roles Key: MESOS-4144 URL: https://issues.apache.org/jira/browse/MESOS-4144 Project: Mesos Issue Type: Bug Components: master Affects Versions: 0.25.0 Reporter: John Omernik Roles must be specified at master run time. If the environment changes, and more roles are needed, it requires a restart of masters. Instead, there should be a way via API to add roles or remove roles to properly authorized principles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MESOS-4143) Reserse/UnReserve Dynamic Reservation Endpoints allow reservations on non-existing roles
John Omernik created MESOS-4143: --- Summary: Reserse/UnReserve Dynamic Reservation Endpoints allow reservations on non-existing roles Key: MESOS-4143 URL: https://issues.apache.org/jira/browse/MESOS-4143 Project: Mesos Issue Type: Bug Components: general Affects Versions: 0.25.0, 0.26.0 Reporter: John Omernik When working with Dynamic reservations via the /reserve and /unreserve endpoints, it is possible to reserve resources for roles that have not been specified via the --roles flag on the master. However, these roles are not usable because the roles have not been defined, nor are they added to the list of roles available. Per the mailing list, changing roles after the fact is not possible at this time. (That may be another JIRA), more importantly, the /reserve and /unreserve end points should not allow reservation of roles not specified by --roles. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Assigned] (MESOS-4142) HttpAuthenticationTest.Unauthorized is flaky
[
https://issues.apache.org/jira/browse/MESOS-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Rojas reassigned MESOS-4142:
--
Assignee: Alexander Rojas
> HttpAuthenticationTest.Unauthorized is flaky
>
>
> Key: MESOS-4142
> URL: https://issues.apache.org/jira/browse/MESOS-4142
> Project: Mesos
> Issue Type: Bug
> Components: libprocess
>Reporter: Joris Van Remoortere
>Assignee: Alexander Rojas
> Labels: authentication, libprocess, mesosphere
>
> {code}
> [ RUN ] HttpAuthenticationTest.Unauthorized
> libprocess: (35605)@127.0.1.1:40875 terminating due to Uninteresting mock
> function call - returning default value.
> Function call: authenticated(@0x7f412c016540 224-byte object <38-68 01-2C
> 41-7F 00-00 01-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 01-00 00-00 00-00
> 00-00 00-00 00-00 00-00 00-00 01-00 00-00 00-00 00-00 00-00 00-00 01-00 00-00
> 00-00 00-00 00-00 00-00 ... E0-75 01-2C 41-7F 00-00 03-00 00-00 00-00 00-00
> 00-00 80-3F 00-00 00-00 0B-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 78-A6
> F9-3A 41-7F 00-00 00-00 00-00 02-00 00-00 7F-00 00-01 13-EB 00-00>,
> @0x7f411c614cd8 16-byte object <01-00 00-00 00-00 00-00 E8-66 91-01 00-00
> 00-00>)
> The mock function has no default action set, and its return type has no
> default value set.
> ../../../3rdparty/libprocess/src/tests/http_tests.cpp:1271: Failure
> Value of: (response).get().status
> Actual: "500 Internal Server Error"
> Expected: http::Unauthorized(vector()).status
> Which is: "401 Unauthorized"
> terminate called after throwing an instance of
> 'testing::internal::GoogleTestFailureException'
> what(): ../../../3rdparty/libprocess/src/tests/http_tests.cpp:1271: Failure
> Value of: (response).get().status
> Actual: "500 Internal Server Error"
> Expected: http::Unauthorized(vector()).status
> Which is: "401 Unauthorized"
> *** Aborted at 1449970589 (unix time) try "date -d @1449970589" if you are
> using GNU date ***
> PC: @ 0x7f413a6e1267 (unknown)
> *** SIGABRT (@0x3e8641e) received by PID 25630 (TID 0x7f413c81f7c0) from
> PID 25630; stack trace: ***
> @ 0x7f413c206d10 (unknown)
> @ 0x7f413a6e1267 (unknown)
> @ 0x7f413a6e2eca (unknown)
> @ 0x7f413aced06d (unknown)
> @ 0x7f413aceaee6 (unknown)
> @ 0x7f413aceaf31 (unknown)
> @ 0x7f413aceb199 (unknown)
> @ 0x73369d
> testing::internal::HandleExceptionsInMethodIfSupported<>()
> @ 0x71a605 testing::UnitTest::Run()
> @ 0x53e201 RUN_ALL_TESTS()
> @ 0x53dfa2 main
> @ 0x7f413a6cca40 (unknown)
> @ 0x419599 _start
> Aborted (core dumped)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-4142) HttpAuthenticationTest.Unauthorized is flaky
[
https://issues.apache.org/jira/browse/MESOS-4142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055027#comment-15055027
]
Alexander Rojas commented on MESOS-4142:
So the root of the problem is the asynchronicity of {{spawn}} and
{{ProcessBase::initialize()}}. The bug occurs because in
[{{http_tests.cpp}}|https://github.com/apache/mesos/blob/6bd9b65b9d93f154ff9187fb5e5136262ede043c/3rdparty/libprocess/src/tests/http_tests.cpp#L71]
the class {{HttpProcess}} execute calls to {{ProcessBase::route()}} commands
in the overload of {{ProcessBase::initialize()}}, this causes the endpoint to
be registered for authentication after the request was made. Below I post a
timeline of the bug (Which somewhat is more likely to happen under gcc than
under clang):
* {{Http http}} is created.
* {{Http::Http()}} calls {{HttpProcess::HttpProcess}}.
* {{Http::Http()}} calls {{spawn(process) // where process is an instance of
HttpProcess}}.
* {{spawn(process)}} calls {{enqueue(process)}} which will call
{{HttpProcess::initialize()}} later.
* {{Http::Http()}} returns and can be used already.
* The test calls {{http::get(http.process->self(), "authenticated")}}.
* The request arrives to {{ProcessManager::handle()}} it dispatches for
authentication.
* At this point {{HttpProcess::initialize()}} begins to be executed.
* Request arrives to {{AuthenticationRouterProcess::authenticate()}}, it
doesn't find the path of the request into the registered endpoints.
* {{AuthenticationRouterProcess::authenticate()}} returns with a non
authentication needed response.
* {{HttpProcess::initialize()}} calls {{route("/authenticated", "realm",
None(), &HttpProcess::authenticated);}} At this point it is too late to set
authentication.
* {{ProcessManager::handle()}} dispatches the request to the instance of
{{Http}} but it is too late to set handler. Test fails.
As I see it, this race existed before and I find it rather surprising that it
didn't affected other tests before, while it is true that {{route}} takes
longer if it requires authentication. I have an easy workaround which is
calling {{route}} from {{HttpProcess}} constructor, however, I think we should
evaluate how wise is to allow the use of processes if initialize hasn't run, or
at least being able to wait until the process is initialized.
> HttpAuthenticationTest.Unauthorized is flaky
>
>
> Key: MESOS-4142
> URL: https://issues.apache.org/jira/browse/MESOS-4142
> Project: Mesos
> Issue Type: Bug
> Components: libprocess
>Reporter: Joris Van Remoortere
> Labels: authentication, libprocess, mesosphere
>
> {code}
> [ RUN ] HttpAuthenticationTest.Unauthorized
> libprocess: (35605)@127.0.1.1:40875 terminating due to Uninteresting mock
> function call - returning default value.
> Function call: authenticated(@0x7f412c016540 224-byte object <38-68 01-2C
> 41-7F 00-00 01-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 01-00 00-00 00-00
> 00-00 00-00 00-00 00-00 00-00 01-00 00-00 00-00 00-00 00-00 00-00 01-00 00-00
> 00-00 00-00 00-00 00-00 ... E0-75 01-2C 41-7F 00-00 03-00 00-00 00-00 00-00
> 00-00 80-3F 00-00 00-00 0B-00 00-00 00-00 00-00 00-00 00-00 00-00 00-00 78-A6
> F9-3A 41-7F 00-00 00-00 00-00 02-00 00-00 7F-00 00-01 13-EB 00-00>,
> @0x7f411c614cd8 16-byte object <01-00 00-00 00-00 00-00 E8-66 91-01 00-00
> 00-00>)
> The mock function has no default action set, and its return type has no
> default value set.
> ../../../3rdparty/libprocess/src/tests/http_tests.cpp:1271: Failure
> Value of: (response).get().status
> Actual: "500 Internal Server Error"
> Expected: http::Unauthorized(vector()).status
> Which is: "401 Unauthorized"
> terminate called after throwing an instance of
> 'testing::internal::GoogleTestFailureException'
> what(): ../../../3rdparty/libprocess/src/tests/http_tests.cpp:1271: Failure
> Value of: (response).get().status
> Actual: "500 Internal Server Error"
> Expected: http::Unauthorized(vector()).status
> Which is: "401 Unauthorized"
> *** Aborted at 1449970589 (unix time) try "date -d @1449970589" if you are
> using GNU date ***
> PC: @ 0x7f413a6e1267 (unknown)
> *** SIGABRT (@0x3e8641e) received by PID 25630 (TID 0x7f413c81f7c0) from
> PID 25630; stack trace: ***
> @ 0x7f413c206d10 (unknown)
> @ 0x7f413a6e1267 (unknown)
> @ 0x7f413a6e2eca (unknown)
> @ 0x7f413aced06d (unknown)
> @ 0x7f413aceaee6 (unknown)
> @ 0x7f413aceaf31 (unknown)
> @ 0x7f413aceb199 (unknown)
> @ 0x73369d
> testing::internal::HandleExceptionsInMethodIfSupported<>()
> @ 0x71a605 testing::UnitTest::Run()
> @ 0x53e201 RUN_ALL_TESTS()
> @ 0x53dfa2 main
> @ 0x7f413a6cca40 (unknown)
> @ 0x419599 _
