[jira] [Commented] (MESOS-2673) Follow Google Style Guide for header file include order completely.
[ https://issues.apache.org/jira/browse/MESOS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546199#comment-14546199 ] Marco Massenzio commented on MESOS-2673: Does this really need to be an "Epic"? I'm turning it into a Story (also, "There are no Issues in this epic") - if you feel otherwise, please let me know. Also, can you please update progress? > Follow Google Style Guide for header file include order completely. > --- > > Key: MESOS-2673 > URL: https://issues.apache.org/jira/browse/MESOS-2673 > Project: Mesos > Issue Type: Epic >Reporter: Joerg Schad >Assignee: Joerg Schad > > The header include order for Mesos actually follows the Google Styleguide but > omits step 1 without mentioning this exception in the Mesos styleguide. This > proposal suggests to adapt to the include order explained in the Google > Styleguide i.e. include the direct headers first in the .cpp files > implementing them. > A gist of the proposal can be found here: > https://gist.github.com/joerg84/65cb9611d24b2e35b69b > The corresponding Review Board review can be found here: > https://reviews.apache.org/r/33646/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2673) Follow Google Style Guide for header file include order completely.
[ https://issues.apache.org/jira/browse/MESOS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590666#comment-14590666 ] Niklas Quarfot Nielsen commented on MESOS-2673: --- [~js84] Are you getting reviews on this? I was a bit confused about the proposal directory - is that new? > Follow Google Style Guide for header file include order completely. > --- > > Key: MESOS-2673 > URL: https://issues.apache.org/jira/browse/MESOS-2673 > Project: Mesos > Issue Type: Improvement >Reporter: Joerg Schad >Assignee: Joerg Schad >Priority: Minor > Fix For: 0.23.0 > > > The header include order for Mesos actually follows the Google Styleguide but > omits step 1 without mentioning this exception in the Mesos styleguide. This > proposal suggests to adapt to the include order explained in the Google > Styleguide i.e. include the direct headers first in the .cpp files > implementing them. > A gist of the proposal can be found here: > https://gist.github.com/joerg84/65cb9611d24b2e35b69b > The corresponding Review Board review can be found here: > https://reviews.apache.org/r/33646/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MESOS-2673) Follow Google Style Guide for header file include order completely.
[ https://issues.apache.org/jira/browse/MESOS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14599195#comment-14599195 ] Adam B commented on MESOS-2673: --- [~js84] If, as described in the gist, this Epic describes not just updating the style guide, but also making the changes in stout/libprocess/mesos, then I highly doubt that we will complete this Epic in time for 0.23. Could you please retarget to 0.24 if appropriate? Thanks! > Follow Google Style Guide for header file include order completely. > --- > > Key: MESOS-2673 > URL: https://issues.apache.org/jira/browse/MESOS-2673 > Project: Mesos > Issue Type: Improvement >Reporter: Joerg Schad >Assignee: Joerg Schad >Priority: Minor > Labels: mesosphere > Fix For: 0.23.0 > > > The header include order for Mesos actually follows the Google Styleguide but > omits step 1 without mentioning this exception in the Mesos styleguide. This > proposal suggests to adapt to the include order explained in the Google > Styleguide i.e. include the direct headers first in the .cpp files > implementing them. > A gist of the proposal can be found here: > https://gist.github.com/joerg84/65cb9611d24b2e35b69b > The corresponding Review Board review can be found here: > https://reviews.apache.org/r/33646/ -- This message was sent by Atlassian JIRA (v6.3.4#6332)
