[GitHub] [nifi] ijokarumawak commented on issue #3404: NIFI-5176 Java 11 Build Compatibilty
ijokarumawak commented on issue #3404: NIFI-5176 Java 11 Build Compatibilty URL: https://github.com/apache/nifi/pull/3404#issuecomment-517126697 I'm also +1. Full clean build and contrib check passed and a secured NiFi cluster worked as expected. I used Oracle JDK 11.0.3. Thanks for your effort @jtstorck ! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6479) Fix TestJdbcCommon timezone issues
[
https://issues.apache.org/jira/browse/NIFI-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Storck updated NIFI-6479:
--
Description:
TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is failing
with timezone issues.
The workaround for this issue is to add
{code:java}
-Dmaven.surefire.arguments=-Duser.timezone=UTC
{code}
when running maven. If {{-Dmaven.surefire.arguments}} is already specified as
part of the build, add {{-Duser.timezone=UTC}} to the value supplied to that
parameter.
was:
TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is failing
with timezone issues.
The workaround for this error is to add
{code:java}
-Dmaven.surefire.arguments=-Duser.timezone=UTC
{code}
when running maven. If {{-Dmaven.surefire.arguments}} is already specified as
part of the build, add {{-Duser.timezone=UTC}} to the value supplied to that
parameter.
> Fix TestJdbcCommon timezone issues
> --
>
> Key: NIFI-6479
> URL: https://issues.apache.org/jira/browse/NIFI-6479
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.9.2
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is failing
> with timezone issues.
> The workaround for this issue is to add
> {code:java}
> -Dmaven.surefire.arguments=-Duser.timezone=UTC
> {code}
> when running maven. If {{-Dmaven.surefire.arguments}} is already specified
> as part of the build, add {{-Duser.timezone=UTC}} to the value supplied to
> that parameter.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (NIFI-6479) Fix TestJdbcCommon timezone issues
[
https://issues.apache.org/jira/browse/NIFI-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897740#comment-16897740
]
Jeff Storck commented on NIFI-6479:
---
[~pcgrenier] I updated the description of this JIRA with a workaround if you
encounter this issue.
> Fix TestJdbcCommon timezone issues
> --
>
> Key: NIFI-6479
> URL: https://issues.apache.org/jira/browse/NIFI-6479
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.9.2
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is failing
> with timezone issues.
> The workaround for this error is to add
> {code:java}
> -Dmaven.surefire.arguments=-Duser.timezone=UTC
> {code}
> when running maven. If {{-Dmaven.surefire.arguments}} is already specified
> as part of the build, add {{-Duser.timezone=UTC}} to the value supplied to
> that parameter.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (NIFI-6479) Fix TestJdbcCommon timezone issues
[
https://issues.apache.org/jira/browse/NIFI-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jeff Storck updated NIFI-6479:
--
Description:
TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is failing
with timezone issues.
The workaround for this error is to add
{code:java}
-Dmaven.surefire.arguments=-Duser.timezone=UTC
{code}
when running maven. If {{-Dmaven.surefire.arguments}} is already specified as
part of the build, add {{-Duser.timezone=UTC}} to the value supplied to that
parameter.
was:TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is
failing with timezone issues.
> Fix TestJdbcCommon timezone issues
> --
>
> Key: NIFI-6479
> URL: https://issues.apache.org/jira/browse/NIFI-6479
> Project: Apache NiFi
> Issue Type: Bug
> Components: Extensions
>Affects Versions: 1.9.2
>Reporter: Jeff Storck
>Assignee: Jeff Storck
>Priority: Major
>
> TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is failing
> with timezone issues.
> The workaround for this error is to add
> {code:java}
> -Dmaven.surefire.arguments=-Duser.timezone=UTC
> {code}
> when running maven. If {{-Dmaven.surefire.arguments}} is already specified
> as part of the build, add {{-Duser.timezone=UTC}} to the value supplied to
> that parameter.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [nifi] SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation
SandishKumarHN commented on issue #3387: NIFI-6009 ScanKudu Processor & KuduPut Processor Delete Operation URL: https://github.com/apache/nifi/pull/3387#issuecomment-517101715 @granthenke made changes suggestion on the main PR. #3611 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] SandishKumarHN commented on issue #3611: NIFI-6009 ScanKudu Processor
SandishKumarHN commented on issue #3611: NIFI-6009 ScanKudu Processor URL: https://github.com/apache/nifi/pull/3611#issuecomment-517101706 @granthanke made changes suggestion on the previous one This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6513) The property of PutHive3Streaming Processor named "Auto-Create Partitions" is useless
[ https://issues.apache.org/jira/browse/NIFI-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Wang updated NIFI-6513: -- Description: The PutHive3Streaming processor always creates the partition, regardless of whether the value of property named "Auto-Create Partitions" is set to true or false。 (was: The property of PutHive3Streaming Processor named is useless The PutHive3Streaming processor always creates the partition, regardless of whether the value of property named "Auto-Create Partitions" is set to true or false。) > The property of PutHive3Streaming Processor named "Auto-Create Partitions" is > useless > - > > Key: NIFI-6513 > URL: https://issues.apache.org/jira/browse/NIFI-6513 > Project: Apache NiFi > Issue Type: Bug > Components: Core Framework >Affects Versions: 1.9.0 > Environment: Hive3.1.0 >Reporter: Lu Wang >Priority: Major > > The PutHive3Streaming processor always creates the partition, regardless of > whether the value of property named "Auto-Create Partitions" is set to true > or false。 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (NIFI-6514) Add Chinese filename support to the processors
[ https://issues.apache.org/jira/browse/NIFI-6514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Wang updated NIFI-6514: -- Description: The processors, such as ListFTP, can not correctly identify Chinese file names. Summary: Add Chinese filename support to the processors (was: Processors) > Add Chinese filename support to the processors > --- > > Key: NIFI-6514 > URL: https://issues.apache.org/jira/browse/NIFI-6514 > Project: Apache NiFi > Issue Type: Improvement >Reporter: Lu Wang >Priority: Major > > The processors, such as ListFTP, can not correctly identify Chinese file > names. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (NIFI-6514) Add Chinese filename support to the processors
[ https://issues.apache.org/jira/browse/NIFI-6514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lu Wang updated NIFI-6514: -- Affects Version/s: 1.9.0 Component/s: Core Framework > Add Chinese filename support to the processors > --- > > Key: NIFI-6514 > URL: https://issues.apache.org/jira/browse/NIFI-6514 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.9.0 >Reporter: Lu Wang >Priority: Major > > The processors, such as ListFTP, can not correctly identify Chinese file > names. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (NIFI-6514) Processors
Lu Wang created NIFI-6514: - Summary: Processors Key: NIFI-6514 URL: https://issues.apache.org/jira/browse/NIFI-6514 Project: Apache NiFi Issue Type: Improvement Reporter: Lu Wang -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (NIFI-6513) The property of PutHive3Streaming Processor named "Auto-Create Partitions" is useless
Lu Wang created NIFI-6513: - Summary: The property of PutHive3Streaming Processor named "Auto-Create Partitions" is useless Key: NIFI-6513 URL: https://issues.apache.org/jira/browse/NIFI-6513 Project: Apache NiFi Issue Type: Bug Components: Core Framework Affects Versions: 1.9.0 Environment: Hive3.1.0 Reporter: Lu Wang The property of PutHive3Streaming Processor named is useless The PutHive3Streaming processor always creates the partition, regardless of whether the value of property named "Auto-Create Partitions" is set to true or false。 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #612: MINIFICPP-854: Capture RTSP Frame
arpadboda closed pull request #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MINIFICPP-994) Opencv shouldn't be build by bootstrap (cmake), just cloned. Building it should be part of MiNiFi build.
[
https://issues.apache.org/jira/browse/MINIFICPP-994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpad Boda updated MINIFICPP-994:
-
Description:
Opencv is built when executing a cmake command (for eg. using bootstrap), which
seems to be wrong as:
* This build is single-threaded, takes a lot of time
* Linker warnings are generated when building MiNiFI:
{code}
ld: warning: direct access in function '___cxx_global_var_init.35' from file
'../thirdparty/opencv/opencv-external/src/opencv-external-build/lib/libopencv_flann.a(miniflann.cpp.o)'
to global weak symbol 'guard variable for
cvflann::anyimpl::SinglePolicy, std::__1::allocator > >::policy' from file
'CMakeFiles/CaptureRTSPFrameTest.dir/CaptureRTSPFrameTest.cpp.o' means the weak
symbol cannot be overridden at runtime. This was likely caused by different
translation units being compiled with different visibility settings.
{code}
Static linking should be kept when integrating opencv build to the build
process of MiNiFi.
was:
Opencv is built when executing a cmake command (for eg. using bootstrap), which
seems to be wrong as:
* This build is single-threaded, takes a lot of time
* Linker warnings are generated when building MiNiFI:
```
ld: warning: direct access in function '___cxx_global_var_init.35' from file
'../thirdparty/opencv/opencv-external/src/opencv-external-build/lib/libopencv_flann.a(miniflann.cpp.o)'
to global weak symbol 'guard variable for
cvflann::anyimpl::SinglePolicy, std::__1::allocator > >::policy' from file
'CMakeFiles/CaptureRTSPFrameTest.dir/CaptureRTSPFrameTest.cpp.o' means the weak
symbol cannot be overridden at runtime. This was likely caused by different
translation units being compiled with different visibility settings.
```
Static linking should be kept when integrating opencv build to the build
process of MiNiFi.
> Opencv shouldn't be build by bootstrap (cmake), just cloned. Building it
> should be part of MiNiFi build.
>
>
> Key: MINIFICPP-994
> URL: https://issues.apache.org/jira/browse/MINIFICPP-994
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Affects Versions: 0.6.0
>Reporter: Arpad Boda
>Assignee: Nghia Le
>Priority: Minor
>
> Opencv is built when executing a cmake command (for eg. using bootstrap),
> which seems to be wrong as:
> * This build is single-threaded, takes a lot of time
> * Linker warnings are generated when building MiNiFI:
> {code}
> ld: warning: direct access in function '___cxx_global_var_init.35' from file
> '../thirdparty/opencv/opencv-external/src/opencv-external-build/lib/libopencv_flann.a(miniflann.cpp.o)'
> to global weak symbol 'guard variable for
> cvflann::anyimpl::SinglePolicy std::__1::char_traits, std::__1::allocator > >::policy' from file
> 'CMakeFiles/CaptureRTSPFrameTest.dir/CaptureRTSPFrameTest.cpp.o' means the
> weak symbol cannot be overridden at runtime. This was likely caused by
> different translation units being compiled with different visibility settings.
> {code}
> Static linking should be kept when integrating opencv build to the build
> process of MiNiFi.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (MINIFICPP-995) Opencv testing should be improved
[
https://issues.apache.org/jira/browse/MINIFICPP-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpad Boda updated MINIFICPP-995:
-
Description:
As we proceed with opencv we will need to be able to verify motion-detection
and face-detection for eg., which requires using captures, basically being able
to stream video in our unit or integration tests.
The current opencv tests seems to fail anyway, but it's not a big issue given
it depends on an external source:
{code}
[2019-08-tracel 00:04:04.971]
[org::apache::nifi::minifi::processors::CaptureRTSPFrame] [trace]
CaptureRTSPFrame processor scheduled
OpenCV: Couldn't read video stream from file "rtsp://:@170.93.143.139/abcd"
[2019-08-errorl 00:04:04.972]
[org::apache::nifi::minifi::processors::CaptureRTSPFrame] [error] Unable to
open RTSP stream: OpenCV(4.1.0)
/Users/aboda/work/shadow/PRs/nifi-minifi-cpp/build/extensions/opencv/thirdparty/opencv/opencv-external/src/opencv-external/modules/videoio/src/cap.cpp:206:
error: (-215:Assertion failed) api != 0 in function 'getBackendName'
{code}
was:
As we proceed with opencv we will need to be able to verify motion-detection
and face-detection for eg., which requires using captures, basically being able
to stream video in our unit or integration tests.
The current opencv tests seems to fail anyway, but it's not a big issue given
it depends on an external source:
```
[2019-08-tracel 00:04:04.971]
[org::apache::nifi::minifi::processors::CaptureRTSPFrame] [trace]
CaptureRTSPFrame processor scheduled
OpenCV: Couldn't read video stream from file "rtsp://:@170.93.143.139/abcd"
[2019-08-errorl 00:04:04.972]
[org::apache::nifi::minifi::processors::CaptureRTSPFrame] [error] Unable to
open RTSP stream: OpenCV(4.1.0)
/Users/aboda/work/shadow/PRs/nifi-minifi-cpp/build/extensions/opencv/thirdparty/opencv/opencv-external/src/opencv-external/modules/videoio/src/cap.cpp:206:
error: (-215:Assertion failed) api != 0 in function 'getBackendName'
```
> Opencv testing should be improved
> -
>
> Key: MINIFICPP-995
> URL: https://issues.apache.org/jira/browse/MINIFICPP-995
> Project: Apache NiFi MiNiFi C++
> Issue Type: Improvement
>Reporter: Arpad Boda
>Assignee: Nghia Le
>Priority: Minor
>
> As we proceed with opencv we will need to be able to verify motion-detection
> and face-detection for eg., which requires using captures, basically being
> able to stream video in our unit or integration tests.
> The current opencv tests seems to fail anyway, but it's not a big issue given
> it depends on an external source:
> {code}
> [2019-08-tracel 00:04:04.971]
> [org::apache::nifi::minifi::processors::CaptureRTSPFrame] [trace]
> CaptureRTSPFrame processor scheduled
> OpenCV: Couldn't read video stream from file "rtsp://:@170.93.143.139/abcd"
> [2019-08-errorl 00:04:04.972]
> [org::apache::nifi::minifi::processors::CaptureRTSPFrame] [error] Unable to
> open RTSP stream: OpenCV(4.1.0)
> /Users/aboda/work/shadow/PRs/nifi-minifi-cpp/build/extensions/opencv/thirdparty/opencv/opencv-external/src/opencv-external/modules/videoio/src/cap.cpp:206:
> error: (-215:Assertion failed) api != 0 in function 'getBackendName'
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [nifi-minifi-cpp] arpadboda commented on issue #612: MINIFICPP-854: Capture RTSP Frame
arpadboda commented on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-517040775 Added further follow-ups: https://issues.apache.org/jira/browse/MINIFICPP-994 https://issues.apache.org/jira/browse/MINIFICPP-995 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MINIFICPP-995) Opencv testing should be improved
Arpad Boda created MINIFICPP-995: Summary: Opencv testing should be improved Key: MINIFICPP-995 URL: https://issues.apache.org/jira/browse/MINIFICPP-995 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Arpad Boda Assignee: Nghia Le As we proceed with opencv we will need to be able to verify motion-detection and face-detection for eg., which requires using captures, basically being able to stream video in our unit or integration tests. The current opencv tests seems to fail anyway, but it's not a big issue given it depends on an external source: ``` [2019-08-tracel 00:04:04.971] [org::apache::nifi::minifi::processors::CaptureRTSPFrame] [trace] CaptureRTSPFrame processor scheduled OpenCV: Couldn't read video stream from file "rtsp://:@170.93.143.139/abcd" [2019-08-errorl 00:04:04.972] [org::apache::nifi::minifi::processors::CaptureRTSPFrame] [error] Unable to open RTSP stream: OpenCV(4.1.0) /Users/aboda/work/shadow/PRs/nifi-minifi-cpp/build/extensions/opencv/thirdparty/opencv/opencv-external/src/opencv-external/modules/videoio/src/cap.cpp:206: error: (-215:Assertion failed) api != 0 in function 'getBackendName' ``` -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (MINIFICPP-994) Opencv shouldn't be build by bootstrap (cmake), just cloned. Building it should be part of MiNiFi build.
Arpad Boda created MINIFICPP-994: Summary: Opencv shouldn't be build by bootstrap (cmake), just cloned. Building it should be part of MiNiFi build. Key: MINIFICPP-994 URL: https://issues.apache.org/jira/browse/MINIFICPP-994 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Affects Versions: 0.6.0 Reporter: Arpad Boda Assignee: Nghia Le Opencv is built when executing a cmake command (for eg. using bootstrap), which seems to be wrong as: * This build is single-threaded, takes a lot of time * Linker warnings are generated when building MiNiFI: ``` ld: warning: direct access in function '___cxx_global_var_init.35' from file '../thirdparty/opencv/opencv-external/src/opencv-external-build/lib/libopencv_flann.a(miniflann.cpp.o)' to global weak symbol 'guard variable for cvflann::anyimpl::SinglePolicy, std::__1::allocator > >::policy' from file 'CMakeFiles/CaptureRTSPFrameTest.dir/CaptureRTSPFrameTest.cpp.o' means the weak symbol cannot be overridden at runtime. This was likely caused by different translation units being compiled with different visibility settings. ``` Static linking should be kept when integrating opencv build to the build process of MiNiFi. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi-minifi-cpp] arpadboda commented on issue #612: MINIFICPP-854: Capture RTSP Frame
arpadboda commented on issue #612: MINIFICPP-854: Capture RTSP Frame URL: https://github.com/apache/nifi-minifi-cpp/pull/612#issuecomment-517024298 Merging this, handling env vars is a complex topic, to be followed up in scope of https://issues.apache.org/jira/browse/MINIFICPP-991 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #614: MINIFICPP-732 - Add property to expose librdkafka "debug" values for …
arpadboda closed pull request #614: MINIFICPP-732 - Add property to expose librdkafka "debug" values for … URL: https://github.com/apache/nifi-minifi-cpp/pull/614 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] arpadboda commented on issue #614: MINIFICPP-732 - Add property to expose librdkafka "debug" values for …
arpadboda commented on issue #614: MINIFICPP-732 - Add property to expose librdkafka "debug" values for … URL: https://github.com/apache/nifi-minifi-cpp/pull/614#issuecomment-517021684 Merging this as it works and adds feature, property validation will be done in scope of the linked follow-up. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6479) Fix TestJdbcCommon timezone issues
[ https://issues.apache.org/jira/browse/NIFI-6479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897526#comment-16897526 ] Phillip Grenier commented on NIFI-6479: --- Can we get an ignore on this, until fixed? TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType > Fix TestJdbcCommon timezone issues > -- > > Key: NIFI-6479 > URL: https://issues.apache.org/jira/browse/NIFI-6479 > Project: Apache NiFi > Issue Type: Bug > Components: Extensions >Affects Versions: 1.9.2 >Reporter: Jeff Storck >Assignee: Jeff Storck >Priority: Major > > TestJdbcCommon.testConvertToAvroStreamForDateTimeAsLogicalType() is failing > with timezone issues. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (MINIFICPP-993) Use JNI to leverage NiFi tests for V on MiNiFi components
Mr TheSegfault created MINIFICPP-993: Summary: Use JNI to leverage NiFi tests for V on MiNiFi components Key: MINIFICPP-993 URL: https://issues.apache.org/jira/browse/MINIFICPP-993 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Mr TheSegfault We should be able to use the JNI extension to test MiNiFi against NiFi tests that already exist and are trusted -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] pcgrenier commented on issue #3624: NIFI-6255 NIFI-6287: Hash function for expression language and record…
pcgrenier commented on issue #3624: NIFI-6255 NIFI-6287: Hash function for expression language and record… URL: https://github.com/apache/nifi/pull/3624#issuecomment-517009188 Looks like travis-ci failed to get a dependency [ERROR] Failed to execute goal org.antlr:antlr3-maven-plugin:3.5.2:antlr (default) on project nifi-hl7-query-language: Execution default of goal org.antlr:antlr3-maven-plugin:3.5.2:antlr failed: Plugin org.antlr:antlr3-maven-plugin:3.5.2 or one of its dependencies could not be resolved: Could not transfer artifact org.antlr:antlr:jar:3.5.2 from/to google-maven-central (https://maven-central.storage-download.googleapis.com/repos/central/data/): Failed to transfer file https://maven-central.storage-download.googleapis.com/repos/central/data/org/antlr/antlr/3.5.2/antlr-3.5.2.jar with status code 503 -> [Help 1] This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] AxelSync commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
AxelSync commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309412328
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
+ final Evaluator pad) {
+this.subject = subject;
+this.desiredLength = desiredLength;
+this.pad = pad;
+}
+
+@Override
+public QueryResult evaluate(final Map attributes,
final EvaluatorState context) {
+final String subjectValue = subject.evaluate(attributes,
context).getValue();
+if (subjectValue == null) {
+return new StringQueryResult(null);
+}
+final Long desiredLengthValue = desiredLength.evaluate(attributes,
context).getValue();
+if(desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
+return new StringQueryResult(null);
+}
+
+char padValue;
Review comment:
ah ok. In this case I'll do the same also in #3613 to preserve same behavior
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language URL: https://github.com/apache/nifi/pull/3615#discussion_r309410648 ## File path: nifi-commons/nifi-expression-language/src/main/antlr3/org/apache/nifi/attribute/expression/language/antlr/AttributeExpressionParser.g ## @@ -77,8 +77,9 @@ zeroArgString : (TO_UPPER | TO_LOWER | TRIM | TO_STRING | URL_ENCODE | URL_DECOD oneArgString : ((SUBSTRING_BEFORE | SUBSTRING_BEFORE_LAST | SUBSTRING_AFTER | SUBSTRING_AFTER_LAST | REPLACE_NULL | REPLACE_EMPTY | PREPEND | APPEND | STARTS_WITH | ENDS_WITH | CONTAINS | JOIN | JSON_PATH | FROM_RADIX) LPAREN! anyArg RPAREN!) | (TO_RADIX LPAREN! anyArg (COMMA! anyArg)? RPAREN!); -twoArgString : ((REPLACE | REPLACE_FIRST | REPLACE_ALL | IF_ELSE) LPAREN! anyArg COMMA! anyArg RPAREN!) | - ((SUBSTRING | FORMAT) LPAREN! anyArg (COMMA! anyArg)? RPAREN!); +twoArgString : ((REPLACE | REPLACE_FIRST | REPLACE_ALL | IF_ELSE | ) LPAREN! anyArg COMMA! anyArg RPAREN!) | + ((SUBSTRING | FORMAT) LPAREN! anyArg (COMMA! anyArg)? RPAREN!) | (PAD_LEFT LPAREN! anyArg (COMMA! anyArg)? RPAREN!) | Review comment: yes, but if you put them in the list with `SUBSTRING | FORMAT`, you allow 2 parameters, don't you? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309410305
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
+ final Evaluator pad) {
+this.subject = subject;
+this.desiredLength = desiredLength;
+this.pad = pad;
+}
+
+@Override
+public QueryResult evaluate(final Map attributes,
final EvaluatorState context) {
+final String subjectValue = subject.evaluate(attributes,
context).getValue();
+if (subjectValue == null) {
+return new StringQueryResult(null);
+}
+final Long desiredLengthValue = desiredLength.evaluate(attributes,
context).getValue();
+if(desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
+return new StringQueryResult(null);
+}
+
+char padValue;
Review comment:
yes. `StringUtils` you're using has a method for that.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309410111
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
+ final Evaluator pad) {
+this.subject = subject;
+this.desiredLength = desiredLength;
+this.pad = pad;
+}
+
+@Override
+public QueryResult evaluate(final Map attributes,
final EvaluatorState context) {
+final String subjectValue = subject.evaluate(attributes,
context).getValue();
+if (subjectValue == null) {
+return new StringQueryResult(null);
+}
+final Long desiredLengthValue = desiredLength.evaluate(attributes,
context).getValue();
+if(desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
Review comment:
I think we should just return the string as it is. Overflow is not handled
in other expression language functions, and when overflow happens, a negative
value is returned. So I think it is fine to behave as for negative values in
case of overflow. At least, it is consistent with other EL functions.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Comment Edited] (MINIFICPP-990) Segfault on SIGINT after shutdown initiated
[ https://issues.apache.org/jira/browse/MINIFICPP-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897484#comment-16897484 ] Mr TheSegfault edited comment on MINIFICPP-990 at 7/31/19 8:08 PM: --- Thanks for debugging. I always assumed the issue is that we wait on the sem, close it then unlink it before unloading flow controller, meaning when we sem_post, the semaphore won't exist. We should likely move those sem close and sem unlink after "MiNiFi exit" – but I haven't actually debugged it myself. I always made a mental note to "look into it" but never did. I see it a lot when I'm waiting for the repos to clear out and get impatient ( hitting ctrl+c multiple times)so this could potentially cause data loss. was (Author: phrocker): Thanks for debugging. I always assumed the issue is that we wait on the sem, close it then unlink it before unloading flow controller, meaning when we sem_post, the semaphore won't exist. We should likely move those sem close and sem unlink after "MiNiFi exit" – but I haven't actually debugged it myself. I always made a mental note to "look into it" but never did. > Segfault on SIGINT after shutdown initiated > > > Key: MINIFICPP-990 > URL: https://issues.apache.org/jira/browse/MINIFICPP-990 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Andrew Christianson >Priority: Major > Fix For: 0.7.0 > > > If I send a SIGINT (ctrl-c) to MiNiFI, MiNiFi begins shutdown. If I send > another SIGINT while that shutdown is in progress, MiNiFi crashes with a > segfault. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (MINIFICPP-990) Segfault on SIGINT after shutdown initiated
[ https://issues.apache.org/jira/browse/MINIFICPP-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mr TheSegfault updated MINIFICPP-990: - Fix Version/s: 0.7.0 > Segfault on SIGINT after shutdown initiated > > > Key: MINIFICPP-990 > URL: https://issues.apache.org/jira/browse/MINIFICPP-990 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Andrew Christianson >Priority: Major > Fix For: 0.7.0 > > > If I send a SIGINT (ctrl-c) to MiNiFI, MiNiFi begins shutdown. If I send > another SIGINT while that shutdown is in progress, MiNiFi crashes with a > segfault. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (MINIFICPP-990) Segfault on SIGINT after shutdown initiated
[ https://issues.apache.org/jira/browse/MINIFICPP-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897484#comment-16897484 ] Mr TheSegfault commented on MINIFICPP-990: -- Thanks for debugging. I always assumed the issue is that we wait on the sem, close it then unlink it before unloading flow controller, meaning when we sem_post, the semaphore won't exist. We should likely move those sem close and sem unlink after "MiNiFi exit" – but I haven't actually debugged it myself. I always made a mental note to "look into it" but never did. > Segfault on SIGINT after shutdown initiated > > > Key: MINIFICPP-990 > URL: https://issues.apache.org/jira/browse/MINIFICPP-990 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Andrew Christianson >Priority: Major > > If I send a SIGINT (ctrl-c) to MiNiFI, MiNiFi begins shutdown. If I send > another SIGINT while that shutdown is in progress, MiNiFi crashes with a > segfault. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] pcgrenier opened a new pull request #3624: NIFI-6255 NIFI-6287: Hash function for expression language and record…
pcgrenier opened a new pull request #3624: NIFI-6255 NIFI-6287: Hash function
for expression language and record…
URL: https://github.com/apache/nifi/pull/3624
… path.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables a hash function in bot the expression language and record path.
Feature request NIFI-6255
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder? Ignored
JdbcCommonTest do to known issue
- [x] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (MINIFICPP-992) Move name of connection queue inside object
Mr TheSegfault created MINIFICPP-992: Summary: Move name of connection queue inside object Key: MINIFICPP-992 URL: https://issues.apache.org/jira/browse/MINIFICPP-992 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Mr TheSegfault Assignee: Mr TheSegfault Use this as an opportunity to clean up FlowInformation.h too -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] pcgrenier commented on issue #3604: NIFI-6255 NIFI-6287: Hash function for expression language and record…
pcgrenier commented on issue #3604: NIFI-6255 NIFI-6287: Hash function for expression language and record… URL: https://github.com/apache/nifi/pull/3604#issuecomment-516997463 Closing to re-open on master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] pcgrenier closed pull request #3604: NIFI-6255 NIFI-6287: Hash function for expression language and record…
pcgrenier closed pull request #3604: NIFI-6255 NIFI-6287: Hash function for expression language and record… URL: https://github.com/apache/nifi/pull/3604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi-minifi-cpp] phrocker commented on issue #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f…
phrocker commented on issue #610: MINIFICPP-814 - Fixed ListenHTTP and HTTPClient bugs, created tests f… URL: https://github.com/apache/nifi-minifi-cpp/pull/610#issuecomment-516994667 @bakaid I made some changes in a prior PR that collided with this. one of them, a test fails on OSX. I think you noted that using the P12s worked better on travis? You don't have to fix those tests. I'll fix them as a follow on once this is merged, but since it's only really a dev platform ( and passes locally ) I think we can wait until this is merged. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] AxelSync commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
AxelSync commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language URL: https://github.com/apache/nifi/pull/3615#discussion_r309393486 ## File path: nifi-commons/nifi-expression-language/src/main/antlr3/org/apache/nifi/attribute/expression/language/antlr/AttributeExpressionParser.g ## @@ -77,8 +77,9 @@ zeroArgString : (TO_UPPER | TO_LOWER | TRIM | TO_STRING | URL_ENCODE | URL_DECOD oneArgString : ((SUBSTRING_BEFORE | SUBSTRING_BEFORE_LAST | SUBSTRING_AFTER | SUBSTRING_AFTER_LAST | REPLACE_NULL | REPLACE_EMPTY | PREPEND | APPEND | STARTS_WITH | ENDS_WITH | CONTAINS | JOIN | JSON_PATH | FROM_RADIX) LPAREN! anyArg RPAREN!) | (TO_RADIX LPAREN! anyArg (COMMA! anyArg)? RPAREN!); -twoArgString : ((REPLACE | REPLACE_FIRST | REPLACE_ALL | IF_ELSE) LPAREN! anyArg COMMA! anyArg RPAREN!) | - ((SUBSTRING | FORMAT) LPAREN! anyArg (COMMA! anyArg)? RPAREN!); +twoArgString : ((REPLACE | REPLACE_FIRST | REPLACE_ALL | IF_ELSE | ) LPAREN! anyArg COMMA! anyArg RPAREN!) | + ((SUBSTRING | FORMAT) LPAREN! anyArg (COMMA! anyArg)? RPAREN!) | (PAD_LEFT LPAREN! anyArg (COMMA! anyArg)? RPAREN!) | Review comment: My intent here is to allow both 1 or 2 parameters, if I just add them to the declared functions (i.e. in the list, after the IF_ELSE function), won't I allow only two parameters? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] AxelSync commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
AxelSync commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309392174
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
+ final Evaluator pad) {
+this.subject = subject;
+this.desiredLength = desiredLength;
+this.pad = pad;
+}
+
+@Override
+public QueryResult evaluate(final Map attributes,
final EvaluatorState context) {
+final String subjectValue = subject.evaluate(attributes,
context).getValue();
+if (subjectValue == null) {
+return new StringQueryResult(null);
+}
+final Long desiredLengthValue = desiredLength.evaluate(attributes,
context).getValue();
+if(desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
+return new StringQueryResult(null);
+}
+
+char padValue;
Review comment:
In such a case, how would you handle the case in which the pad string is
`"abc"` and the chars to pad are 5? `"abcab"`?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] AxelSync commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
AxelSync commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309391493
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
+ final Evaluator pad) {
+this.subject = subject;
+this.desiredLength = desiredLength;
+this.pad = pad;
+}
+
+@Override
+public QueryResult evaluate(final Map attributes,
final EvaluatorState context) {
+final String subjectValue = subject.evaluate(attributes,
context).getValue();
+if (subjectValue == null) {
+return new StringQueryResult(null);
+}
+final Long desiredLengthValue = desiredLength.evaluate(attributes,
context).getValue();
+if(desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
Review comment:
I was thinking about it. Could it maybe become a problem in case the desired
length comes in a variable as a result of some previous computation? What do
you think it would be the most convenient behavior?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309384216
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
Review comment:
indent
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309385222
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/compile/ExpressionCompiler.java
##
@@ -652,6 +656,28 @@ private DateEvaluator toDateEvaluator(final Evaluator
evaluator, final String
toStringEvaluator(argEvaluators.get(0), "first argument to
replaceAll"),
toStringEvaluator(argEvaluators.get(1), "second argument
to replaceAll")), "replaceAll");
}
+case PAD_LEFT: {
+if (argEvaluators.size() == 1) {
+return addToken(new
PadLeftEvaluator(toStringEvaluator(subjectEvaluator),
+toWholeNumberEvaluator(argEvaluators.get(0),
"desired string length")),
+"padLeft");
+} else {
+return addToken(new
PadLeftEvaluator(toStringEvaluator(subjectEvaluator),
+toWholeNumberEvaluator(argEvaluators.get(0),
"desired string length"),
+toStringEvaluator(argEvaluators.get(1), "padding
character")), "padLeft");
+}
+}
+case PAD_RIGHT: {
+if (argEvaluators.size() == 1) {
+return addToken(new
PadRightEvaluator(toStringEvaluator(subjectEvaluator),
+
toWholeNumberEvaluator(argEvaluators.get(0), "desired string length")),
+"padRight");
Review comment:
indent
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309377740
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
+ final Evaluator pad) {
+this.subject = subject;
+this.desiredLength = desiredLength;
+this.pad = pad;
+}
+
+@Override
+public QueryResult evaluate(final Map attributes,
final EvaluatorState context) {
+final String subjectValue = subject.evaluate(attributes,
context).getValue();
+if (subjectValue == null) {
+return new StringQueryResult(null);
+}
+final Long desiredLengthValue = desiredLength.evaluate(attributes,
context).getValue();
+if(desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
+return new StringQueryResult(null);
+}
+
+char padValue;
+if( pad == null) {
Review comment:
```suggestion
if (pad == null) {
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309375721
##
File path:
nifi-commons/nifi-expression-language/src/test/java/org/apache/nifi/attribute/expression/language/TestQuery.java
##
@@ -1822,6 +1826,63 @@ public void testThread() {
verifyEquals("${thread()}", attributes, "main");
}
+@Test
+public void testPadLeft() {
+final Map attributes = new HashMap<>();
+attributes.put("attr", "hello");
+attributes.put("emptyString", "");
+attributes.put("nullString", null);
+
+verifyEquals("${attr:padLeft(10, '@')}", attributes, "@hello");
+verifyEquals("${attr:padLeft(10)}", attributes, "_hello");
+verifyEquals("${attr:padLeft(10, \"abc\")}", attributes, "ahello");
+verifyEquals("${attr:padLeft(1, \"a\")}", attributes, "hello");
+verifyEquals("${attr:padLeft(-10, \"a\")}", attributes, "hello");
+verifyEquals("${emptyString:padLeft(10, '@')}", attributes,
"@@");
+
+// Cannot pass by verifyEquals
+final Query notExistingAttrQuery =
Query.compile("${nonExistingAttr:padLeft(10, \"abc\")}");
+final QueryResult notExistingAttrResult =
notExistingAttrQuery.evaluate(attributes, null);
+assertTrue(notExistingAttrResult.getValue() == null);
+
+final Query overflowLengthQuery =
Query.compile("${nonExistingAttr:padLeft(99, \"abc\")}");
+final QueryResult overflowLengthResult =
overflowLengthQuery.evaluate(attributes, null);
+assertTrue(overflowLengthResult.getValue() == null);
+
+final Query nullStringQuery = Query.compile("${nullString:padLeft(10,
\"@\")}");
+final QueryResult nullStringResult =
nullStringQuery.evaluate(attributes, null);
+assertTrue(nullStringResult.getValue() == null);
+
Review comment:
nit:remove empty line
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309383854
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
+ final Evaluator pad) {
+this.subject = subject;
+this.desiredLength = desiredLength;
+this.pad = pad;
+}
+
+@Override
+public QueryResult evaluate(final Map attributes,
final EvaluatorState context) {
+final String subjectValue = subject.evaluate(attributes,
context).getValue();
+if (subjectValue == null) {
+return new StringQueryResult(null);
+}
+final Long desiredLengthValue = desiredLength.evaluate(attributes,
context).getValue();
+if(desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
Review comment:
Anyway, in case of overflow, I think we should just return the input
string... and we can also add a check for negative values too to return here
and avoid useless computation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309379518
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
+ final Evaluator pad) {
+this.subject = subject;
+this.desiredLength = desiredLength;
+this.pad = pad;
+}
+
+@Override
+public QueryResult evaluate(final Map attributes,
final EvaluatorState context) {
+final String subjectValue = subject.evaluate(attributes,
context).getValue();
+if (subjectValue == null) {
+return new StringQueryResult(null);
+}
+final Long desiredLengthValue = desiredLength.evaluate(attributes,
context).getValue();
+if(desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
+return new StringQueryResult(null);
+}
+
+char padValue;
Review comment:
what about:
```
char padValue = DEFAULT_PADDING_CHARACTER;
if (pad != null) {
final String s = pad.evaluate(attributes, context).getValue();
if (s != null && !s.isEmpty()) {
padValue = s.charAt(0);
}
}
```
Anyway, I don't really agree with this behavior. If the user specify a
String which is not a single char, we should use that string for padding
instead of taking only the first char.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language URL: https://github.com/apache/nifi/pull/3615#discussion_r309385029 ## File path: nifi-commons/nifi-expression-language/src/main/antlr3/org/apache/nifi/attribute/expression/language/antlr/AttributeExpressionParser.g ## @@ -77,8 +77,9 @@ zeroArgString : (TO_UPPER | TO_LOWER | TRIM | TO_STRING | URL_ENCODE | URL_DECOD oneArgString : ((SUBSTRING_BEFORE | SUBSTRING_BEFORE_LAST | SUBSTRING_AFTER | SUBSTRING_AFTER_LAST | REPLACE_NULL | REPLACE_EMPTY | PREPEND | APPEND | STARTS_WITH | ENDS_WITH | CONTAINS | JOIN | JSON_PATH | FROM_RADIX) LPAREN! anyArg RPAREN!) | (TO_RADIX LPAREN! anyArg (COMMA! anyArg)? RPAREN!); -twoArgString : ((REPLACE | REPLACE_FIRST | REPLACE_ALL | IF_ELSE) LPAREN! anyArg COMMA! anyArg RPAREN!) | - ((SUBSTRING | FORMAT) LPAREN! anyArg (COMMA! anyArg)? RPAREN!); +twoArgString : ((REPLACE | REPLACE_FIRST | REPLACE_ALL | IF_ELSE | ) LPAREN! anyArg COMMA! anyArg RPAREN!) | + ((SUBSTRING | FORMAT) LPAREN! anyArg (COMMA! anyArg)? RPAREN!) | (PAD_LEFT LPAREN! anyArg (COMMA! anyArg)? RPAREN!) | Review comment: can't we just add `PAD_LEFT` and `PAD_RIGHT` to the function names here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding functions in Expression Language
mgaido91 commented on a change in pull request #3615: NIFI-6500 Support Padding
functions in Expression Language
URL: https://github.com/apache/nifi/pull/3615#discussion_r309378228
##
File path:
nifi-commons/nifi-expression-language/src/main/java/org/apache/nifi/attribute/expression/language/evaluation/functions/PaddingEvaluator.java
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.nifi.attribute.expression.language.evaluation.functions;
+
+import org.apache.nifi.attribute.expression.language.evaluation.Evaluator;
+import org.apache.nifi.attribute.expression.language.evaluation.EvaluatorState;
+import org.apache.nifi.attribute.expression.language.evaluation.QueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringQueryResult;
+import
org.apache.nifi.attribute.expression.language.evaluation.StringEvaluator;
+
+import java.util.Map;
+
+abstract class PaddingEvaluator extends StringEvaluator {
+
+public static final char DEFAULT_PADDING_CHARACTER = '_';
+
+private final Evaluator subject;
+private final Evaluator desiredLength;
+private final Evaluator pad;
+
+PaddingEvaluator( final Evaluator subject,
+ final Evaluator desiredLength,
+ final Evaluator pad) {
+this.subject = subject;
+this.desiredLength = desiredLength;
+this.pad = pad;
+}
+
+@Override
+public QueryResult evaluate(final Map attributes,
final EvaluatorState context) {
+final String subjectValue = subject.evaluate(attributes,
context).getValue();
+if (subjectValue == null) {
+return new StringQueryResult(null);
+}
+final Long desiredLengthValue = desiredLength.evaluate(attributes,
context).getValue();
+if(desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
Review comment:
```suggestion
if (desiredLengthValue == null || desiredLengthValue >
Integer.MAX_VALUE) {
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] pushpavanthar commented on issue #3616: NIFI-6501: Add config to limit buffer queue size in CaptureChangeMySQL
pushpavanthar commented on issue #3616: NIFI-6501: Add config to limit buffer queue size in CaptureChangeMySQL URL: https://github.com/apache/nifi/pull/3616#issuecomment-516973860 @ijokarumawak kindly review this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (NIFI-6324) Add Hashicorp Vault SPP
[
https://issues.apache.org/jira/browse/NIFI-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Troy Melhase updated NIFI-6324:
---
Status: Patch Available (was: Open)
> Add Hashicorp Vault SPP
> ---
>
> Key: NIFI-6324
> URL: https://issues.apache.org/jira/browse/NIFI-6324
> Project: Apache NiFi
> Issue Type: Sub-task
> Components: Extensions
>Affects Versions: 1.9.2
>Reporter: Andy LoPresto
>Assignee: Troy Melhase
>Priority: Major
> Labels: property, protection, security, vault
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Add a {{SensitivePropertyProvider}} which works with Hashicorp Vault.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [nifi] natural opened a new pull request #3623: NIFI-6324 HashiCorp Vault Sensitive Property Provider
natural opened a new pull request #3623: NIFI-6324 HashiCorp Vault Sensitive
Property Provider
URL: https://github.com/apache/nifi/pull/3623
Description of PR
The code in this change-set adds a Secure Property Provider based on
HashiCorp Vault wrap and unwrap operations. Integration tests and
documentation are also included.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
*PENDING* this branch is based on un-merged code (see #3542).
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [X] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] kaHaleMaKai commented on issue #3543: NIFI-6388 Add dynamic relationships to the ExecuteScript processor.
kaHaleMaKai commented on issue #3543: NIFI-6388 Add dynamic relationships to the ExecuteScript processor. URL: https://github.com/apache/nifi/pull/3543#issuecomment-516932909 @mattyb149 I submitted all proposed changes. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] patricker opened a new pull request #3622: NIFI-6512 Relationship Name ellipsis Not Working
patricker opened a new pull request #3622: NIFI-6512 Relationship Name ellipsis
Not Working
URL: https://github.com/apache/nifi/pull/3622
Description of PR
The relationship name calls the `ellipsis` jQuery plugin, but does not work
because of a CSS style being applied to the list.
This causes long relationship names to be cut off abruptly instead of having
the `ellipsis` applied.
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (NIFI-6512) Relationship Name `ellipsis` Not Working
Peter Wicks created NIFI-6512: - Summary: Relationship Name `ellipsis` Not Working Key: NIFI-6512 URL: https://issues.apache.org/jira/browse/NIFI-6512 Project: Apache NiFi Issue Type: Bug Components: Core UI Affects Versions: 1.9.2 Reporter: Peter Wicks Assignee: Peter Wicks The relationship name calls the `ellipsis` jQuery plugin, but does not work because of a CSS style being applied to the list. This causes long relationship names to be cut off abruptly instead of having the `ellipsis` applied. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (MINIFICPP-990) Segfault on SIGINT after shutdown initiated
[
https://issues.apache.org/jira/browse/MINIFICPP-990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897258#comment-16897258
]
Andrew Christianson commented on MINIFICPP-990:
---
Due to the nature of the bug (shutdown signal handling) it is kind of tricky to
debug, but I think this is the relevant gdb/backtrace info:
{noformat}
Thread 1 "minifi" received signal SIGSEGV, Segmentation fault.
__new_sem_post (sem=0x77ffb000) at sem_post.c:36
36 sem_post.c: No such file or directory.
(gdb) bt
#0 __new_sem_post (sem=0x77ffb000) at sem_post.c:36
#1
#2 0x771c868d in syscall () from /usr/lib64/haswell/libc.so.6
#3 0x774e7a5d in std::__atomic_futex_unsigned_base::_M_futex_wait_until
(this=this@entry=0x561eeeb0, __addr=__addr@entry=0x561eeeb0,
__val=2147483648, __has_timeout=__has_timeout@entry=true, __s=...,
__s@entry=...,
__ns=__ns@entry=...) at
../../../../../gcc-9.1.0/libstdc++-v3/src/c++11/futex.cc:76
#4 0x558659ba in
std::__atomic_futex_unsigned<2147483648u>::_M_load_and_test_until (__ns=...,
__s=..., __has_timeout=true, __mo=std::memory_order_acquire, __equal=true,
__operand=1, __assumed=, this=0x561eeeb0)
at /usr/include/c++/9/bits/atomic_base.h:569
#5
std::__atomic_futex_unsigned<2147483648u>::_M_load_and_test_until_impl > > (__atime=...,
__mo=std::memory_order_acquire, __equal=true, __operand=1,
__assumed=, this=0x561eeeb0) at
/usr/include/c++/9/bits/atomic_futex.h:140
#6
std::__atomic_futex_unsigned<2147483648u>::_M_load_when_equal_until > > (__atime=...,
__mo=std::memory_order_acquire, __val=1, this=0x561eeeb0)
at /usr/include/c++/9/bits/atomic_futex.h:199
#7
std::__future_base::_State_baseV2::wait_until > > (__abs=..., this=0x561eeea0) at /usr/include/c++/9/future:380
#8 std::__basic_future::wait_until > > (__abs=..., this=) at /usr/include/c++/9/future:708
#9 org::apache::nifi::minifi::FlowController::waitUnload (this=0x561a6200,
timeToWaitMs=) at
/home/achristianson/workspace/nifi-minifi-cpp-experimental/libminifi/src/FlowController.cpp:272
#10 0x55773421 in main (argc=, argv=) at
/usr/include/c++/9/bits/shared_ptr_base.h:1020
{noformat}
Seems to crash in this bit from FlowController.cpp:
{noformat}
if (std::future_status::ready == unload_task.wait_until(wait_time)) {
running_ = false;
}{noformat}
> Segfault on SIGINT after shutdown initiated
>
>
> Key: MINIFICPP-990
> URL: https://issues.apache.org/jira/browse/MINIFICPP-990
> Project: Apache NiFi MiNiFi C++
> Issue Type: Bug
>Reporter: Andrew Christianson
>Priority: Major
>
> If I send a SIGINT (ctrl-c) to MiNiFI, MiNiFi begins shutdown. If I send
> another SIGINT while that shutdown is in progress, MiNiFi crashes with a
> segfault.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Updated] (MINIFICPP-990) Segfault on SIGINT after shutdown initiated
[ https://issues.apache.org/jira/browse/MINIFICPP-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Christianson updated MINIFICPP-990: -- Summary: Segfault on SIGINT after shutdown initiated (was: Segfault on SIGHUP after shutdown initiated ) > Segfault on SIGINT after shutdown initiated > > > Key: MINIFICPP-990 > URL: https://issues.apache.org/jira/browse/MINIFICPP-990 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Andrew Christianson >Priority: Major > > If I send a SIGHUP (ctrl-c) to MiNiFI, MiNiFi begins shutdown. If I send > another SIGHUP while that shutdown is in progress, MiNiFi crashes with a > segfault. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (MINIFICPP-990) Segfault on SIGINT after shutdown initiated
[ https://issues.apache.org/jira/browse/MINIFICPP-990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Christianson updated MINIFICPP-990: -- Description: If I send a SIGINT (ctrl-c) to MiNiFI, MiNiFi begins shutdown. If I send another SIGINT while that shutdown is in progress, MiNiFi crashes with a segfault. (was: If I send a SIGHUP (ctrl-c) to MiNiFI, MiNiFi begins shutdown. If I send another SIGHUP while that shutdown is in progress, MiNiFi crashes with a segfault.) > Segfault on SIGINT after shutdown initiated > > > Key: MINIFICPP-990 > URL: https://issues.apache.org/jira/browse/MINIFICPP-990 > Project: Apache NiFi MiNiFi C++ > Issue Type: Bug >Reporter: Andrew Christianson >Priority: Major > > If I send a SIGINT (ctrl-c) to MiNiFI, MiNiFi begins shutdown. If I send > another SIGINT while that shutdown is in progress, MiNiFi crashes with a > segfault. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (NIFI-6502) Add padLeft() and padRight() functions to RecordPath
[
https://issues.apache.org/jira/browse/NIFI-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro D'Armiento reassigned NIFI-6502:
---
Assignee: (was: Alessandro D'Armiento)
> Add padLeft() and padRight() functions to RecordPath
> -
>
> Key: NIFI-6502
> URL: https://issues.apache.org/jira/browse/NIFI-6502
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Alessandro D'Armiento
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> h2. Current Situation
> - [Record path
> functions|https://nifi.apache.org/docs/nifi-docs/html/record-path-guide.html#functions]
> don't provide anything to perform string padding
> h1. Improvement Proposal
> - Support two new recordPath functions
> -- padLeft:
> --- padLeft(string field, int desiredLength) will prepend a default character
> to the input string until it reaches the length desiredLength
> --- padLeft(String field, int desiredLength, char c) will prepend the c
> characters to the input string until it reaches the length n
> -- padRight:
> --- padRight(string field, int desiredLength) will append a default character
> to the input string until it reaches the length desiredLength
> --- padRight(String field, int desiredLength, char c) will append the c
> characters to the input string until it reaches the length n
> -- Default character should be a renderable character such as underscore
> -- If the input string is already longer than the padding length, no
> operation should be performed
> h3. Examples
>
> {
> "name" : "john smith"
> }
>
> `padLeft(/name, 15, '@')` => @john smith
> `padLeft(/name, 15)` => _john smith
> `padRight(/name, 15, '@')` => john smith@
> `padRight(/name, 15)`=> john smith_
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Assigned] (NIFI-6500) Add padLeft() and padRight() functions to expression language
[
https://issues.apache.org/jira/browse/NIFI-6500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro D'Armiento reassigned NIFI-6500:
---
Assignee: (was: Alessandro D'Armiento)
> Add padLeft() and padRight() functions to expression language
> -
>
> Key: NIFI-6500
> URL: https://issues.apache.org/jira/browse/NIFI-6500
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Alessandro D'Armiento
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> h2. Current Situation
> - [Expression Language string
> manipulation|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#strings]
> doesn't have anything to perform string padding
> - Existing solutions to achieve left or right padding are unintuitive
> -- Es:
> ${prop:prepend(''):substring(${prop:length()},${prop:length():plus(4)})}
> h1. Improvement Proposal
> - Support two new expression language methods
> -- padLeft:
> --- padLeft(int n) will prepend a default character to of the input string
> until it reaches the length n
> --- padLeft(int n, char c) will prepend the c characters to the input string
> until it reaches the length n
> -- padRight:
> --- padRight(int n) will append a default character to the input string until
> it reaches the length n
> --- padRight(int n, char c) will append the c character to the input string
> until it reaches the length n
> -- Default character should be a renderable character such as underscore
> -- If the input string is already longer than the padding length, no
> operation should be performed
> h3. Examples
>
> input = "myString"
>
> - ${input:padLeft(10, '#')} => "##myString"
> - ${input:padRight(10, '#')} => "myString##"
> - ${input:padLeft(10)} => "__myString"
> - ${input:padRight(10)} => "myString__"
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (MINIFICPP-991) Handling environment vars in MiNiFi
Arpad Boda created MINIFICPP-991: Summary: Handling environment vars in MiNiFi Key: MINIFICPP-991 URL: https://issues.apache.org/jira/browse/MINIFICPP-991 Project: Apache NiFi MiNiFi C++ Issue Type: Improvement Reporter: Arpad Boda Assignee: Arpad Boda As [~phrocker] pointed out in [https://github.com/apache/nifi-minifi-cpp/pull/612] env var setting might caused unintended behaviour in case multiple processors (for eg. a cpp and a Python one) try to set and use the same env var, which is a valid case for oepncv. We should find a general approach of handling env vars: * If we handle them in processor init phase, that's guaranteed to be thread safe, but property values are not accessible in that phase, so configuration is difficult * Handling in onschedule phase allows access to properties, although we have to deal with thread-safety. * No matter what approach we choose, a recommended way of doing this should be documented to avoid users experiencing unwanted behaviours. [~le.nghia] [~bakaid] [~phrocker] please share your opinions! -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (MINIFICPP-990) Segfault on SIGHUP after shutdown initiated
Andrew Christianson created MINIFICPP-990: - Summary: Segfault on SIGHUP after shutdown initiated Key: MINIFICPP-990 URL: https://issues.apache.org/jira/browse/MINIFICPP-990 Project: Apache NiFi MiNiFi C++ Issue Type: Bug Reporter: Andrew Christianson If I send a SIGHUP (ctrl-c) to MiNiFI, MiNiFi begins shutdown. If I send another SIGHUP while that shutdown is in progress, MiNiFi crashes with a segfault. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi-minifi-cpp] achristianson commented on issue #603: MINIFICPP-929 mmap
achristianson commented on issue #603: MINIFICPP-929 mmap URL: https://github.com/apache/nifi-minifi-cpp/pull/603#issuecomment-516862718 The mio library does build for Windows, but I'm not happy with the performance. It's still faster than the non-mmap implemation (esp. w/ random access), but I think this PR should directly make the mmap calls. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (NIFI-6511) Specify remote protocol for predictive analytics
Andrew Christianson created NIFI-6511: - Summary: Specify remote protocol for predictive analytics Key: NIFI-6511 URL: https://issues.apache.org/jira/browse/NIFI-6511 Project: Apache NiFi Issue Type: Sub-task Reporter: Andrew Christianson In order to allow more resource-demanding analytics to be run outside of the main NiFi process, we need to define a protocol which allows NiFi to send analytic input data (e.g. NiFi metrics) and receive predictions/answers/useful values back. Because the amount of input data to models may be large, the protocol needs to be lightweight and efficient. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (NIFI-6510) Predictive Analytics for NiFi Metrics
Andrew Christianson created NIFI-6510:
-
Summary: Predictive Analytics for NiFi Metrics
Key: NIFI-6510
URL: https://issues.apache.org/jira/browse/NIFI-6510
Project: Apache NiFi
Issue Type: Improvement
Reporter: Andrew Christianson
>From Yolanda's email to the list:
{noformat}
Currently NiFi has lots of metrics available for areas including jvm and flow
component usage (via component status) as well as provenance data which NiFi
makes available either through the UI or reporting tasks (for consumption by
other systems). Past discussions in the community cite users shipping this data
to applications such as Prometheus, ELK stacks, or Ambari metrics for further
analysis in order to capture/review performance issues, detect anomalies, and
send alerts or notifications. These systems are efficient in capturing and
helping to analyze these metrics however it requires customization work and
knowledge of NiFi operations to provide meaningful analytics within a flow
context.
In speaking with Matt Burgess and Andy Christianson on this topic we feel that
there is an opportunity to introduce an analytics framework that could provide
users reasonable predictions on key performance indicators for flows, such as
back pressure and flow rate, to help administrators improve operational
management of NiFi clusters. This framework could offer several key features:
- Provide a flexible internal analytics engine and model api which supports the
addition of or enhancement to onboard models
- Support integration of remote or cloud based ML models
- Support both traditional and online (incremental) learning methods
- Provide support for model caching (perhaps later inclusion into a model
repository or registry)
- UI enhancements to display prediction information either in existing summary
data, new data visualizations, or directly within the flow/canvas (where
applicable)
For an initial target we thought that back pressure prediction would be a good
starting point for this initiative, given that back pressure detection is a key
indicator of flow performance and many of the metrics currently available would
provide enough data points to create a reasonable performing model. We have
some ideas on how this could be achieved however we wanted to discuss this more
with the community to get thoughts about tackling this work, especially if
there are specific use cases or other factors that should be
considered.{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [nifi] tpalfy opened a new pull request #3621: NIFI-6509 - Date related issue in unit test VolatileComponentStatusRe…
tpalfy opened a new pull request #3621: NIFI-6509 - Date related issue in unit test VolatileComponentStatusRe… URL: https://github.com/apache/nifi/pull/3621 …positoryTest VolatileComponentStatusRepositoryTest: In 'createBuffers' adding Date objects to repositories starting from 1970.01.01 00:00:00 local time (instead of GMT) - the same way as the 'start' filter parameters are created in the tests. Minor refactor (some code duplication elimination in creating the repositories and the testing logic in a couple of unit tests.) VolatileComponentStatusRepository: filterDates method also used 'new Date(0)' when the start parameter was null. Replaced with 'new Date(Integer.MIN_VALUE)'. Replaced comment with a fitting annotation (@VisibleForTesting). ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with **NIFI-** where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically `master`)? - [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._ ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`? - [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`? - [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6342) HandleHttpRequest enters in fault state and does not recover (regression)
[ https://issues.apache.org/jira/browse/NIFI-6342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16897054#comment-16897054 ] Jeff Zemerick commented on NIFI-6342: - [~Diego Queiroz] We're also seeing the behavior your described in NIFI-5522 in 1.9.2. Doing lots of curls in a loop against a HandleHttpRequest can cause the processor to become "frozen" and require a restart. We found your post at [https://community.hortonworks.com/questions/148032/apache-nifi-handlehttprequestresponse-issue.html] and ensured that all paths route to a HandleHttpResponse. Have you happened to find out any more since this issue was created? > HandleHttpRequest enters in fault state and does not recover (regression) > - > > Key: NIFI-6342 > URL: https://issues.apache.org/jira/browse/NIFI-6342 > Project: Apache NiFi > Issue Type: Task >Affects Versions: 1.9.2 >Reporter: Diego Queiroz >Priority: Major > Labels: security > > Hello guys. > I just updated my NiFi environment to the last available version and, > apparently, the bug reported in > [https://issues.apache.org/jira/projects/NIFI/issues/NIFI-5522] continues in > the last release (=1.9.2, Jetty = 9.4.11.v20180605). > I was confused if I should comment in the same thread or open a new ticket, > so sorry if I did wrong in opening a new issue. > Are there any thoughts about this? I really wasn't able to test in 1.8.0 > where this bug was supposed to be fixed, so I don't know if it wasn't fixed > at all or if it happened again in 1.9.2. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] H3CDataEngine opened a new pull request #3620: NIFI-6512:Optimize the CaptureChangeMySQL Processor:when Distributed Map Cache …
H3CDataEngine opened a new pull request #3620: NIFI-6512:Optimize the
CaptureChangeMySQL Processor:when Distributed Map Cache …
URL: https://github.com/apache/nifi/pull/3620
…Client property is not set ,the output flowfile has many null data,include
table meta and column value.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
The problem:when Distributed Map Cache Client property is not set,output
flowfile has many null data.
The resolve method:I add condition to add info to currentTable from data
when the property in not set ,and when column type is null ,I set value to
String not to null.This method is to optimize processor.
_Enables X functionality; fixes bug NIFI-6512._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [nifi] H3CDataEngine opened a new pull request #3619: NIFI-6511:Resolve the problem:select processor data provenance null,must restar…
H3CDataEngine opened a new pull request #3619: NIFI-6511:Resolve the
problem:select processor data provenance null,must restar…
URL: https://github.com/apache/nifi/pull/3619
…t nifi can select data provenance.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
The problem: when flowfile is not generated for a long time,when the time
over nifi.provenance.repository.max.storage.time ,the
provenacne_repository/*.prov file will be delete.
And it does not satisfy the roll condition,so wo select data provenance
failed.
The resolve method:I add condition to judge tryClaim() and add condition to
judge shouldRoll(),so when *.prov is delete,and new data provenance is
generated ,new prov file generate and can be successful to select data
provenance.
_Enables X functionality; fixes bug NIFI-6511._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6509) Date related issue in unit test VolatileComponentStatusRepositoryTest
[
https://issues.apache.org/jira/browse/NIFI-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Palfy updated NIFI-6509:
--
Description:
Unit test
{{VolatileComponentStatusRepositoryTest.testFilterDatesUsingPreferredDataPoints}}
may fail with the following:
{code:java}
java.lang.AssertionError:
Expected :Thu Jan 01 00:00:00 CET 1970
Actual :Thu Jan 01 01:00:00 CET 1970
{code}
The test creates a {{VolatileComponentStatusRepository}} instance and adds
{{java.util.Date}} objects to it starting from epoch (via {{new Date(0)}}).
This first date at epoch is the _Actual_ in the _AssertionError_.
Then filters this list by looking for those that are earlier or matching a
_start_ paramater. This _start_ is created from a {{LocalDateTime}} at the
default system time zone.
This is the _Expected_ in the _AssertionError_.
In general the issue is the difference in how the list is created (dates that
are 00:00:00 GMT) and how the filter parameter date is created (00:00:00 at
system time zone).
was:
Unit test
{{VolatileComponentStatusRepositoryTest.testFilterDatesUsingPreferredDataPoints}}
may fail with the following:
{code:java}
java.lang.AssertionError:
Expected :Thu Jan 01 00:00:00 CET 1970
Actual :Thu Jan 01 01:00:00 CET 1970
{code}
The test creates a {{VolatileComponentStatusRepository}} instance and adds
{{java.util.Date}} objects to it starting from epoch (via {{new Date(0)}}).
This first date at epoch is the _Actual_ in the _AssertionError_.
Then filters this list by looking for those that are earlier or matching a
_start_ paramater. This _start_ is created from a {{LocalDateTime}} at the
default system time zone.
This is the _Expected_ in the _AssertionError_.
In general the issue is the difference in how the list is created (dates that
are 00:00:00 GMT) and how the filter parameter date is created (00:00:00 at
system time zone).
Related JIRA:
https://issues.apache.org/jira/browse/NIFI-6433
> Date related issue in unit test VolatileComponentStatusRepositoryTest
> -
>
> Key: NIFI-6509
> URL: https://issues.apache.org/jira/browse/NIFI-6509
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Tamas Palfy
>Priority: Minor
>
> Unit test
> {{VolatileComponentStatusRepositoryTest.testFilterDatesUsingPreferredDataPoints}}
> may fail with the following:
> {code:java}
> java.lang.AssertionError:
> Expected :Thu Jan 01 00:00:00 CET 1970
> Actual :Thu Jan 01 01:00:00 CET 1970
> {code}
> The test creates a {{VolatileComponentStatusRepository}} instance and adds
> {{java.util.Date}} objects to it starting from epoch (via {{new Date(0)}}).
> This first date at epoch is the _Actual_ in the _AssertionError_.
> Then filters this list by looking for those that are earlier or matching a
> _start_ paramater. This _start_ is created from a {{LocalDateTime}} at the
> default system time zone.
> This is the _Expected_ in the _AssertionError_.
> In general the issue is the difference in how the list is created (dates that
> are 00:00:00 GMT) and how the filter parameter date is created (00:00:00 at
> system time zone).
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (NIFI-6509) Date related issue in unit test VolatileComponentStatusRepositoryTest
Tamas Palfy created NIFI-6509:
-
Summary: Date related issue in unit test
VolatileComponentStatusRepositoryTest
Key: NIFI-6509
URL: https://issues.apache.org/jira/browse/NIFI-6509
Project: Apache NiFi
Issue Type: Bug
Components: Core Framework
Reporter: Tamas Palfy
Unit test
{{VolatileComponentStatusRepositoryTest.testFilterDatesUsingPreferredDataPoints}}
may fail with the following:
{code:java}
java.lang.AssertionError:
Expected :Thu Jan 01 00:00:00 CET 1970
Actual :Thu Jan 01 01:00:00 CET 1970
{code}
The test creates a {{VolatileComponentStatusRepository}} instance and adds
{{java.util.Date}} objects to it starting from epoch (via {{new Date(0)}}).
This first date at epoch is the _Actual_ in the _AssertionError_.
Then filters this list by looking for those that are earlier or matching a
_start_ paramater. This _start_ is created from a {{LocalDateTime}} at the
default system time zone.
This is the _Expected_ in the _AssertionError_.
In general the issue is the difference in how the list is created (dates that
are 00:00:00 GMT) and how the filter parameter date is created (00:00:00 at
system time zone).
Related JIRA:
https://issues.apache.org/jira/browse/NIFI-6433
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[GitHub] [nifi] H3CDataEngine opened a new pull request #3618: NIFI-6510:Resolve the problem when node restart ListHDFS load the repeating hdf…
H3CDataEngine opened a new pull request #3618: NIFI-6510:Resolve the problem
when node restart ListHDFS load the repeating hdf…
URL: https://github.com/apache/nifi/pull/3618
…etitive hdfs file
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
The problem:when ListHDFS is used ,the processor save timestamp .The
Directory property is set,but when node restart,the Directory property is
different from default,"onPropertyModified" method is used and the resetState
is set to true,so timestamp is also reset.The processor read repetitive hdfs
files.So we must add condition to decide whether to set resetState to true.
_Enables X functionality; fixes bug NIFI-6510._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Updated] (NIFI-6508) Test failures caused by timezone differences
[
https://issues.apache.org/jira/browse/NIFI-6508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Malthe Borch updated NIFI-6508:
---
Attachment: 0001-NIFI-6508-Fix-test-failure-caused-by-timezone-and-or.patch
> Test failures caused by timezone differences
>
>
> Key: NIFI-6508
> URL: https://issues.apache.org/jira/browse/NIFI-6508
> Project: Apache NiFi
> Issue Type: Test
> Components: Core Framework
>Reporter: Malthe Borch
>Priority: Minor
> Attachments:
> 0001-NIFI-6508-Fix-test-failure-caused-by-timezone-and-or.patch
>
>
> Some tests in {{VolatileComponentStatusRepositoryTest}} fail due to incorrect
> timezone conversion, for example {{testFilterDatesUsingStartFilter}}:
> {{java.lang.AssertionError: expected: but
> was: at
> org.apache.nifi.controller.status.history.VolatileComponentStatusRepositoryTest.testFilterDatesUsingStartFilter(VolatileComponentStatusRepositoryTest.java:132)}}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Created] (NIFI-6508) Test failures caused by timezone differences
Malthe Borch created NIFI-6508:
--
Summary: Test failures caused by timezone differences
Key: NIFI-6508
URL: https://issues.apache.org/jira/browse/NIFI-6508
Project: Apache NiFi
Issue Type: Test
Components: Core Framework
Reporter: Malthe Borch
Some tests in {{VolatileComponentStatusRepositoryTest}} fail due to incorrect
timezone conversion, for example {{testFilterDatesUsingStartFilter}}:
{{java.lang.AssertionError: expected: but
was: at
org.apache.nifi.controller.status.history.VolatileComponentStatusRepositoryTest.testFilterDatesUsingStartFilter(VolatileComponentStatusRepositoryTest.java:132)}}
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Assigned] (NIFI-6502) Add padLeft() and padRight() functions to RecordPath
[
https://issues.apache.org/jira/browse/NIFI-6502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro D'Armiento reassigned NIFI-6502:
---
Assignee: Alessandro D'Armiento
> Add padLeft() and padRight() functions to RecordPath
> -
>
> Key: NIFI-6502
> URL: https://issues.apache.org/jira/browse/NIFI-6502
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Alessandro D'Armiento
>Assignee: Alessandro D'Armiento
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> h2. Current Situation
> - [Record path
> functions|https://nifi.apache.org/docs/nifi-docs/html/record-path-guide.html#functions]
> don't provide anything to perform string padding
> h1. Improvement Proposal
> - Support two new recordPath functions
> -- padLeft:
> --- padLeft(string field, int desiredLength) will prepend a default character
> to the input string until it reaches the length desiredLength
> --- padLeft(String field, int desiredLength, char c) will prepend the c
> characters to the input string until it reaches the length n
> -- padRight:
> --- padRight(string field, int desiredLength) will append a default character
> to the input string until it reaches the length desiredLength
> --- padRight(String field, int desiredLength, char c) will append the c
> characters to the input string until it reaches the length n
> -- Default character should be a renderable character such as underscore
> -- If the input string is already longer than the padding length, no
> operation should be performed
> h3. Examples
>
> {
> "name" : "john smith"
> }
>
> `padLeft(/name, 15, '@')` => @john smith
> `padLeft(/name, 15)` => _john smith
> `padRight(/name, 15, '@')` => john smith@
> `padRight(/name, 15)`=> john smith_
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Assigned] (NIFI-6500) Add padLeft() and padRight() functions to expression language
[
https://issues.apache.org/jira/browse/NIFI-6500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alessandro D'Armiento reassigned NIFI-6500:
---
Assignee: Alessandro D'Armiento
> Add padLeft() and padRight() functions to expression language
> -
>
> Key: NIFI-6500
> URL: https://issues.apache.org/jira/browse/NIFI-6500
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Core Framework
>Affects Versions: 1.9.2
>Reporter: Alessandro D'Armiento
>Assignee: Alessandro D'Armiento
>Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> h2. Current Situation
> - [Expression Language string
> manipulation|https://nifi.apache.org/docs/nifi-docs/html/expression-language-guide.html#strings]
> doesn't have anything to perform string padding
> - Existing solutions to achieve left or right padding are unintuitive
> -- Es:
> ${prop:prepend(''):substring(${prop:length()},${prop:length():plus(4)})}
> h1. Improvement Proposal
> - Support two new expression language methods
> -- padLeft:
> --- padLeft(int n) will prepend a default character to of the input string
> until it reaches the length n
> --- padLeft(int n, char c) will prepend the c characters to the input string
> until it reaches the length n
> -- padRight:
> --- padRight(int n) will append a default character to the input string until
> it reaches the length n
> --- padRight(int n, char c) will append the c character to the input string
> until it reaches the length n
> -- Default character should be a renderable character such as underscore
> -- If the input string is already longer than the padding length, no
> operation should be performed
> h3. Examples
>
> input = "myString"
>
> - ${input:padLeft(10, '#')} => "##myString"
> - ${input:padRight(10, '#')} => "myString##"
> - ${input:padLeft(10)} => "__myString"
> - ${input:padRight(10)} => "myString__"
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Commented] (MINIFICPP-974) Ensure that non-docker tested processors are not included into the make packaged docker builds
[ https://issues.apache.org/jira/browse/MINIFICPP-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896914#comment-16896914 ] Arpad Boda commented on MINIFICPP-974: -- I'm in, too. As a first step I would like to have a well defined criteria for "sufficiently tested" to leave no room for "why did you...?" discussions. :) > Ensure that non-docker tested processors are not included into the make > packaged docker builds > -- > > Key: MINIFICPP-974 > URL: https://issues.apache.org/jira/browse/MINIFICPP-974 > Project: Apache NiFi MiNiFi C++ > Issue Type: New Feature >Reporter: Mr TheSegfault >Priority: Major > > This ensures that we don't trust and deploy artifacts that don't have some > type of regression test framework as it relates to our SITs. There may be > exceptions, so we can feel this desire out. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (NIFI-6490) MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language
[ https://issues.apache.org/jira/browse/NIFI-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896898#comment-16896898 ] Alessandro D'Armiento commented on NIFI-6490: - [~ijokarumawak] Thank you very much! I'm glad this was helpful! > MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable > registry expression language > -- > > Key: NIFI-6490 > URL: https://issues.apache.org/jira/browse/NIFI-6490 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: Alessandro D'Armiento >Assignee: Alessandro D'Armiento >Priority: Minor > Fix For: 1.10.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > h2. Current Situation > MergeRecords allows two attributes MIN_RECORDS and MAX_RECORDS to define how > many records a merged bin can contain. > These properties, however, do not support expression language and cannot be > inserted from variables. > h2. Improvement Proposal > Accept variable registry in these properties -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (NIFI-6407) Support useAvroLogicalTypes in the PutBigQueryBatch Processor
[ https://issues.apache.org/jira/browse/NIFI-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura updated NIFI-6407: Resolution: Fixed Status: Resolved (was: Patch Available) > Support useAvroLogicalTypes in the PutBigQueryBatch Processor > - > > Key: NIFI-6407 > URL: https://issues.apache.org/jira/browse/NIFI-6407 > Project: Apache NiFi > Issue Type: Wish > Components: Extensions >Affects Versions: 1.9.2 >Reporter: John >Assignee: Pierre Villard >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Would be great if PutBigQueryBatch supported the Google useAvroLogicalTypes > option, similar to https://issues.apache.org/jira/browse/AIRFLOW-3541 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (NIFI-6407) Support useAvroLogicalTypes in the PutBigQueryBatch Processor
[ https://issues.apache.org/jira/browse/NIFI-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura updated NIFI-6407: Fix Version/s: 1.10.0 > Support useAvroLogicalTypes in the PutBigQueryBatch Processor > - > > Key: NIFI-6407 > URL: https://issues.apache.org/jira/browse/NIFI-6407 > Project: Apache NiFi > Issue Type: Wish > Components: Extensions >Affects Versions: 1.9.2 >Reporter: John >Assignee: Pierre Villard >Priority: Major > Fix For: 1.10.0 > > Time Spent: 40m > Remaining Estimate: 0h > > Would be great if PutBigQueryBatch supported the Google useAvroLogicalTypes > option, similar to https://issues.apache.org/jira/browse/AIRFLOW-3541 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (NIFI-6407) Support useAvroLogicalTypes in the PutBigQueryBatch Processor
[ https://issues.apache.org/jira/browse/NIFI-6407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896892#comment-16896892 ] ASF subversion and git services commented on NIFI-6407: --- Commit 639e81e5a12f5fccb35a581e009eee5bcdb4bff6 in nifi's branch refs/heads/master from Pierre Villard [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=639e81e ] NIFI-6407 - added support for useAvroLogicalTypes in PutBigQueryBatch fix Maven dep This closes #3592. Signed-off-by: Koji Kawamura > Support useAvroLogicalTypes in the PutBigQueryBatch Processor > - > > Key: NIFI-6407 > URL: https://issues.apache.org/jira/browse/NIFI-6407 > Project: Apache NiFi > Issue Type: Wish > Components: Extensions >Affects Versions: 1.9.2 >Reporter: John >Assignee: Pierre Villard >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > Would be great if PutBigQueryBatch supported the Google useAvroLogicalTypes > option, similar to https://issues.apache.org/jira/browse/AIRFLOW-3541 -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] asfgit closed pull request #3592: NIFI-6407 - added support for useAvroLogicalTypes in PutBigQueryBatch
asfgit closed pull request #3592: NIFI-6407 - added support for useAvroLogicalTypes in PutBigQueryBatch URL: https://github.com/apache/nifi/pull/3592 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] ijokarumawak commented on issue #3592: NIFI-6407 - added support for useAvroLogicalTypes in PutBigQueryBatch
ijokarumawak commented on issue #3592: NIFI-6407 - added support for useAvroLogicalTypes in PutBigQueryBatch URL: https://github.com/apache/nifi/pull/3592#issuecomment-516743597 Thanks @pvillard31 ! I confirmed that the version conflict has been resolved. LGTM +1, merging to master. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFI-6487) ListS3 processor doesn't add S3 User Metadata to the Flow File
[ https://issues.apache.org/jira/browse/NIFI-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura resolved NIFI-6487. - Resolution: Fixed Fix Version/s: 1.10.0 [~jf.beauvais] I've added NiFi JIRA's 'Contributor' role to your account. You can assign yourself to NiFi JIRAs. Thanks for your contribution! > ListS3 processor doesn't add S3 User Metadata to the Flow File > -- > > Key: NIFI-6487 > URL: https://issues.apache.org/jira/browse/NIFI-6487 > Project: Apache NiFi > Issue Type: Wish > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: JF Beauvais >Assignee: JF Beauvais >Priority: Major > Fix For: 1.10.0 > > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently there is the possibility to add S3 tags to the flow files > attributes by setting "Write Object Tags" to true. > It could be also interesting to add S3 Object "User metadata" as well -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (NIFI-6487) ListS3 processor doesn't add S3 User Metadata to the Flow File
[ https://issues.apache.org/jira/browse/NIFI-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura reassigned NIFI-6487: --- Assignee: JF Beauvais > ListS3 processor doesn't add S3 User Metadata to the Flow File > -- > > Key: NIFI-6487 > URL: https://issues.apache.org/jira/browse/NIFI-6487 > Project: Apache NiFi > Issue Type: Wish > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: JF Beauvais >Assignee: JF Beauvais >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > Currently there is the possibility to add S3 tags to the flow files > attributes by setting "Write Object Tags" to true. > It could be also interesting to add S3 Object "User metadata" as well -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (NIFI-6487) ListS3 processor doesn't add S3 User Metadata to the Flow File
[ https://issues.apache.org/jira/browse/NIFI-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896874#comment-16896874 ] ASF subversion and git services commented on NIFI-6487: --- Commit cdee1d8c09c52dd2aa78311cf8c8fe9b2f449d44 in nifi's branch refs/heads/master from JF Beauvais [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cdee1d8 ] NIFI-6487 Add S3 User Metadata to ListS3 processor Fix imports auto formatted by intellij NIFI-6487 Fix WriteAttribute documentation This closes #3603. Signed-off-by: Koji Kawamura > ListS3 processor doesn't add S3 User Metadata to the Flow File > -- > > Key: NIFI-6487 > URL: https://issues.apache.org/jira/browse/NIFI-6487 > Project: Apache NiFi > Issue Type: Wish > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: JF Beauvais >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently there is the possibility to add S3 tags to the flow files > attributes by setting "Write Object Tags" to true. > It could be also interesting to add S3 Object "User metadata" as well -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] asfgit closed pull request #3603: NIFI-6487 Add S3 User Metadata to ListS3 processor
asfgit closed pull request #3603: NIFI-6487 Add S3 User Metadata to ListS3 processor URL: https://github.com/apache/nifi/pull/3603 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6487) ListS3 processor doesn't add S3 User Metadata to the Flow File
[ https://issues.apache.org/jira/browse/NIFI-6487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896873#comment-16896873 ] ASF subversion and git services commented on NIFI-6487: --- Commit cdee1d8c09c52dd2aa78311cf8c8fe9b2f449d44 in nifi's branch refs/heads/master from JF Beauvais [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=cdee1d8 ] NIFI-6487 Add S3 User Metadata to ListS3 processor Fix imports auto formatted by intellij NIFI-6487 Fix WriteAttribute documentation This closes #3603. Signed-off-by: Koji Kawamura > ListS3 processor doesn't add S3 User Metadata to the Flow File > -- > > Key: NIFI-6487 > URL: https://issues.apache.org/jira/browse/NIFI-6487 > Project: Apache NiFi > Issue Type: Wish > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: JF Beauvais >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > Currently there is the possibility to add S3 tags to the flow files > attributes by setting "Write Object Tags" to true. > It could be also interesting to add S3 Object "User metadata" as well -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] ijokarumawak commented on issue #3603: NIFI-6487 Add S3 User Metadata to ListS3 processor
ijokarumawak commented on issue #3603: NIFI-6487 Add S3 User Metadata to ListS3 processor URL: https://github.com/apache/nifi/pull/3603#issuecomment-516737468 @jf-beauvais Thanks for the update! LGTM +1. I'm going to squash commits and merge it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (NIFI-6490) MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language
[ https://issues.apache.org/jira/browse/NIFI-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura resolved NIFI-6490. - Resolution: Fixed Fix Version/s: 1.10.0 [~AxelSync], I've added NiFi Jira projects 'Contributor' roll to your account. Now you can assign yourself to NiFi JIRAs. Thanks for your contribution! > MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable > registry expression language > -- > > Key: NIFI-6490 > URL: https://issues.apache.org/jira/browse/NIFI-6490 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: Alessandro D'Armiento >Assignee: Alessandro D'Armiento >Priority: Minor > Fix For: 1.10.0 > > Time Spent: 2h 20m > Remaining Estimate: 0h > > h2. Current Situation > MergeRecords allows two attributes MIN_RECORDS and MAX_RECORDS to define how > many records a merged bin can contain. > These properties, however, do not support expression language and cannot be > inserted from variables. > h2. Improvement Proposal > Accept variable registry in these properties -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Assigned] (NIFI-6490) MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language
[ https://issues.apache.org/jira/browse/NIFI-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Koji Kawamura reassigned NIFI-6490: --- Assignee: Alessandro D'Armiento > MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable > registry expression language > -- > > Key: NIFI-6490 > URL: https://issues.apache.org/jira/browse/NIFI-6490 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: Alessandro D'Armiento >Assignee: Alessandro D'Armiento >Priority: Minor > Time Spent: 2h 20m > Remaining Estimate: 0h > > h2. Current Situation > MergeRecords allows two attributes MIN_RECORDS and MAX_RECORDS to define how > many records a merged bin can contain. > These properties, however, do not support expression language and cannot be > inserted from variables. > h2. Improvement Proposal > Accept variable registry in these properties -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] asfgit closed pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS
asfgit closed pull request #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (NIFI-6490) MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable registry expression language
[ https://issues.apache.org/jira/browse/NIFI-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16896860#comment-16896860 ] ASF subversion and git services commented on NIFI-6490: --- Commit 1d22e8a86d001540bb86d017a9139393778628cb in nifi's branch refs/heads/master from Alessandro D'Armiento [ https://gitbox.apache.org/repos/asf?p=nifi.git;h=1d22e8a ] NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS Unified unit tests Added custom validation cases for MIN_RECORDS and MAX_RECORDS enforcing they are greater than zero. While MIN_RECORDS > 0 can fail individually, MAX_RECORDS > 0 validator cannot fail without having also at least another validation step (either the MIN_RECORDS > 0 or the MAX_RECORDS > MIN_RECORDS) to fail, since MIN_RECORDS is a required property with default value 1 This closes #3607. Signed-off-by: Koji Kawamura > MergeRecord properties MIN_RECORDS and MAX_RECORDS should accept variable > registry expression language > -- > > Key: NIFI-6490 > URL: https://issues.apache.org/jira/browse/NIFI-6490 > Project: Apache NiFi > Issue Type: Improvement > Components: Core Framework >Affects Versions: 1.9.2 >Reporter: Alessandro D'Armiento >Priority: Minor > Time Spent: 2h 10m > Remaining Estimate: 0h > > h2. Current Situation > MergeRecords allows two attributes MIN_RECORDS and MAX_RECORDS to define how > many records a merged bin can contain. > These properties, however, do not support expression language and cannot be > inserted from variables. > h2. Improvement Proposal > Accept variable registry in these properties -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[GitHub] [nifi] ijokarumawak commented on issue #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS
ijokarumawak commented on issue #3607: NIFI-6490 MergeRecord supports Variable Registry for MIN_RECORDS and MAX_RECORDS URL: https://github.com/apache/nifi/pull/3607#issuecomment-516734009 @AxelSync Thanks for the update! LGTM, too +1. I'll squash commits and merge it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [nifi] ijokarumawak opened a new pull request #3617: NIFI-6507 Unsubscribe if WindowsEventLog subscription encounters an e…
ijokarumawak opened a new pull request #3617: NIFI-6507 Unsubscribe if
WindowsEventLog subscription encounters an e…
URL: https://github.com/apache/nifi/pull/3617
…rror
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
ConsumeWindowsEventLog doesn't renew failed subscription. It should try
initiating a new subscription automatically to recover from previous failure.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
