[jira] [Updated] (NIFI-9773) Refactor nifi-system-tests to use JUnit 5
[ https://issues.apache.org/jira/browse/NIFI-9773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9773: --- Fix Version/s: 1.16.1 > Refactor nifi-system-tests to use JUnit 5 > - > > Key: NIFI-9773 > URL: https://issues.apache.org/jira/browse/NIFI-9773 > Project: Apache NiFi > Issue Type: Sub-task >Reporter: David Handermann >Assignee: David Handermann >Priority: Minor > Fix For: 1.17.0, 1.16.1 > > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (NIFI-9793) System Integration Test Failure with HTTP 409
[
https://issues.apache.org/jira/browse/NIFI-9793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9793:
---
Fix Version/s: 1.16.1
> System Integration Test Failure with HTTP 409
> -
>
> Key: NIFI-9793
> URL: https://issues.apache.org/jira/browse/NIFI-9793
> Project: Apache NiFi
> Issue Type: Bug
> Components: Tools and Build
>Reporter: David Handermann
>Assignee: David Handermann
>Priority: Minor
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> System Integration tests for NiFi reported the following failure in a recent
> automated build on GitHub:
> {noformat}
> Error:
> org.apache.nifi.tests.system.verification.ClusteredVerifiableControllerServiceSystemIT.testVerificationWithValidConfigWhenComponentRunning
> Time elapsed: 1.096 s <<< ERROR!
> org.apache.nifi.toolkit.cli.impl.client.nifi.NiFiClientException: Error
> deleting Controller Service: Node localhost:5671 is unable to fulfill this
> request due to: Controller Service 85f6b66c-017f-1000--68457893
> cannot be deleted because it is not disabled
> Caused by: javax.ws.rs.ClientErrorException: HTTP 409 Conflict
> Error:
> ClusteredVerifiableControllerServiceSystemIT>NiFiSystemIT.teardown:126->NiFiSystemIT.destroyFlow:177
> » NiFiClient
> {noformat}
> The impacted portion of the test should be adjusted to retry when receiving a
> response with HTTP 409.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (NIFI-1468) Add unit tests for invalid cipher streams
[
https://issues.apache.org/jira/browse/NIFI-1468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-1468:
---
Fix Version/s: 1.16.1
> Add unit tests for invalid cipher streams
> -
>
> Key: NIFI-1468
> URL: https://issues.apache.org/jira/browse/NIFI-1468
> Project: Apache NiFi
> Issue Type: Test
> Components: Core Framework
>Affects Versions: 0.5.0
>Reporter: Andy LoPresto
>Assignee: Emilio Setiadarma
>Priority: Minor
> Labels: encryption, security
> Fix For: 1.17.0, 1.16.1
>
> Original Estimate: 48h
> Time Spent: 0.5h
> Remaining Estimate: 47.5h
>
> Add unit tests for {{PasswordBasedEncryptorGroovyTest}} and
> {{KeyedEncryptorGroovyTest}} to ensure they handle invalid cipher streams
> correctly during decryption. Include the following tests:
> {{PasswordBasedEncryptorGroovyTest}}
> * {{testDecryptShouldHandleCipherStreamMissingSalt()}}
> * {{testDecryptShouldHandleCipherStreamMissingSaltDelimiter()}}
> * {{testDecryptShouldHandleCipherStreamMissingIV()}}
> * {{testDecryptShouldHandleCipherStreamMissingIVDelimiter()}}
> {{KeyedEncryptorGroovyTest}}
> * {{testDecryptShouldHandleCipherStreamMissingIV()}}
> * {{testDecryptShouldHandleCipherStreamMissingIVDelimiter()}}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (NIFI-8124) Allow Cookie Preservation in Redirects for InvokeHTTP
[ https://issues.apache.org/jira/browse/NIFI-8124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-8124: --- Fix Version/s: 1.16.1 > Allow Cookie Preservation in Redirects for InvokeHTTP > - > > Key: NIFI-8124 > URL: https://issues.apache.org/jira/browse/NIFI-8124 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Affects Versions: 1.15.3 >Reporter: Shawn Weeks >Assignee: Marcus Ely >Priority: Minor > Labels: InvokeHTTP, cookie, cookies, http > Fix For: 1.17.0, 1.16.1 > > Time Spent: 50m > Remaining Estimate: 0h > > Some authentication systems like 2-way ssl on an F5 Appliance use session > cookies during redirection to determine who you are. Currently InvokeHTTP > does not preserve these cookies during redirection causing authentication > failure. The OkHttp Library supports a Cookie Jar option like curl's "-c" > that would allow this to work. This issue is to add the option to enable that > feature if needed but leave it disabled by default. > Of note it appears the Apache HttpClient supports this by default exactly > opposite from OkHttp. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (NIFI-9834) ExecuteStateless fails when the output FlowFile has no content
[
https://issues.apache.org/jira/browse/NIFI-9834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9834:
---
Fix Version/s: 1.16.1
> ExecuteStateless fails when the output FlowFile has no content
> --
>
> Key: NIFI-9834
> URL: https://issues.apache.org/jira/browse/NIFI-9834
> Project: Apache NiFi
> Issue Type: Bug
> Components: NiFi Stateless
>Reporter: Peter Turcsanyi
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Stateless flow: Input port -> UpdateAttibute -> Output port
> Executor flow: GenerateFlowFile -> ExecuteStateless -> LogAttribute
> When GFF produces a FF with content => no error
> When GFF produces empty FF =>
> {code:java}
> 2022-03-24 21:15:38,536 ERROR [Timer-Driven Process Thread-8]
> o.a.n.p.stateless.ExecuteStateless
> ExecuteStateless[id=5bb8285e-36cb-3c02-0aeb-0bd7f61d91c8] Failed to process
> session due to java.lang.NullPointerException; Processor Administratively
> Yielded for 1 sec: java.lang.NullPointerException
> java.lang.NullPointerException: null
> at java.util.Objects.requireNonNull(Objects.java:203)
> at
> org.apache.nifi.stateless.repository.ByteArrayContentRepository.verifyClaim(ByteArrayContentRepository.java:243)
> at
> org.apache.nifi.stateless.repository.ByteArrayContentRepository.read(ByteArrayContentRepository.java:218)
> at
> org.apache.nifi.stateless.engine.StandardExecutionProgress$1.readContent(StandardExecutionProgress.java:189)
> at
> org.apache.nifi.processors.stateless.ExecuteStateless.createOutputFlowFiles(ExecuteStateless.java:691)
> at
> org.apache.nifi.processors.stateless.ExecuteStateless.runDataflow(ExecuteStateless.java:605)
> at
> org.apache.nifi.processors.stateless.ExecuteStateless.onTrigger(ExecuteStateless.java:506)
> at
> org.apache.nifi.processor.AbstractProcessor.onTrigger(AbstractProcessor.java:27)
> at
> org.apache.nifi.controller.StandardProcessorNode.onTrigger(StandardProcessorNode.java:1283)
> at
> org.apache.nifi.controller.tasks.ConnectableTask.invoke(ConnectableTask.java:214)
> at
> org.apache.nifi.controller.scheduling.TimerDrivenSchedulingAgent$1.run(TimerDrivenSchedulingAgent.java:103)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.runAndReset(FutureTask.java:308)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$301(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:294)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (NIFI-9827) Update regions in AWS processors
[ https://issues.apache.org/jira/browse/NIFI-9827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9827: --- Fix Version/s: 1.16.1 > Update regions in AWS processors > > > Key: NIFI-9827 > URL: https://issues.apache.org/jira/browse/NIFI-9827 > Project: Apache NiFi > Issue Type: Improvement > Components: Extensions >Reporter: Joe Gresock >Assignee: Joe Gresock >Priority: Major > Fix For: 1.17.0, 1.16.1 > > Time Spent: 0.5h > Remaining Estimate: 0h > > A more up-to-date list of AWS regions could be added to the AWS processors. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (NIFI-9833) Batch replay files based on Provenance search
[ https://issues.apache.org/jira/browse/NIFI-9833?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt updated NIFI-9833: --- Fix Version/s: (was: 1.17.0) > Batch replay files based on Provenance search > - > > Key: NIFI-9833 > URL: https://issues.apache.org/jira/browse/NIFI-9833 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration >Affects Versions: 1.15.2 > Environment: NiFi >Reporter: Paul Pascoe >Priority: Major > > The ability to batch replay files based on Provenance search criteria. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Updated] (NIFI-9835) When node offloads, can get stuck, logging errors about a negative queue size
[
https://issues.apache.org/jira/browse/NIFI-9835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9835:
---
Fix Version/s: 1.16.1
> When node offloads, can get stuck, logging errors about a negative queue size
> -
>
> Key: NIFI-9835
> URL: https://issues.apache.org/jira/browse/NIFI-9835
> Project: Apache NiFi
> Issue Type: Bug
> Components: Core Framework
>Reporter: Mark Payne
>Assignee: Mark Payne
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When a node is offloaded, we can occasionally see that it does not complete
> the offload and logs errors about creating a negative queue size. For example:
> {code:java}
> 2022-03-24 19:43:53,919 ERROR [Load-Balanced Client Thread-1[]
> o.a.n.c.queue.SwappablePriorityQueue Updated Size of Queue Unacknowledged
> from FlowFile Queue Size[ ActiveQueue=[0, 0 Bytes[], Swap Queue=[0, 0
> Bytes[], Swap Files=[0[], Unacknowledged=[-7, -5820 Bytes[] ] to FlowFile
> Queue Size[ ActiveQueue=[0, 0 Bytes[], Swap Queue=[0, 0 Bytes[], Swap
> Files=[0[], Unacknowledged=[-7, -5820 Bytes[] ]
> java.lang.RuntimeException: Cannot create negative queue size
> at
> org.apache.nifi.controller.queue.SwappablePriorityQueue.logIfNegative(SwappablePriorityQueue.java:1055)
> at
> org.apache.nifi.controller.queue.SwappablePriorityQueue.incrementUnacknowledgedQueueSize(SwappablePriorityQueue.java:1045)
> at
> org.apache.nifi.controller.queue.SwappablePriorityQueue.acknowledge(SwappablePriorityQueue.java:451)
> at
> org.apache.nifi.controller.queue.clustered.partition.RemoteQueuePartition$2.onTransactionComplete(RemoteQueuePartition.java:223)
> at
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClient.communicate(NioAsyncLoadBalanceClient.java:281)
> at
> org.apache.nifi.controller.queue.clustered.client.async.nio.NioAsyncLoadBalanceClientTask.run(NioAsyncLoadBalanceClientTask.java:81)
> at org.apache.nifi.engine.FlowEngine$2.run(FlowEngine.java:110)
> at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
> at
> java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Commented] (NIFI-9836) Nifi registry db migration fails if database is postgresql
[
https://issues.apache.org/jira/browse/NIFI-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17513111#comment-17513111
]
Joe Witt commented on NIFI-9836:
thanks for reporting and posting a fix. I tagged this to 1.16.1
> Nifi registry db migration fails if database is postgresql
> --
>
> Key: NIFI-9836
> URL: https://issues.apache.org/jira/browse/NIFI-9836
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Zoltán Kornél Török
>Assignee: Zoltán Kornél Török
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There was an H2 upgrade -
> https://github.com/apache/nifi/commit/bcc8d03314889e7d2d0724390059d0315efe2a34
> In this pr the following if is refactored:
> https://github.com/apache/nifi/blob/main/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/CustomFlywayConfiguration.java#L64
> However the
> {code}
> databaseType.equals(new PostgreSQLDatabaseType())
> {code}
> will not work, because flyway DatabaseType classes doesn’t implement a proper
> equals method:
> https://github.com/flyway/flyway/blob/master/flyway-core/src/main/java/org/flywaydb/core/internal/database/postgresql/PostgreSQLDatabaseType.java#L36
> Because of this if the user not use the default database, then not the proper
> migration locations will be used.
> {code}
> 2022-03-26 12:28:14,593 INFO
> org.apache.nifi.registry.db.CustomFlywayConfiguration: Determined database
> type is PostgreSQL
> 2022-03-26 12:28:14,593 INFO
> org.apache.nifi.registry.db.CustomFlywayConfiguration: Setting migration
> locations to [classpath:db/migration/common, classpath:db/migration/default]
> 2022-03-26 12:28:14,616 INFO
> org.apache.nifi.registry.db.CustomFlywayConfiguration: Using default Flyway
> configuration table
> ..
> ..
> led; nested exception is
> org.flywaydb.core.internal.command.DbMigrate$FlywayMigrateException:
> Migration V6__AddFlowPersistence.sql failed
> ---
> SQL State : 42704
> Error Code : 0
> Message: ERROR: type "blob" does not exist
> Position: 951
> Location : db/migration/default/V6__AddFlowPersistence.sql
> Line : 16
> Statement : -- Licensed to the Apache Software Foundation (ASF) under one or
> more
> -- contributor license agreements. See the NOTICE file distributed with
> -- this work for additional information regarding copyright ownership.
> -- The ASF licenses this file to You under the Apache License, Version 2.0
> -- (the "License"); you may not use this file except in compliance with
> -- the License. You may obtain a copy of the License at
> --
> -- http://www.apache.org/licenses/LICENSE-2.0
> --
> -- Unless required by applicable law or agreed to in writing, software
> -- distributed under the License is distributed on an "AS IS" BASIS,
> -- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> -- See the License for the specific language governing permissions and
> -- limitations under the License.
> CREATE TABLE FLOW_PERSISTENCE_PROVIDER (
> BUCKET_ID VARCHAR(50) NOT NULL,
> FLOW_ID VARCHAR(50) NOT NULL,
> VERSION INT NOT NULL,
> FLOW_CONTENT BLOB NOT NULL,
> CONSTRAINT PK__FLOW_PERSISTENCE_PROVIDER PRIMARY KEY (BUCKET_ID, FLOW_ID,
> VERSION)
> )
> ..
> ..
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Updated] (NIFI-9836) Nifi registry db migration fails if database is postgresql
[
https://issues.apache.org/jira/browse/NIFI-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joe Witt updated NIFI-9836:
---
Fix Version/s: 1.17.0
1.16.1
> Nifi registry db migration fails if database is postgresql
> --
>
> Key: NIFI-9836
> URL: https://issues.apache.org/jira/browse/NIFI-9836
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Zoltán Kornél Török
>Assignee: Zoltán Kornél Török
>Priority: Major
> Fix For: 1.17.0, 1.16.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There was an H2 upgrade -
> https://github.com/apache/nifi/commit/bcc8d03314889e7d2d0724390059d0315efe2a34
> In this pr the following if is refactored:
> https://github.com/apache/nifi/blob/main/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/CustomFlywayConfiguration.java#L64
> However the
> {code}
> databaseType.equals(new PostgreSQLDatabaseType())
> {code}
> will not work, because flyway DatabaseType classes doesn’t implement a proper
> equals method:
> https://github.com/flyway/flyway/blob/master/flyway-core/src/main/java/org/flywaydb/core/internal/database/postgresql/PostgreSQLDatabaseType.java#L36
> Because of this if the user not use the default database, then not the proper
> migration locations will be used.
> {code}
> 2022-03-26 12:28:14,593 INFO
> org.apache.nifi.registry.db.CustomFlywayConfiguration: Determined database
> type is PostgreSQL
> 2022-03-26 12:28:14,593 INFO
> org.apache.nifi.registry.db.CustomFlywayConfiguration: Setting migration
> locations to [classpath:db/migration/common, classpath:db/migration/default]
> 2022-03-26 12:28:14,616 INFO
> org.apache.nifi.registry.db.CustomFlywayConfiguration: Using default Flyway
> configuration table
> ..
> ..
> led; nested exception is
> org.flywaydb.core.internal.command.DbMigrate$FlywayMigrateException:
> Migration V6__AddFlowPersistence.sql failed
> ---
> SQL State : 42704
> Error Code : 0
> Message: ERROR: type "blob" does not exist
> Position: 951
> Location : db/migration/default/V6__AddFlowPersistence.sql
> Line : 16
> Statement : -- Licensed to the Apache Software Foundation (ASF) under one or
> more
> -- contributor license agreements. See the NOTICE file distributed with
> -- this work for additional information regarding copyright ownership.
> -- The ASF licenses this file to You under the Apache License, Version 2.0
> -- (the "License"); you may not use this file except in compliance with
> -- the License. You may obtain a copy of the License at
> --
> -- http://www.apache.org/licenses/LICENSE-2.0
> --
> -- Unless required by applicable law or agreed to in writing, software
> -- distributed under the License is distributed on an "AS IS" BASIS,
> -- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> -- See the License for the specific language governing permissions and
> -- limitations under the License.
> CREATE TABLE FLOW_PERSISTENCE_PROVIDER (
> BUCKET_ID VARCHAR(50) NOT NULL,
> FLOW_ID VARCHAR(50) NOT NULL,
> VERSION INT NOT NULL,
> FLOW_CONTENT BLOB NOT NULL,
> CONSTRAINT PK__FLOW_PERSISTENCE_PROVIDER PRIMARY KEY (BUCKET_ID, FLOW_ID,
> VERSION)
> )
> ..
> ..
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[jira] [Resolved] (NIFI-9780) Conduct 1.16.0 Release
[ https://issues.apache.org/jira/browse/NIFI-9780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joe Witt resolved NIFI-9780. Resolution: Fixed > Conduct 1.16.0 Release > -- > > Key: NIFI-9780 > URL: https://issues.apache.org/jira/browse/NIFI-9780 > Project: Apache NiFi > Issue Type: Task >Reporter: Joe Witt >Assignee: Joe Witt >Priority: Major > Fix For: 1.16.0 > > -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Assigned] (NIFI-7254) Upgrade to a newer version of geoip2
[ https://issues.apache.org/jira/browse/NIFI-7254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen reassigned NIFI-7254: -- Assignee: Mike Thomsen > Upgrade to a newer version of geoip2 > > > Key: NIFI-7254 > URL: https://issues.apache.org/jira/browse/NIFI-7254 > Project: Apache NiFi > Issue Type: Task > Components: Extensions >Reporter: Matt Gilman >Assignee: Mike Thomsen >Priority: Major > > In order to upgrade a transitive dependency on an older version of > jackson-databind we should upgrade to the latest version of > com.maxmind.geoip2:geoip2. -- This message was sent by Atlassian Jira (v8.20.1#820001)
[GitHub] [nifi] taz1988 opened a new pull request #5907: NIFI-9836: fix database selection during nifi registry startup
taz1988 opened a new pull request #5907:
URL: https://github.com/apache/nifi/pull/5907
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Fix https://issues.apache.org/jira/browse/NIFI-9836 bug.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-** where is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [x] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes? - no
because it would require a lot of class mocking, I guess that is the reason why
it has no tests originally
- [x] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [x] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Assigned] (NIFI-9836) Nifi registry db migration fails if database is postgresql
[
https://issues.apache.org/jira/browse/NIFI-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltán Kornél Török reassigned NIFI-9836:
-
Assignee: Zoltán Kornél Török
> Nifi registry db migration fails if database is postgresql
> --
>
> Key: NIFI-9836
> URL: https://issues.apache.org/jira/browse/NIFI-9836
> Project: Apache NiFi
> Issue Type: Bug
>Affects Versions: 1.16.0
>Reporter: Zoltán Kornél Török
>Assignee: Zoltán Kornél Török
>Priority: Major
>
> There was an H2 upgrade -
> https://github.com/apache/nifi/commit/bcc8d03314889e7d2d0724390059d0315efe2a34
> In this pr the following if is refactored:
> https://github.com/apache/nifi/blob/main/nifi-registry/nifi-registry-core/nifi-registry-framework/src/main/java/org/apache/nifi/registry/db/CustomFlywayConfiguration.java#L64
> However the
> {code}
> databaseType.equals(new PostgreSQLDatabaseType())
> {code}
> will not work, because flyway DatabaseType classes doesn’t implement a proper
> equals method:
> https://github.com/flyway/flyway/blob/master/flyway-core/src/main/java/org/flywaydb/core/internal/database/postgresql/PostgreSQLDatabaseType.java#L36
> Because of this if the user not use the default database, then not the proper
> migration locations will be used.
> {code}
> 2022-03-26 12:28:14,593 INFO
> org.apache.nifi.registry.db.CustomFlywayConfiguration: Determined database
> type is PostgreSQL
> 2022-03-26 12:28:14,593 INFO
> org.apache.nifi.registry.db.CustomFlywayConfiguration: Setting migration
> locations to [classpath:db/migration/common, classpath:db/migration/default]
> 2022-03-26 12:28:14,616 INFO
> org.apache.nifi.registry.db.CustomFlywayConfiguration: Using default Flyway
> configuration table
> ..
> ..
> led; nested exception is
> org.flywaydb.core.internal.command.DbMigrate$FlywayMigrateException:
> Migration V6__AddFlowPersistence.sql failed
> ---
> SQL State : 42704
> Error Code : 0
> Message: ERROR: type "blob" does not exist
> Position: 951
> Location : db/migration/default/V6__AddFlowPersistence.sql
> Line : 16
> Statement : -- Licensed to the Apache Software Foundation (ASF) under one or
> more
> -- contributor license agreements. See the NOTICE file distributed with
> -- this work for additional information regarding copyright ownership.
> -- The ASF licenses this file to You under the Apache License, Version 2.0
> -- (the "License"); you may not use this file except in compliance with
> -- the License. You may obtain a copy of the License at
> --
> -- http://www.apache.org/licenses/LICENSE-2.0
> --
> -- Unless required by applicable law or agreed to in writing, software
> -- distributed under the License is distributed on an "AS IS" BASIS,
> -- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> -- See the License for the specific language governing permissions and
> -- limitations under the License.
> CREATE TABLE FLOW_PERSISTENCE_PROVIDER (
> BUCKET_ID VARCHAR(50) NOT NULL,
> FLOW_ID VARCHAR(50) NOT NULL,
> VERSION INT NOT NULL,
> FLOW_CONTENT BLOB NOT NULL,
> CONSTRAINT PK__FLOW_PERSISTENCE_PROVIDER PRIMARY KEY (BUCKET_ID, FLOW_ID,
> VERSION)
> )
> ..
> ..
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
[GitHub] [nifi] MikeThomsen commented on a change in pull request #5900: NIFI-7234 Standardized on Avro 1.11.0
MikeThomsen commented on a change in pull request #5900:
URL: https://github.com/apache/nifi/pull/5900#discussion_r835955309
##
File path:
nifi-nar-bundles/nifi-hive-bundle/nifi-hive-processors/src/test/java/org/apache/nifi/util/orc/TestNiFiOrcUtils.java
##
@@ -377,10 +378,11 @@ public static Schema buildComplexAvroSchema() {
public static GenericData.Record buildComplexAvroRecord(Integer i,
Map m, String e, Object unionVal, List intArray,
ByteBuffer decimal) {
Schema schema = buildComplexAvroSchema();
+Schema enumSchema = schema.getField("myEnum").schema();
GenericData.Record row = new GenericData.Record(schema);
row.put("myInt", i);
row.put("myMap", m);
-row.put("myEnum", e);
+row.put("myEnum", new GenericData.EnumSymbol(enumSchema, e));
Review comment:
https://issues.apache.org/jira/browse/AVRO-1810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a change in pull request #5900: NIFI-7234 Standardized on Avro 1.11.0
MikeThomsen commented on a change in pull request #5900:
URL: https://github.com/apache/nifi/pull/5900#discussion_r835954170
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/resources/org/apache/nifi/avro/schema.json
##
@@ -1,20 +1,20 @@
[ {
- "namespace" : "net.a",
- "type" : "record",
- "name" : "O",
- "fields" : [ {
- "name" : "hash",
- "type" : [ "null", {
- "type" : "map",
- "values" : "string"
- } ]
- } ]
-}, {
"namespace" : "net.a",
"type" : "record",
"name" : "A",
"fields" : [ {
"name" : "o",
- "type" : [ "null", "O" ]
+ "type" : [ {
Review comment:
This appears to have changed with the parsing functionality in 1.9+.
Under 1.10 and 1.11, the Avro API was not able to the first type and reference
it in the second type until it was embedded in the second type as shown here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a change in pull request #5900: NIFI-7234 Standardized on Avro 1.11.0
MikeThomsen commented on a change in pull request #5900: URL: https://github.com/apache/nifi/pull/5900#discussion_r835954005 ## File path: nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/test/resources/org/apache/nifi/avro/defaultArrayInRecords1.json ## @@ -16,7 +16,7 @@ "items":"int" }, "doc":"array of ints", - "default": 0 + "default": [ 0 ] Review comment: Not sure why the first one ever worked because the `0` literal is not an array. It broke with the update to 1.11 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a change in pull request #5900: NIFI-7234 Standardized on Avro 1.11.0
MikeThomsen commented on a change in pull request #5900:
URL: https://github.com/apache/nifi/pull/5900#discussion_r835953933
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-avro-record-utils/src/main/java/org/apache/nifi/avro/AvroTypeUtil.java
##
@@ -326,7 +326,7 @@ private static Schema nullable(final Schema schema) {
return Schema.createUnion(unionTypes);
}
-return Schema.createUnion(Schema.create(Type.NULL), schema);
+return Schema.createUnion(schema, Schema.create(Type.NULL));
Review comment:
Changed this and our test schemas per this line in the Avro
Specification:
> default: A default value for this field, only used when reading instances
that lack the field for schema evolution purposes. The presence of a default
value does not make the field optional at encoding time. Permitted values
depend on the field's schema type, according to the table below. **Default
values for union fields correspond to the first schema in the union**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (NIFI-6121) Update low hanging fruit dependencies of apache commons and related items
[ https://issues.apache.org/jira/browse/NIFI-6121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen resolved NIFI-6121. Resolution: Fixed Looks like we forgot to close out this ticket when it was closed on GitHub. > Update low hanging fruit dependencies of apache commons and related items > - > > Key: NIFI-6121 > URL: https://issues.apache.org/jira/browse/NIFI-6121 > Project: Apache NiFi > Issue Type: Task > Components: Core Framework >Reporter: Joe Witt >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > > https://www.mojohaus.org/versions-maven-plugin/display-dependency-updates-mojo.html > org.apache.commons:commons-collections4 ... 4.2 -> 4.3 > org.apache.commons:commons-configuration2 . 2.3 -> 2.4 > org.apache.commons:commons-csv 1.5 -> 1.6 > org.apache.commons:commons-dbcp2 .. 2.5.0 -> 2.6.0 > org.apache.commons:commons-text ... 1.4 -> 1.6 > org.apache.poi:poi 4.0.0 -> 4.0.1 > org.apache.tika:tika-core . 1.19.1 -> 1.20 > org.bouncycastle: ... 1.60 -> 1.61 > org.json:json ... 20160810 -> 20180813 > org.scijava:jython-shaded ... 2.7.1 -> 2.7.1.1 -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Resolved] (NIFI-6528) nifi ganglia监控，在哪个属性文件配置
[ https://issues.apache.org/jira/browse/NIFI-6528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Thomsen resolved NIFI-6528. Resolution: Abandoned > nifi ganglia监控，在哪个属性文件配置 > > > Key: NIFI-6528 > URL: https://issues.apache.org/jira/browse/NIFI-6528 > Project: Apache NiFi > Issue Type: Improvement > Components: Configuration >Affects Versions: 1.9.2 > Environment: linux >Reporter: jiangtinglong >Priority: Major > > 我想使用ganglia 监控nifi，请问 nifi 应该怎么配置，我的ganglia环境是ok的，现在不知道怎么配置nifi -- This message was sent by Atlassian Jira (v8.20.1#820001)
[jira] [Commented] (NIFI-6528) nifi ganglia监控，在哪个属性文件配置
[
https://issues.apache.org/jira/browse/NIFI-6528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17512891#comment-17512891
]
Mike Thomsen commented on NIFI-6528:
{quote}I want to use ganglia to monitor nifi, how should nifi be configured, my
ganglia environment is ok, now I don't know how to configure nifi
{quote}
Questions should be asked in community fora and not Jira.
> nifi ganglia监控，在哪个属性文件配置
>
>
> Key: NIFI-6528
> URL: https://issues.apache.org/jira/browse/NIFI-6528
> Project: Apache NiFi
> Issue Type: Improvement
> Components: Configuration
>Affects Versions: 1.9.2
> Environment: linux
>Reporter: jiangtinglong
>Priority: Major
>
> 我想使用ganglia 监控nifi，请问 nifi 应该怎么配置，我的ganglia环境是ok的，现在不知道怎么配置nifi
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
