[GitHub] [nifi] MikeThomsen commented on a change in pull request #4104: NIFI-7159

2020-03-04 Thread GitBox 
MikeThomsen commented on a change in pull request #4104: NIFI-7159
URL: https://github.com/apache/nifi/pull/4104#discussion_r388006141
 
 

 ##
 File path: 
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch/PutElasticsearchHttpRecord.java
 ##
 @@ -669,6 +669,9 @@ private void writeValue(final JsonGenerator generator, 
final Object value, final
 }
 break;
 }
+case DECIMAL:
 
 Review comment:
   I think this should actually be a double because that's the maximum that 
Elasticsearch supports. See here:
   
   
https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-types.html


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] MikeThomsen commented on a change in pull request #4104: NIFI-7159

2020-03-04 Thread GitBox 
MikeThomsen commented on a change in pull request #4104: NIFI-7159
URL: https://github.com/apache/nifi/pull/4104#discussion_r388006930
 
 

 ##
 File path: 
nifi-nar-bundles/nifi-hive-bundle/nifi-hive3-processors/src/main/java/org/apache/hadoop/hive/ql/io/orc/NiFiOrcUtils.java
 ##
 @@ -104,6 +105,10 @@ public static Object convertToORCObject(TypeInfo 
typeInfo, Object o, final boole
 if (o instanceof Double) {
 return new DoubleWritable((double) o);
 }
+// Map BigDecimal to a Double type - this should be improved to 
map to Hive Decimal type
+if (o instanceof BigDecimal) {
 
 Review comment:
   There were some runtime issues with unit tests related to Orc. @mattyb149 
@bbende @ijokarumawak do y'all have any insight into this ORC conversion?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] MikeThomsen commented on a change in pull request #4104: NIFI-7159

2020-03-04 Thread GitBox 
MikeThomsen commented on a change in pull request #4104: NIFI-7159
URL: https://github.com/apache/nifi/pull/4104#discussion_r388006605
 
 

 ##
 File path: 
nifi-nar-bundles/nifi-hbase-bundle/nifi-hbase-processors/src/main/java/org/apache/nifi/hbase/PutHBaseRecord.java
 ##
 @@ -341,6 +341,8 @@ protected PutFlowFile createPut(ProcessSession session, 
ProcessContext context,
 case BOOLEAN:
 retVal = clientService.toBytes(record.getAsBoolean(field));
 break;
+case DECIMAL:
+// Decimal to be treated as the same as double
 
 Review comment:
   It should be broken down into a byte array like the other types.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [nifi] MikeThomsen commented on a change in pull request #4104: NIFI-7159

2020-03-04 Thread GitBox 
MikeThomsen commented on a change in pull request #4104: NIFI-7159
URL: https://github.com/apache/nifi/pull/4104#discussion_r388007299
 
 

 ##
 File path: 
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-controller-service/src/main/java/org/apache/nifi/controller/kudu/KuduLookupService.java
 ##
 @@ -317,7 +317,7 @@ private RecordSchema kuduSchemaToNiFiSchema(Schema 
kuduTableSchema, List
 case BINARY:
 case STRING:
 case DECIMAL:
-fields.add(new RecordField(cs.getName(), 
RecordFieldType.STRING.getDataType()));
+fields.add(new RecordField(cs.getName(), 
RecordFieldType.DECIMAL.getDataType()));
 
 Review comment:
   I don't know anything about Kudu, so I may put this ticket on hold and ask 
for input from nifi-dev on a few of these other components (ex Hive)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services