[jira] [Commented] (NIFI-3640) GetEventHub should not assume domain names
[ https://issues.apache.org/jira/browse/NIFI-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025073#comment-16025073 ] ASF GitHub Bot commented on NIFI-3640: -- Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/1617 +1, confirmed that change is backwards compatible with older flow template, merging. > GetEventHub should not assume domain names > -- > > Key: NIFI-3640 > URL: https://issues.apache.org/jira/browse/NIFI-3640 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Joseph Niemiec >Assignee: Joseph Niemiec > > Today the GetEventHubProcessor hard codes in the servicebus host from Azure > as ".servicebus.windows.net" this does not allow us to deploy to other Geo's > where the URL changes such as "servicebus.chinacloudapi.cn" -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3640) GetEventHub should not assume domain names
[ https://issues.apache.org/jira/browse/NIFI-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025051#comment-16025051 ] ASF GitHub Bot commented on NIFI-3640: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/1617 > GetEventHub should not assume domain names > -- > > Key: NIFI-3640 > URL: https://issues.apache.org/jira/browse/NIFI-3640 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Joseph Niemiec >Assignee: Joseph Niemiec > > Today the GetEventHubProcessor hard codes in the servicebus host from Azure > as ".servicebus.windows.net" this does not allow us to deploy to other Geo's > where the URL changes such as "servicebus.chinacloudapi.cn" -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3640) GetEventHub should not assume domain names
[ https://issues.apache.org/jira/browse/NIFI-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025050#comment-16025050 ] ASF subversion and git services commented on NIFI-3640: --- Commit 44fdc0e4ef3f0e9e99c2e39c1994e641ce02d146 in nifi's branch refs/heads/master from [~josephxsxn] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=44fdc0e ] NIFI-3640 uri eventhub changes This closes #1617 > GetEventHub should not assume domain names > -- > > Key: NIFI-3640 > URL: https://issues.apache.org/jira/browse/NIFI-3640 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Joseph Niemiec >Assignee: Joseph Niemiec > > Today the GetEventHubProcessor hard codes in the servicebus host from Azure > as ".servicebus.windows.net" this does not allow us to deploy to other Geo's > where the URL changes such as "servicebus.chinacloudapi.cn" -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3640) GetEventHub should not assume domain names
[ https://issues.apache.org/jira/browse/NIFI-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024119#comment-16024119 ] ASF GitHub Bot commented on NIFI-3640: -- Github user jtstorck commented on the issue: https://github.com/apache/nifi/pull/1617 Reviewing... > GetEventHub should not assume domain names > -- > > Key: NIFI-3640 > URL: https://issues.apache.org/jira/browse/NIFI-3640 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Joseph Niemiec >Assignee: Joseph Niemiec > > Today the GetEventHubProcessor hard codes in the servicebus host from Azure > as ".servicebus.windows.net" this does not allow us to deploy to other Geo's > where the URL changes such as "servicebus.chinacloudapi.cn" -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3640) GetEventHub should not assume domain names
[ https://issues.apache.org/jira/browse/NIFI-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939089#comment-15939089 ] ASF GitHub Bot commented on NIFI-3640: -- GitHub user josephxsxn opened a pull request: https://github.com/apache/nifi/pull/1617 NIFI-3640 uri eventhub changes Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/josephxsxn/nifi NIFI-3640 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/1617.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1617 commit 478cc850e539d2d3fc9d46e5ecc69d8bd1a79179 Author: Joseph Niemiec Date: 2017-03-23T15:19:56Z uri eventhub changes > GetEventHub should not assume domain names > -- > > Key: NIFI-3640 > URL: https://issues.apache.org/jira/browse/NIFI-3640 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Joseph Niemiec >Assignee: Joseph Niemiec > > Today the GetEventHubProcessor hard codes in the servicebus host from Azure > as ".servicebus.windows.net" this does not allow us to deploy to other Geo's > where the URL changes such as "servicebus.chinacloudapi.cn" -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3640) GetEventHub should not assume domain names
[ https://issues.apache.org/jira/browse/NIFI-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938933#comment-15938933 ] Joseph Niemiec commented on NIFI-3640: -- configured to have a drop down right now to pick between the two hosts. having some issues that are china specific now, works fine when i connect to NA but not CN > GetEventHub should not assume domain names > -- > > Key: NIFI-3640 > URL: https://issues.apache.org/jira/browse/NIFI-3640 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Joseph Niemiec >Assignee: Joseph Niemiec > > Today the GetEventHubProcessor hard codes in the servicebus host from Azure > as ".servicebus.windows.net" this does not allow us to deploy to other Geo's > where the URL changes such as "servicebus.chinacloudapi.cn" -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (NIFI-3640) GetEventHub should not assume domain names
[ https://issues.apache.org/jira/browse/NIFI-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15938371#comment-15938371 ] Joseph Witt commented on NIFI-3640: --- removed fix version as we want to hold off on setting those unless it is blocker issues or things that have PRs and review progress on them. > GetEventHub should not assume domain names > -- > > Key: NIFI-3640 > URL: https://issues.apache.org/jira/browse/NIFI-3640 > Project: Apache NiFi > Issue Type: Improvement >Affects Versions: 1.2.0 >Reporter: Joseph Niemiec >Assignee: Joseph Niemiec > > Today the GetEventHubProcessor hard codes in the servicebus host from Azure > as ".servicebus.windows.net" this does not allow us to deploy to other Geo's > where the URL changes such as "servicebus.chinacloudapi.cn" -- This message was sent by Atlassian JIRA (v6.3.15#6346)
