[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[Koji Kawamura (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980611#comment-15980611
 ] 

Koji Kawamura commented on NIFI-3666:
-

I see, created a sub-ticket. Thanks [~joewitt]

> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978860#comment-15978860
 ] 

Joseph Witt commented on NIFI-3666:
---

spinning off sub-tickets is perfectly fine [~ijokarumawak]  thanks

> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[Koji Kawamura (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978231#comment-15978231
 ] 

Koji Kawamura commented on NIFI-3666:
-

[~bryanrosan...@gmail.com] [~joewitt] I merged PR #1641. But I just realized 
that this JIRA can't be marked as 'Resolved' until all tests have been 
addressed or confirmed that is fine to be ignored. How should we track the 
progress? Adding sub ticket for the fixed TlsToolkit is appropriate?

> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978226#comment-15978226
 ] 

ASF GitHub Bot commented on NIFI-3666:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1641
  
@brosander Confirmed this change addresses test failure. Thanks for fixing 
this, merged into master!


> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978222#comment-15978222
 ] 

ASF subversion and git services commented on NIFI-3666:
---

Commit 1c9ea249f77f5cc7675510a143a8f6c15ddeaa85 in nifi's branch 
refs/heads/master from [~bryanrosan...@gmail.com]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=1c9ea24 ]

NIFI-3666 - TlsToolkit using .equals() comparison for parent and root

This closes #1641.

Signed-off-by: Koji Kawamura 


> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978225#comment-15978225
 ] 

ASF GitHub Bot commented on NIFI-3666:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/1641


> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978187#comment-15978187
 ] 

ASF GitHub Bot commented on NIFI-3666:
--

Github user ijokarumawak commented on the issue:

https://github.com/apache/nifi/pull/1641
  
@brosander I will review this since I was able to reproduce test failure on 
my Windows env.


> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[Koji Kawamura (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978184#comment-15978184
 ] 

Koji Kawamura commented on NIFI-3666:
-

[~joewitt] I looked at following tests, using Windows Server 2016 Datacenter, 
JDK 1.8.0_121

h4.SIte-to-Site
nifi-commons/nifi-site-to-site-client/src/test/java/org/apache/nifi/remote/client/http/TestHttpClient.java
- testSendTimeout: Worked successfully.
- testSendTimeoutAfterDataExchange: Failed. The test expects a timeout error 
occurs when a client sends data. However, the test can fail when a client 
attempts to create a transaction before sending data. It seems on Windows (at 
least on my VM or test server) the initial connection takes longer than other 
environment. Initial connection timed out, took longer than 500ms. Changing 
timeout from 500ms to 1000ms made the test run successfully. It doesn't seem an 
OS dependent test but certainly depends on server spec.

h4.WebSocket
nifi-nar-bundles/nifi-websocket-bundle/nifi-websocket-services-jetty/src/test/java/org/apache/nifi/websocket/TestJettyWebSocketCommunication.java
- testClientServerCommunication: It works fine on my environment. However, it 
uses CountDownLatch to assert async events. That can fail on certain 
environment if took longer than expected. Timeout is set as 5 seconds.

h4.Kafka
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-0-9-processors/src/test/java/org/apache/nifi/processors/kafka/pubsub/ConsumeKafkaTest.java
- validateConsumerRetainer: It works fine. But I was able to make it fail with 
shorter timeout setting. 

[~JPercivall], I ran AttributeRollingWindow test on my Windows machine and it 
succeeded without issue. I think above S2S, WebSocket and Kafka tests are the 
same as AttributeRollingWindow test. It can fail but not Windows specific.

Supposedly, these time related test can be fixed by designing timeout long 
enough, but it requires longer build time, too. I like idea of quarantine tests 
based on condition. I think it would be great if we can annotate these tests as 
time-consuming ones and only run these tests when we planned to release or some 
other important phase of development cycle. I certainly do not want to abandon 
these tests.


> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[Puspendu Banerjee (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956161#comment-15956161
 ] 

Puspendu Banerjee commented on NIFI-3666:
-

Raised NIFI-3593 when found that many tests are failing on Windows.

> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[Joseph Percivall (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15952799#comment-15952799
 ] 

Joseph Percivall commented on NIFI-3666:


[~joewitt], I checked out the AttributeRollingWindow tests and I'm confused 
about why they need to be ignored on Windows. I am able to run them just fine 
on my system (Win 10).

The tests are inherently time related, due to the nature of the processor, so 
I'd understand if the tests should be ignored/reworked due to that but I don't 
see any Windows specific reworks that are needed.

> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[Joseph Percivall (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951694#comment-15951694
 ] 

Joseph Percivall commented on NIFI-3666:


Thanks for the heads up [~joewitt], I'll take a look at the Rolling Window 
changes this weekend. 

> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (NIFI-3666) Skipped tests on windows need to be validated or fixed

[Joseph Witt (JIRA)]

[ 
https://issues.apache.org/jira/browse/NIFI-3666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15950821#comment-15950821
 ] 

Joseph Witt commented on NIFI-3666:
---

Flagging this for a few folks that I believe were involved in the code/tests 
involved.

[~markap14] Can you please take a look at the tests which needed skipping for 
provenance and content repo.
[~ijokarumawak] Can you please look into the site to site client tests skipped 
and I think the kafka client test and websocket client
[~mattyb149] Can you look at TestListDatabaseTables
[~JPercivall] rolling attribute test
[~bryanrosan...@gmail.com] the tls toolkit had one or two



> Skipped tests on windows need to be validated or fixed
> --
>
> Key: NIFI-3666
> URL: https://issues.apache.org/jira/browse/NIFI-3666
> Project: Apache NiFi
>  Issue Type: Bug
>  Components: Core Framework, Extensions
>Reporter: Joseph Witt
>Priority: Critical
>
> In NIFI-3440 a number of relatively recently created tests were failing on 
> windows.  These tests were skipped when running on windows to help keep the 
> build moving along and to continue to test regressions on older more stable 
> tests.  However, this approach leaves room for error because we must go 
> through each and validate whether it was a bad test that needs to be fixed to 
> be more stable/portable OR whether the test exposed a bug in the code and its 
> behavior on windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)