[jira] [Commented] (NIFI-4929) Convert existing MongoDB unit tests to integration tests

2018-03-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391682#comment-16391682
 ] 

ASF GitHub Bot commented on NIFI-4929:
--

Github user asfgit closed the pull request at:

https://github.com/apache/nifi/pull/2508


> Convert existing MongoDB unit tests to integration tests
> 
>
> Key: NIFI-4929
> URL: https://issues.apache.org/jira/browse/NIFI-4929
> Project: Apache NiFi
>  Issue Type: Improvement
>  Components: Extensions, Tools and Build
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
> Fix For: 1.6.0
>
>
> Most of the existing MongoDB unit tests are actually integration tests that 
> require a live installation of MongoDB to run. They're marked with @Ignore 
> which is a very suboptimal solution for testing and makes it easy for a 
> reviewer to run the tests and think everything passed if they're not looking 
> for that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4929) Convert existing MongoDB unit tests to integration tests

2018-03-08 Thread ASF subversion and git services (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391679#comment-16391679
 ] 

ASF subversion and git services commented on NIFI-4929:
---

Commit dae2b73d94f51230ff3193fe7baae657ff10ce82 in nifi's branch 
refs/heads/master from [~mike.thomsen]
[ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=dae2b73 ]

NIFI-4929 Converted the majority of MongoDB unit tests to integration tests so 
they can be reliably run with 'mvn -Pintegration-tests integration-test'

Signed-off-by: Pierre Villard 

This closes #2508.


> Convert existing MongoDB unit tests to integration tests
> 
>
> Key: NIFI-4929
> URL: https://issues.apache.org/jira/browse/NIFI-4929
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>
> Most of the existing MongoDB unit tests are actually integration tests that 
> require a live installation of MongoDB to run. They're marked with @Ignore 
> which is a very suboptimal solution for testing and makes it easy for a 
> reviewer to run the tests and think everything passed if they're not looking 
> for that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4929) Convert existing MongoDB unit tests to integration tests

2018-03-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16391678#comment-16391678
 ] 

ASF GitHub Bot commented on NIFI-4929:
--

Github user pvillard31 commented on the issue:

https://github.com/apache/nifi/pull/2508
  
+1, merging to master, thanks @MikeThomsen 


> Convert existing MongoDB unit tests to integration tests
> 
>
> Key: NIFI-4929
> URL: https://issues.apache.org/jira/browse/NIFI-4929
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>
> Most of the existing MongoDB unit tests are actually integration tests that 
> require a live installation of MongoDB to run. They're marked with @Ignore 
> which is a very suboptimal solution for testing and makes it easy for a 
> reviewer to run the tests and think everything passed if they're not looking 
> for that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (NIFI-4929) Convert existing MongoDB unit tests to integration tests

2018-03-03 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/NIFI-4929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16384691#comment-16384691
 ] 

ASF GitHub Bot commented on NIFI-4929:
--

GitHub user MikeThomsen opened a pull request:

https://github.com/apache/nifi/pull/2508

NIFI-4929 Converted the majority of MongoDB unit tests to integration…

… tests so they can be reliably run with 'mvn -Pintegration-tests 
integration-tes'

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
 in the commit message?

- [ ] Does your PR title start with NIFI- where  is the JIRA number 
you are trying to resolve? Pay particular attention to the hyphen "-" character.

- [ ] Has your PR been rebased against the latest commit within the target 
branch (typically master)?

- [ ] Is your initial contribution a single, squashed commit?

### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn 
-Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)? 
- [ ] If applicable, have you updated the LICENSE file, including the main 
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main 
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to 
.name (programmatic access) for each of the new properties?

### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in 
which it is rendered?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build 
issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/MikeThomsen/nifi NIFI-4929

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/nifi/pull/2508.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2508


commit 8d95043099e09bcbe93584084b43952ce78469c6
Author: Mike Thomsen 
Date:   2018-03-03T15:17:21Z

NIFI-4929 Converted the majority of MongoDB unit tests to integration tests 
so they can be reliably run with 'mvn -Pintegration-tests integration-tes'




> Convert existing MongoDB unit tests to integration tests
> 
>
> Key: NIFI-4929
> URL: https://issues.apache.org/jira/browse/NIFI-4929
> Project: Apache NiFi
>  Issue Type: Improvement
>Reporter: Mike Thomsen
>Assignee: Mike Thomsen
>Priority: Minor
>
> Most of the existing MongoDB unit tests are actually integration tests that 
> require a live installation of MongoDB to run. They're marked with @Ignore 
> which is a very suboptimal solution for testing and makes it easy for a 
> reviewer to run the tests and think everything passed if they're not looking 
> for that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)