[jira] [Commented] (SCB-763) Simplify Dynamic Config (Apollo) Integration Test in Java Chassis
[ https://issues.apache.org/jira/browse/SCB-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550301#comment-16550301 ] ASF GitHub Bot commented on SCB-763: zhengyangyong opened a new pull request #826: [SCB-763] simplify dynamic config (apollo) integration test URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/826 …ig (apollo) integration test Signed-off-by: zhengyangyong Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Simplify Dynamic Config (Apollo) Integration Test in Java Chassis > - > > Key: SCB-763 > URL: https://issues.apache.org/jira/browse/SCB-763 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Affects Versions: java-chassis-1.0.0-m2 >Reporter: yangyongzheng >Assignee: yangyongzheng >Priority: Major > Fix For: java-chassis-1.0.0 > > > Simplify Dynamic Config (Apollo) Integration Test in Java Chassis > Discussion Is here： > https://lists.apache.org/thread.html/d6adfe1c23a68b00271cac70840b8ed531939d565f80fa49171f68c1@%3Cdev.servicecomb.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550298#comment-16550298
]
ASF GitHub Bot commented on SCB-687:
zhengyangyong commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203951323
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
##
@@ -18,23 +18,35 @@
package org.apache.servicecomb.foundation.vertx.server;
import java.net.InetSocketAddress;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.servicecomb.foundation.common.event.EventManager;
import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
import org.apache.servicecomb.foundation.ssl.SSLCustom;
import org.apache.servicecomb.foundation.ssl.SSLOption;
import org.apache.servicecomb.foundation.ssl.SSLOptionFactory;
import org.apache.servicecomb.foundation.vertx.AsyncResultCallback;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
import org.apache.servicecomb.foundation.vertx.VertxTLSBuilder;
+import com.netflix.config.DynamicPropertyFactory;
+
import io.vertx.core.Vertx;
import io.vertx.core.net.NetServer;
import io.vertx.core.net.NetServerOptions;
public class TcpServer {
private URIEndpointObject endpointObject;
+ private final AtomicInteger connectedCounter;
Review comment:
your means I need move it to HighwayServerVerticle instance?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550293#comment-16550293
]
ASF GitHub Bot commented on SCB-687:
wujimin commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203948367
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
##
@@ -18,23 +18,35 @@
package org.apache.servicecomb.foundation.vertx.server;
import java.net.InetSocketAddress;
+import java.util.concurrent.atomic.AtomicInteger;
+import org.apache.servicecomb.foundation.common.event.EventManager;
import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
import org.apache.servicecomb.foundation.ssl.SSLCustom;
import org.apache.servicecomb.foundation.ssl.SSLOption;
import org.apache.servicecomb.foundation.ssl.SSLOptionFactory;
import org.apache.servicecomb.foundation.vertx.AsyncResultCallback;
+import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
import org.apache.servicecomb.foundation.vertx.VertxTLSBuilder;
+import com.netflix.config.DynamicPropertyFactory;
+
import io.vertx.core.Vertx;
import io.vertx.core.net.NetServer;
import io.vertx.core.net.NetServerOptions;
public class TcpServer {
private URIEndpointObject endpointObject;
+ private final AtomicInteger connectedCounter;
Review comment:
TcpServer will be created for each HighwayServerVerticle instance
so the counter number in server is not correct.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-741) Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'payloads' at row 1
[
https://issues.apache.org/jira/browse/SCB-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550245#comment-16550245
]
ASF GitHub Bot commented on SCB-741:
WillemJiang closed pull request #226: SCB-741 change payloads database type
from varbinary(10240) to blob
URL: https://github.com/apache/incubator-servicecomb-saga/pull/226
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/alpha/alpha-server/src/main/resources/schema-mysql.sql
b/alpha/alpha-server/src/main/resources/schema-mysql.sql
index ecb934e3..b1598573 100644
--- a/alpha/alpha-server/src/main/resources/schema-mysql.sql
+++ b/alpha/alpha-server/src/main/resources/schema-mysql.sql
@@ -26,7 +26,7 @@ CREATE TABLE IF NOT EXISTS TxEvent (
type varchar(50) NOT NULL,
compensationMethod varchar(256) NOT NULL,
expiryTime datetime NOT NULL DEFAULT CURRENT_TIMESTAMP,
- payloads varbinary(10240),
+ payloads blob,
retries int(11) NOT NULL DEFAULT '0',
retryMethod varchar(256) DEFAULT NULL,
PRIMARY KEY (surrogateId),
@@ -42,7 +42,7 @@ CREATE TABLE IF NOT EXISTS Command (
localTxId varchar(36) NOT NULL,
parentTxId varchar(36) DEFAULT NULL,
compensationMethod varchar(256) NOT NULL,
- payloads varbinary(10240),
+ payloads blob,
status varchar(12),
lastModified datetime NOT NULL DEFAULT CURRENT_TIMESTAMP,
version bigint NOT NULL,
diff --git a/alpha/alpha-server/src/test/resources/schema.sql
b/alpha/alpha-server/src/test/resources/schema.sql
index 8d708990..0da26860 100644
--- a/alpha/alpha-server/src/test/resources/schema.sql
+++ b/alpha/alpha-server/src/test/resources/schema.sql
@@ -28,7 +28,7 @@ CREATE TABLE IF NOT EXISTS TxEvent (
expiryTime TIMESTAMP NOT NULL,
retryMethod varchar(256) NOT NULL,
retries int DEFAULT 0 NOT NULL,
- payloads varbinary(10240)
+ payloads blob
);
CREATE TABLE IF NOT EXISTS Command (
@@ -40,7 +40,7 @@ CREATE TABLE IF NOT EXISTS Command (
localTxId varchar(36) NOT NULL,
parentTxId varchar(36) DEFAULT NULL,
compensationMethod varchar(256) NOT NULL,
- payloads varbinary(10240),
+ payloads blob,
status varchar(12),
lastModified TIMESTAMP DEFAULT CURRENT_TIMESTAMP NOT NULL,
version bigint NOT NULL
diff --git
a/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/TxAbortedEvent.java
b/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/TxAbortedEvent.java
index f0bac541..0a4146af 100644
---
a/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/TxAbortedEvent.java
+++
b/omega/omega-transaction/src/main/java/org/apache/servicecomb/saga/omega/transaction/TxAbortedEvent.java
@@ -23,6 +23,9 @@
import org.apache.servicecomb.saga.common.EventType;
public class TxAbortedEvent extends TxEvent {
+
+ private static final int PAYLOADS_MAX_LENGTH = 10240;
+
public TxAbortedEvent(String globalTxId, String localTxId, String
parentTxId, String compensationMethod, Throwable throwable) {
super(EventType.TxAbortedEvent, globalTxId, localTxId, parentTxId,
compensationMethod, 0, "", 0,
stackTrace(throwable));
@@ -31,6 +34,10 @@ public TxAbortedEvent(String globalTxId, String localTxId,
String parentTxId, St
private static String stackTrace(Throwable e) {
StringWriter writer = new StringWriter();
e.printStackTrace(new PrintWriter(writer));
-return writer.toString();
+String stackTrace = writer.toString();
+if (stackTrace.length() > PAYLOADS_MAX_LENGTH) {
+ stackTrace = stackTrace.substring(0, PAYLOADS_MAX_LENGTH);
+}
+return stackTrace;
}
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads' at row 1
>
>
> Key: SCB-741
> URL: https://issues.apache.org/jira/browse/SCB-741
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
>Affects Versions: saga-0.3.0
> Environment: Mac,Intellij Idea
>Reporter: justdebugit
>Assignee: Gao Xin
>Priority: Major
>
> I encounter an Exception at Alpha Server
> {code:java}
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads'
[jira] [Updated] (SCB-764) Vertx tests failed when running 'mvn install'
[ https://issues.apache.org/jira/browse/SCB-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhenJu updated SCB-764: --- Description: Hi, guys, when I run 'mvn clean install' with the latest commit 82f098f67745af2659f5a1822f5edc988d9a3402 on master branch, I get some errors in Vertx testing: Tests in error: TestClientPoolManager.findByContext_otherVertx:205 » NullPointer TestClientPoolManager.findByContext_woker:222 » NullPointer TestAbstractTcpClientPoolFactory.createClientPool:37 » NullPointer TestTcpClientConnectionPool.setup:38 » NullPointer I put the full log in the attachments, any thoughts on this? was: Hi, guys, when I run 'mvn clean install' with the latest commit 82f098f67745af2659f5a1822f5edc988d9a3402 on master branch, I get some errors in Vertx testing: Tests in error: TestClientPoolManager.findByContext_otherVertx:205 » NullPointer TestClientPoolManager.findByContext_woker:222 » NullPointer TestAbstractTcpClientPoolFactory.createClientPool:37 » NullPointer TestTcpClientConnectionPool.setup:38 » NullPointer > Vertx tests failed when running 'mvn install' > - > > Key: SCB-764 > URL: https://issues.apache.org/jira/browse/SCB-764 > Project: Apache ServiceComb > Issue Type: Test > Components: Java-Chassis > Environment: JDK: openjdk 1.8.0 > Linux Distribution: Arch Linux > Kernel Version: 4.17.5 >Reporter: ZhenJu >Priority: Blocker > Labels: Vertx, maven, test > Attachments: mvn-install-result.log > > > Hi, guys, when I run 'mvn clean install' with the latest commit > 82f098f67745af2659f5a1822f5edc988d9a3402 on master branch, I get some errors > in Vertx testing: > Tests in error: > TestClientPoolManager.findByContext_otherVertx:205 » NullPointer > TestClientPoolManager.findByContext_woker:222 » NullPointer > TestAbstractTcpClientPoolFactory.createClientPool:37 » NullPointer > TestTcpClientConnectionPool.setup:38 » NullPointer > I put the full log in the attachments, any thoughts on this? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-764) Vertx tests failed when running 'mvn install'
[ https://issues.apache.org/jira/browse/SCB-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhenJu updated SCB-764: --- Attachment: mvn-install-result.log > Vertx tests failed when running 'mvn install' > - > > Key: SCB-764 > URL: https://issues.apache.org/jira/browse/SCB-764 > Project: Apache ServiceComb > Issue Type: Test > Components: Java-Chassis > Environment: JDK: openjdk 1.8.0 > Linux Distribution: Arch Linux > Kernel Version: 4.17.5 >Reporter: ZhenJu >Priority: Blocker > Labels: Vertx, maven, test > Attachments: mvn-install-result.log > > > Hi, guys, when I run 'mvn clean install' with the latest commit > 82f098f67745af2659f5a1822f5edc988d9a3402 on master branch, I get some errors > in Vertx testing: > Tests in error: > TestClientPoolManager.findByContext_otherVertx:205 » NullPointer > TestClientPoolManager.findByContext_woker:222 » NullPointer > TestAbstractTcpClientPoolFactory.createClientPool:37 » NullPointer > TestTcpClientConnectionPool.setup:38 » NullPointer > I put the full log in the attachments, any thoughts on this? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-764) Vertx tests failed when running 'mvn install'
[ https://issues.apache.org/jira/browse/SCB-764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhenJu updated SCB-764: --- Description: Hi, guys, when I run 'mvn clean install' with the latest commit 82f098f67745af2659f5a1822f5edc988d9a3402 on master branch, I get some errors in Vertx testing: Tests in error: TestClientPoolManager.findByContext_otherVertx:205 » NullPointer TestClientPoolManager.findByContext_woker:222 » NullPointer TestAbstractTcpClientPoolFactory.createClientPool:37 » NullPointer TestTcpClientConnectionPool.setup:38 » NullPointer was: Hi, guys, when I'm running 'mvn clean install' with the latest commit , I just get the error complaining that the test application can't connect to port 8080, below is the whole log: --- T E S T S --- Running io.vertx.ext.web.impl.TestHttpServerRequestUtils Running io.vertx.ext.web.impl.TestMimeTypesUtils Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.425 sec - in io.vertx.ext.web.impl.TestMimeTypesUtils Running io.vertx.core.impl.TestVertxImplEx Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.662 sec - in io.vertx.ext.web.impl.TestHttpServerRequestUtils Running org.apache.servicecomb.foundation.vertx.TestStream Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.141 sec - in org.apache.servicecomb.foundation.vertx.TestStream Running org.apache.servicecomb.foundation.vertx.TestAddressResolverConfig 2018-07-20 11:35:32,758 [main ] WARN URLConfigurationSource - No URLs will be polled as dynamic configuration sources. 2018-07-20 11:35:32,759 [main ] INFO URLConfigurationSource - To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath. 2018-07-20 11:35:32,788 [main ] WARN URLConfigurationSource - No URLs will be polled as dynamic configuration sources. 2018-07-20 11:35:32,788 [main ] INFO URLConfigurationSource - To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath. Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.447 sec - in io.vertx.core.impl.TestVertxImplEx 2018-07-20 11:35:32,790 [main ] INFO DynamicPropertyFactory - DynamicPropertyFactory is initialized with configuration sources: com.netflix.config.ConcurrentCompositeConfiguration@2362f559 Running org.apache.servicecomb.foundation.vertx.TestVertxUtils 2018-07-20 11:35:32,811 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.cacheMinTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,811 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.cacheMinTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,811 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.cacheMaxTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,812 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.cacheMaxTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,812 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.cacheNegativeTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,812 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.cacheNegativeTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,813 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.queryTimeout's value:0 is not positive, please check! 2018-07-20 11:35:32,813 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.maxQueries's value:0 is not positive, please check! 2018-07-20 11:35:32,813 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.maxQueries's value:-2 is not positive, please check! 2018-07-20 11:35:32,814 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.ndots's value:0 is not positive, please check! 2018-07-20 11:35:32,814 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.ndots's value:0 is not positive, please check! 2018-07-20 11:35:32,819 [main ] WARN URLConfigurationSource - No URLs will be polled as dynamic configuration sources. 2018-07-20 11:35:32,819 [main ] INFO URLConfigurationSource - To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath. 2018-07-20 11:35:32,819 [main ] INFO DynamicPropertyFactory - DynamicPropertyFactory is initialized with configuration sources: com.netflix.config.ConcurrentCompositeConfiguration@4e50c791 2018-07-20 11:35:32,830 [main
[jira] [Created] (SCB-764) Vertx tests failed when running 'mvn install'
ZhenJu created SCB-764: -- Summary: Vertx tests failed when running 'mvn install' Key: SCB-764 URL: https://issues.apache.org/jira/browse/SCB-764 Project: Apache ServiceComb Issue Type: Test Components: Java-Chassis Environment: JDK: openjdk 1.8.0 Linux Distribution: Arch Linux Kernel Version: 4.17.5 Reporter: ZhenJu Hi, guys, when I'm running 'mvn clean install' with the latest commit , I just get the error complaining that the test application can't connect to port 8080, below is the whole log: --- T E S T S --- Running io.vertx.ext.web.impl.TestHttpServerRequestUtils Running io.vertx.ext.web.impl.TestMimeTypesUtils Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.425 sec - in io.vertx.ext.web.impl.TestMimeTypesUtils Running io.vertx.core.impl.TestVertxImplEx Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.662 sec - in io.vertx.ext.web.impl.TestHttpServerRequestUtils Running org.apache.servicecomb.foundation.vertx.TestStream Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.141 sec - in org.apache.servicecomb.foundation.vertx.TestStream Running org.apache.servicecomb.foundation.vertx.TestAddressResolverConfig 2018-07-20 11:35:32,758 [main ] WARN URLConfigurationSource - No URLs will be polled as dynamic configuration sources. 2018-07-20 11:35:32,759 [main ] INFO URLConfigurationSource - To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath. 2018-07-20 11:35:32,788 [main ] WARN URLConfigurationSource - No URLs will be polled as dynamic configuration sources. 2018-07-20 11:35:32,788 [main ] INFO URLConfigurationSource - To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath. Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.447 sec - in io.vertx.core.impl.TestVertxImplEx 2018-07-20 11:35:32,790 [main ] INFO DynamicPropertyFactory - DynamicPropertyFactory is initialized with configuration sources: com.netflix.config.ConcurrentCompositeConfiguration@2362f559 Running org.apache.servicecomb.foundation.vertx.TestVertxUtils 2018-07-20 11:35:32,811 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.cacheMinTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,811 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.cacheMinTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,811 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.cacheMaxTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,812 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.cacheMaxTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,812 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.cacheNegativeTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,812 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.cacheNegativeTimeToLive's value:0 is not positive, please check! 2018-07-20 11:35:32,813 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.queryTimeout's value:0 is not positive, please check! 2018-07-20 11:35:32,813 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.maxQueries's value:0 is not positive, please check! 2018-07-20 11:35:32,813 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.maxQueries's value:-2 is not positive, please check! 2018-07-20 11:35:32,814 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.test.ndots's value:0 is not positive, please check! 2018-07-20 11:35:32,814 [main ] WARN AddressResolverConfig - Address resover key:addressResolver.ndots's value:0 is not positive, please check! 2018-07-20 11:35:32,819 [main ] WARN URLConfigurationSource - No URLs will be polled as dynamic configuration sources. 2018-07-20 11:35:32,819 [main ] INFO URLConfigurationSource - To enable URLs as dynamic configuration sources, define System property archaius.configurationSource.additionalUrls or make config.properties available on classpath. 2018-07-20 11:35:32,819 [main ] INFO DynamicPropertyFactory - DynamicPropertyFactory is initialized with configuration sources: com.netflix.config.ConcurrentCompositeConfiguration@4e50c791 2018-07-20 11:35:32,830 [main ] WARN URLConfigurationSource - No URLs will be polled as dynamic configuration sources. 2018-07-20 11:35:32,831 [main ] INFO URLConfigurationSource - To enable URLs as dynamic configuration sources,
[jira] [Commented] (SCB-741) Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'payloads' at row 1
[
https://issues.apache.org/jira/browse/SCB-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550185#comment-16550185
]
ASF GitHub Bot commented on SCB-741:
coveralls edited a comment on issue #226: SCB-741 change payloads database type
from varbinary(10240) to blob
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/226#issuecomment-405794531
[](https://coveralls.io/builds/18077891)
Coverage decreased (-0.3%) to 93.023% when pulling
**aa893a2052425513dc1edd49b935dd9315f9d338 on SingleX:SCB-741** into
**2c1f574f16cc492d35cb3d66079ba589a899d7be on apache:master**.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads' at row 1
>
>
> Key: SCB-741
> URL: https://issues.apache.org/jira/browse/SCB-741
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
>Affects Versions: saga-0.3.0
> Environment: Mac,Intellij Idea
>Reporter: justdebugit
>Assignee: Gao Xin
>Priority: Major
>
> I encounter an Exception at Alpha Server
> {code:java}
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads' at row 1
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3974)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3912)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2530)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2683)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2486)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1858)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2079)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2013)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeLargeUpdate(PreparedStatement.java:5104)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1998)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at sun.reflect.GeneratedMethodAccessor68.invoke(Unknown Source) ~[na:na]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[na:1.8.0_102]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_102]
> at
> org.apache.tomcat.jdbc.pool.StatementFacade$StatementProxy.invoke(StatementFacade.java:114)
> ~[tomcat-jdbc-8.5.31.jar:na]
> at com.sun.proxy.$Proxy106.executeUpdate(Unknown Source) ~[na:na]
> at
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:895)
> ~[org.eclipse.persistence.core-2.7.1.jar:na]
> ... 60 common frames omitted
> {code}
> I find it's because payload bytes is more than 10240
> {code:java}
> public class TxAbortedEvent extends TxEvent {
> public TxAbortedEvent(String globalTxId, String localTxId, String
> parentTxId, String compensationMethod, Throwable throwable) {
> super(EventType.TxAbortedEvent, globalTxId, localTxId, parentTxId,
> compensationMethod, 0, "", 0,
> stackTrace(throwable));
> }
> private static String stackTrace(Throwable e) {
> StringWriter writer = new StringWriter();
> e.printStackTrace(new PrintWriter(writer));
> return writer.toString();
> }
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-741) Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'payloads' at row 1
[
https://issues.apache.org/jira/browse/SCB-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550183#comment-16550183
]
ASF GitHub Bot commented on SCB-741:
SingleX commented on issue #226: SCB-741 change payloads database type from
varbinary(10240) to blob
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/226#issuecomment-406480029
@WillemJiang PR has been updated, please help to review it again, thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads' at row 1
>
>
> Key: SCB-741
> URL: https://issues.apache.org/jira/browse/SCB-741
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Saga
>Affects Versions: saga-0.3.0
> Environment: Mac,Intellij Idea
>Reporter: justdebugit
>Assignee: Gao Xin
>Priority: Major
>
> I encounter an Exception at Alpha Server
> {code:java}
> Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long
> for column 'payloads' at row 1
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3974)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.checkErrorPacket(MysqlIO.java:3912)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.sendCommand(MysqlIO.java:2530)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.MysqlIO.sqlQueryDirect(MysqlIO.java:2683)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at com.mysql.jdbc.ConnectionImpl.execSQL(ConnectionImpl.java:2486)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeInternal(PreparedStatement.java:1858)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2079)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdateInternal(PreparedStatement.java:2013)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeLargeUpdate(PreparedStatement.java:5104)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at
> com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1998)
> ~[mysql-connector-java-5.1.46.jar:5.1.46]
> at sun.reflect.GeneratedMethodAccessor68.invoke(Unknown Source) ~[na:na]
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> ~[na:1.8.0_102]
> at java.lang.reflect.Method.invoke(Method.java:498) ~[na:1.8.0_102]
> at
> org.apache.tomcat.jdbc.pool.StatementFacade$StatementProxy.invoke(StatementFacade.java:114)
> ~[tomcat-jdbc-8.5.31.jar:na]
> at com.sun.proxy.$Proxy106.executeUpdate(Unknown Source) ~[na:na]
> at
> org.eclipse.persistence.internal.databaseaccess.DatabaseAccessor.executeDirectNoSelect(DatabaseAccessor.java:895)
> ~[org.eclipse.persistence.core-2.7.1.jar:na]
> ... 60 common frames omitted
> {code}
> I find it's because payload bytes is more than 10240
> {code:java}
> public class TxAbortedEvent extends TxEvent {
> public TxAbortedEvent(String globalTxId, String localTxId, String
> parentTxId, String compensationMethod, Throwable throwable) {
> super(EventType.TxAbortedEvent, globalTxId, localTxId, parentTxId,
> compensationMethod, 0, "", 0,
> stackTrace(throwable));
> }
> private static String stackTrace(Throwable e) {
> StringWriter writer = new StringWriter();
> e.printStackTrace(new PrintWriter(writer));
> return writer.toString();
> }
> }
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (SCB-666) Test failure on system that have rotate option set in /etc/resolv.conf
[ https://issues.apache.org/jira/browse/SCB-666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang resolved SCB-666. -- Resolution: Fixed Merged the patch into master branch. > Test failure on system that have rotate option set in /etc/resolv.conf > -- > > Key: SCB-666 > URL: https://issues.apache.org/jira/browse/SCB-666 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Minor > Fix For: java-chassis-1.0.0 > > > Test failure on system that have rotate option set in /etc/resolv.conf > Failed tests: > TestAbstractClientPool.create:83 expected:<...rue,"rotateServers":[fals]e}> > but was:<...rue,"rotateServers":[tru]e}> > > Vertx read /etc/resolv.conf and set the option according to the rotate > configuration. Need to fix the test case, only check the bits that's are > specifically set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-666) Test failure on system that have rotate option set in /etc/resolv.conf
[
https://issues.apache.org/jira/browse/SCB-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550176#comment-16550176
]
ASF GitHub Bot commented on SCB-666:
WillemJiang closed pull request #825: [SCB-666] Remove assert for
AddressResolverOptions
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/825
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestAbstractClientPool.java
b/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestAbstractClientPool.java
index 56b609bf9..5187dc667 100644
---
a/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestAbstractClientPool.java
+++
b/service-registry/src/test/java/org/apache/servicecomb/serviceregistry/client/http/TestAbstractClientPool.java
@@ -80,19 +80,6 @@ public void create() {
HttpClientPool.INSTANCE.create();
Assert.assertEquals("registry", vertxName);
-Assert.assertEquals(
-"{"
-+ "\"cacheMaxTimeToLive\":2147483647,"
-+ "\"cacheMinTimeToLive\":0,"
-+ "\"cacheNegativeTimeToLive\":0,"
-+ "\"maxQueries\":4,"
-+ "\"ndots\":0,"
-+ "\"optResourceEnabled\":true,"
-+ "\"queryTimeout\":5000,"
-+ "\"rdFlag\":true,"
-+ "\"rotateServers\":false"
-+ "}",
-vertxOptions.getAddressResolverOptions().toJson().toString());
Assert.assertEquals(ClientVerticle.class, verticleCls);
Assert.assertEquals(ClientPoolManager.class,
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Test failure on system that have rotate option set in /etc/resolv.conf
> --
>
> Key: SCB-666
> URL: https://issues.apache.org/jira/browse/SCB-666
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
>Reporter: Yang Bo
>Assignee: Yang Bo
>Priority: Minor
> Fix For: java-chassis-1.0.0
>
>
> Test failure on system that have rotate option set in /etc/resolv.conf
> Failed tests:
> TestAbstractClientPool.create:83 expected:<...rue,"rotateServers":[fals]e}>
> but was:<...rue,"rotateServers":[tru]e}>
>
> Vertx read /etc/resolv.conf and set the option according to the rotate
> configuration. Need to fix the test case, only check the bits that's are
> specifically set.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[
https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550171#comment-16550171
]
ASF GitHub Bot commented on SCB-687:
wujimin commented on a change in pull request #824: [SCB-687] add highway
server connection protection
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#discussion_r203929543
##
File path:
foundations/foundation-vertx/src/main/java/org/apache/servicecomb/foundation/vertx/server/TcpServer.java
##
@@ -57,8 +69,18 @@ public void init(Vertx vertx, String sslKey,
AsyncResultCallback {
- TcpServerConnection connection = createTcpServerConnection();
- connection.init(netSocket);
+ if (connectedCounter.get() < connectionLimit) {
Review comment:
seems this is more clear.
```
if (connectedCounter.incrementAndGet() > connectionLimit){
connectedCounter.decrementAndGet();
netSocket.close();
return;
}
TcpServerConnection connection = createTcpServerConnection();
connection.init(netSocket, connectedCounter);
EventManager.post(new ClientConnectedEvent(netSocket, connectedCount));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> highway server not accept too many connection
> -
>
> Key: SCB-687
> URL: https://issues.apache.org/jira/browse/SCB-687
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
>Reporter: wujimin
>Assignee: yangyongzheng
>Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (SCB-609) News of the LC3 Co-Located Event Linked to The Wrong Page
[ https://issues.apache.org/jira/browse/SCB-609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhinan Lin closed SCB-609. -- > News of the LC3 Co-Located Event Linked to The Wrong Page > - > > Key: SCB-609 > URL: https://issues.apache.org/jira/browse/SCB-609 > Project: Apache ServiceComb > Issue Type: Bug > Components: website >Reporter: Zhinan Lin >Assignee: Zhinan Lin >Priority: Minor > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-763) Simplify Dynamic Config (Apollo) Integration Test in Java Chassis
yangyongzheng created SCB-763: - Summary: Simplify Dynamic Config (Apollo) Integration Test in Java Chassis Key: SCB-763 URL: https://issues.apache.org/jira/browse/SCB-763 Project: Apache ServiceComb Issue Type: Improvement Components: Java-Chassis Affects Versions: java-chassis-1.0.0-m2 Reporter: yangyongzheng Assignee: yangyongzheng Fix For: java-chassis-1.0.0 Simplify Dynamic Config (Apollo) Integration Test in Java Chassis Discussion Is here： https://lists.apache.org/thread.html/d6adfe1c23a68b00271cac70840b8ed531939d565f80fa49171f68c1@%3Cdev.servicecomb.apache.org%3E -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550144#comment-16550144 ] ASF GitHub Bot commented on SCB-762: coveralls edited a comment on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406460006 [](https://coveralls.io/builds/18076774) Coverage increased (+0.02%) to 87.1% when pulling **d805dbae87f6208886ee697e109b0f88f548ad7c on wujimin:resolve-eclipse-compile-warnings** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-666) Test failure on system that have rotate option set in /etc/resolv.conf
[ https://issues.apache.org/jira/browse/SCB-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550127#comment-16550127 ] ASF GitHub Bot commented on SCB-666: coveralls commented on issue #825: [SCB-666] Remove assert for AddressResolverOptions URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/825#issuecomment-406468466 [](https://coveralls.io/builds/18077226) Coverage remained the same at 87.081% when pulling **121655bf149a14348d13a06c13a34c908d5025c5 on yangbor:master** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Test failure on system that have rotate option set in /etc/resolv.conf > -- > > Key: SCB-666 > URL: https://issues.apache.org/jira/browse/SCB-666 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Minor > Fix For: java-chassis-1.0.0 > > > Test failure on system that have rotate option set in /etc/resolv.conf > Failed tests: > TestAbstractClientPool.create:83 expected:<...rue,"rotateServers":[fals]e}> > but was:<...rue,"rotateServers":[tru]e}> > > Vertx read /etc/resolv.conf and set the option according to the rotate > configuration. Need to fix the test case, only check the bits that's are > specifically set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550104#comment-16550104 ] ASF GitHub Bot commented on SCB-687: coveralls commented on issue #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824#issuecomment-406465050 [](https://coveralls.io/builds/18077099) Coverage decreased (-0.04%) to 87.041% when pulling **2bf89b0a4b2ea14af9862990e4bad5da0d56651a on zhengyangyong:SCB-687** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-575) Publish the Java doc of ServiceComb projects
[ https://issues.apache.org/jira/browse/SCB-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550102#comment-16550102 ] Yang Bo commented on SCB-575: - The PR is rejected. We might need a better way to include the javadoc into the website. Perhaps something like the chassis gitbook, host the javadoc in a separate server(not the jekyel server the main site used) and link it in the site. > Publish the Java doc of ServiceComb projects > > > Key: SCB-575 > URL: https://issues.apache.org/jira/browse/SCB-575 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis, Saga >Reporter: Willem Jiang >Assignee: Yang Bo >Priority: Major > Fix For: java-chassis-1.0.0, saga-0.3.0 > > > We should generate the API document and publish it to the website. > * Aggregate the java doc > * Submit the generated pages to ServiceComb website. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-750) Dependency management is incomplete in Saga and Java-Chassis
[ https://issues.apache.org/jira/browse/SCB-750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yang Bo resolved SCB-750. - Resolution: Fixed > Dependency management is incomplete in Saga and Java-Chassis > > > Key: SCB-750 > URL: https://issues.apache.org/jira/browse/SCB-750 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis, Saga >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Minor > Fix For: java-chassis-1.0.0, saga-0.3.0 > > > Dependency management is incomplete in Saga and Java-Chassis -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-666) Test failure on system that have rotate option set in /etc/resolv.conf
[ https://issues.apache.org/jira/browse/SCB-666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550098#comment-16550098 ] ASF GitHub Bot commented on SCB-666: yangbor opened a new pull request #825: [SCB-666] Remove assert for AddressResolverOptions URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/825 The AddressResolverOptions just uses the vertx defaults. The conigSource is set to null when creating. So there is no need to test these options. Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Test failure on system that have rotate option set in /etc/resolv.conf > -- > > Key: SCB-666 > URL: https://issues.apache.org/jira/browse/SCB-666 > Project: Apache ServiceComb > Issue Type: Bug > Components: Java-Chassis >Reporter: Yang Bo >Assignee: Yang Bo >Priority: Minor > Fix For: java-chassis-1.0.0 > > > Test failure on system that have rotate option set in /etc/resolv.conf > Failed tests: > TestAbstractClientPool.create:83 expected:<...rue,"rotateServers":[fals]e}> > but was:<...rue,"rotateServers":[tru]e}> > > Vertx read /etc/resolv.conf and set the option according to the rotate > configuration. Need to fix the test case, only check the bits that's are > specifically set. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-687) highway server not accept too many connection
[ https://issues.apache.org/jira/browse/SCB-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550089#comment-16550089 ] ASF GitHub Bot commented on SCB-687: zhengyangyong opened a new pull request #824: [SCB-687] add highway server connection protection URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/824 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- Add `servicecomb.highway.server.connection-limit` for setting this limit Default value is Integer.MAX_VALUE This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > highway server not accept too many connection > - > > Key: SCB-687 > URL: https://issues.apache.org/jira/browse/SCB-687 > Project: Apache ServiceComb > Issue Type: Sub-task > Components: Java-Chassis >Reporter: wujimin >Assignee: yangyongzheng >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550086#comment-16550086 ] ASF GitHub Bot commented on SCB-762: coveralls commented on issue #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823#issuecomment-406460006 [](https://coveralls.io/builds/18076774) Coverage remained the same at 87.081% when pulling **d805dbae87f6208886ee697e109b0f88f548ad7c on wujimin:resolve-eclipse-compile-warnings** into **8227f0ccbe7d69db51df1fc22b11a364662c1d9d on apache:master**. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-762) resolve eclipse compile warnings
[ https://issues.apache.org/jira/browse/SCB-762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16550068#comment-16550068 ] ASF GitHub Bot commented on SCB-762: wujimin opened a new pull request #823: [SCB-762] resolve eclipse compile warnings URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/823 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > resolve eclipse compile warnings > > > Key: SCB-762 > URL: https://issues.apache.org/jira/browse/SCB-762 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Fix For: java-chassis-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-762) resolve eclipse compile warnings
wujimin created SCB-762: --- Summary: resolve eclipse compile warnings Key: SCB-762 URL: https://issues.apache.org/jira/browse/SCB-762 Project: Apache ServiceComb Issue Type: Task Components: Java-Chassis Reporter: wujimin Assignee: wujimin Fix For: java-chassis-1.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-139) Optimization suggestions for README
[ https://issues.apache.org/jira/browse/SCB-139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-139: - Fix Version/s: (was: java-chassis-1.0.0) > Optimization suggestions for README > --- > > Key: SCB-139 > URL: https://issues.apache.org/jira/browse/SCB-139 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: mabin >Priority: Major > > For the user to understand chassis quickly, it is better to added some more > summary informations in README, eg. > 1.Major features list > 2.Summary design graph > 3.Module dependency graph > 4.Complete quick start guide > 5.FAQ > What is your opinion? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-719) support complex integration test
[ https://issues.apache.org/jira/browse/SCB-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] wujimin updated SCB-719: Description: currently we only support simple integration test if a test case need to start/stop microservice instance, then must run it manually, it's not so good. so we need to create a mechanism to support complex integration test. 1.support multiple node because Travis CI docker container resources are limited, so must start multiple containers 2.not depend on docker, can run in windows too. -3.support run in IDE equals run unit test- abandon because it's too difficult to manage microservice instance lifecycle and junit test class lifecycle some microservice instances should share cross many test class, and some microservice instances only used by one test class junit child test suite always run duplicate when whole project or package. 4.support run by java -jar .. was: currently we only support simple integration test if a test case need to start/stop microservice instance, then must run it manually, it's not so good. so we need to create a mechanism to support complex integration test. 1.support multiple node because Travis CI docker container resources are limited, so must start multiple containers 2.not depend on docker, can run in windows too. 3.support run in IDE equals run unit test 4.support run by java -jar .. > support complex integration test > > > Key: SCB-719 > URL: https://issues.apache.org/jira/browse/SCB-719 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > Attachments: image-2018-07-07-08-31-37-950.png, > image-2018-07-07-08-35-01-791.png > > > currently we only support simple integration test > if a test case need to start/stop microservice instance, then must run it > manually, it's not so good. > > so we need to create a mechanism to support complex integration test. > 1.support multiple node > because Travis CI docker container resources are limited, so must start > multiple containers > 2.not depend on docker, can run in windows too. > -3.support run in IDE equals run unit test- > abandon > because it's too difficult to manage microservice instance lifecycle and > junit test class lifecycle > some microservice instances should share cross many test class, and some > microservice instances only used by one test class > junit child test suite always run duplicate when whole project or package. > 4.support run by java -jar .. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-760) provide a way to invoke service with full path
[ https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao updated SCB-760: --- Fix Version/s: java-chassis-1.0.0 > provide a way to invoke service with full path > -- > > Key: SCB-760 > URL: https://issues.apache.org/jira/browse/SCB-760 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.0.0 > > > When deploying in a container, like tomcat, users want to invoke service > with full path, including container context > root and servlet path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-760) provide a way to invoke service with full path
[ https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] liubao resolved SCB-760. Resolution: Fixed > provide a way to invoke service with full path > -- > > Key: SCB-760 > URL: https://issues.apache.org/jira/browse/SCB-760 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > Fix For: java-chassis-1.0.0 > > > When deploying in a container, like tomcat, users want to invoke service > with full path, including container context > root and servlet path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-760) provide a way to invoke service with full path
[
https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549115#comment-16549115
]
ASF GitHub Bot commented on SCB-760:
liubao68 closed pull request #822: [SCB-760]provide a way to invoke service
with full path
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/822
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
index cc93248b5..beab26a74 100644
---
a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
+++
b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
@@ -30,6 +30,7 @@
import org.apache.servicecomb.foundation.common.utils.Log4jUtils;
import org.apache.servicecomb.provider.springmvc.reference.CseRestTemplate;
import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import
org.apache.servicecomb.provider.springmvc.reference.UrlWithProviderPrefixClientHttpRequestFactory;
import
org.apache.servicecomb.provider.springmvc.reference.UrlWithServiceNameClientHttpRequestFactory;
import org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory;
import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
@@ -47,6 +48,8 @@
public class SpringmvcClient {
private static RestTemplate templateUrlWithServiceName = new
CseRestTemplate();
+ private static RestTemplate templateUrlWithProviderPrefix = new
CseRestTemplate();
+
private static RestTemplate restTemplate;
private static Controller controller;
@@ -65,6 +68,7 @@ public static void run() {
templateUrlWithServiceName.setRequestFactory(new
UrlWithServiceNameClientHttpRequestFactory());
restTemplate = RestTemplateBuilder.create();
+templateUrlWithProviderPrefix.setRequestFactory(new
UrlWithProviderPrefixClientHttpRequestFactory("/pojo/rest"));
controller = BeanUtils.getBean("controller");
String prefix = "cse://springmvc";
@@ -80,6 +84,7 @@ public static void run() {
CodeFirstRestTemplateSpringmvc codeFirstClient =
BeanUtils.getContext().getBean(CodeFirstRestTemplateSpringmvc.class);
codeFirstClient.testCodeFirst(restTemplate, "springmvc",
"/codeFirstSpringmvc/");
+codeFirstClient.testCodeFirst(templateUrlWithProviderPrefix, "springmvc",
"/pojo/rest/codeFirstSpringmvc/");
String microserviceName = "springmvc";
for (String transport : DemoConst.transports) {
@@ -115,11 +120,13 @@ public static void run() {
TestMgr.check(true, metrics.size() > 0);
TestMgr.check(true,
metrics.get(
-
"servicecomb.invocation(operation=springmvc.codeFirst.saySomething,role=PRODUCER,stage=total,statistic=count,status=200,transport=highway)")
>= 0);
+
"servicecomb.invocation(operation=springmvc.codeFirst.saySomething,role=PRODUCER,stage=total,statistic=count,status=200,transport=highway)")
+>= 0);
//prometheus integration test
try {
- String content =
restTemplate.getForObject("cse://springmvc/codeFirstSpringmvc/prometheusForTest",
String.class);
+ String content = restTemplate
+
.getForObject("cse://springmvc/codeFirstSpringmvc/prometheusForTest",
String.class);
TestMgr.check(true,
content.contains("servicecomb_invocation{operation=\"springmvc.codeFirst.addDate"));
TestMgr.check(true,
content.contains("servicecomb_invocation{operation=\"springmvc.codeFirst.sayHello"));
diff --git
a/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/UrlWithProviderPrefixClientHttpRequestFactory.java
b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/UrlWithProviderPrefixClientHttpRequestFactory.java
new file mode 100644
index 0..6c7ba67d3
--- /dev/null
+++
b/providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/UrlWithProviderPrefixClientHttpRequestFactory.java
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may
[jira] [Commented] (SCB-760) provide a way to invoke service with full path
[ https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549114#comment-16549114 ] ASF GitHub Bot commented on SCB-760: liubao68 commented on issue #822: [SCB-760]provide a way to invoke service with full path URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/822#issuecomment-406233922 Since last commit is approved and there is a test case error blocking others work, so I merge this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > provide a way to invoke service with full path > -- > > Key: SCB-760 > URL: https://issues.apache.org/jira/browse/SCB-760 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > > When deploying in a container, like tomcat, users want to invoke service > with full path, including container context > root and servlet path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-720) Show the instance statistics in Dashboard and Instance List in Side Menu
[ https://issues.apache.org/jira/browse/SCB-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui updated SCB-720: --- Fix Version/s: (was: service-center-1.0.0) service-center-1.1.0 > Show the instance statistics in Dashboard and Instance List in Side Menu > > > Key: SCB-720 > URL: https://issues.apache.org/jira/browse/SCB-720 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: vibakar >Priority: Major > Fix For: service-center-1.1.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-761) Prepare 1.0.0 Release for SC
Mohammad Asif Siddiqui created SCB-761: -- Summary: Prepare 1.0.0 Release for SC Key: SCB-761 URL: https://issues.apache.org/jira/browse/SCB-761 Project: Apache ServiceComb Issue Type: Task Components: Service-Center Reporter: Mohammad Asif Siddiqui Assignee: Mohammad Asif Siddiqui Fix For: service-center-1.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-724) Support Release Binaries for Mac OS
[ https://issues.apache.org/jira/browse/SCB-724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui resolved SCB-724. Resolution: Fixed > Support Release Binaries for Mac OS > --- > > Key: SCB-724 > URL: https://issues.apache.org/jira/browse/SCB-724 > Project: Apache ServiceComb > Issue Type: Task > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Fix For: service-center-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-603) Add Support of FIle Upload Testing in SchemaTesting
[ https://issues.apache.org/jira/browse/SCB-603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549084#comment-16549084 ] Mohammad Asif Siddiqui commented on SCB-603: File Upload Testing has been done using the New UI > Add Support of FIle Upload Testing in SchemaTesting > --- > > Key: SCB-603 > URL: https://issues.apache.org/jira/browse/SCB-603 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Labels: roadmap > Fix For: service-center-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-603) Add Support of FIle Upload Testing in SchemaTesting
[ https://issues.apache.org/jira/browse/SCB-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui resolved SCB-603. Resolution: Fixed > Add Support of FIle Upload Testing in SchemaTesting > --- > > Key: SCB-603 > URL: https://issues.apache.org/jira/browse/SCB-603 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Labels: roadmap > Fix For: service-center-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-603) Add Support of FIle Upload Testing in SchemaTesting
[ https://issues.apache.org/jira/browse/SCB-603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mohammad Asif Siddiqui reassigned SCB-603: -- Assignee: Mohammad Asif Siddiqui > Add Support of FIle Upload Testing in SchemaTesting > --- > > Key: SCB-603 > URL: https://issues.apache.org/jira/browse/SCB-603 > Project: Apache ServiceComb > Issue Type: New Feature > Components: Service-Center >Reporter: Mohammad Asif Siddiqui >Assignee: Mohammad Asif Siddiqui >Priority: Major > Labels: roadmap > Fix For: service-center-1.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-760) provide a way to invoke service with full path
[ https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549074#comment-16549074 ] ASF GitHub Bot commented on SCB-760: liubao68 opened a new pull request #822: [SCB-760]provide a way to invoke service with full path URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/822 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > provide a way to invoke service with full path > -- > > Key: SCB-760 > URL: https://issues.apache.org/jira/browse/SCB-760 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > > When deploying in a container, like tomcat, users want to invoke service > with full path, including container context > root and servlet path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (SCB-755) [SCB-755] 755 Duplicate copy cse config to Servicecomb config
[ https://issues.apache.org/jira/browse/SCB-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang resolved SCB-755. -- Resolution: Fixed Applied the patch into master branch. > [SCB-755] 755 Duplicate copy cse config to Servicecomb config > - > > Key: SCB-755 > URL: https://issues.apache.org/jira/browse/SCB-755 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Minor > Fix For: java-chassis-1.0.0 > > > [main ] WARN Key cse.tcc.transaction.redis.host with an ambiguous > item servicecomb.tcc.transaction.redis.host exists, it's recommended to use > only one of them. > [org.apache.servicecomb.config.ConfigUtil.duplicateCseConfigToServicecomb(ConfigUtil.java:178)] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCB-755) [SCB-755] 755 Duplicate copy cse config to Servicecomb config
[ https://issues.apache.org/jira/browse/SCB-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang reassigned SCB-755: Assignee: 何一乐 > [SCB-755] 755 Duplicate copy cse config to Servicecomb config > - > > Key: SCB-755 > URL: https://issues.apache.org/jira/browse/SCB-755 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Assignee: 何一乐 >Priority: Minor > Fix For: java-chassis-1.0.0 > > > [main ] WARN Key cse.tcc.transaction.redis.host with an ambiguous > item servicecomb.tcc.transaction.redis.host exists, it's recommended to use > only one of them. > [org.apache.servicecomb.config.ConfigUtil.duplicateCseConfigToServicecomb(ConfigUtil.java:178)] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-760) provide a way to invoke service with full path
[
https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549062#comment-16549062
]
ASF GitHub Bot commented on SCB-760:
liubao68 closed pull request #821: [SCB-760]provide a way to invoke service
with full path
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/821
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/archetypes/README.md b/archetypes/README.md
index 687a6f4ca..84663b553 100644
--- a/archetypes/README.md
+++ b/archetypes/README.md
@@ -48,5 +48,5 @@ In console Interactive mode, input your GroupId, ArtifactId
and Version of new p
*Notice: We will publish these archetypes to maven center repository since
1.0.0-m2, if you would like to use an archetype from an unreleased version,
must use `archetypeRepository` option in the version 2.4 of archetype-plugin in
order to set maven repository to apache snapshot groups: *
```bash
-mvn org.apache.maven.plugins:maven-archetype-plugin:2.4:generate
-DarchetypeGroupId=org.apache.servicecomb.archetypes
-DarchetypeArtifactId=business-service-jaxrs-archetype
-DarchetypeVersion=1.0.0-m2-SNAPSHOT
-DarchetypeRepository=https://repository.apache.org/content/groups/snapshots-group
+mvn org.apache.maven.plugins:maven-archetype-plugin:2.4:generate
-DarchetypeGroupId=org.apache.servicecomb.archetypes
-DarchetypeArtifactId=business-service-jaxrs-archetype
-DarchetypeVersion=1.0.0-SNAPSHOT
-DarchetypeRepository=https://repository.apache.org/content/groups/snapshots-group
```
\ No newline at end of file
diff --git
a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
index cc93248b5..beab26a74 100644
---
a/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
+++
b/demo/demo-springmvc/springmvc-client/src/main/java/org/apache/servicecomb/demo/springmvc/client/SpringmvcClient.java
@@ -30,6 +30,7 @@
import org.apache.servicecomb.foundation.common.utils.Log4jUtils;
import org.apache.servicecomb.provider.springmvc.reference.CseRestTemplate;
import org.apache.servicecomb.provider.springmvc.reference.RestTemplateBuilder;
+import
org.apache.servicecomb.provider.springmvc.reference.UrlWithProviderPrefixClientHttpRequestFactory;
import
org.apache.servicecomb.provider.springmvc.reference.UrlWithServiceNameClientHttpRequestFactory;
import org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory;
import org.apache.servicecomb.swagger.invocation.exception.InvocationException;
@@ -47,6 +48,8 @@
public class SpringmvcClient {
private static RestTemplate templateUrlWithServiceName = new
CseRestTemplate();
+ private static RestTemplate templateUrlWithProviderPrefix = new
CseRestTemplate();
+
private static RestTemplate restTemplate;
private static Controller controller;
@@ -65,6 +68,7 @@ public static void run() {
templateUrlWithServiceName.setRequestFactory(new
UrlWithServiceNameClientHttpRequestFactory());
restTemplate = RestTemplateBuilder.create();
+templateUrlWithProviderPrefix.setRequestFactory(new
UrlWithProviderPrefixClientHttpRequestFactory("/pojo/rest"));
controller = BeanUtils.getBean("controller");
String prefix = "cse://springmvc";
@@ -80,6 +84,7 @@ public static void run() {
CodeFirstRestTemplateSpringmvc codeFirstClient =
BeanUtils.getContext().getBean(CodeFirstRestTemplateSpringmvc.class);
codeFirstClient.testCodeFirst(restTemplate, "springmvc",
"/codeFirstSpringmvc/");
+codeFirstClient.testCodeFirst(templateUrlWithProviderPrefix, "springmvc",
"/pojo/rest/codeFirstSpringmvc/");
String microserviceName = "springmvc";
for (String transport : DemoConst.transports) {
@@ -115,11 +120,13 @@ public static void run() {
TestMgr.check(true, metrics.size() > 0);
TestMgr.check(true,
metrics.get(
-
"servicecomb.invocation(operation=springmvc.codeFirst.saySomething,role=PRODUCER,stage=total,statistic=count,status=200,transport=highway)")
>= 0);
+
"servicecomb.invocation(operation=springmvc.codeFirst.saySomething,role=PRODUCER,stage=total,statistic=count,status=200,transport=highway)")
+>= 0);
//prometheus integration test
try {
- String content =
restTemplate.getForObject("cse://springmvc/codeFirstSpringmvc/prometheusForTest",
String.class);
+ String content = restTemplate
+
.getForObject("cse://springmvc/codeFirstSpringmvc/prometheusForTest",
String
[jira] [Commented] (SCB-760) provide a way to invoke service with full path
[ https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549061#comment-16549061 ] ASF GitHub Bot commented on SCB-760: liubao68 commented on issue #821: [SCB-760]provide a way to invoke service with full path URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/821#issuecomment-406218156 conflicts, abondon This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > provide a way to invoke service with full path > -- > > Key: SCB-760 > URL: https://issues.apache.org/jira/browse/SCB-760 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > > When deploying in a container, like tomcat, users want to invoke service > with full path, including container context > root and servlet path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCB-755) [SCB-755] 755 Duplicate copy cse config to Servicecomb config
[ https://issues.apache.org/jira/browse/SCB-755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Jiang updated SCB-755: - Fix Version/s: java-chassis-1.0.0 > [SCB-755] 755 Duplicate copy cse config to Servicecomb config > - > > Key: SCB-755 > URL: https://issues.apache.org/jira/browse/SCB-755 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Priority: Minor > Fix For: java-chassis-1.0.0 > > > [main ] WARN Key cse.tcc.transaction.redis.host with an ambiguous > item servicecomb.tcc.transaction.redis.host exists, it's recommended to use > only one of them. > [org.apache.servicecomb.config.ConfigUtil.duplicateCseConfigToServicecomb(ConfigUtil.java:178)] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-755) [SCB-755] 755 Duplicate copy cse config to Servicecomb config
[ https://issues.apache.org/jira/browse/SCB-755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549053#comment-16549053 ] ASF GitHub Bot commented on SCB-755: WillemJiang closed pull request #819: [SCB-755] 755 Duplicate copy cse config to Servicecomb config URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/819 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java index 21f22426d..284139875 100644 --- a/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java +++ b/foundations/foundation-config/src/main/java/org/apache/servicecomb/config/ConfigUtil.java @@ -137,8 +137,9 @@ public static ConcurrentCompositeConfiguration createLocalConfig(List duplicateCseConfigToServicecomb(config, new ConcurrentMapConfiguration(configMapEntry.getValue()), configMapEntry.getKey())); -duplicateCseConfigToServicecomb(config, -new DynamicConfiguration( +// we have already copy the cse config to the serviceComb config when we load the config from local yaml files +// hence, we do not need duplicate copy it. +config.addConfiguration( new DynamicConfiguration( new MicroserviceConfigurationSource(configModelList), new NeverStartPollingScheduler()), "configFromYamlFile"); duplicateCseConfigToServicecombAtFront(config, This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [SCB-755] 755 Duplicate copy cse config to Servicecomb config > - > > Key: SCB-755 > URL: https://issues.apache.org/jira/browse/SCB-755 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Java-Chassis >Reporter: 何一乐 >Priority: Minor > > [main ] WARN Key cse.tcc.transaction.redis.host with an ambiguous > item servicecomb.tcc.transaction.redis.host exists, it's recommended to use > only one of them. > [org.apache.servicecomb.config.ConfigUtil.duplicateCseConfigToServicecomb(ConfigUtil.java:178)] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SCB-759) Fix ServiceComb version error
[ https://issues.apache.org/jira/browse/SCB-759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YaoHaishi closed SCB-759. - Resolution: Fixed PR has been merged > Fix ServiceComb version error > - > > Key: SCB-759 > URL: https://issues.apache.org/jira/browse/SCB-759 > Project: Apache ServiceComb > Issue Type: Bug >Reporter: YaoHaishi >Assignee: YaoHaishi >Priority: Major > Fix For: java-chassis-1.0.0 > > > In some pom files and others， the version of ServiceComb is still > 1.0.0-m2-SNAPSHOT. We need to change them to 1.0.0-SNAPSHOT -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-760) provide a way to invoke service with full path
[ https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549040#comment-16549040 ] ASF GitHub Bot commented on SCB-760: wujimin commented on a change in pull request #821: [SCB-760]provide a way to invoke service with full path URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/821#discussion_r203655091 ## File path: providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/UrlWithProviderPrefixClientHttpRequestFactory.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.servicecomb.provider.springmvc.reference; + +import java.io.IOException; +import java.net.URI; + +import org.springframework.http.HttpMethod; +import org.springframework.http.client.ClientHttpRequest; +import org.springframework.http.client.ClientHttpRequestFactory; + +/** Review comment: already support this? org.apache.servicecomb.transport.rest.client.http.RestClientInvocation#createRequestPath This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > provide a way to invoke service with full path > -- > > Key: SCB-760 > URL: https://issues.apache.org/jira/browse/SCB-760 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > > When deploying in a container, like tomcat, users want to invoke service > with full path, including container context > root and servlet path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-760) provide a way to invoke service with full path
[ https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549036#comment-16549036 ] ASF GitHub Bot commented on SCB-760: wujimin commented on a change in pull request #821: [SCB-760]provide a way to invoke service with full path URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/821#discussion_r203655091 ## File path: providers/provider-springmvc/src/main/java/org/apache/servicecomb/provider/springmvc/reference/UrlWithProviderPrefixClientHttpRequestFactory.java ## @@ -0,0 +1,56 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.servicecomb.provider.springmvc.reference; + +import java.io.IOException; +import java.net.URI; + +import org.springframework.http.HttpMethod; +import org.springframework.http.client.ClientHttpRequest; +import org.springframework.http.client.ClientHttpRequestFactory; + +/** Review comment: already support this? org.apache.servicecomb.transport.rest.client.http.RestClientInvocation#createRequestPath This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > provide a way to invoke service with full path > -- > > Key: SCB-760 > URL: https://issues.apache.org/jira/browse/SCB-760 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > > When deploying in a container, like tomcat, users want to invoke service > with full path, including container context > root and servlet path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-760) provide a way to invoke service with full path
[ https://issues.apache.org/jira/browse/SCB-760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16549025#comment-16549025 ] ASF GitHub Bot commented on SCB-760: liubao68 opened a new pull request #821: [SCB-760]provide a way to invoke service with full path URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/821 Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > provide a way to invoke service with full path > -- > > Key: SCB-760 > URL: https://issues.apache.org/jira/browse/SCB-760 > Project: Apache ServiceComb > Issue Type: New Feature >Reporter: liubao >Assignee: liubao >Priority: Major > > When deploying in a container, like tomcat, users want to invoke service > with full path, including container context > root and servlet path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-748) ServiceComb engine resource optimize
[ https://issues.apache.org/jira/browse/SCB-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548999#comment-16548999 ] wujimin commented on SCB-748: - 1.not official module 2.don't know if support codec based on IDL not java class, from the README.md, it seems that similar to protoStuff based on java class we need to check this. > ServiceComb engine resource optimize > > > Key: SCB-748 > URL: https://issues.apache.org/jira/browse/SCB-748 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > > to support protobuf codec not coupled with business logic, we must create > classloader for each microserviceId(app/microservice/version), and create > classes in it dynamiclly. > that makes logic very complex, because must support generic and recursive > reference. > and in edge, create too many classes, will cause jvm meta area overflow > so we will change invocation mechanism from strong type to weak type: > * protobuf codec based on IDL not model class, maybe will switch from > protoStuff to jackson, (protoStuff not support IDL, jackson support idl but > not support protobuf V3) > * delete all mechanism related to dynamic class creation > * invocation not unify to RPC argument, but unify to HttpServletRequestEx -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SCB-760) provide a way to invoke service with full path
liubao created SCB-760: -- Summary: provide a way to invoke service with full path Key: SCB-760 URL: https://issues.apache.org/jira/browse/SCB-760 Project: Apache ServiceComb Issue Type: New Feature Reporter: liubao Assignee: liubao When deploying in a container, like tomcat, users want to invoke service with full path, including container context root and servlet path. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCB-748) ServiceComb engine resource optimize
[ https://issues.apache.org/jira/browse/SCB-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16548987#comment-16548987 ] Yang Bo commented on SCB-748: - Jackson now has some protobuf3 support. https://github.com/HubSpot/jackson-datatype-protobuf/blob/jackson29-proto3/README.md#protobuf-3-support > ServiceComb engine resource optimize > > > Key: SCB-748 > URL: https://issues.apache.org/jira/browse/SCB-748 > Project: Apache ServiceComb > Issue Type: Task > Components: Java-Chassis >Reporter: wujimin >Assignee: wujimin >Priority: Major > > to support protobuf codec not coupled with business logic, we must create > classloader for each microserviceId(app/microservice/version), and create > classes in it dynamiclly. > that makes logic very complex, because must support generic and recursive > reference. > and in edge, create too many classes, will cause jvm meta area overflow > so we will change invocation mechanism from strong type to weak type: > * protobuf codec based on IDL not model class, maybe will switch from > protoStuff to jackson, (protoStuff not support IDL, jackson support idl but > not support protobuf V3) > * delete all mechanism related to dynamic class creation > * invocation not unify to RPC argument, but unify to HttpServletRequestEx -- This message was sent by Atlassian JIRA (v7.6.3#76005)
