[jira] [Assigned] (SPARK-15978) Some improvement of "Show Tables"
[ https://issues.apache.org/jira/browse/SPARK-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apache Spark reassigned SPARK-15978: Assignee: Apache Spark > Some improvement of "Show Tables" > - > > Key: SPARK-15978 > URL: https://issues.apache.org/jira/browse/SPARK-15978 > Project: Spark > Issue Type: Bug > Components: SQL >Reporter: Bo Meng >Assignee: Apache Spark >Priority: Minor > > I've found some minor issues in "show tables" command: > 1. In the SessionCatalog.scala, listTables(db: String) method will call > listTables(formatDatabaseName(db), "*") to list all the tables for certain > db, but in the method listTables(db: String, pattern: String), this db name > is formatted once more. So I think we should remove formatDatabaseName() in > the caller. > 2. I suggest to add sort to listTables(db: String) in InMemoryCatalog.scala, > just like listDatabases(). > I will make a PR shortly. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Assigned] (SPARK-15978) Some improvement of "Show Tables"
[ https://issues.apache.org/jira/browse/SPARK-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apache Spark reassigned SPARK-15978: Assignee: (was: Apache Spark) > Some improvement of "Show Tables" > - > > Key: SPARK-15978 > URL: https://issues.apache.org/jira/browse/SPARK-15978 > Project: Spark > Issue Type: Bug > Components: SQL >Reporter: Bo Meng >Priority: Minor > > I've found some minor issues in "show tables" command: > 1. In the SessionCatalog.scala, listTables(db: String) method will call > listTables(formatDatabaseName(db), "*") to list all the tables for certain > db, but in the method listTables(db: String, pattern: String), this db name > is formatted once more. So I think we should remove formatDatabaseName() in > the caller. > 2. I suggest to add sort to listTables(db: String) in InMemoryCatalog.scala, > just like listDatabases(). > I will make a PR shortly. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Assigned] (SPARK-15978) Some improvement of "Show Tables"
[ https://issues.apache.org/jira/browse/SPARK-15978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apache Spark reassigned SPARK-15978: Assignee: Apache Spark > Some improvement of "Show Tables" > - > > Key: SPARK-15978 > URL: https://issues.apache.org/jira/browse/SPARK-15978 > Project: Spark > Issue Type: Bug > Components: SQL >Reporter: Bo Meng >Assignee: Apache Spark >Priority: Minor > > I've found some minor issues in "show tables" command: > 1. In the SessionCatalog.scala, listTables(db: String) method will call > listTables(formatDatabaseName(db), "*") to list all the tables for certain > db, but in the method listTables(db: String, pattern: String), this db name > is formatted once more. So I think we should remove formatDatabaseName() in > the caller. > 2. I suggest to add sort to listTables(db: String) in InMemoryCatalog.scala, > just like listDatabases(). > I will make a PR shortly. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org
