[jira] [Commented] (SPARK-15237) SparkR corr function documentation

2017-01-08 Thread Shaul (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810850#comment-15810850
 ] 

Shaul commented on SPARK-15237:
---

Great, looks good

cheers!




> SparkR corr function documentation
> --
>
> Key: SPARK-15237
> URL: https://issues.apache.org/jira/browse/SPARK-15237
> Project: Spark
>  Issue Type: Documentation
>  Components: SparkR
>Affects Versions: 1.6.0, 1.6.1
>Reporter: Shaul
>Priority: Minor
>  Labels: corr, sparkr
>
> Please review the documentation of the corr function in SparkR, the example 
> given: corr(df$c, df$d) won't run. The correct usage seems to be 
> corr(dataFrame,"someColumn","OtherColumn"), is this correct? 
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-15237) SparkR corr function documentation

2017-01-08 Thread Felix Cheung (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810760#comment-15810760
 ] 

Felix Cheung commented on SPARK-15237:
--

I think this is better now? Shall we resolve this JIRA?

> SparkR corr function documentation
> --
>
> Key: SPARK-15237
> URL: https://issues.apache.org/jira/browse/SPARK-15237
> Project: Spark
>  Issue Type: Documentation
>  Components: SparkR
>Affects Versions: 1.6.0, 1.6.1
>Reporter: Shaul
>Priority: Minor
>  Labels: corr, sparkr
>
> Please review the documentation of the corr function in SparkR, the example 
> given: corr(df$c, df$d) won't run. The correct usage seems to be 
> corr(dataFrame,"someColumn","OtherColumn"), is this correct? 
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-15237) SparkR corr function documentation

2016-05-13 Thread Felix Cheung (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283283#comment-15283283
 ] 

Felix Cheung commented on SPARK-15237:
--

opened SPARK-15319

> SparkR corr function documentation
> --
>
> Key: SPARK-15237
> URL: https://issues.apache.org/jira/browse/SPARK-15237
> Project: Spark
>  Issue Type: Documentation
>  Components: SparkR
>Affects Versions: 1.6.0, 1.6.1
>Reporter: Shaul
>Priority: Minor
>  Labels: corr, sparkr
>
> Please review the documentation of the corr function in SparkR, the example 
> given: corr(df$c, df$d) won't run. The correct usage seems to be 
> corr(dataFrame,"someColumn","OtherColumn"), is this correct? 
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-15237) SparkR corr function documentation

2016-05-13 Thread Felix Cheung (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15283234#comment-15283234
 ] 

Felix Cheung commented on SPARK-15237:
--

as per the @rdname 
(https://github.com/apache/spark/blame/a55fbe2a16aa0866ff8aca25bf9f772e6eb516a1/R/pkg/R/stats.R#L89),
 the other `corr` is here: 
http://spark.apache.org/docs/latest/api/R/statfunctions.html

I'm sure we could put both under "corr" if we change that rdname - but should 
we? I think it is confusing. I suspect it is better to group all column 
functions onto a (long?) pages and move the DataFrame function to the former 
space, http://spark.apache.org/docs/latest/api/R/corr.html.


> SparkR corr function documentation
> --
>
> Key: SPARK-15237
> URL: https://issues.apache.org/jira/browse/SPARK-15237
> Project: Spark
>  Issue Type: Documentation
>  Components: SparkR
>Affects Versions: 1.6.0, 1.6.1
>Reporter: Shaul
>Priority: Minor
>  Labels: corr, sparkr
>
> Please review the documentation of the corr function in SparkR, the example 
> given: corr(df$c, df$d) won't run. The correct usage seems to be 
> corr(dataFrame,"someColumn","OtherColumn"), is this correct? 
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org



[jira] [Commented] (SPARK-15237) SparkR corr function documentation

2016-05-09 Thread Sun Rui (JIRA)

[ 
https://issues.apache.org/jira/browse/SPARK-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15277454#comment-15277454
 ] 

Sun Rui commented on SPARK-15237:
-

SparkR supports two types of corr(), something like corr(SparkDataFrame, 
"col1", "col2") and corr(df$col1, df$col2). But the documentation of corr seems 
containing only the example for the latter.
[~felixcheung] how to fix the documentation?

> SparkR corr function documentation
> --
>
> Key: SPARK-15237
> URL: https://issues.apache.org/jira/browse/SPARK-15237
> Project: Spark
>  Issue Type: Documentation
>  Components: SparkR
>Affects Versions: 1.6.0, 1.6.1
>Reporter: Shaul
>Priority: Minor
>  Labels: corr, sparkr
>
> Please review the documentation of the corr function in SparkR, the example 
> given: corr(df$c, df$d) won't run. The correct usage seems to be 
> corr(dataFrame,"someColumn","OtherColumn"), is this correct? 
> Thank you.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org