[jira] [Commented] (SPARK-15790) Audit @Since annotations in ML
[
https://issues.apache.org/jira/browse/SPARK-15790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15931580#comment-15931580
]
Apache Spark commented on SPARK-15790:
--
User 'ehsun7b' has created a pull request for this issue:
https://github.com/apache/spark/pull/17314
> Audit @Since annotations in ML
> --
>
> Key: SPARK-15790
> URL: https://issues.apache.org/jira/browse/SPARK-15790
> Project: Spark
> Issue Type: Documentation
> Components: ML, PySpark
>Reporter: Nick Pentreath
>Assignee: Nick Pentreath
>
> Many classes & methods in ML are missing {{@Since}} annotations. Audit what's
> missing and add annotations to public API constructors, vals and methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15790) Audit @Since annotations in ML
[
https://issues.apache.org/jira/browse/SPARK-15790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904698#comment-15904698
]
Sean Owen commented on SPARK-15790:
---
[~ehsun7b] you're welcome to look for any public methods without {{@Since}} .
It might be a lot of work manually; maybe there's a way to create an automated
check with scalastyle?
> Audit @Since annotations in ML
> --
>
> Key: SPARK-15790
> URL: https://issues.apache.org/jira/browse/SPARK-15790
> Project: Spark
> Issue Type: Documentation
> Components: ML, PySpark
>Reporter: Nick Pentreath
>Assignee: Nick Pentreath
>
> Many classes & methods in ML are missing {{@Since}} annotations. Audit what's
> missing and add annotations to public API constructors, vals and methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15790) Audit @Since annotations in ML
[
https://issues.apache.org/jira/browse/SPARK-15790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904652#comment-15904652
]
Ehsun Behravesh commented on SPARK-15790:
-
Does this JIRA still need someone to work on?
> Audit @Since annotations in ML
> --
>
> Key: SPARK-15790
> URL: https://issues.apache.org/jira/browse/SPARK-15790
> Project: Spark
> Issue Type: Documentation
> Components: ML, PySpark
>Reporter: Nick Pentreath
>Assignee: Nick Pentreath
>
> Many classes & methods in ML are missing {{@Since}} annotations. Audit what's
> missing and add annotations to public API constructors, vals and methods.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15790) Audit @Since annotations in ML
[
https://issues.apache.org/jira/browse/SPARK-15790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363017#comment-15363017
]
Nick Pentreath commented on SPARK-15790:
Yeah all the {{ml.feature}} stuff is done. There might be a few stragglers
around in other places that are not complete. But I don't think it warrants a
blocker. So yeah let's resolve SPARK-14811
> Audit @Since annotations in ML
> --
>
> Key: SPARK-15790
> URL: https://issues.apache.org/jira/browse/SPARK-15790
> Project: Spark
> Issue Type: Documentation
> Components: ML, PySpark
>Reporter: Nick Pentreath
>Assignee: Nick Pentreath
>
> Many classes & methods in ML are missing {{@Since}} annotations. Audit what's
> missing and add annotations to public API constructors, vals and methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15790) Audit @Since annotations in ML
[
https://issues.apache.org/jira/browse/SPARK-15790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15362019#comment-15362019
]
Yanbo Liang commented on SPARK-15790:
-
[~mlnick] Can this catch up with 2.0.0? This is the only unresolved issue left
at SPARK-14811. If this does not target to 2.0.0, I think we can resolve
SPARK-14811 and make that not block the RC. Thanks.
> Audit @Since annotations in ML
> --
>
> Key: SPARK-15790
> URL: https://issues.apache.org/jira/browse/SPARK-15790
> Project: Spark
> Issue Type: Documentation
> Components: ML, PySpark
>Reporter: Nick Pentreath
>Assignee: Nick Pentreath
>
> Many classes & methods in ML are missing {{@Since}} annotations. Audit what's
> missing and add annotations to public API constructors, vals and methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15790) Audit @Since annotations in ML
[
https://issues.apache.org/jira/browse/SPARK-15790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327193#comment-15327193
]
Nick Pentreath commented on SPARK-15790:
Yes, I've just looked at things in the concrete classes - params & methods
defined in the traits etc are not annotated.
> Audit @Since annotations in ML
> --
>
> Key: SPARK-15790
> URL: https://issues.apache.org/jira/browse/SPARK-15790
> Project: Spark
> Issue Type: Documentation
> Components: ML, PySpark
>Reporter: Nick Pentreath
>Assignee: Nick Pentreath
>
> Many classes & methods in ML are missing {{@Since}} annotations. Audit what's
> missing and add annotations to public API constructors, vals and methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15790) Audit @Since annotations in ML
[
https://issues.apache.org/jira/browse/SPARK-15790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15327028#comment-15327028
]
Nick Pentreath commented on SPARK-15790:
Ah thanks - missed that umbrella. It's actually really the {{ml.feature}}
classes mostly, and that PR seems to have stalled. I've started on a new one to
cover the feature package.
> Audit @Since annotations in ML
> --
>
> Key: SPARK-15790
> URL: https://issues.apache.org/jira/browse/SPARK-15790
> Project: Spark
> Issue Type: Documentation
> Components: ML, PySpark
>Reporter: Nick Pentreath
>Assignee: Nick Pentreath
>
> Many classes & methods in ML are missing {{@Since}} annotations. Audit what's
> missing and add annotations to public API constructors, vals and methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
[jira] [Commented] (SPARK-15790) Audit @Since annotations in ML
[
https://issues.apache.org/jira/browse/SPARK-15790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325317#comment-15325317
]
Joseph K. Bradley commented on SPARK-15790:
---
Linking existing umbrella.
Also, I want to note: there are a lot of functions in abstract classes to which
we can't add Since annotations since they are used in concrete classes added at
different times. We could override those functions in concrete classes, but
that does not seem worthwhile.
> Audit @Since annotations in ML
> --
>
> Key: SPARK-15790
> URL: https://issues.apache.org/jira/browse/SPARK-15790
> Project: Spark
> Issue Type: Documentation
> Components: ML, PySpark
>Reporter: Nick Pentreath
>Assignee: Nick Pentreath
>
> Many classes & methods in ML are missing {{@Since}} annotations. Audit what's
> missing and add annotations to public API constructors, vals and methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
-
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
