[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104169#comment-15104169 ] ASF subversion and git services commented on TS-4106: - Commit 507dbaf62e3109495fb6aab1938e1b1d7d908ba3 in trafficserver's branch refs/heads/6.1.x from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=507dbaf ] TS-4140 Fixes a coverity warning due to changes in TS-4106 (dead code) This closes #427. > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura >Assignee: Leif Hedstrom > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15103982#comment-15103982 ] ASF subversion and git services commented on TS-4106: - Commit 7115b366b5e2946960175a596daf1b5374443876 in trafficserver's branch refs/heads/master from [~zwoop] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=7115b36 ] TS-4140 Fixes a coverity warning due to changes in TS-4106 (dead code) This closes #427. > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura >Assignee: Leif Hedstrom > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095027#comment-15095027 ] ASF subversion and git services commented on TS-4106: - Commit 19ea44d0db1ae3697f8100909f3b3b84b158c8d8 in trafficserver's branch refs/heads/6.1.x from [~hnakamur] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=19ea44d ] TS-4106 Allow Cache Inspector to split properly on multiline URLs Leif: This was broken in commit bd304288b55e989, and the fixes seems to restore original behavior (while retaining the use of strlcpy() ). This closes #401 (cherry picked from commit a70e9473cabba89861965d5ab775dbe4f20c720b) > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura >Assignee: Leif Hedstrom > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095025#comment-15095025 ] ASF GitHub Bot commented on TS-4106: Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/401 > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura >Assignee: Leif Hedstrom > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095024#comment-15095024 ] ASF subversion and git services commented on TS-4106: - Commit a70e9473cabba89861965d5ab775dbe4f20c720b in trafficserver's branch refs/heads/master from [~hnakamur] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=a70e947 ] TS-4106 Allow Cache Inspector to split properly on multiline URLs Leif: This was broken in commit bd304288b55e989, and the fixes seems to restore original behavior (while retaining the use of strlcpy() ). This closes #401 > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura >Assignee: Leif Hedstrom > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076204#comment-15076204 ] Hiroaki Nakamura commented on TS-4106: -- Sorry for my bad English. You can input multiple URLs separated new lines in the textarea of the four forms below of Cache Inspector: * Delete url * Regex lookup * Regex delete * Regex invalidate How to reproduce the problem: 1. Enable the debug log and add cache_inspector to debug tags. /etc/trafficserver/records.config CONFIG proxy.config.diags.debug.enabled INT 1 CONFIG proxy.config.diags.debug.tags STRING http.*|dns.*|cache_inspector.* 2. Input the following two lines in the Regex invalidate form. http://.*\.js http://.*\.jpg 3. See /var/log/trafficserver/traffic.out /var/log/trafficserver/traffic.out [Dec 31 20:49:25.677] Server {0x2b45e18837a0} DEBUG: (cache_inspector) query params: 'url=http%3A%2F%2F.*%5C.js%0D%0Ahttp%3A%2F%2F.*%5C.jpg' len 33 [unescaped] [Dec 31 20:49:25.677] Server {0x2b45e18837a0} DEBUG: (cache_inspector) query params: 'url=http://.*\.js http://.*\.jpg' len 33 [escaped] [Dec 31 20:49:25.677] Server {0x2b45e18837a0} DEBUG: (cache_inspector) there were 1 url(s) passed in [Dec 31 20:49:25.677] Server {0x2b45e18837a0} DEBUG: (cache_inspector) URL 1: 'http%3A%2F%2F.*%5C.js%0D%0Ahttp%3A%2F%2F.*%5C.jpg' [Dec 31 20:49:25.677] Server {0x2b45e18837a0} DEBUG: (cache_inspector) URL 1: 'http://.*\.js http://.*\.jpg' [Dec 31 20:49:25.677] Server {0x2b45e18837a0} DEBUG: (cache_inspector) URL 2: 'http%3A%2F%2F.*%5C.jpg' [Dec 31 20:49:25.677] Server {0x2b45e18837a0} DEBUG: (cache_inspector) URL 2: 'http://.*\.jpg' Note URL 1 is 'http://.*\.js http://.*\.jpg'. It should be 'http://.*\.js' > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura >Assignee: Leif Hedstrom > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076201#comment-15076201 ] James Peach commented on TS-4106: - What is a "multiline URL" in this context? How does one reproduce and test this? > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura >Assignee: Leif Hedstrom > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076195#comment-15076195 ] Hiroaki Nakamura commented on TS-4106: -- Thanks! I made a pull request: [Fix Cache Inspector fails to split multiline URLs by hnakamur · Pull Request #401 · apache/trafficserver](https://github.com/apache/trafficserver/pull/401) > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura >Assignee: Leif Hedstrom > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076193#comment-15076193 ] ASF GitHub Bot commented on TS-4106: GitHub user hnakamur opened a pull request: https://github.com/apache/trafficserver/pull/401 Fix Cache Inspector fails to split multiline URLs Please referer [\[TS-4106\] Cache Inspector fails to split multiline URLs - ASF JIRA](https://issues.apache.org/jira/browse/TS-4106). You can merge this pull request into a Git repository by running: $ git pull https://github.com/hnakamur/trafficserver fix_cache_inspector_fails_to_split_multiline_urls Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/401.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #401 commit 534098423d0567ce4aa275ee4a46a3d34fc13ae4 Author: Hiroaki Nakamura Date: 2016-01-01T00:00:19Z Fix Cache Inspector fails to split multiline URLs > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura >Assignee: Leif Hedstrom > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4106) Cache Inspector fails to split multiline URLs
[ https://issues.apache.org/jira/browse/TS-4106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15076191#comment-15076191 ] Leif Hedstrom commented on TS-4106: --- Can you make a github pull request for this please? I plan on back porting this to 6.1 as well. > Cache Inspector fails to split multiline URLs > - > > Key: TS-4106 > URL: https://issues.apache.org/jira/browse/TS-4106 > Project: Traffic Server > Issue Type: Bug > Components: Web UI >Reporter: Hiroaki Nakamura > Fix For: 6.1.0 > > Attachments: cache_inspector_multiline_urls_split.patch > > > The error is in the length parameter at > https://github.com/apache/trafficserver/blob/413dd51d5dc17bf388805071efdb8f882014b847/iocore/cache/CachePages.cc#L129 > Because of this error, ink_strlcpy copies strings from the current poisition > to the end of multiline URLs, not to the end of line. > The attached patch cache_inspector_multiline_urls_split.patch fixes this bug. -- This message was sent by Atlassian JIRA (v6.3.4#6332)