[jira] [Commented] (TS-4107) proxy.process.ssl.total_success_handshake_count_in has wrong record type
[ https://issues.apache.org/jira/browse/TS-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15096490#comment-15096490 ] ASF subversion and git services commented on TS-4107: - Commit 980c525edcdb5beacfb1e59e9c7854fa29191954 in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=980c525 ] TS-4107: backwards compatibility for StatsProcessor metrics > proxy.process.ssl.total_success_handshake_count_in has wrong record type > > > Key: TS-4107 > URL: https://issues.apache.org/jira/browse/TS-4107 > Project: Traffic Server > Issue Type: Bug > Components: Metrics, SSL >Reporter: James Peach >Assignee: James Peach > Fix For: 6.2.0 > > > {{proxy.process.ssl.total_success_handshake_count_in}} is the only SSL metric > registered in {{RecordsConfig.cc}} where it is incorrectly registered as a > node metric, rather than a process metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4107) proxy.process.ssl.total_success_handshake_count_in has wrong record type
[ https://issues.apache.org/jira/browse/TS-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15093950#comment-15093950 ] ASF GitHub Bot commented on TS-4107: Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/409#issuecomment-170926550 Looks good to me. It wasn't clear to me how to do the generated metric when I was originally fixing up the names, so I no doubt messed it up. > proxy.process.ssl.total_success_handshake_count_in has wrong record type > > > Key: TS-4107 > URL: https://issues.apache.org/jira/browse/TS-4107 > Project: Traffic Server > Issue Type: Bug > Components: Metrics, SSL >Reporter: James Peach >Assignee: James Peach > Fix For: 6.2.0 > > > {{proxy.process.ssl.total_success_handshake_count_in}} is the only SSL metric > registered in {{RecordsConfig.cc}} where it is incorrectly registered as a > node metric, rather than a process metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4107) proxy.process.ssl.total_success_handshake_count_in has wrong record type
[ https://issues.apache.org/jira/browse/TS-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095353#comment-15095353 ] ASF GitHub Bot commented on TS-4107: Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/409 > proxy.process.ssl.total_success_handshake_count_in has wrong record type > > > Key: TS-4107 > URL: https://issues.apache.org/jira/browse/TS-4107 > Project: Traffic Server > Issue Type: Bug > Components: Metrics, SSL >Reporter: James Peach >Assignee: James Peach > Fix For: 6.2.0 > > > {{proxy.process.ssl.total_success_handshake_count_in}} is the only SSL metric > registered in {{RecordsConfig.cc}} where it is incorrectly registered as a > node metric, rather than a process metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4107) proxy.process.ssl.total_success_handshake_count_in has wrong record type
[ https://issues.apache.org/jira/browse/TS-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095351#comment-15095351 ] ASF subversion and git services commented on TS-4107: - Commit 8e0f81454fd79cc4dde4bba17b4eb38a7f195c0d in trafficserver's branch refs/heads/master from [~jpe...@apache.org] [ https://git-wip-us.apache.org/repos/asf?p=trafficserver.git;h=8e0f814 ] TS-4107: proxy.process.ssl.total_success_handshake_count_in has wrong record type proxy.process.ssl.total_success_handshake_count_in should be the metrics generated in the core SSL code, and the old compatible name proxy.process.ssl.total_success_handshake_count should be generated as a custom metric. The custom metric needs to be registered in RecordsConfig.cc but it should be of type RECT_PROCESS not RECT_NODE. This closes #409. > proxy.process.ssl.total_success_handshake_count_in has wrong record type > > > Key: TS-4107 > URL: https://issues.apache.org/jira/browse/TS-4107 > Project: Traffic Server > Issue Type: Bug > Components: Metrics, SSL >Reporter: James Peach >Assignee: James Peach > Fix For: 6.2.0 > > > {{proxy.process.ssl.total_success_handshake_count_in}} is the only SSL metric > registered in {{RecordsConfig.cc}} where it is incorrectly registered as a > node metric, rather than a process metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4107) proxy.process.ssl.total_success_handshake_count_in has wrong record type
[ https://issues.apache.org/jira/browse/TS-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15095356#comment-15095356 ] Leif Hedstrom commented on TS-4107: --- [~jpe...@apache.org] do we want this in for 6.1.0 ? > proxy.process.ssl.total_success_handshake_count_in has wrong record type > > > Key: TS-4107 > URL: https://issues.apache.org/jira/browse/TS-4107 > Project: Traffic Server > Issue Type: Bug > Components: Metrics, SSL >Reporter: James Peach >Assignee: James Peach > Fix For: 6.2.0 > > > {{proxy.process.ssl.total_success_handshake_count_in}} is the only SSL metric > registered in {{RecordsConfig.cc}} where it is incorrectly registered as a > node metric, rather than a process metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4107) proxy.process.ssl.total_success_handshake_count_in has wrong record type
[ https://issues.apache.org/jira/browse/TS-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091319#comment-15091319 ] ASF GitHub Bot commented on TS-4107: GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/409 TS-4107: proxy.process.ssl.total_success_handshake_count_in has wrong record type ``proxy.process.ssl.total_success_handshake_count_in`` should be the metrics generated in the core SSL code, and the old compatible name ``proxy.process.ssl.total_success_handshake_count`` should be generated as a custom metric. The custom metric needs to be registered in ``RecordsConfig.cc`` but it should be of type ``RECT_PROCESS`` not ``RECT_NODE``. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/trafficserver fix/TS-4107 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/trafficserver/pull/409.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #409 commit 147d4291679821c6405ecf6ecaee283042e18288 Author: James PeachDate: 2016-01-06T04:18:43Z TS-4107: proxy.process.ssl.total_success_handshake_count_in has wrong record type proxy.process.ssl.total_success_handshake_count_in should be the metrics generated in the core SSL code, and the old compatible name proxy.process.ssl.total_success_handshake_count should be generated as a custom metric. The custom metric needs to be registered in RecordsConfig.cc but it should be of type RECT_PROCESS not RECT_NODE. > proxy.process.ssl.total_success_handshake_count_in has wrong record type > > > Key: TS-4107 > URL: https://issues.apache.org/jira/browse/TS-4107 > Project: Traffic Server > Issue Type: Bug > Components: Metrics, SSL >Reporter: James Peach >Assignee: James Peach > Fix For: 6.2.0 > > > {{proxy.process.ssl.total_success_handshake_count_in}} is the only SSL metric > registered in {{RecordsConfig.cc}} where it is incorrectly registered as a > node metric, rather than a process metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4107) proxy.process.ssl.total_success_handshake_count_in has wrong record type
[ https://issues.apache.org/jira/browse/TS-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15091321#comment-15091321 ] ASF GitHub Bot commented on TS-4107: Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/409#issuecomment-170414186 ping @zwoop @shinrich > proxy.process.ssl.total_success_handshake_count_in has wrong record type > > > Key: TS-4107 > URL: https://issues.apache.org/jira/browse/TS-4107 > Project: Traffic Server > Issue Type: Bug > Components: Metrics, SSL >Reporter: James Peach >Assignee: James Peach > Fix For: 6.2.0 > > > {{proxy.process.ssl.total_success_handshake_count_in}} is the only SSL metric > registered in {{RecordsConfig.cc}} where it is incorrectly registered as a > node metric, rather than a process metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (TS-4107) proxy.process.ssl.total_success_handshake_count_in has wrong record type
[ https://issues.apache.org/jira/browse/TS-4107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15076210#comment-15076210 ] James Peach commented on TS-4107: - Looks like the original bug did this backwards. {{proxy.process.ssl.total_success_handshake_count_in}} should be the metrics generated in the core SSL code, and the old compatible name {{proxy.process.ssl.total_success_handshake_count}} should be generated as a custom metric. The custom metric needs to be registered in {{RecordsConfig.cc}} but it should be {{RECT_PROCESS}}. > proxy.process.ssl.total_success_handshake_count_in has wrong record type > > > Key: TS-4107 > URL: https://issues.apache.org/jira/browse/TS-4107 > Project: Traffic Server > Issue Type: Bug > Components: Metrics, SSL >Reporter: James Peach > > {{proxy.process.ssl.total_success_handshake_count_in}} is the only SSL metric > registered in {{RecordsConfig.cc}} where it is incorrectly registered as a > node metric, rather than a process metric. -- This message was sent by Atlassian JIRA (v6.3.4#6332)