[jira] [Commented] (TS-3426) Consolidate the multiple API for disabling cache
[
https://issues.apache.org/jira/browse/TS-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680751#comment-14680751
]
Alan M. Carroll commented on TS-3426:
-
What is desired is a single point where the plugin can set one of three values:
1) Default - do the default thing as if the plugin had done nothing.
2) Do not cache - do not cache the transaction.
3) Do cache - cache the transaction if possible.
There are few complications. The primary one is checking to see if the
transaction is cacheable via {{TSHttpTxnIsCacheable}} which should ignore this
value. That is, it should return a value as if the setting was default
otherwise you get in to circularity problems.
It should also be noted that is possible covers the cache being entirely
disabled. In that case nothing will be cached regardless of setting this
override.
This would replace (at a minimum)
* {{TSHttpTxnServerRespNoStore}}
* {{proxy.config.http.cache.http}} as overridable (this configuration would
become restart only)
* {{TSHttpTxnUntransformedRespCache}}
* {{TSHttpTxnTransformedRespCache}}
Consolidate the multiple API for disabling cache
Key: TS-3426
URL: https://issues.apache.org/jira/browse/TS-3426
Project: Traffic Server
Issue Type: Improvement
Components: TS API
Reporter: Sudheer Vinukonda
Assignee: Alan M. Carroll
Labels: A
Fix For: 6.1.0
There are currently multiple API (see below) that can be used by a plugin to
disable cache for a given transaction.
{{TSHttpTxnServerRespNoStoreSet}}, {{TSHttpTxnReqCacheableSet}},
{{TSHttpTxnRespCacheableSet}}
Opening this jira to analyze whether these are redundant and consolidate if
necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3426) Consolidate the multiple API for disabling cache
[
https://issues.apache.org/jira/browse/TS-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680896#comment-14680896
]
William Bardwell commented on TS-3426:
--
Aren't the Transformed vs Untransformed thing allowing you to choose where the
Cache is attached to the tunnel, which is nothing that the new 3 values would
not allow, it sounds like it needs more values or a bit-mask or to keep some
variation of those APIs.
Consolidate the multiple API for disabling cache
Key: TS-3426
URL: https://issues.apache.org/jira/browse/TS-3426
Project: Traffic Server
Issue Type: Improvement
Components: TS API
Reporter: Sudheer Vinukonda
Assignee: Alan M. Carroll
Labels: A
Fix For: 6.1.0
There are currently multiple API (see below) that can be used by a plugin to
disable cache for a given transaction.
{{TSHttpTxnServerRespNoStoreSet}}, {{TSHttpTxnReqCacheableSet}},
{{TSHttpTxnRespCacheableSet}}
Opening this jira to analyze whether these are redundant and consolidate if
necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3426) Consolidate the multiple API for disabling cache
[
https://issues.apache.org/jira/browse/TS-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680922#comment-14680922
]
Leif Hedstrom commented on TS-3426:
---
I agree with William, and I replied a while back on the mailing list as well.
In an ideal world, we replace all the APIs, including the ones mentioned in the
original post here. In addition, as I pointed out in email, I think there are
APIs that are very specific, such as allow caching this even though the method
used is not allowed for caching. So I think a bit-mask (under the hood) could
be necessary?
I'm also not sure that changing the overidable config is a requirement, since
it can not be done in a compatible way. Rather, we'd mark it as deprecated for
7.0.0 and removed for 8.0.0, replace with either a new config or some other
more generic method (e.g. Options in cache.config, storage.config or Lua
scriptlets).
Consolidate the multiple API for disabling cache
Key: TS-3426
URL: https://issues.apache.org/jira/browse/TS-3426
Project: Traffic Server
Issue Type: Improvement
Components: TS API
Reporter: Sudheer Vinukonda
Assignee: Alan M. Carroll
Labels: A
Fix For: 6.1.0
There are currently multiple API (see below) that can be used by a plugin to
disable cache for a given transaction.
{{TSHttpTxnServerRespNoStoreSet}}, {{TSHttpTxnReqCacheableSet}},
{{TSHttpTxnRespCacheableSet}}
Opening this jira to analyze whether these are redundant and consolidate if
necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3426) Consolidate the multiple API for disabling cache
[
https://issues.apache.org/jira/browse/TS-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680928#comment-14680928
]
Sudheer Vinukonda commented on TS-3426:
---
+1 on *not* trying to change the semantics of existing config to somehow
satisfy overridability and/or reload-ability, since it most likely will cause
confusion and/or break compatibility one way or the other. I also agree that a
cleaner way is to not modify the meaning of existing settings and use new
settings/methods while deprecating the existing ones.
Consolidate the multiple API for disabling cache
Key: TS-3426
URL: https://issues.apache.org/jira/browse/TS-3426
Project: Traffic Server
Issue Type: Improvement
Components: TS API
Reporter: Sudheer Vinukonda
Assignee: Alan M. Carroll
Labels: A
Fix For: 6.1.0
There are currently multiple API (see below) that can be used by a plugin to
disable cache for a given transaction.
{{TSHttpTxnServerRespNoStoreSet}}, {{TSHttpTxnReqCacheableSet}},
{{TSHttpTxnRespCacheableSet}}
Opening this jira to analyze whether these are redundant and consolidate if
necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TS-3426) consolidate the multiple API for disabling cache
[
https://issues.apache.org/jira/browse/TS-3426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14491700#comment-14491700
]
Leif Hedstrom commented on TS-3426:
---
I need this consolidation and generalization, such that I can turn off the
cache(ability) early on in the TXN. In my case, I need to be able to turn off
cache in TS_EVENT_HTTP_CACHE_LOOKUP_COMPLETE .
consolidate the multiple API for disabling cache
Key: TS-3426
URL: https://issues.apache.org/jira/browse/TS-3426
Project: Traffic Server
Issue Type: Improvement
Components: TS API
Reporter: Sudheer Vinukonda
Fix For: sometime
There are currently multiple API (see below) that can be used by a plugin to
disable cache for a given transaction.
{{TSHttpTxnServerRespNoStoreSet}}, {{TSHttpTxnReqCacheableSet}},
{{TSHttpTxnRespCacheableSet}}
Opening this jira to analyze whether these are redundant and consolidate if
necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
