[jira] [Work logged] (TS-4976) Clean up casting in the plugins.
[ https://issues.apache.org/jira/browse/TS-4976?focusedWorklogId=30802&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30802 ] ASF GitHub Bot logged work on TS-4976: -- Author: ASF GitHub Bot Created on: 18/Oct/16 13:51 Start Date: 18/Oct/16 13:51 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1114 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1038/ for details. Issue Time Tracking --- Worklog Id: (was: 30802) Time Spent: 1.5h (was: 1h 20m) > Clean up casting in the plugins. > > > Key: TS-4976 > URL: https://issues.apache.org/jira/browse/TS-4976 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Alan M. Carroll >Assignee: Alan M. Carroll > Fix For: 7.1.0 > > Time Spent: 1.5h > Remaining Estimate: 0h > > With TS-4971 committed, we should clean up the {{const_cast}} formerly > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4976) Clean up casting in the plugins.
[ https://issues.apache.org/jira/browse/TS-4976?focusedWorklogId=30801&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30801 ] ASF GitHub Bot logged work on TS-4976: -- Author: ASF GitHub Bot Created on: 18/Oct/16 13:46 Start Date: 18/Oct/16 13:46 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1114 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/929/ for details. Issue Time Tracking --- Worklog Id: (was: 30801) Time Spent: 1h 20m (was: 1h 10m) > Clean up casting in the plugins. > > > Key: TS-4976 > URL: https://issues.apache.org/jira/browse/TS-4976 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Alan M. Carroll >Assignee: Alan M. Carroll > Fix For: 7.1.0 > > Time Spent: 1h 20m > Remaining Estimate: 0h > > With TS-4971 committed, we should clean up the {{const_cast}} formerly > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4976) Clean up casting in the plugins.
[ https://issues.apache.org/jira/browse/TS-4976?focusedWorklogId=30800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30800 ] ASF GitHub Bot logged work on TS-4976: -- Author: ASF GitHub Bot Created on: 18/Oct/16 13:45 Start Date: 18/Oct/16 13:45 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1114 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1037/ for details. Issue Time Tracking --- Worklog Id: (was: 30800) Time Spent: 1h 10m (was: 1h) > Clean up casting in the plugins. > > > Key: TS-4976 > URL: https://issues.apache.org/jira/browse/TS-4976 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Alan M. Carroll >Assignee: Alan M. Carroll > Fix For: 7.1.0 > > Time Spent: 1h 10m > Remaining Estimate: 0h > > With TS-4971 committed, we should clean up the {{const_cast}} formerly > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4976) Clean up casting in the plugins.
[ https://issues.apache.org/jira/browse/TS-4976?focusedWorklogId=30799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30799 ] ASF GitHub Bot logged work on TS-4976: -- Author: ASF GitHub Bot Created on: 18/Oct/16 13:37 Start Date: 18/Oct/16 13:37 Worklog Time Spent: 10m Work Description: Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1114#discussion_r83854785 --- Diff: example/intercept/intercept.cc --- @@ -538,9 +538,9 @@ TSPluginInit(int /* argc */, const char * /* argv */ []) { TSPluginRegistrationInfo info; - info.plugin_name = (char *)PLUGIN; - info.vendor_name = (char *)"MyCompany"; - info.support_email = (char *)"ts-api-supp...@mycompany.com"; + info.plugin_name = PLUGIN; + info.vendor_name = "MyCompany"; + info.support_email = "ts-api-supp...@mycompany.com"; --- End diff -- I fixed `example/add-header` and `example/append-transform` this way. See if that looks reasonable. For `.cc` files I would replace `static` with the anonymous namespace. Issue Time Tracking --- Worklog Id: (was: 30799) Time Spent: 1h (was: 50m) > Clean up casting in the plugins. > > > Key: TS-4976 > URL: https://issues.apache.org/jira/browse/TS-4976 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Alan M. Carroll >Assignee: Alan M. Carroll > Fix For: 7.1.0 > > Time Spent: 1h > Remaining Estimate: 0h > > With TS-4971 committed, we should clean up the {{const_cast}} formerly > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4976) Clean up casting in the plugins.
[ https://issues.apache.org/jira/browse/TS-4976?focusedWorklogId=30794&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30794 ] ASF GitHub Bot logged work on TS-4976: -- Author: ASF GitHub Bot Created on: 18/Oct/16 00:56 Start Date: 18/Oct/16 00:56 Worklog Time Spent: 10m Work Description: Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1114 Clang format Issue Time Tracking --- Worklog Id: (was: 30794) Time Spent: 50m (was: 40m) > Clean up casting in the plugins. > > > Key: TS-4976 > URL: https://issues.apache.org/jira/browse/TS-4976 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Alan M. Carroll > Time Spent: 50m > Remaining Estimate: 0h > > With TS-4971 committed, we should clean up the {{const_cast}} formerly > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4976) Clean up casting in the plugins.
[ https://issues.apache.org/jira/browse/TS-4976?focusedWorklogId=30775&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30775 ] ASF GitHub Bot logged work on TS-4976: -- Author: ASF GitHub Bot Created on: 17/Oct/16 21:54 Start Date: 17/Oct/16 21:54 Worklog Time Spent: 10m Work Description: Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1114#discussion_r83743000 --- Diff: plugins/experimental/ats_pagespeed/gzip/misc.cc --- @@ -157,7 +157,7 @@ register_plugin() const char * load_dictionary(const char *preload_file) { - char *dict = (char *)malloc(80); + char *dict = malloc(80); --- End diff -- That's outside the scope of this fix :-) Issue Time Tracking --- Worklog Id: (was: 30775) Time Spent: 40m (was: 0.5h) > Clean up casting in the plugins. > > > Key: TS-4976 > URL: https://issues.apache.org/jira/browse/TS-4976 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Alan M. Carroll > Time Spent: 40m > Remaining Estimate: 0h > > With TS-4971 committed, we should clean up the {{const_cast}} formerly > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4976) Clean up casting in the plugins.
[ https://issues.apache.org/jira/browse/TS-4976?focusedWorklogId=30774&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30774 ] ASF GitHub Bot logged work on TS-4976: -- Author: ASF GitHub Bot Created on: 17/Oct/16 21:49 Start Date: 17/Oct/16 21:49 Worklog Time Spent: 10m Work Description: Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1114#discussion_r83742164 --- Diff: plugins/experimental/mysql_remap/mysql_remap.cc --- @@ -232,7 +232,7 @@ TSPluginInit(int argc, const char *argv[]) return; } - data->query = (char *)TSmalloc(QSIZE * sizeof(char)); // TODO: malloc smarter sizes + data->query = TSmalloc(QSIZE * sizeof(char)); // TODO: malloc smarter sizes --- End diff -- Ah, that's not being compiled for me due to lack of mySQL packages. Issue Time Tracking --- Worklog Id: (was: 30774) Time Spent: 0.5h (was: 20m) > Clean up casting in the plugins. > > > Key: TS-4976 > URL: https://issues.apache.org/jira/browse/TS-4976 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Alan M. Carroll > Time Spent: 0.5h > Remaining Estimate: 0h > > With TS-4971 committed, we should clean up the {{const_cast}} formerly > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4976) Clean up casting in the plugins.
[ https://issues.apache.org/jira/browse/TS-4976?focusedWorklogId=30761&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30761 ] ASF GitHub Bot logged work on TS-4976: -- Author: ASF GitHub Bot Created on: 17/Oct/16 19:16 Start Date: 17/Oct/16 19:16 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1114 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/1033/ for details. Issue Time Tracking --- Worklog Id: (was: 30761) Time Spent: 20m (was: 10m) > Clean up casting in the plugins. > > > Key: TS-4976 > URL: https://issues.apache.org/jira/browse/TS-4976 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Alan M. Carroll > Time Spent: 20m > Remaining Estimate: 0h > > With TS-4971 committed, we should clean up the {{const_cast}} formerly > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Work logged] (TS-4976) Clean up casting in the plugins.
[ https://issues.apache.org/jira/browse/TS-4976?focusedWorklogId=30760&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-30760 ] ASF GitHub Bot logged work on TS-4976: -- Author: ASF GitHub Bot Created on: 17/Oct/16 19:08 Start Date: 17/Oct/16 19:08 Worklog Time Spent: 10m Work Description: Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/1114 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/925/ for details. Issue Time Tracking --- Worklog Id: (was: 30760) Time Spent: 10m Remaining Estimate: 0h > Clean up casting in the plugins. > > > Key: TS-4976 > URL: https://issues.apache.org/jira/browse/TS-4976 > Project: Traffic Server > Issue Type: Improvement > Components: Plugins >Reporter: Alan M. Carroll > Time Spent: 10m > Remaining Estimate: 0h > > With TS-4971 committed, we should clean up the {{const_cast}} formerly > required. -- This message was sent by Atlassian JIRA (v6.3.4#6332)