[jira] [Commented] (IMPALA-7251) Fix QueryMaintenance calls in Aggregators
[ https://issues.apache.org/jira/browse/IMPALA-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16810087#comment-16810087 ] ASF subversion and git services commented on IMPALA-7251: - Commit fdd6db524c9c97f0baebfde0119fce19d62eaec3 in impala's branch refs/heads/2.x from Thomas Tauber-Marshall [ https://gitbox.apache.org/repos/asf?p=impala.git;h=fdd6db5 ] IMPALA-7251: Fix QueryMaintenance calls in Aggregators A recent change, IMPALA-110 (part 2), refactored PartitionedAggregationNode into several classes, including a new type 'Aggregator'. During this refactor, code that makes local allocations while evaluating exprs was moved from the ExecNode (now AggregationNode/StreamingAggregationNode) into the Aggregators, but code related to cleaning these allocations up (ie QueryMaintenance()) was not, resulting in some queries using an excessive amount of memory. This patch removes all calls to QueryMaintenance() from the exec nodes and moves them into the Aggregators. Testing: - Added new test cases with a mem limit that fails if the expr allocations aren't released in a timely manner. - Passed a full exhaustive run. Change-Id: I4dac2bb0a15cdd7315ee15608bae409c125c82f5 Reviewed-on: http://gerrit.cloudera.org:8080/10871 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins > Fix QueryMaintenance calls in Aggregators > - > > Key: IMPALA-7251 > URL: https://issues.apache.org/jira/browse/IMPALA-7251 > Project: IMPALA > Issue Type: Bug >Affects Versions: Impala 3.1.0 >Reporter: Thomas Tauber-Marshall >Assignee: Thomas Tauber-Marshall >Priority: Blocker > Fix For: Impala 3.1.0 > > > A recent change, IMPALA-110 (part 2), refactored PartitionedAggregationNode > into several classes, including GroupingAggregator. During this refactor, > code that makes local allocations while evaluating exprs was moved from the > ExecNode (now AggregationNode/StreamingAggregationNode) into the new type > Aggregator, but code related to cleaning these allocations up (ie > QueryMaintenance()) was not, resulting in some queries using an excessive > amount of memory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
[jira] [Commented] (IMPALA-7251) Fix QueryMaintenance calls in Aggregators
[ https://issues.apache.org/jira/browse/IMPALA-7251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542570#comment-16542570 ] ASF subversion and git services commented on IMPALA-7251: - Commit e2aafae204a695ddc6a9745f879f6164af19027a in impala's branch refs/heads/master from [~twmarshall] [ https://git-wip-us.apache.org/repos/asf?p=impala.git;h=e2aafae ] IMPALA-7251: Fix QueryMaintenance calls in Aggregators A recent change, IMPALA-110 (part 2), refactored PartitionedAggregationNode into several classes, including a new type 'Aggregator'. During this refactor, code that makes local allocations while evaluating exprs was moved from the ExecNode (now AggregationNode/StreamingAggregationNode) into the Aggregators, but code related to cleaning these allocations up (ie QueryMaintenance()) was not, resulting in some queries using an excessive amount of memory. This patch removes all calls to QueryMaintenance() from the exec nodes and moves them into the Aggregators. Testing: - Added new test cases with a mem limit that fails if the expr allocations aren't released in a timely manner. - Passed a full exhaustive run. Change-Id: I4dac2bb0a15cdd7315ee15608bae409c125c82f5 Reviewed-on: http://gerrit.cloudera.org:8080/10871 Reviewed-by: Impala Public Jenkins Tested-by: Impala Public Jenkins > Fix QueryMaintenance calls in Aggregators > - > > Key: IMPALA-7251 > URL: https://issues.apache.org/jira/browse/IMPALA-7251 > Project: IMPALA > Issue Type: Bug >Affects Versions: Impala 3.1.0 >Reporter: Thomas Tauber-Marshall >Assignee: Thomas Tauber-Marshall >Priority: Blocker > > A recent change, IMPALA-110 (part 2), refactored PartitionedAggregationNode > into several classes, including GroupingAggregator. During this refactor, > code that makes local allocations while evaluating exprs was moved from the > ExecNode (now AggregationNode/StreamingAggregationNode) into the new type > Aggregator, but code related to cleaning these allocations up (ie > QueryMaintenance()) was not, resulting in some queries using an excessive > amount of memory. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: issues-all-unsubscr...@impala.apache.org For additional commands, e-mail: issues-all-h...@impala.apache.org
