[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Tom FENNELLY commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms I parked trying to sort out JENKINS-23405(https://issues.jenkins-ci.org/browse/JENKINS-23405) for now - issues replicating the same release structure as was used to create the 2.9.0 YUI resources (which Jenkins depends on). Pull request: https://github.com/jenkinsci/jenkins/pull/1278 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Tom FENNELLY edited a comment on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms I parked trying to sort out JENKINS-23405 for now - issues replicating the same release structure as was used to create the 2.9.0 YUI resources (which Jenkins depends on). Pull request: https://github.com/jenkinsci/jenkins/pull/1278 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
SCM/JIRA link daemon commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms Code changed in jenkins User: tfennelly Path: changelog.html war/src/main/webapp/scripts/yui/button/button-debug.js war/src/main/webapp/scripts/yui/button/button-min.js http://jenkins-ci.org/commit/jenkins/aa8f5955cd478d4a473f49126dad1a0efecc0e2a Log: JENKINS-22373 Submit on Enter key bug on IE9 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Tom FENNELLY resolved JENKINS-22373 as Fixed IE 9 regular mode: Enter does not work to submit forms Change By: Tom FENNELLY (13/Jun/14 6:03 PM) Status: Open Resolved Resolution: Fixed This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
dogfood commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms Integrated in jenkins_main_trunk #3465 JENKINS-22373 Submit on Enter key bug on IE9 (Revision aa8f5955cd478d4a473f49126dad1a0efecc0e2a) Result = SUCCESS tom.fennelly : aa8f5955cd478d4a473f49126dad1a0efecc0e2a Files : changelog.html war/src/main/webapp/scripts/yui/button/button-min.js war/src/main/webapp/scripts/yui/button/button-debug.js This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Spike Washburn commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms After reviewing with Tom, it turns out that the configure page does actually have the submit-on-enter behavior for standard input elements in the form. It happened that the input I tested with previously was specialized (number input) and was likely overriding the Enter behavior. So finding what's blocking this standard Jenkins form behavior seems worthwhile. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Tom FENNELLY commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms Looked at this again day and think I found a more appropriate fix. See new version of https://github.com/tfennelly/jenkins/tree/JENKINS-22373 I tracked the issue down to the YUI button. It's not correctly firing Enter keypress events for IE = 9 (should call dispatchEvent instead of fireEvent for IE = 9). The change in the above branch fixes the issue for the login screen and any other "submit-button" inputs that hudson-behavior.js" is applying YUI to. YUI calls fireEvent in other places, so this issue might raise its head again in another form. How have ye been minifying this code on other such changes (I see there have been a few)? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Tom FENNELLY edited a comment on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms Looked at this again today and think I found a more appropriate fix. See new version of https://github.com/tfennelly/jenkins/tree/JENKINS-22373 I tracked the issue down to the YUI button. It's not correctly firing Enter keypress events for IE = 9 (should call dispatchEvent instead of fireEvent for IE = 9). The change in the above branch fixes the issue for the login screen and any other "submit-button" inputs that hudson-behavior.js" is applying YUI to. YUI calls fireEvent in other places, so this issue might raise its head again in another form. How have ye been minifying this code on other such changes (I see there have been a few)? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Jesse Glick commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms By the way the more helpful link (precursor to a PR) is: https://github.com/tfennelly/jenkins/compare/JENKINS-22373 This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Jesse Glick commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms I am not sure how minifying works. I once did a change to something like, IIRC in Prototype, and just manually edited the minified version (ick). Obviously integrating a Maven plugin to do the minification during a build would be ideal. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Tom FENNELLY commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms Talked to KK about this. He was not aware that changes were being made to the YUI code. 6 have been made in total since the update to v2.9 (not including this change). See JENKINS-23405. Re minification... it's all obfuscated so changing by hand is a last resort imo. I tried an online YUI compressor. Output is formatted differently and the obfuscation is not exactly the same, but it seems to work (pushed to the same branch if you want to look). Might be dangerous though I think? Maybe we need to fork YUI2 as suggested by KK in JENKINS-23405. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Tom FENNELLY commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms I think we should sort YUI out properly ala JENKINS-23405. Spike, KK, Jesse? This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Tom FENNELLY commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms Here's a possible fix for this issue using _javascript_: https://github.com/tfennelly/jenkins/tree/JENKINS-22373 That was the only thing I could find that fixed it (only tested on the login screen so far). There was also a suggestion that meta http-equiv="X-UA-Compatible" content="IE=EmulateIE7" / would fix it. I tried that but it didn't work. This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Jesse Glick assigned JENKINS-22373 to Tom FENNELLY IE 9 regular mode: Enter does not work to submit forms Looks like a hack but maybe that is what we need. File a pull request in case someone else with knowledge of IE issues has an idea. Change By: Jesse Glick (10/Jun/14 6:51 PM) Assignee: TomFENNELLY This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Spike Washburn commented on JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms Beware that a generic JS hook to submit the form on Enter keypress may interfere with controls that are designed to consume Enter, like textarea very bad. This may also interfere with plugins that customize the behavior of Enter bad for unknown subset of plugins. Finally, hooking forms during onload will miss form elements that are injected into the DOM after onload bad since it creates inconsistencies in form handling. Is the goal here to really make it so enter-on-submit is the default for all forms? Clicking Enter on the Jenkins Job Configure form does not auto-submit for me on Chromewhy is that the desirable behavior on IE9? If something in the Jenkins DOM or default JS scripts is interfering with the standard IE 9 Enter key behavior then finding the root cause of that to restore standard behavior generically seems like logical fix. However, if this is intended to change the default form-handling behavior of IE, then isolating this change to specific forms where submit-on-enter is specifically known to be highly desirable and non-breaking seems more appropriate (for example, the login form). This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
[JIRA] [core] (JENKINS-22373) IE 9 regular mode: Enter does not work to submit forms
Jesse Glick created JENKINS-22373 IE 9 regular mode: Enter does not work to submit forms Issue Type: Bug Assignee: Unassigned Components: core Created: 26/Mar/14 10:20 PM Description: In IE 9 on Windows 7 in regular mode, pressing the Enter key does not submit forms (such as the login form) as expected. It does work in compatibility mode. Project: Jenkins Labels: ie ui Priority: Minor Reporter: Jesse Glick This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators. For more information on JIRA, see: http://www.atlassian.com/software/jira -- You received this message because you are subscribed to the Google Groups Jenkins Issues group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-issues+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
