Re: RFR 8147794: Jlink's ModuleEntry.stream can't be consumed more than once and ModuleEntry content should be read only if needed

2016-06-24 Thread Paul Sandoz

> On 24 Jun 2016, at 15:12, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8147794/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8147794
> 

+1

I have a quibble on naming e.g. the default methods ModuleEntry.create, it 
feels more like copyWithContent, but we can hash out stuff like that later on.

Paul.


Re: RFR 8147794: Jlink's ModuleEntry.stream can't be consumed more than once and ModuleEntry content should be read only if needed

2016-06-24 Thread Jim Laskey (Oracle)
+1 nice to get this done


> On Jun 24, 2016, at 10:12 AM, Sundararajan Athijegannathan 
>  wrote:
> 
> Please review http://cr.openjdk.java.net/~sundar/8147794/webrev.00/ for
> https://bugs.openjdk.java.net/browse/JDK-8147794
> 
> Thanks,
> 
> -Sundar
>